mirror of
https://gitlab.winehq.org/wine/vkd3d.git
synced 2025-09-12 18:50:22 -07:00
9983d9c4de
The expected λ value for the tests in question is about 0.59, which after linear mipmap interpolation should result in a sampled value of about 0.41. The quantisation step was added to allow results as high as 0.43, as seen on some implementations. AMD Radeon Pro Vega 20 on macOS 15.5 returns a sampled value of about 0.39, with both Vulkan/MoltenVK and MSL/Metal. This is not an issue with the bias calculation; the same behaviour could be reproduced with SampleLevel(), as used in the sample-level tests, if those tests used more exciting values for the "level" parameter. It also doesn't appear to be a general Metal issue; Intel UHD Graphics 630 does return the expected values on the same setup. Instead, this appears to be a mipmap interpolation issue on this particular GPU/driver. Mapping the sampled values for "level" from 0.0 to 1.0, it seems the interpolation factor used is "saturate(frac(λ) * 1.25 - 0.125)", instead of the normal "frac(λ)". Fascinating as that may be, the test here mainly cares about whether the bias value was applied correctly, and in that regard a sampled value of 0.39 isn't any worse than the 0.43 we already accept. This commit adjusts the bias value so that the expected sampled value is 0.45, which makes the accepted error the same on both the positive and negative side.
73 lines
1.6 KiB
Plaintext
73 lines
1.6 KiB
Plaintext
[sampler 0]
|
|
filter linear linear linear
|
|
address clamp clamp clamp
|
|
|
|
[srv 0]
|
|
size (2d, 2, 2)
|
|
levels 2
|
|
|
|
1.0 0.0 1.0 0.0 1.0 0.0 1.0 0.0
|
|
1.0 0.0 1.0 0.0 1.0 0.0 1.0 0.0
|
|
|
|
0.0 0.0 1.0 0.0
|
|
|
|
[vertex shader]
|
|
void main(float4 pos : position, out float2 tex : texcoord, out float4 out_pos : sv_position)
|
|
{
|
|
tex = pos.xy;
|
|
out_pos = pos;
|
|
}
|
|
|
|
[pixel shader]
|
|
sampler s;
|
|
Texture2D t;
|
|
uniform float bias;
|
|
|
|
float4 main(float2 coord : texcoord) : sv_target
|
|
{
|
|
/* Choice of initial mipmap level is hardware-dependent, and in practice
|
|
* varies too much to be reasonably covered by ULPS. Quantize instead. */
|
|
return floor(t.SampleBias(s, coord, bias) * 10);
|
|
}
|
|
|
|
[test]
|
|
uniform 0 float4 6.5 0.0 0.0 0.0
|
|
todo(msl) draw quad
|
|
probe (0, 0) rgba (10.0, 0.0, 10.0, 0.0)
|
|
|
|
uniform 0 float4 7.46 0.0 0.0 0.0
|
|
todo(msl) draw quad
|
|
probe (0, 0) rgba(4.0, 0.0, 10.0, 0.0)
|
|
|
|
uniform 0 float4 8.5 0.0 0.0 0.0
|
|
todo(msl) draw quad
|
|
probe (0, 0) rgba(0.0, 0.0, 10.0, 0.0)
|
|
|
|
[require]
|
|
shader model >= 3.0
|
|
options: backcompat
|
|
|
|
[pixel shader fail(sm>=5.1) todo(sm>=5.1)]
|
|
sampler s;
|
|
float bias;
|
|
|
|
float4 main(float2 coord : texcoord) : sv_target
|
|
{
|
|
/* Choice of initial mipmap level is hardware-dependent, and in practice
|
|
* varies too much to be reasonably covered by ULPS. Quantize instead. */
|
|
return floor(tex2Dbias(s, float4(coord, 0, bias)) * 10);
|
|
}
|
|
|
|
[test]
|
|
uniform 0 float4 6.5 0.0 0.0 0.0
|
|
todo(msl) draw quad
|
|
probe (0, 0) rgba (10.0, 0.0, 10.0, 0.0)
|
|
|
|
uniform 0 float4 7.46 0.0 0.0 0.0
|
|
todo(msl) draw quad
|
|
probe (0,0) rgba(4.0, 0.0, 10.0, 0.0)
|
|
|
|
uniform 0 float4 8.5 0.0 0.0 0.0
|
|
todo(msl) draw quad
|
|
probe (0,0) rgba(0.0, 0.0, 10.0, 0.0)
|