From 90196f7d015c61d8d31f74f978aa0f45ae8eaf9c Mon Sep 17 00:00:00 2001 From: Giovanni Mascellani Date: Tue, 2 Dec 2025 15:14:22 +0100 Subject: [PATCH] vkd3d-shader/dxil: Remove sm6_parser_emit_unhandled(). It's currently useless, when there is a failure we drop out of sm6_parser_function_init() before even checking what the current instruction or value looks like. --- libs/vkd3d-shader/dxil.c | 16 ---------------- 1 file changed, 16 deletions(-) diff --git a/libs/vkd3d-shader/dxil.c b/libs/vkd3d-shader/dxil.c index 58919563d..497c03509 100644 --- a/libs/vkd3d-shader/dxil.c +++ b/libs/vkd3d-shader/dxil.c @@ -7093,35 +7093,19 @@ static bool sm6_parser_validate_dx_op(struct sm6_parser *sm6, enum dx_intrinsic_ return true; } -static void sm6_parser_emit_unhandled(struct sm6_parser *sm6, struct vkd3d_shader_instruction *ins, - struct sm6_value *dst) -{ - ins->opcode = VSIR_OP_NOP; - - if (!dst->type) - return; - - dst->value_type = VALUE_TYPE_INVALID; -} - static void sm6_parser_decode_dx_op(struct sm6_parser *sm6, enum dx_intrinsic_opcode op, const char *name, const struct sm6_value **operands, unsigned int operand_count, struct function_emission_state *state, struct sm6_value *dst) { if (op >= ARRAY_SIZE(sm6_dx_op_table) || !sm6_dx_op_table[op].operand_info) { - FIXME("Unhandled dx intrinsic function id %u, '%s'.\n", op, name); vkd3d_shader_parser_error(&sm6->p, VKD3D_SHADER_ERROR_DXIL_UNHANDLED_INTRINSIC, "Call to intrinsic function %s is unhandled.", name); - sm6_parser_emit_unhandled(sm6, state->ins, dst); return; } if (!sm6_parser_validate_dx_op(sm6, op, name, operands, operand_count, dst)) - { - sm6_parser_emit_unhandled(sm6, state->ins, dst); return; - } sm6_dx_op_table[op].handler(sm6, op, operands, state);