From 87f01f5205d70287a6940474e0f295a4adee06a1 Mon Sep 17 00:00:00 2001 From: Francisco Casas Date: Wed, 24 Jul 2024 17:59:58 -0400 Subject: [PATCH] vkd3d-shader/hlsl: Remove SM1 fixme for matrix writemasks. hlsl_ir_store instructions don't use writemasks for whole matrices. --- libs/vkd3d-shader/d3dbc.c | 6 ------ tests/hlsl/matrix-indexing.shader_test | 4 ++-- 2 files changed, 2 insertions(+), 8 deletions(-) diff --git a/libs/vkd3d-shader/d3dbc.c b/libs/vkd3d-shader/d3dbc.c index 2bbd9f81..eb6b805c 100644 --- a/libs/vkd3d-shader/d3dbc.c +++ b/libs/vkd3d-shader/d3dbc.c @@ -2767,12 +2767,6 @@ static void d3dbc_write_store(struct d3dbc_compiler *d3dbc, const struct hlsl_ir .src_count = 1, }; - if (store->lhs.var->data_type->class == HLSL_CLASS_MATRIX) - { - hlsl_fixme(ctx, &instr->loc, "Lower matrix writemasks."); - return; - } - if (store->lhs.var->is_output_semantic) { if (version->type == VKD3D_SHADER_TYPE_PIXEL && version->major == 1) diff --git a/tests/hlsl/matrix-indexing.shader_test b/tests/hlsl/matrix-indexing.shader_test index 6793542f..27505c30 100644 --- a/tests/hlsl/matrix-indexing.shader_test +++ b/tests/hlsl/matrix-indexing.shader_test @@ -108,7 +108,7 @@ todo(glsl) draw quad probe (0, 0) rgba (3.0, 4.0, 50.0, 60.0) -[pixel shader todo(sm<4)] +[pixel shader] uniform float i; float4 main() : sv_target @@ -120,7 +120,7 @@ float4 main() : sv_target [test] uniform 0 float 2 -todo(sm<4 | glsl) draw quad +todo(glsl) draw quad probe (0, 0) rgba (8, 9, 10, 11)