From 4522a80de899d9a17ab6140fd2f3a7868a5e85bd Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?J=C3=B3zef=20Kucia?= <jkucia@codeweavers.com>
Date: Tue, 10 Oct 2017 16:57:36 +0200
Subject: [PATCH] libs/vkd3d-shader: Use switch statement in
 shader_write_root_parameters().

---
 libs/vkd3d-shader/dxbc.c | 36 ++++++++++++++++++------------------
 1 file changed, 18 insertions(+), 18 deletions(-)

diff --git a/libs/vkd3d-shader/dxbc.c b/libs/vkd3d-shader/dxbc.c
index 7c328a89..573355f5 100644
--- a/libs/vkd3d-shader/dxbc.c
+++ b/libs/vkd3d-shader/dxbc.c
@@ -2473,26 +2473,26 @@ static HRESULT shader_write_root_parameters(struct root_signature_writer_context
     {
         context->data[parameters_position + 3 * i + 2] = get_chunk_offset(context); /* offset */
 
-        if (parameters[i].ParameterType == D3D12_ROOT_PARAMETER_TYPE_DESCRIPTOR_TABLE)
+        switch (parameters[i].ParameterType)
         {
-            if (FAILED(hr = shader_write_descriptor_table(context, &parameters[i].u.DescriptorTable)))
-                return hr;
-        }
-        else if (parameters[i].ParameterType == D3D12_ROOT_PARAMETER_TYPE_32BIT_CONSTANTS)
-        {
-            if (FAILED(hr = shader_write_root_constants(context, &parameters[i].u.Constants)))
-                return hr;
-        }
-        else  if (parameters[i].ParameterType <= D3D12_ROOT_PARAMETER_TYPE_UAV)
-        {
-            if (FAILED(hr = shader_write_root_descriptor(context, &parameters[i].u.Descriptor)))
-                return hr;
-        }
-        else
-        {
-            FIXME("Unrecognized type %#x.\n", parameters[i].ParameterType);
-            return E_INVALIDARG;
+            case D3D12_ROOT_PARAMETER_TYPE_DESCRIPTOR_TABLE:
+                hr = shader_write_descriptor_table(context, &parameters[i].u.DescriptorTable);
+                break;
+            case D3D12_ROOT_PARAMETER_TYPE_32BIT_CONSTANTS:
+                hr = shader_write_root_constants(context, &parameters[i].u.Constants);
+                break;
+            case D3D12_ROOT_PARAMETER_TYPE_CBV:
+            case D3D12_ROOT_PARAMETER_TYPE_SRV:
+            case D3D12_ROOT_PARAMETER_TYPE_UAV:
+                hr = shader_write_root_descriptor(context, &parameters[i].u.Descriptor);
+                break;
+            default:
+                FIXME("Unrecognized type %#x.\n", parameters[i].ParameterType);
+                return E_INVALIDARG;
         }
+
+        if (FAILED(hr))
+            return hr;
     }
 
     return S_OK;