vkd3d-shader/hlsl: Emit fixmes on non-constant vector addressing.

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=56162

Storing to a vector component using a non-constant index is not allowed
on profiles lower than 6.0. Unless this happens inside a loop that can be
unrolled, which we are not doing yet.

For this reason, a validate_nonconstant_vector_store_derefs pass is
added to detect these cases.

Ideally we would want to emit an hlsl_error on this pass, but before
implementing loop unrolling, we could reach this point on valid HLSL.

Also, as pointed out by Nikolay in the mentioned bug, currently
new_offset_from_path_index() fails an assertion when this happens,
because it expects an hlsl_ir_constant, so a check is added.
It also felt correct to emit an hlsl_fixme there, despite the
redundancy.
This commit is contained in:
Francisco Casas
2024-01-11 16:54:20 -03:00
committed by Alexandre Julliard
parent b0c8a47f9d
commit 43ff28b00b
Notes: Alexandre Julliard 2024-01-15 23:02:01 +01:00
Approved-by: Zebediah Figura (@zfigura)
Approved-by: Henri Verbeet (@hverbeet)
Approved-by: Giovanni Mascellani (@giomasce)
Approved-by: Alexandre Julliard (@julliard)
Merge-Request: https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/558
2 changed files with 52 additions and 0 deletions

View File

@@ -49,3 +49,16 @@ float4 main() : SV_TARGET
[test]
draw quad
probe all rgba (2.0, 2.0, 2.0, 2.0)
[pixel shader fail(sm<6) todo]
float4 v;
float i;
float4 main() : sv_target
{
float4 p = v;
p[i] = 2.0;
return 0;
}