wine/vkd3d
0
0
Fork 0
mirror of https://gitlab.winehq.org/wine/vkd3d.git synced 2025-04-13 05:43:18 -07:00
Code Issues Packages Projects Releases Wiki Activity

vkd3d: Support signalling a fence once all outstanding work is submitted to Vulkan.

Browse Source 
When the client acquires the Vulkan queue it has to ensure that
it is not submitting work before other work it depends on already
submitted through the Direct3D 12 API but currently in the internal
vkd3d queue. Currently we suggest to enqueue signalling a fence and
than wait for it before acquiring the Vulkan queue, which is
correct but excessive: it will wait not just for the work currently
in the queue to be submitted, but for it to be executed too,
introducing useless dependencies.

By adding a way to enqueue signalling a fence on the CPU side we
allow the client to wait for the currently outstanding work to
be submitted to Vulkan, but nothing more.
This commit is contained in:
Giovanni Mascellani
2025-01-16 12:53:01 +01:00
committed by Henri Verbeet
parent bdb8291f6c
commit 22d0841412
Notes: Henri Verbeet 2025-01-21 14:13:31 +01:00 
Approved-by: Henri Verbeet (@hverbeet)
Approved-by: Giovanni Mascellani (@giomasce)
Merge-Request: https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/1343
5 changed files with 139 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

29
include/vkd3d.h
View File

@@ -411,9 +411,13 @@ VKD3D_API uint32_t vkd3d_get_vk_queue_family_index(ID3D12CommandQueue *queue);
* the Vulkan driver as being submitted before other work submitted
* though the Direct3D 12 API. If this is not desired, it is
* recommended to synchronize work submission using an ID3D12Fence
* object, by submitting to the queue a signal operation after all the
* Direct3D 12 work is submitted and waiting for it before calling
* vkd3d_acquire_vk_queue().
* object:
* 1. submit work through the Direct3D 12 API;
* 2. call vkd3d_queue_signal_on_cpu();
* 3. wait for the fence to be signalled;
* 4. call vkd3d_acquire_vk_queue(); it is guaranteed that all work submitted
* at point 1 has already been submitted to Vulkan (though not necessarily
* executed).
*
* \since 1.0
*/
@@ -466,6 +470,21 @@ VKD3D_API HRESULT vkd3d_create_versioned_root_signature_deserializer(const void
*/
VKD3D_API void vkd3d_set_log_callback(PFN_vkd3d_log callback);
/**
* Signal a fence on the CPU once all the currently outstanding queue work is
* submitted to Vulkan.
*
* The fence will be signalled on the CPU (as if ID3D12Fence_Signal() was
* called) once all the work submitted through the Direct3D 12 API before
* vkd3d_queue_signal_on_cpu() is called has left the internal queue and has
* been submitted to the underlying Vulkan queue. Read the documentation for
* vkd3d_acquire_vk_queue() for more details.
*
* \since 1.15
*/
VKD3D_API HRESULT vkd3d_queue_signal_on_cpu(ID3D12CommandQueue *queue,
ID3D12Fence *fence, uint64_t value);
#endif /* VKD3D_NO_PROTOTYPES */
/*
@@ -512,6 +531,10 @@ typedef HRESULT (*PFN_vkd3d_create_versioned_root_signature_deserializer)(const
/** Type of vkd3d_set_log_callback(). \since 1.4 */
typedef void (*PFN_vkd3d_set_log_callback)(PFN_vkd3d_log callback);
/** Type of vkd3d_queue_signal_on_cpu(). \since 1.15 */
typedef HRESULT (*PFN_vkd3d_queue_signal_on_cpu)(ID3D12CommandQueue *queue,
ID3D12Fence *fence, uint64_t value);
#ifdef __cplusplus
}
#endif /* __cplusplus */