mirror of
https://gitlab.winehq.org/wine/wine-gecko.git
synced 2024-09-13 09:24:08 -07:00
8075a939ec
This fixes a crash when we initialize nsNavBookmarks with a database that is out of date (the schema version is less than the current one). Because the bookmark service initializes the history service in its Init method, and the history service tries to get the bookmark service if the database needs an upgrade, we try to re-enter the bookmark service's constructor. Bad things happen. Adds a test to ensure that we don't do this again. r=dietrich r=MaK77
62 lines
2.8 KiB
JavaScript
62 lines
2.8 KiB
JavaScript
/* -*- Mode: Java; tab-width: 2; indent-tabs-mode: nil; c-basic-offset: 2 -*- */
|
|
/* vim:set ts=2 sw=2 sts=2 et: */
|
|
/* ***** BEGIN LICENSE BLOCK *****
|
|
* Version: MPL 1.1/GPL 2.0/LGPL 2.1
|
|
*
|
|
* The contents of this file are subject to the Mozilla Public License Version
|
|
* 1.1 (the "License"); you may not use this file except in compliance with
|
|
* the License. You may obtain a copy of the License at
|
|
* http://www.mozilla.org/MPL/
|
|
*
|
|
* Software distributed under the License is distributed on an "AS IS" basis,
|
|
* WITHOUT WARRANTY OF ANY KIND, either express or implied. See the License
|
|
* for the specific language governing rights and limitations under the
|
|
* License.
|
|
*
|
|
* The Original Code is Places Test code.
|
|
*
|
|
* The Initial Developer of the Original Code is
|
|
* Mozilla Corporation.
|
|
* Portions created by the Initial Developer are Copyright (C) 2009
|
|
* the Initial Developer. All Rights Reserved.
|
|
*
|
|
* Contributor(s):
|
|
* Shawn Wilsher <me@shawnwilsher.com> (Original Author)
|
|
*
|
|
* Alternatively, the contents of this file may be used under the terms of
|
|
* either the GNU General Public License Version 2 or later (the "GPL"), or
|
|
* the GNU Lesser General Public License Version 2.1 or later (the "LGPL"),
|
|
* in which case the provisions of the GPL or the LGPL are applicable instead
|
|
* of those above. If you wish to allow use of your version of this file only
|
|
* under the terms of either the GPL or the LGPL, and not to allow others to
|
|
* use your version of this file under the terms of the MPL, indicate your
|
|
* decision by deleting the provisions above and replace them with the notice
|
|
* and other provisions required by the GPL or the LGPL. If you do not delete
|
|
* the provisions above, a recipient may use your version of this file under
|
|
* the terms of any one of the MPL, the GPL or the LGPL.
|
|
*
|
|
* ***** END LICENSE BLOCK ***** */
|
|
|
|
/**
|
|
* This tests a crash during startup found in bug 476292 that was caused by
|
|
* getting the bookmarks service during nsNavHistory::Init when the bookmarks
|
|
* service was created before the history service was.
|
|
*/
|
|
|
|
function run_test()
|
|
{
|
|
// First, we need to move our old database file into our test profile
|
|
// directory. This will trigger DATABASE_STATUS_UPGRADED (CREATE is not
|
|
// sufficient since there will be no entires to update frecencies for, which
|
|
// causes us to get the bookmarks service in the first place).
|
|
let dbFile = do_get_file("toolkit/components/places/tests/unit/bug476292.sqlite");
|
|
let profD = Cc["@mozilla.org/file/directory_service;1"].
|
|
getService(Ci.nsIProperties).
|
|
get(NS_APP_USER_PROFILE_50_DIR, Ci.nsIFile);
|
|
dbFile.copyTo(profD, "places.sqlite");
|
|
|
|
// Now get the bookmarks service. This will crash when the bug exists.
|
|
let bs = Cc["@mozilla.org/browser/nav-bookmarks-service;1"].
|
|
getService(Ci.nsINavBookmarksService);
|
|
}
|