mirror of
https://gitlab.winehq.org/wine/wine-gecko.git
synced 2024-09-13 09:24:08 -07:00
1a68eab98d
The nsCSSValue in nsGenericHTMLElement::MapBackgroundInto is a temporary. This causes a problem after Bug 697230 landed, because the nsCSSValue::Image we put into that value is destroyed once we're done doing style stuff. Previously the nsImageLoader would grab the request off the nsCSSValue::Image and hold it alive. Bug 697230 changed the behavior here; now when the nsCSSValue::Image is destroyed it tells the image loader to drop the request. The result is that all the references to the request are dropped and the frame is never told it has a background. The solution is to keep the nsCSSValue::Image alive longer. This patch adds two new types of nsAttrValue. The first is an nsCSSValue::URL. A ParseBackgroundAttribute method is added on nsGenericHTMLElement that the relevant elements (body/td/th/table/tr/tbody/thead/tfoot) call that parses background into an nsCSSValue::URL. The second is an nsCSSValue::Image. nsGenericHTMLElement::MapBackgroundInto attempts to convert the nsCSSValue::URL into an nsCSSValue::Image by kicking off the image load. The result is that image loads are only started when the element is actually visible. This also mirrors the way background-image works. This also allows us to fix two longstanding bugs in this code. Since MapBackgroundInto doesn't have a pointer to the actual element, it relied on grabbing the principal of the document. Now we can grab the principal of the node in ParseBackgroundAttribute. MapBackgroundInto also has no way to get at the element's base URI (to honor xml:base), which is now possible in ParseBackgroundAttribute. nsCSSValue::[Image|URL] have also been moved to be mozilla::css::[Image|URL]Value. nsAttrValue.h is included in external linkage code, so it can't include nsCSSValue.h to get the declarations of nsCSSValue::[Image|URL], and nested classes can't be forward declared. Moving the classes to a namespace solves the problem. Finally some old inoperative quirks mode code was removed. This code has done nothing since Bug 273078 was landed in 2004.
125 lines
3.8 KiB
C++
125 lines
3.8 KiB
C++
/* This Source Code Form is subject to the terms of the Mozilla Public
|
|
* License, v. 2.0. If a copy of the MPL was not distributed with this file,
|
|
* You can obtain one at http://mozilla.org/MPL/2.0/. */
|
|
|
|
// A class that handles style system image loads (other image loads are handled
|
|
// by the nodes in the content tree).
|
|
|
|
#include "nsAutoPtr.h"
|
|
#include "nsClassHashtable.h"
|
|
#include "nsHashKeys.h"
|
|
#include "nsInterfaceHashtable.h"
|
|
#include "nsCSSValue.h"
|
|
#include "imgIRequest.h"
|
|
#include "imgIOnloadBlocker.h"
|
|
#include "nsStubImageDecoderObserver.h"
|
|
|
|
class nsIFrame;
|
|
class nsIDocument;
|
|
class nsPresContext;
|
|
class nsIURI;
|
|
class nsIPrincipal;
|
|
|
|
namespace mozilla {
|
|
namespace css {
|
|
|
|
class ImageLoader : public nsStubImageDecoderObserver,
|
|
public imgIOnloadBlocker {
|
|
public:
|
|
typedef mozilla::css::ImageValue Image;
|
|
|
|
ImageLoader(nsIDocument* aDocument)
|
|
: mDocument(aDocument),
|
|
mInClone(false)
|
|
{
|
|
MOZ_ASSERT(mDocument);
|
|
|
|
mRequestToFrameMap.Init();
|
|
mFrameToRequestMap.Init();
|
|
mImages.Init();
|
|
}
|
|
|
|
NS_DECL_ISUPPORTS
|
|
NS_DECL_IMGIONLOADBLOCKER
|
|
|
|
// imgIDecoderObserver (override nsStubImageDecoderObserver)
|
|
NS_IMETHOD OnStartContainer(imgIRequest *aRequest, imgIContainer *aImage);
|
|
NS_IMETHOD OnStopFrame(imgIRequest *aRequest, uint32_t aFrame);
|
|
NS_IMETHOD OnImageIsAnimated(imgIRequest *aRequest);
|
|
// Do not override OnDataAvailable since background images are not
|
|
// displayed incrementally; they are displayed after the entire image
|
|
// has been loaded.
|
|
|
|
// imgIContainerObserver (override nsStubImageDecoderObserver)
|
|
NS_IMETHOD FrameChanged(imgIRequest* aRequest,
|
|
imgIContainer *aContainer,
|
|
const nsIntRect *aDirtyRect);
|
|
|
|
void DropDocumentReference();
|
|
|
|
void MaybeRegisterCSSImage(Image* aImage);
|
|
void DeregisterCSSImage(Image* aImage);
|
|
|
|
void AssociateRequestToFrame(imgIRequest* aRequest,
|
|
nsIFrame* aFrame);
|
|
|
|
void DisassociateRequestFromFrame(imgIRequest* aRequest,
|
|
nsIFrame* aFrame);
|
|
|
|
void DropRequestsForFrame(nsIFrame* aFrame);
|
|
|
|
void SetAnimationMode(uint16_t aMode);
|
|
|
|
void ClearAll();
|
|
|
|
void LoadImage(nsIURI* aURI, nsIPrincipal* aPrincipal, nsIURI* aReferrer,
|
|
Image* aCSSValue);
|
|
|
|
void DestroyRequest(imgIRequest* aRequest);
|
|
|
|
private:
|
|
// We need to be able to look up the frames associated with a request (for
|
|
// delivering notifications) and the requests associated with a frame (when
|
|
// the frame goes away). Thus we maintain hashtables going both ways. These
|
|
// should always be in sync.
|
|
|
|
typedef nsTArray<nsIFrame*> FrameSet;
|
|
typedef nsTArray<nsCOMPtr<imgIRequest> > RequestSet;
|
|
typedef nsTHashtable<nsPtrHashKey<Image> > ImageHashSet;
|
|
typedef nsClassHashtable<nsISupportsHashKey,
|
|
FrameSet> RequestToFrameMap;
|
|
typedef nsClassHashtable<nsPtrHashKey<nsIFrame>,
|
|
RequestSet> FrameToRequestMap;
|
|
|
|
void AddImage(Image* aCSSImage);
|
|
void RemoveImage(Image* aCSSImage);
|
|
|
|
nsPresContext* GetPresContext();
|
|
|
|
void DoRedraw(FrameSet* aFrameSet);
|
|
|
|
static PLDHashOperator
|
|
SetAnimationModeEnumerator(nsISupports* aKey, FrameSet* aValue,
|
|
void* aClosure);
|
|
|
|
// A map of imgIRequests to the nsIFrames that are using them.
|
|
RequestToFrameMap mRequestToFrameMap;
|
|
|
|
// A map of nsIFrames to the imgIRequests they use.
|
|
FrameToRequestMap mFrameToRequestMap;
|
|
|
|
// A weak pointer to our document. Nulled out by DropDocumentReference.
|
|
nsIDocument* mDocument;
|
|
|
|
// The set of all nsCSSValue::Images (whether they're associated a frame or
|
|
// not). We'll need this when we go away to remove any requests associated
|
|
// with our document from those Images.
|
|
ImageHashSet mImages;
|
|
|
|
// Are we cloning? If so, ignore any notifications we get.
|
|
bool mInClone;
|
|
};
|
|
|
|
} // namespace css
|
|
} // namespace mozilla
|