mirror of
https://gitlab.winehq.org/wine/wine-gecko.git
synced 2024-09-13 09:24:08 -07:00
742666beae
I broke out this this change on its own, because it seemed to require some care: PR_ADDRESS_NOT_SUPPORTED_ERROR used to be lumped in with several other NSPR error codes and reported as NS_ERROR_CONNECTION_REFUSED; and a dumb grep shows that the NS_ERROR_ is widely checked for. Introducing the distinction might require the new NS_ERROR_SOCKET_ADDRESS_NOT_SUPPORTED value to be checked for everywhere that currently checks for NS_ERROR_CONNECTION_REFUSED. But that seems unlikely to be necessary: first of all, it shouldn't really be possible, via the XPCOM interface, to force this error path to occur at present: the components' implementations are in complete control over which socket address types get used. I also did a Try push with a call to NS_ABORT if a PR_ADDRESS_NOT_SUPPORTED_ERROR ever flows through ErrorAccordingToNSPR; there were no crashes. But if that's so, then why introduce the new error code at all? A later patch adds support for Unix-domain sockets, a type of socket address which is *not* supported on non-Unix systems. In that case, a distinct error code will help people diagnose problems quickly. |
||
|---|---|---|
| .. | ||
| public | ||
| src | ||
| moz.build | ||