mirror of
https://gitlab.winehq.org/wine/wine-gecko.git
synced 2024-09-13 09:24:08 -07:00
72d5471898
The tree doesn't have a robust and reusable API for interfacing with crash data. This patch is the start of a new API. In this patch, the CrashManager type is introduced. It has APIs for retrieving the lists of files related to crash dumps. In subsequent patches, I will convert existing code in the tree that does similar things to the new API. I will also build the events/timeline API onto this type. I made CrashManager generic because I hate, hate, hate singletons and global variables. Allowing it to be instantiated multiple times with different options (instead of say binding a global instance to ProfD) makes the testing story much, much nicer. That is reason enough, IMO. In a subsequent patch, I'll add an XPCOM service that instantiates the "global" instance of CrashManager with the appropriate options. It was tempting to add this code into the existing CrashReports.jsm. However, this file does not import cleanly in xpcshell tests and I didn't want to bloat scope to include fixing that file... yet. CrashReports.jsm is using synchronous I/O. So, depending on how adventerous I feel, I may replace consumers of CrashReports.jsm with the new CrashManager.jsm, remove CrashReports.jsm, and eliminate another source of synchronous I/O in the tree. --HG-- extra : rebase_source : 379fa6a78b53bc0dea0c7c64e8b1bdcf85b61a7c |
||
|---|---|---|
| .. | ||
| components | ||
| content | ||
| crashreporter | ||
| devtools | ||
| forgetaboutsite | ||
| identity | ||
| library | ||
| locales | ||
| modules | ||
| mozapps | ||
| obsolete | ||
| profile | ||
| system | ||
| themes | ||
| webapps | ||
| xre | ||
| moz.build | ||
| toolkit.mozbuild | ||