mirror of
https://gitlab.winehq.org/wine/wine-gecko.git
synced 2024-09-13 09:24:08 -07:00
fdaefb68d6
These scriptable interfaces use uint_64 arguments with sentinel values of UINT64_MAX. However, UINT64_MAX exceeds MAX_SAFE_INTEGER and cannot be gatewayed to/from javascript - so they cannot be used correctly. Change them to use signed 64 bit numbers and -1 as the sentinnel. C++ implementations ought to be enough to audit as the special value could never be used correctly in JS anyhow - also audited OnProgressChange() uses for downstream use of this data. --- dom/base/nsXMLHttpRequest.cpp | 19 +++++++---- dom/base/nsXMLHttpRequest.h | 10 +++--- dom/plugins/base/nsPluginStreamListenerPeer.cpp | 4 +-- .../webbrowserpersist/nsWebBrowserPersist.cpp | 14 ++++---- image/src/imgLoader.cpp | 4 +-- modules/libjar/nsJARChannel.cpp | 3 +- netwerk/base/public/nsIProgressEventSink.idl | 8 ++--- netwerk/base/public/nsITransport.idl | 8 ++--- netwerk/base/public/nsNetUtil.h | 24 ++++++++++++++ netwerk/base/src/Dashboard.cpp | 2 +- netwerk/base/src/nsBaseChannel.cpp | 12 +++---- netwerk/base/src/nsIncrementalDownload.cpp | 4 +-- netwerk/base/src/nsSocketTransport2.cpp | 5 +-- netwerk/base/src/nsStreamTransportService.cpp | 38 +++++++++++++--------- netwerk/base/src/nsTransportUtils.cpp | 12 +++---- netwerk/protocol/file/nsFileChannel.cpp | 8 +++-- netwerk/protocol/ftp/nsFtpConnectionThread.cpp | 4 +-- netwerk/protocol/http/Http2Push.cpp | 2 +- netwerk/protocol/http/Http2Session.cpp | 2 +- netwerk/protocol/http/HttpChannelChild.cpp | 31 +++++++++--------- netwerk/protocol/http/HttpChannelChild.h | 6 ++-- netwerk/protocol/http/HttpChannelParent.cpp | 4 +-- netwerk/protocol/http/HttpChannelParent.h | 4 +-- netwerk/protocol/http/NullHttpTransaction.cpp | 2 +- netwerk/protocol/http/PHttpChannel.ipdl | 2 +- netwerk/protocol/http/SpdyPush31.cpp | 2 +- netwerk/protocol/http/SpdySession31.cpp | 2 +- netwerk/protocol/http/TunnelUtils.cpp | 2 +- netwerk/protocol/http/nsAHttpTransaction.h | 4 +-- netwerk/protocol/http/nsHttpChannel.cpp | 30 +++++++++++------ netwerk/protocol/http/nsHttpConnection.cpp | 4 +-- netwerk/protocol/http/nsHttpConnectionMgr.cpp | 4 +-- netwerk/protocol/http/nsHttpPipeline.cpp | 4 +-- netwerk/protocol/http/nsHttpPipeline.h | 6 ++-- netwerk/protocol/http/nsHttpResponseHead.cpp | 2 +- netwerk/protocol/http/nsHttpResponseHead.h | 2 +- netwerk/protocol/http/nsHttpTransaction.cpp | 32 +++++++++--------- netwerk/protocol/http/nsHttpTransaction.h | 2 +- netwerk/protocol/wyciwyg/WyciwygChannelChild.cpp | 2 +- netwerk/protocol/wyciwyg/nsWyciwygChannel.cpp | 3 +- netwerk/test/TestIncrementalDownload.cpp | 7 ++-- uriloader/base/nsDocLoader.cpp | 14 ++++---- 42 files changed, 203 insertions(+), 151 deletions(-)
105 lines
3.1 KiB
C++
105 lines
3.1 KiB
C++
/* -*- Mode: C++; tab-width: 4; indent-tabs-mode: nil; c-basic-offset: 4 -*- */
|
|
/* This Source Code Form is subject to the terms of the Mozilla Public
|
|
* License, v. 2.0. If a copy of the MPL was not distributed with this
|
|
* file, You can obtain one at http://mozilla.org/MPL/2.0/. */
|
|
|
|
#ifndef nsHttpPipeline_h__
|
|
#define nsHttpPipeline_h__
|
|
|
|
#include "nsAHttpConnection.h"
|
|
#include "nsAHttpTransaction.h"
|
|
#include "nsTArray.h"
|
|
#include "nsCOMPtr.h"
|
|
|
|
class nsIInputStream;
|
|
class nsIOutputStream;
|
|
|
|
namespace mozilla { namespace net {
|
|
|
|
class nsHttpPipeline MOZ_FINAL : public nsAHttpConnection
|
|
, public nsAHttpTransaction
|
|
, public nsAHttpSegmentReader
|
|
{
|
|
public:
|
|
NS_DECL_THREADSAFE_ISUPPORTS
|
|
NS_DECL_NSAHTTPCONNECTION(mConnection)
|
|
NS_DECL_NSAHTTPTRANSACTION
|
|
NS_DECL_NSAHTTPSEGMENTREADER
|
|
|
|
nsHttpPipeline();
|
|
|
|
bool ResponseTimeoutEnabled() const MOZ_OVERRIDE MOZ_FINAL {
|
|
return true;
|
|
}
|
|
|
|
private:
|
|
virtual ~nsHttpPipeline();
|
|
|
|
nsresult FillSendBuf();
|
|
|
|
static NS_METHOD ReadFromPipe(nsIInputStream *, void *, const char *,
|
|
uint32_t, uint32_t, uint32_t *);
|
|
|
|
// convenience functions
|
|
nsAHttpTransaction *Request(int32_t i)
|
|
{
|
|
if (mRequestQ.Length() == 0)
|
|
return nullptr;
|
|
|
|
return mRequestQ[i];
|
|
}
|
|
nsAHttpTransaction *Response(int32_t i)
|
|
{
|
|
if (mResponseQ.Length() == 0)
|
|
return nullptr;
|
|
|
|
return mResponseQ[i];
|
|
}
|
|
|
|
// overload of nsAHttpTransaction::QueryPipeline()
|
|
nsHttpPipeline *QueryPipeline() MOZ_OVERRIDE;
|
|
|
|
nsRefPtr<nsAHttpConnection> mConnection;
|
|
nsTArray<nsAHttpTransaction*> mRequestQ; // array of transactions
|
|
nsTArray<nsAHttpTransaction*> mResponseQ; // array of transactions
|
|
nsresult mStatus;
|
|
|
|
// these flags indicate whether or not the first request or response
|
|
// is partial. a partial request means that Request(0) has been
|
|
// partially written out to the socket. a partial response means
|
|
// that Response(0) has been partially read in from the socket.
|
|
bool mRequestIsPartial;
|
|
bool mResponseIsPartial;
|
|
|
|
// indicates whether or not the pipeline has been explicitly closed.
|
|
bool mClosed;
|
|
|
|
// indicates whether or not a true pipeline (more than 1 request without
|
|
// a synchronous response) has been formed.
|
|
bool mUtilizedPipeline;
|
|
|
|
// used when calling ReadSegments/WriteSegments on a transaction.
|
|
nsAHttpSegmentReader *mReader;
|
|
|
|
// send buffer
|
|
nsCOMPtr<nsIInputStream> mSendBufIn;
|
|
nsCOMPtr<nsIOutputStream> mSendBufOut;
|
|
|
|
// the push back buffer. not exceeding nsIOService::gDefaultSegmentSize bytes.
|
|
char *mPushBackBuf;
|
|
uint32_t mPushBackLen;
|
|
uint32_t mPushBackMax;
|
|
|
|
// The number of transactions completed on this pipeline.
|
|
uint32_t mHttp1xTransactionCount;
|
|
|
|
// For support of OnTransportStatus()
|
|
int64_t mReceivingFromProgress;
|
|
int64_t mSendingToProgress;
|
|
bool mSuppressSendEvents;
|
|
};
|
|
|
|
}} // namespace mozilla::net
|
|
|
|
#endif // nsHttpPipeline_h__
|