mirror of
https://gitlab.winehq.org/wine/wine-gecko.git
synced 2024-09-13 09:24:08 -07:00
e48e824329
Issue #1: indent/justify* can create non-valid fragments. When applying a block-level formatting to a text node, Gecko creates a div or blockquote block around the text node and sets the corresponding "align" or "style" attribute. This patch checks that the active editing host can contain such a block-level element. Issue #2: indent/justify* can modify the active editing host. On the first child of the editable element, the selection is extended outside of the active editing host -- which causes a few issues for our test cases. In this patch, this issue is "solved" by modifying `nsHTMLEditRules::GetPromotedPoint' for block-level operations. ** About the tests ** Sorry for the long explanation but I prefer to be as sharp as possible when I have to modify existing unit tests. This patch raises 34 unit test "failures" which are improvements. Two test files are concerned and have been modified accordingly: * test_htmleditor_keyevent_handling * test_richtext2.html One test has been clarified (no real modification): * test_bug414526.html Of course, a specific unit test has been added, see `test_bug677752.html'. ** editor/libeditor/html/tests/test_htmleditor_keyevent_handling.html ** Outdenting now works properly, which results in 4 `FAIL'. * 7372 ERROR TEST-UNEXPECTED-FAIL | non-tabbable HTML editor: Shift+Tab after Tab on UL - got "<ul><li id=\"target\">ul list item</li></ul>", expected "<ul><ul><li id=\"target\">ul list item</li></ul></ul>" * 7379 ERROR TEST-UNEXPECTED-FAIL | non-tabbable HTML editor: Shift+Tab on UL - got "ul list item", expected "<ul><li id=\"target\">ul list item</li></ul>" * 7415 ERROR TEST-UNEXPECTED-FAIL | non-tabbable HTML editor: Shift+Tab after Tab on OL - got "<ol><li id=\"target\">ol list item</li></ol>", expected "<ol><ol><li id=\"target\">ol list item</li></ol></ol>" * 7422 ERROR TEST-UNEXPECTED-FAIL | non-tabbable HTML editor: Shfit+Tab on OL - got "ol list item", expected "<ol><li id=\"target\">ol list item</li></ol>" ** editor/libeditor/html/tests/browserscope/test_richtext2.html ** The 15 tests that now pass result in 15 `FAIL' and 15 `UNEXPECTED_PASS'. Here's an overview of what we had before the patch: * Section A - Apply Formatting Tests: +10 points before patch: 21/31 (Selection: 9/31) after patch: 28/31 (Selection: 12/31) FB:BQ_TEXT-1_SI EXECUTION EXCEPTION FB:BQ_TEXT-1_SI EXECUTION EXCEPTION FB:BQ_BR.BR-1_SM EXECUTION EXCEPTION FB:BQ_BR.BR-1_SM EXECUTION EXCEPTION IND_TEXT-1_SI EXECUTION EXCEPTION IND_TEXT-1_SI EXECUTION EXCEPTION JC_TEXT-1_SC editing host is modified JF_TEXT-1_SC editing host is modified JL_TEXT-1_SC editing host is modified JR_TEXT-1_SC editing host is modified * Section AC - Apply Formatting Tests, using styleWithCSS: +5 points before patch: 7/18 (Selection: 5/18) after patch: 12/18 (Selection: 5/18) IND_TEXT-1_SI editing host is modified JC_TEXT-1_SC editing host is modified JF_TEXT-1_SC editing host is modified JL_TEXT-1_SC editing host is modified JR_TEXT-1_SC editing host is modified ** editor/libeditor/html/tests/test_bug414526.html ** This test has been clarified to get more explicit report messages -- the test themselves haven't been changed. A `todo_is' test has been added. This test is the one that shows that `IsNodeInActiveEditor' can't be modified, and that limiting the range promotion for block-level operations is preferrable.
125 lines
3.9 KiB
Makefile
125 lines
3.9 KiB
Makefile
#
|
|
# ***** BEGIN LICENSE BLOCK *****
|
|
# Version: MPL 1.1/GPL 2.0/LGPL 2.1
|
|
#
|
|
# The contents of this file are subject to the Mozilla Public License Version
|
|
# 1.1 (the "License"); you may not use this file except in compliance with
|
|
# the License. You may obtain a copy of the License at
|
|
# http://www.mozilla.org/MPL/
|
|
#
|
|
# Software distributed under the License is distributed on an "AS IS" basis,
|
|
# WITHOUT WARRANTY OF ANY KIND, either express or implied. See the License
|
|
# for the specific language governing rights and limitations under the
|
|
# License.
|
|
#
|
|
# The Original Code is mozilla.org code.
|
|
#
|
|
# The Initial Developer of the Original Code is
|
|
# Mozilla Foundation.
|
|
# Portions created by the Initial Developer are Copyright (C) 2008
|
|
# the Initial Developer. All Rights Reserved.
|
|
#
|
|
# Contributor(s):
|
|
#
|
|
# Alternatively, the contents of this file may be used under the terms of
|
|
# either of the GNU General Public License Version 2 or later (the "GPL"),
|
|
# or the GNU Lesser General Public License Version 2.1 or later (the "LGPL"),
|
|
# in which case the provisions of the GPL or the LGPL are applicable instead
|
|
# of those above. If you wish to allow use of your version of this file only
|
|
# under the terms of either the GPL or the LGPL, and not to allow others to
|
|
# use your version of this file under the terms of the MPL, indicate your
|
|
# decision by deleting the provisions above and replace them with the notice
|
|
# and other provisions required by the GPL or the LGPL. If you do not delete
|
|
# the provisions above, a recipient may use your version of this file under
|
|
# the terms of any one of the MPL, the GPL or the LGPL.
|
|
#
|
|
# ***** END LICENSE BLOCK *****
|
|
|
|
DEPTH = ../../../..
|
|
topsrcdir = @top_srcdir@
|
|
srcdir = @srcdir@
|
|
VPATH = @srcdir@
|
|
relativesrcdir = editor/libeditor/html/tests
|
|
|
|
include $(DEPTH)/config/autoconf.mk
|
|
include $(topsrcdir)/config/rules.mk
|
|
|
|
_TEST_FILES = \
|
|
green.png \
|
|
test_bug290026.html \
|
|
test_bug291780.html \
|
|
test_bug332636.html \
|
|
test_bug332636.html^headers^ \
|
|
test_bug366682.html \
|
|
test_bug372345.html \
|
|
test_bug410986.html \
|
|
test_bug414526.html \
|
|
test_bug417418.html \
|
|
test_bug432225.html \
|
|
test_bug439808.html \
|
|
test_bug442186.html \
|
|
test_bug449243.html \
|
|
test_bug455992.html \
|
|
test_bug456244.html \
|
|
test_bug460740.html \
|
|
test_bug478725.html \
|
|
test_bug480972.html \
|
|
test_bug484181.html \
|
|
test_bug487524.html \
|
|
test_bug520189.html \
|
|
test_bug525389.html \
|
|
test_bug537046.html \
|
|
test_bug549262.html \
|
|
file_bug549262.html \
|
|
test_bug550434.html \
|
|
test_bug551704.html \
|
|
test_bug592592.html \
|
|
test_bug597784.html \
|
|
test_bug599322.html \
|
|
test_bug607584.html \
|
|
test_bug611182.html \
|
|
test_bug612447.html \
|
|
test_bug620906.html \
|
|
test_bug622371.html \
|
|
test_bug629845.html \
|
|
test_bug640321.html \
|
|
test_bug668599.html \
|
|
test_bug674861.html \
|
|
test_bug676401.html \
|
|
test_bug677752.html \
|
|
test_CF_HTML_clipboard.html \
|
|
test_contenteditable_focus.html \
|
|
test_htmleditor_keyevent_handling.html \
|
|
test_select_all_without_body.html \
|
|
file_select_all_without_body.html \
|
|
test_root_element_replacement.html \
|
|
$(NULL)
|
|
|
|
_DATA_FILES = \
|
|
data/cfhtml-chromium.txt \
|
|
data/cfhtml-firefox.txt \
|
|
data/cfhtml-ie.txt \
|
|
data/cfhtml-ooo.txt \
|
|
$(NULL)
|
|
|
|
_CHROME_TEST_FILES = \
|
|
test_contenteditable_text_input_handling.html \
|
|
test_bug489202.xul \
|
|
test_bug490879.xul \
|
|
test_bug607584.xul \
|
|
test_bug616590.xul \
|
|
test_bug635636.html \
|
|
green.png \
|
|
$(NULL)
|
|
|
|
libs:: $(_TEST_FILES)
|
|
$(INSTALL) $(foreach f,$^,"$f") $(DEPTH)/_tests/testing/mochitest/tests/$(relativesrcdir)
|
|
(cd $(srcdir) && tar $(TAR_CREATE_FLAGS) - browserscope 2> /dev/null) | (cd $(DEPTH)/_tests/testing/mochitest/tests/$(relativesrcdir) && tar -xf -)
|
|
|
|
libs:: $(_DATA_FILES)
|
|
$(INSTALL) $(foreach f,$^,"$f") $(DEPTH)/_tests/testing/mochitest/tests/$(relativesrcdir)/data
|
|
|
|
libs:: $(_CHROME_TEST_FILES)
|
|
$(INSTALL) $(foreach f,$^,"$f") $(DEPTH)/_tests/testing/mochitest/chrome/$(relativesrcdir)
|
|
|