mirror of
https://gitlab.winehq.org/wine/wine-gecko.git
synced 2024-09-13 09:24:08 -07:00
bda7f00f83
The build system / mach currently has a very hacky virtualenv setup. Essentially, it resorts to sys.path munging instead of a proper, isolated environment. During initialization, mach installs python/psutil in sys.path. Later on, some code does an |import psutil|. This fails iff the psutil C extension can't be found. If there is a psutil C extension installed outside of mach and python/psutil, |import psutil| may load it. The version mismatch isn't detected until an extension-using psutil API is called. This has manifested inside |mach build| via the resource monitor as an |AttributeError: 'module' object has no attribute 'linux_sysinfo'| exception during psutil.virtual_memory(). The proper fix for this is for the Python environment to ensure the psutil C extension is built before attempting to import and use psutil. Arguably, psutil itself should perform some kind of version check when it imports the C extension to ensure things are in sync and fail at import time. Fixing mach and the build system Python environment to build psutil earlier/properly is a long outstanding bug. It needs to be addressed. But it is considerable effort. This patch continues the long history of wallpapering over psutil import/run failures because using a proper virutalenv from mach/build system is a lot of work. Sad panda. --HG-- extra : rebase_source : 5c449d69c0fd907ea8359ac721ef6287baa4f10e |
||
|---|---|---|
| .. | ||
| mozsystemmonitor | ||
| README.rst | ||
| setup.py | ||
================ mozsystemmonitor ================ mozsystemmonitor contains modules for monitoring a running system. SystemResourceMonitor ===================== mozsystemmonitor.resourcemonitor.SystemResourceMonitor is class used to measure system resource usage. It is useful to get a handle on what an overall system is doing.