diff --git a/media/liboggz/src/liboggz/oggz_dlist.c b/media/liboggz/src/liboggz/oggz_dlist.c index 7b26070..541563a 100644 --- a/media/liboggz/src/liboggz/oggz_dlist.c +++ b/media/liboggz/src/liboggz/oggz_dlist.c @@ -142,17 +142,23 @@ oggz_dlist_prepend(OggzDList *dlist, void *elem) { return 0; } -void +int oggz_dlist_iter(OggzDList *dlist, OggzDListIterFunc func) { OggzDListElem *p; for (p = dlist->head->next; p != dlist->tail; p = p->next) { - if (func(p->data) == DLIST_ITER_CANCEL) { + int r = func(p->data); + if (r == DLIST_ITER_ERROR) { + return -1; + } + + if (r == DLIST_ITER_CANCEL) { break; } } + return 0; } void @@ -167,13 +173,19 @@ oggz_dlist_reverse_iter(OggzDList *dlist, OggzDListIterFunc func) { } } -void +int oggz_dlist_deliter(OggzDList *dlist, OggzDListIterFunc func) { OggzDListElem *p, *q; + int result = 0; for (p = dlist->head->next; p != dlist->tail; p = q) { - if (func(p->data) == DLIST_ITER_CANCEL) { + int r = func(p->data); + if (r == DLIST_ITER_ERROR) { + result = -1; + } + + if (r == DLIST_ITER_CANCEL) { break; } @@ -183,7 +195,7 @@ oggz_dlist_deliter(OggzDList *dlist, OggzDListIterFunc func) { oggz_free(p); } - + return result; } void @@ -195,7 +207,6 @@ oggz_dlist_reverse_deliter(OggzDList *dlist, OggzDListIterFunc func) { if (func(p->data) == DLIST_ITER_CANCEL) { break; } - q = p->prev; p->prev->next = p->next; p->next->prev = p->prev; diff --git a/media/liboggz/src/liboggz/oggz_dlist.h b/media/liboggz/src/liboggz/oggz_dlist.h index 8913e73..8955250 100644 --- a/media/liboggz/src/liboggz/oggz_dlist.h +++ b/media/liboggz/src/liboggz/oggz_dlist.h @@ -36,7 +36,7 @@ struct _OggzDList; typedef struct _OggzDList OggzDList; -typedef enum {DLIST_ITER_CANCEL, DLIST_ITER_CONTINUE} OggzDListIterResponse; +typedef enum {DLIST_ITER_ERROR=-1, DLIST_ITER_CANCEL=0, DLIST_ITER_CONTINUE=1} OggzDListIterResponse; typedef OggzDListIterResponse (*OggzDListIterFunc) (void *elem); @@ -55,13 +55,13 @@ oggz_dlist_append(OggzDList *dlist, void *elem); int oggz_dlist_prepend(OggzDList *dlist, void *elem); -void +int oggz_dlist_iter(OggzDList *dlist, OggzDListIterFunc func); void oggz_dlist_reverse_iter(OggzDList *dlist, OggzDListIterFunc func); -void +int oggz_dlist_deliter(OggzDList *dlist, OggzDListIterFunc func); void diff --git a/media/liboggz/src/liboggz/oggz_read.c b/media/liboggz/src/liboggz/oggz_read.c index 81eeb9e..98e25e8 100644 --- a/media/liboggz/src/liboggz/oggz_read.c +++ b/media/liboggz/src/liboggz/oggz_read.c @@ -295,11 +295,15 @@ oggz_read_deliver_packet(void *elem) { oggz_get_unit (p->oggz, p->serialno, p->calced_granulepos); if (p->stream->read_packet) { - p->stream->read_packet(p->oggz, &(p->packet), p->serialno, - p->stream->read_user_data); + if (p->stream->read_packet(p->oggz, &(p->packet), p->serialno, + p->stream->read_user_data) != 0) { + return DLIST_ITER_ERROR; + } } else if (p->reader->read_packet) { - p->reader->read_packet(p->oggz, &(p->packet), p->serialno, - p->reader->read_user_data); + if (p->reader->read_packet(p->oggz, &(p->packet), p->serialno, + p->reader->read_user_data) != 0) { + return DLIST_ITER_ERROR; + } } p->reader->current_granulepos = gp_stored; @@ -455,7 +459,9 @@ oggz_read_sync (OGGZ * oggz) ogg_int64_t gp_stored = stream->last_granulepos; stream->last_packet = &packet; oggz_dlist_reverse_iter(oggz->packet_buffer, oggz_read_update_gp); - oggz_dlist_deliter(oggz->packet_buffer, oggz_read_deliver_packet); + if (oggz_dlist_deliter(oggz->packet_buffer, oggz_read_deliver_packet) == -1) { + return OGGZ_ERR_HOLE_IN_DATA; + } /* * fix up the stream granulepos @@ -493,7 +499,10 @@ oggz_read_sync (OGGZ * oggz) } /* If we've got a stop already, don't read more data in */ - if (cb_ret == OGGZ_STOP_OK || cb_ret == OGGZ_STOP_ERR) return cb_ret; + if (cb_ret == OGGZ_STOP_OK || + cb_ret == OGGZ_STOP_ERR || + cb_ret == OGGZ_ERR_HOLE_IN_DATA) + return cb_ret; if(oggz_read_get_next_page (oggz, &og) < 0) return OGGZ_READ_EMPTY; /* eof. leave uninitialized */ @@ -595,8 +604,9 @@ oggz_read (OGGZ * oggz, long n) nread += bytes_read; cb_ret = oggz_read_sync (oggz); - if (cb_ret == OGGZ_ERR_OUT_OF_MEMORY) + if (cb_ret == OGGZ_ERR_OUT_OF_MEMORY || cb_ret == OGGZ_ERR_HOLE_IN_DATA) { return cb_ret; + } } }