Commit Graph

866 Commits

Author SHA1 Message Date
mozilla.mano@sent.com
1b25d4835a Bug 385614 - Assert like mad when deleting Livemarks from left pane in the BM. r=dietrich. 2007-06-24 17:00:17 -07:00
sspitzer@mozilla.org
853359a4e9 fix for bug #384731: "Bookmark This Page" throws exception on close in bookmarkProperties.js if you have "bookmarkPropertiesDialog/lastUsed" annotations that point to itemIds for folder that don't exist
fix for bug #384733:  "Add Bookmark" dialog truncated if you have "bookmarkPropertiesDialog/lastUsed" annotations that point to itemIds for folder that don't exist

r=mano
2007-06-22 16:19:47 -07:00
sspitzer@mozilla.org
9cffddc61a backing out fix for bug #373944 as it causes a performance regression, see bug #385208 2007-06-20 15:46:54 -07:00
sspitzer@mozilla.org
ae49d2b81b fix for bug #373944: revert the workarounds for bug #373719, bug #373721, bug #374150 and bug #374166 caused by bug #267833.
Now that bug #373756, it is safe to do this.  But note, even when I revert the fix for bug #373756, I am not seeing the problems we saw after bug #267833 first landed.

r=mano
2007-06-20 00:43:51 -07:00
mozilla.mano@sent.com
a956febc57 Fix typo. 2007-06-20 00:27:41 -07:00
sspitzer@mozilla.org
7228bda8ed fix for bug #380735: Persist open state of the "age in days" and "site" containers in the history sidebar
r=dietrich
2007-06-19 22:19:06 -07:00
sspitzer@mozilla.org
8847d7a2d8 fix for bug #383572: changes made to bookmarks don't show in bookmark searches / Crash [@ nsCOMArray_base::InsertObjectAt nsNavHistoryFolderResultNode::OnItemChanged] deleting "ghost" bookmark
r=dietrich
2007-06-19 09:25:11 -07:00
sspitzer@mozilla.org
dc733c8c66 supplimental checkin for bug #383681: While BM is in a sorted view, adding a new separator is added below the position index, not the bookmark.
r=mano
2007-06-19 09:13:19 -07:00
sspitzer@mozilla.org
d4db964d77 fix for bug #383681: While BM is in a sorted view, adding a new separator is added below the position index, not the bookmark.
disable the "insert separator" from a sorted view and from views that are excluding items.

patch=Christine Yen <cyen@mozilla.com>

r=sspitzer
2007-06-18 21:19:39 -07:00
mozilla.mano@sent.com
df5b1d76e7 Bug 384936 - Folders in bookmarks menu are inaccessible after moving a bookmark to/in the menu. r=sspitzer. 2007-06-18 19:25:41 -07:00
sspitzer@mozilla.org
006402d0e9 fix for bug #384671: when resetting the history sidebar view, don't use applyFilter()
this is needed for bug #380735, for when we persist day and host container
open state in the history sidebar.

additionally, call load() instead of using .place directly to avoid doing queriesToQueryString() only to call queryStringToQueries().

r=mano
2007-06-18 18:31:51 -07:00
mozilla.mano@sent.com
24c272f8c2 Bug 384763 - left click broken in bookmarks menu. r=ssptizer. 2007-06-18 17:16:09 -07:00
sspitzer@mozilla.org
0314d1b6da fix for bug #384677: for history sidebar and history menu, don't specify begin / end times
r=dietrich
2007-06-18 17:08:17 -07:00
kherron@fmailbox.com
264271c49e Backing out patch for bug 376991. 2007-06-17 08:09:44 -07:00
kherron@fmailbox.com
629f5b5d26 Bug 367991 - Remove the places-specific calendar widget. Patch by Asaf Romano <mano@mozilla.com>, r=sspitzer. 2007-06-17 05:52:56 -07:00
mozilla.mano@sent.com
2104094fcf Bug 384690 - bookmarks menu is broken. r=dietrich. 2007-06-16 20:14:08 -07:00
kherron@fmailbox.com
3ef7e96849 Bug 381329 - Build fails with GCC-4.3 due to extra semi-colons and '-pedantic' flag. Patch by Art Haas <ahaas@airmail.net>. r+sr=roc. 2007-06-16 12:53:59 -07:00
sspitzer@mozilla.org
2f0c4a4330 fix for bug #382136: in Bookmarks Menu - delete separator at bottom position, deletes bookmark
r=dietrich
2007-06-15 22:07:42 -07:00
sspitzer@mozilla.org
623aced10e fix for bug #384670: current collection searches in bookmark organizer window search all of bookmarks
r=dietrich
2007-06-15 22:03:40 -07:00
mozilla.mano@sent.com
7d4df6bb57 Bug 384515 - ASSERT: null node when moving the root node in a places tree. r=dietrich. 2007-06-15 18:55:15 -07:00
mozilla.mano@sent.com
56a3006a8d Bug 337855 - Don't rebuild places menus on each open. patch by seth, dietrich & me, r=dietrich/me. 2007-06-15 18:53:06 -07:00
sspitzer@mozilla.org
8e07a8d6d4 fix for bug #381416: Sort order is not remembered by Bookmarks Manager when the View menu is usedpatch=Christine Yen <cyen@mozilla.com>r=sspitzer 2007-06-12 08:40:07 -07:00
sspitzer@mozilla.org
40ceec3b70 fix for bug #383762: "Sort by Name" doesn't work properly with non-ascii characters.patch=Pavel Cvrcek <bugs@jasnapaka.com>r=sspitzer 2007-06-12 08:24:44 -07:00
mozilla.mano@sent.com
0379949225 Bug 381878 - click on a folder in the bookmarks toolbar and then hover over the overflow arrow it doesn't expand. r=ssptizer. 2007-06-11 22:28:20 -07:00
mozilla.mano@sent.com
25393cf047 Bug 382888 - BM menu not working when DM is focused. r=gavin. 2007-06-11 22:24:58 -07:00
sspitzer@mozilla.org
722f5b8433 fix for regression bug #383529: after rebuilding the toolbar, "Open <feed name>" loads bogus address.r=dietrich 2007-06-06 19:00:05 -07:00
mozilla.mano@sent.com
4d33bc373e Bug 383328 - no 'open in tabs' menu item for folders / livemarks in bookmark toolbar overflow chevron. r=sspitzer. 2007-06-05 16:26:26 -07:00
mozilla.mano@sent.com
d485243cf3 Bug 381534 - cannot drag and drop url from location bar to bookmarks toolbar. r=sspitzer. 2007-06-05 16:24:39 -07:00
mozilla.mano@sent.com
b34f3a837c Bug 382073 - Bookmarks Service batch update API is a footgun. r=sayrer/mrbkap, a=mconnor. 2007-05-31 17:44:43 -07:00
mozilla.mano@sent.com
29b143d626 Bug 374613 - the context menu of places bookmarks with live titles is missing the 'reload' option. patch from Steve Won <swon@mozilla.com>, r=me, a=mconnor. 2007-05-31 17:39:09 -07:00
dietrich@mozilla.com
f49133d34f Bug 380232 occasionally not able to open the bookmarks dialog or subscribe to a feed url (using live bookmarks) [Remote chrome not allowed] (r=mano) 2007-05-31 12:13:15 -07:00
mozilla.mano@sent.com
2b3a27413f Bug 382101 - Cannot move bookmark folder to the 'root'. r=sspitzer. 2007-05-30 17:34:13 -07:00
sspitzer@mozilla.org
ea05cf85cb fix for bug #379591: places toolbar.xml should just change existing button itemChanged()r=mano 2007-05-30 09:17:34 -07:00
sspitzer@mozilla.org
216e23344d fix for bug #382195: clicking the "show all bookmark folders" button is slow when we're opening to the bookmarks root.r=mano/dietrich 2007-05-30 09:08:11 -07:00
mozilla.mano@sent.com
c7e487c482 Bug 382261 - Cannot move bookmarks toolbar folder. r=sspitzer. 2007-05-29 17:29:54 -07:00
sspitzer@mozilla.org
46a65c45cd fix for bug #381750: with lots of bookmarks, opening up the bookmark manager dialog is slowr=dietrich 2007-05-27 20:57:20 -07:00
sspitzer@mozilla.org
36437f7205 fix for bug #381894: Some Live Bookmarks only show in the places organizer.also, there was a crash lurking in the export code when we didn't have a feed uri.r=sayrer 2007-05-27 20:50:34 -07:00
sspitzer@mozilla.org
f09f8a8eef fix for bug #382178: unable to clear a livemark's "site location" in the bookmark properties dialogr=mano 2007-05-27 16:36:57 -07:00
sspitzer@mozilla.org
4786dbc7ba fix for bug #380702: right click, "Reload live Bookmark" of livemark on personal toolbar adds blank items to the personal toolbar.r=mano 2007-05-27 12:28:40 -07:00
sspitzer@mozilla.org
fa77da2d7f fix for bug #381624: history sidebar slower the first time you open it (or on startup), then when you switch history views.fix for regression bug #381896: history sidebar not sorted properly the first time you open itr=dietrich, mano 2007-05-25 16:50:21 -07:00
rflint@ryanflint.com
89b164dd07 Bug 381903 - WARNING: Components.reportError deprecated, use Components.utils.reportError in treeView.js. Patch by Ryan Jones <sciguyryan@gmail.com>, r=mano 2007-05-25 02:45:19 -07:00
sspitzer@mozilla.org
d3a6564b46 fix for bug #380230: personal toolbar overflow chevron not updatingr=dietrich 2007-05-24 23:11:02 -07:00
dietrich@mozilla.com
4dd4308599 Bug 381378 export is unacceptably slow for large bookmarks collections (r=mano) 2007-05-24 22:41:49 -07:00
sspitzer@mozilla.org
4a525be3ab fix for bug #381624: history sidebar slower the first time you open it (or on startup), then when you switch history viewsr=mano 2007-05-23 19:27:32 -07:00
jminta@gmail.com
f914a54187 Bug 381485 [Mac] Rename 'Get Info' back to 'Properties', r=mano 2007-05-23 06:19:41 -07:00
sspitzer@mozilla.org
9ab4f9d82c fix for bug #381624: history sidebar slower the first time you open it (or on startup), then when you switch history viewsr=mano 2007-05-22 18:44:36 -07:00
mozilla.mano@sent.com
fcf315384a Bug 372508 - rename insertItem to insertBookmark and add a title parameter. r=dietrich. 2007-05-22 18:06:31 -07:00
mozilla.mano@sent.com
fb0664a9e6 Bug 371823 - Optimize item moves. r=sspitzer. 2007-05-22 15:03:53 -07:00
sspitzer@mozilla.org
767defa6da fix for bug #368240: A link on the bottom of the history list takes long to loadr=mano 2007-05-22 13:36:43 -07:00
sspitzer@mozilla.org
a61bcd2baa fix for bug #381594: not warning user about loading js / data urlsr=dietrich 2007-05-22 13:19:45 -07:00
philringnalda@gmail.com
37bb18dcbe Bug 381335 typo fix, irc-r=mano 2007-05-20 18:38:50 -07:00
mozilla.mano@sent.com
ce228c8079 Bug 381281 - Cannot reorder bookmarks. r=sspitzer. 2007-05-20 15:27:04 -07:00
mozilla.mano@sent.com
a4805be4dd Bug 381335 - Fix various js warnings in places front-end code. patch from Henrik Skupin <hskupin@gmail.com>, r=me. 2007-05-20 08:18:41 -07:00
sayrer@gmail.com
5027b97c3d Bug 381239. Null out members of PrefHandler to break reference cycles. r=dietrich 2007-05-19 20:33:04 -07:00
jminta@gmail.com
af7f11f1ff Bug 381217 places exported bookmarks.html missing classic 'This is an automatically generated file' HTML comment, r=mano 2007-05-19 18:00:19 -07:00
mozilla.mano@sent.com
2af0609eee Bug 381218 - Organizer's view menu is broken. r=sspitzer. 2007-05-19 17:44:57 -07:00
mozilla.mano@sent.com
a5b97a3f54 Yet another attempt to fix result & result nodes leaks (see bug 381239 comment 13) 2007-05-19 13:29:48 -07:00
mozilla.mano@sent.com
c595ac3dea missing semicolon 2007-05-19 12:55:37 -07:00
mozilla.mano@sent.com
adbab58705 Break cycles between the xbl views to history results (bug 381239). 2007-05-19 12:54:10 -07:00
sspitzer@mozilla.org
2af310476a fix for bug #371827: places bookmarks need additional metadate for lastModified and dateAdded.fix for bug #381209: don't write out ID attributes to bookmarks.html, as it will confuse Firefox 2.patch by dietrich, sspitzer. r=mano,dietrich,sspitzer 2007-05-18 17:40:55 -07:00
sspitzer@mozilla.org
f557d5352d fix for bug #381145: export doesn't always write out toolbar folder attribute in some circumstances.r=mano/dietrich 2007-05-18 15:00:36 -07:00
thunder@mozilla.com
06fe86956c Bug 380997: Don't set the places bookmarks toolbar favicon. r=sspitzer 2007-05-18 01:45:36 -07:00
thunder@mozilla.com
1af4acd1c8 Bug 381129: Do not write IDs for separators in exported bookmarks.html files. r=sspitzer 2007-05-18 00:48:00 -07:00
thunder@mozilla.com
ced6a4f9a3 Bug 380999: Disable import-to-folder tests, fix a few other minor issues in import/export code. r=dietrich 2007-05-18 00:00:00 -07:00
thunder@mozilla.com
0fb5370de3 Bug 380999: Clear places bookmarks on initial import. r=dietrich 2007-05-17 20:36:02 -07:00
mozilla.mano@sent.com
3e6b4a6600 Bug 381042 - Error: childFolder not defined. r=sspitzer. 2007-05-17 13:41:01 -07:00
thunder@mozilla.com
b0ef359d62 Bug 376253: Places bookmarks import/export unit tests + assorted fixes uncovered by the tests. r=mano, r=dietrich 2007-05-16 23:06:48 -07:00
enndeakin@sympatico.ca
d7f51d5fe8 Bug 369813, persist container open state in trees, r=mano 2007-05-16 18:14:27 -07:00
thunder@mozilla.com
f3ee419bd1 Fix build bustage - don't build places import/export code except when MOZ_PLACES_BOOKMARKS are enabled. r=mano 2007-05-15 17:05:09 -07:00
thunder@mozilla.com
4f91d1194f Bug 373501: Add import/export of microsummaries to places. r=mano 2007-05-15 16:23:51 -07:00
mozilla.mano@sent.com
f5f32a1a38 Bug 380693 - unable to create a bookmark folder. r=sspitzer. 2007-05-14 21:22:14 -07:00
mozilla.mano@sent.com
7d3423612f Bug 380689 - Import & Export separators titles. r=sspitzer. 2007-05-14 21:18:25 -07:00
mozilla.mano@sent.com
9cf5508862 Bug 329842 - Add support for POST keywords. r=sspitzer. 2007-05-14 20:59:38 -07:00
mozilla.mano@sent.com
3031ce0327 Bug 372508 part 2 - remove folderId getter. r=sspitzer. 2007-05-14 14:56:38 -07:00
mozilla.mano@sent.com
c0bac3b3b7 Bug 376852 - Add description and keyword columns to places orgaznier. r=sspitzer. 2007-05-14 14:53:33 -07:00
mozilla.mano@sent.com
d76e630729 Bug 334758 - Import and export bookmark descriptions, patch by dietrich and me, r=sspitzer. 2007-05-11 12:26:14 -07:00
enndeakin@sympatico.ca
3042d48295 Bug 325342, implement places sort bookmark folder by name command, r=dietrich,mano 2007-05-11 12:06:57 -07:00
sspitzer@mozilla.org
4e84f876cf supplimental patch for bug #334669: "bookmark separators have an icon overlaid over it". the supplimental patch keeps favicons at 16 px x 16 px (see bug #364316).r=manothanks to onemen.one@gmail for the patch 2007-05-10 23:17:18 -07:00
mozilla.mano@sent.com
72de7137c4 Bug 380317 - crash on shutdown in nsPlacesImportExportService::WriteContainerContents(), mLivemarkService is null. r=sspitzer. 2007-05-10 16:52:47 -07:00
mozilla.mano@sent.com
769a716f84 Bug 372508 - compact the bookmark APIs - part 1. r=sspitzer. 2007-05-10 11:18:34 -07:00
mozilla.mano@sent.com
f1ee4c669a Bug 379211 - Use item IDs for annotating bookmark/folder items rather than place: URIs. r=dietrich. 2007-05-10 01:05:19 -07:00
dietrich@mozilla.com
d975b1127f Bug 376008 - typo fix (for onemen.one, r=mano) 2007-05-07 11:27:38 -07:00
asqueella@gmail.com
69e7a629f0 Bug 379472 - fix typo in _getLoadInSidebarAnnotationp=onemen.one@gmail.comr=mano 2007-05-03 23:47:02 -07:00
sspitzer@mozilla.org
28c106ce0b fix for bug #379552: when I drop a page with no title onto the personal toolbar, we should use the uri as the title.r=mano 2007-05-03 07:37:11 -07:00
enndeakin@sympatico.ca
b49d85c4ab Bug 337868, update places bookmarks toolbar when items are modified, r=mano 2007-05-03 05:26:27 -07:00
dietrich@mozilla.com
ee0fa0b46b fix test bustage from bug 376008 2007-05-03 02:57:59 -07:00
dietrich@mozilla.com
1cd5754cc2 Bug 376008 bookmarks html import/export needs to move to /browser (r=mano) 2007-05-03 01:56:41 -07:00
sspitzer@mozilla.org
561c2b6ef8 fix for bug #376302: unable to drop favicon or link onto personal toolbar folder, favicon drop leaves the cursor behindr=mano 2007-05-02 00:06:34 -07:00
asqueella@gmail.com
14b3277bc6 Bug 378257 - Typo in buildSelectionMetadata causing wrong annotations name to fill in the node metadatap=onemen.one@gmail.comr=mano 2007-04-27 09:37:09 -07:00
mozilla.mano@sent.com
7737f46584 Bug 377500 - Result is broken if two bookmarks items have the same URL but with different titles. r=dietrich. 2007-04-25 14:03:29 -07:00
mozilla.mano@sent.com
b833653cb5 Bug 376581 - ASSERT: null node when deleting last history item. patch from onemen.one@gmail.com, r=me. 2007-04-23 16:38:04 -07:00
mozilla.mano@sent.com
27bd6a1ae3 Bug 378248 - PlacesCreateLivemarkTransaction doTransaction use getItemURI instead of getFolderURI. patch from onemen.one@gmail.com, r=me. 2007-04-23 16:34:08 -07:00
mozilla.mano@sent.com
c2a9faa4e3 Bug 378470 - refreshVisibleSection fails to update viewIndex properly. patch from onemen.one@gmail.com, r=me. 2007-04-23 16:30:11 -07:00
dietrich@mozilla.com
4e4384eab1 Bug 377066 GetAnnotationInfo always returns VALUE_TYPE_TEXT as the annotation type (r=mano) 2007-04-22 14:48:52 -07:00
mozilla.mano@sent.com
b3b55e1e56 Bug 376731 - Pasting/Dropping a child of a live-bookmark should not copy over its livemark/bookmarkFeedURI annotation. r=dietrich. 2007-04-09 17:36:43 -07:00
mozilla.mano@sent.com
5bb1430076 Bug 376798 - QueriesToQueryString prefixes the first parameter with an ampersand. r=dietrich. 2007-04-09 17:30:52 -07:00
mozilla.mano@sent.com
9bd69cfc25 Bug 376661 - History Sidebar->Bookmark This Link menu-item should be hidden for multiple-items selection. r=dietrich. 2007-04-05 17:03:13 -07:00
mozilla.mano@sent.com
7a52426d7b Bug 376618 - History Sidebar->Bookmark This Link should open the bookmark properties dialog in minimal UI mode. r=dietrich. 2007-04-05 15:07:06 -07:00
enndeakin@sympatico.ca
d7be331829 Bug 376429, sorting not working when clicking column headers in places window, r=mano 2007-04-03 18:08:43 -07:00
mozilla.mano@sent.com
bb79dc18fb Bug 335323 - Fix bookmark-properties dialog dimensions and the dialog modality flag in the various modes of the dialog. r=sspitzer 2007-03-30 16:47:07 -07:00
dietrich@mozilla.com
855aef4a34 follow-up to bug 373504 (r=mano) 2007-03-30 16:16:24 -07:00
mozilla.mano@sent.com
3b2151b233 Bug 373504 - Duplicating (pasting/dropping) a bookmark item does not copy over its annotations. r=dietrich. 2007-03-30 13:36:32 -07:00
mozilla.mano@sent.com
427bdd91fb Set showRoot on the folder tree for real (bug 371076). 2007-03-30 09:05:19 -07:00
mozilla.mano@sent.com
3a61b2d30e Bug 373264 - bookmarks toolbar event overrides all instances of the toolbar binding. r=dietcih. 2007-03-28 17:07:42 -07:00
dietrich@mozilla.com
efa757deda Bug 329281 'Add Keyword for this Search' does not work w/ Places (r=mano) 2007-03-28 13:32:51 -07:00
mozilla.mano@sent.com
51ba92a2cc Bug 371076 (and bug 371077) - Query the bookmarks root rather than the places root in bookmarks-trees; allow exposing the root node of a query in the tree view (used in the organizer left pane, and in the add-bookmark dialog). This should also allow incremental updates in the bookmarks-sidebar. r=dietrich. 2007-03-27 17:28:34 -07:00
sspitzer@mozilla.org
a7496e9aa6 fix for regression bug #375481: [places] unable to dnd bookmarks to the personal toolbarr=mano 2007-03-26 22:50:29 -07:00
mozilla.mano@sent.com
103a6edab5 Bug 357316 - More add/edit UI work, see comment 18 for the change log. r=sspitzer. 2007-03-26 17:52:59 -07:00
mozilla.mano@sent.com
9653a0dd2a Bug 374986 - Inappropriate commands are enabled for 'special' folders. r=sspitzer. 2007-03-25 14:56:52 -07:00
mozilla.mano@sent.com
2feb7d856b fix typos 2007-03-25 05:35:15 -07:00
mozilla.mano@sent.com
bd9d273059 Bug 373838 - Replace nsNavHistoryResultTreeViewer with a JS, browser-specific tree view. r=dietrich. 2007-03-25 05:28:29 -07:00
mozilla.mano@sent.com
a10c232918 Bug 374990 - Default insertion-point for a new item is passed as its default description. r=gavin. 2007-03-22 18:34:28 -07:00
dietrich@mozilla.com
7a5fefa6c5 Bug 374944 Places toolkit tests should move into /toolkit (r=sayrer) 2007-03-22 17:56:55 -07:00
mozilla.mano@sent.com
66bfaee856 Bug 370105 - Remove ViewConfigurator and 'system-area' cruft. r=sspitzer. 2007-03-22 16:43:56 -07:00
mozilla.mano@sent.com
b911c22408 Bug 373502 - Implement Fx2 style microsummary picker in the properties dialog. r=dietrich. 2007-03-22 16:13:57 -07:00
hg@mozilla.com
465265d0d4 Free the (distributed) Lizard! Automatic merge from CVS: Module mozilla: tag HG_REPO_INITIAL_IMPORT at 22 Mar 2007 10:30 PDT, 2007-03-22 10:30:00 -07:00