Before, we'd run this animate the dynamic toolbar over a specified duration
even if the dynamic toolbar was not actually animating anywhere. Thus, this
patch reduces excess work when the dynamic toolbar is not scrolled out of
place (e.g. onPanZoomStopped, onLocationChange, onTabChanged). This reduced
work includes allocating the RenderTask only when we need it.
This patch moves the "fullscreen" event from the original place to the
second part, which indicates two other changes:
1. When the event is triggered, the value of fullScreen would have been
toggled to the new value, which is different from before. The changes in
browser/../browser-fullScreen.js and mobile/../browser.js are for this.
2. This event is no longer preventDefault-able, since it is triggered
after the fullscreen change. This leads to the removal of the test and
the only place which calls preventDefault on that event. That place is
a workaround for bug 1079222. To address that problem, this patch fixes
the intrinsic issue via stoping handling the fullscreen change once it
finds we failed to change the state of the widget.
This should not have any effect on nightly or aurora.
Also fix browser/installer/windows/Makefile.in
webapprt/win/Makefile.in to use the variable instead
of the file
This was just a remnant from earlier days. This launched the Fennec
activity, which is absolutely *not* something we want to do during
these browser JUnit 3 tests. That is, these should be pure
instrumentation tests that just run Java code in the correct package
and Java classloader context. They shouldn't interact with the App
lifecycle at all.
Not all the tests pass; I took a shot at fixing one but don't care to
dig deeply right now.
There are few things happening here:
* A purely mechanical move of test sources into org.mozilla.test.browser.junit3.
This is only to make it easy to specify the suite in Spoon. (But it has the
advantage of making it possible to move files around in IntelliJ, since the
symlink points to src instead of org/mozilla/gecko.)
* Specifying the suite (package name) ended up requiring changes to the
spoon-gradle-plugin anyway. Hence, I've included this custom
spoon-gradle-plugin version locally, while I work to upstream the changes.
* Some Gradle trickery to make |mach gradle runBrowserTests| execute Spoon with
the correct package name.