Neil Rashbrook
c59400d1b6
Bug 660532 Remove useless uses of PromiseFlatCString r=sdwilsh
2011-09-15 09:36:07 +01:00
Jezreel Ng
952495179e
Bug 666611 - Do not set chunksize if less than 500MiB of storage is available. r=mak
2011-09-05 10:29:06 +01:00
Marco Bonardo
f385bb121a
Bug 666420 - Upgrade to SQLite 3.7.7.1 - Telemetry VFS shim update.
...
r=sdwilsh
2011-08-26 13:43:15 +02:00
Ben Turner
47b4c0a8d0
Bug 681930, r=sicking.
2011-08-26 01:21:35 -07:00
Nicholas Nethercote
af7a092aef
Bug 662989 - Avoid crashing if a DB connection isn't asyncClose()d when it should be. r=mak.
2011-08-04 16:15:03 -07:00
Marco Bonardo
b18c921ac6
Backout changeset 4c509d9b5b59 (Bug 666611) due to failure on Windows.
2011-08-04 14:26:59 +02:00
Jezreel Ng
9979c061cd
Bug 666611 - Do not set chunksize if less than 100MiB of storage is available. r=mak
2011-08-04 09:04:52 +02:00
Taras Glek
6769ff0594
Bug 675737: Calculate time taken for by write/open/sync per db + main/other thread r=mak
2011-08-03 17:05:29 -07:00
Taras Glek
61e0c70faa
Bug 673727: Report sqlite waiting on/off main thread via telemetry r=mak
2011-07-26 15:06:34 -07:00
Taras Glek
1800d8f336
Bug 668378: Telemetry sqlite IO r=asuth
2011-07-21 11:12:31 -07:00
Steve Fink
b5b601df06
Bug 668906 - Do not call openUnsharedDatabase with a null file (r=sdwilsh)
...
--HG--
extra : rebase_source : fbd0febc77e9972d10409ce09c73759f7d156ad1
2011-07-01 15:53:41 -07:00
Nicholas Nethercote
7b61ea2b0e
Bug 653627 - Don't use char** in nsIMemoryReporter. r=khuey, sr=bz.
2011-07-08 12:45:16 +10:00
Justin Lebar
169b00ccad
Bug 664486 - Add page fault counts to about:memory on Linux and Mac. r=njn, sr=bz
...
--HG--
extra : rebase_source : 47dd7501dea7ae69e01828a5c730e8853739dc71
2011-06-16 14:34:09 -04:00
Ed Morley
bae766be77
Bug 665549 - Fix unused variable warning for 'shutdownObserved' in mozStorageService.cpp; r=sdwilsh
2011-06-23 19:01:17 -07:00
Jeff Walden
e84bb50504
Bug 662946 - Remove various headers from INSTALLED_HEADERS that shouldn't be there. r=jimb
...
--HG--
extra : rebase_source : a6028a859cac4625ef2f3227ce0fa3159b5e8556
2011-06-09 01:12:21 -07:00
Nicholas Nethercote
3f2c2d551f
Bug 656773 - Separate the process and the path in nsIMemoryReporter so that about:memory works in private browsing mode. r=sdwilsh, sr=roc.
2011-06-06 11:22:45 +10:00
Masayuki Nakano
a6fe92c33e
Bug 660743 storage should use mozilla::Preferences r=roc+sdwilsh
2011-06-02 10:05:12 +09:00
Marco Bonardo
1d4d6212bb
Merge places and mozilla-central. a=developers
2011-05-24 04:51:59 +02:00
Marco Bonardo
a363c063f6
Bug 658135 - Use sqlite3_stmt_readonly to check if multiple async statements need a transaction.
...
r=sdwilsh
2011-05-24 00:15:01 +02:00
Nicholas Nethercote
6e6a7e6844
Bug 649867 - Remove the heap-used/storage/lookaside-used memory reporter. r=sdwilsh.
2011-05-22 19:50:14 -07:00
Nicholas Nethercote
30e92c3349
Bug 657327 - about:memory: merge the "mapped" and "heap used" trees, and make the resulting tree flatter. r=sdwilsh,Jesse, sr=roc.
2011-05-22 19:49:56 -07:00
Nicholas Nethercote
abb04b1933
Bug 653630 - Change SQLite memory reporters to avoid double-counting some memory usage. r=sdwilsh.
2011-05-11 16:09:50 -07:00
Nicholas Nethercote
6ef173ddbb
Bug 633653 - revamp about:memory. r=vlad,sdwilsh,dvander,gavin,ehsan,edwsmith; sr=benjamin.
2011-05-03 17:12:58 -07:00
Allison Naaktgeboren
28fa217b5a
Bug 472530 - when statement creation fails, dump lastErrorText to stdout in debug builds r=sdwilsh
...
--HG--
extra : rebase_source : ab3a18131377d37715e5ec5474f94966f78f714f
2011-04-29 14:35:22 -07:00
Chris Jones ext:(%20and%20Kyle%20Huey%20%3Ckhuey%40kylehuey.com%3E)
0bb511a3d7
Rollup of bug 645263 and bug 646259: Switch to mozilla:: sync primitives. r=cjones,dbaron,doublec,ehsan src=bsmedberg
...
Bug 645263, part 0: Count sync primitive ctor/dtors. r=dbaron
Bug 645263, part 1: Migrate content/media to mozilla:: sync primitives. r=doublec
Bug 645263, part 2: Migrate modules/plugin to mozilla:: sync primitives. sr=bsmedberg
Bug 645263, part 3: Migrate nsComponentManagerImpl to mozilla:: sync primitives. sr=bsmedberg
Bug 645263, part 4: Migrate everything else to mozilla:: sync primitives. r=dbaron
Bug 645263, part 5: Remove nsAutoLock.*. sr=bsmedberg
Bug 645263, part 6: Make editor test be nicer to deadlock detector. r=ehsan
Bug 645263, part 7: Disable tracemalloc backtraces for xpcshell tests. r=dbaron
Bug 646259: Fix nsCacheService to use a CondVar for notifying. r=cjones
2011-03-31 23:29:02 -05:00
Chris Jones
a75fb12531
Backed out changeset 4beec31b9ea9 for increasing frequency of intermittent orange bug 618052
2011-03-31 18:57:38 -05:00
Chris Jones ext:(%20and%20Kyle%20Huey%20%3Ckhuey%40kylehuey.com%3E)
cc8b4c9c6c
Rollup of bug 645263 and bug 646259: Switch to mozilla:: sync primitives. r=cjones,dbaron,doublec,ehsan src=bsmedberg
...
Bug 645263, part 0: Count sync primitive ctor/dtors. r=dbaron
Bug 645263, part 1: Migrate content/media to mozilla:: sync primitives. r=doublec
Bug 645263, part 2: Migrate modules/plugin to mozilla:: sync primitives. sr=bsmedberg
Bug 645263, part 3: Migrate nsComponentManagerImpl to mozilla:: sync primitives. sr=bsmedberg
Bug 645263, part 4: Migrate everything else to mozilla:: sync primitives. r=dbaron
Bug 645263, part 5: Remove nsAutoLock.*. sr=bsmedberg
Bug 645263, part 6: Make editor test be nicer to deadlock detector. r=ehsan
Bug 645263, part 7: Disable tracemalloc backtraces for xpcshell tests. r=dbaron
Bug 646259: Fix nsCacheService to use a CondVar for notifying. r=cjones
2011-03-31 14:51:19 -05:00
Doug Turner ext:(%2C%20Shawn%20Wilsher%20%3Cme%40shawnwilsher.com%3E)
ef70e47ce5
Bug 615978 - Add SQLITE_DBSTATUS_* memory usage to memory reporter
...
Adds some finer-grained memory reporting about SQLite usage.
r=asuth
2011-03-31 10:19:30 -07:00
Chris Leary
733f538571
Merge mozilla-central and tracemonkey.
2011-03-29 14:52:44 -07:00
Justin Lebar
7e2c5ae50d
Bug 592557 - Eliminate uses of PR_Atomic{Increment,Decrement} functions in favor of PR_ATOMIC_{INCREMENT,DECREMENT} macros. r=bsmedberg,gal
...
--HG--
extra : rebase_source : 71069eb9c9d61131adee49279e136c8574dabc62
2011-03-28 15:58:49 -04:00
Marco Bonardo
37cc2cd994
Bug 637957 - Followup, add proper QI. rs=mossop a=blocker-orange-fix
2011-03-02 21:25:11 +01:00
Marco Bonardo
c9a5aabb5f
Bug 637957 - Make results notifier hold a strong reference to mCallback, to prevent it being destroyed prematurely.
...
r=sdwilsh a=blocker
2011-03-02 19:55:08 +01:00
Shawn Wilsher
bd975c9f6f
Bug 635482 - Crash [@ mozalloc_abort(char const* const) | NS_DebugBreak_P | AbortIfOffMainThreadIfCheckFast ] (was: [@ mozalloc_abort(char const* const) | NS_DebugBreak_P]) from nsCycleCollectingAutoRefCnt::decr with mozilla::storage::BindingParams::Release
...
Be very explicit about what thread we release objects on.
r=asuth
a=blocking
2011-02-28 11:52:31 -08:00
Phil Ringnalda
0b2c623018
Back out f9e075d85552 (Bug 635482) to investigate Mac tp4 regression, a=backout
2011-02-27 10:27:44 -08:00
Shawn Wilsher
c659beeda2
Bug 635482 - Crash [@ mozalloc_abort(char const* const) | NS_DebugBreak_P | AbortIfOffMainThreadIfCheckFast ] (was: [@ mozalloc_abort(char const* const) | NS_DebugBreak_P]) from nsCycleCollectingAutoRefCnt::decr with mozilla::storage::BindingParams::Release
...
Be very explicit about what thread we release objects on.
r=asuth
a=blocking
2011-02-25 16:12:00 -08:00
Marco Bonardo
0786c95d93
Bug 628921 - Changing from WAL to a rollback journal to change page_size may cause a infinite loop @AsyncExecuteStatements::executeStatement.
...
r=sdwilsh a=blocking
2011-02-16 13:51:26 +01:00
Shawn Wilsher
a1d7cbb0a0
Bug 580790 - Connection::initialize can access preferences off of the main thread
...
This fixes the storage service so that it caches the value from the
preference service, and obtains the value once on the main thread.
r=asuth
sr=shaver
a=blocking2.0
2010-08-06 10:28:46 -07:00
Ryan VanderMeulen
642f32862c
Bug 586130 - Warning C4099 fixes (storage). r=sdwilsh a=bsmedberg
2011-01-20 19:49:09 -08:00
Andrew Sutherland
2af4f44190
Bug 624051 - AsyncStatement destructor should finalize statements on the asynchronous thread when available to avoid blocking the main thread. r=sdwilsh, a=blocking2.0
2011-01-19 18:16:42 -08:00
Uli Link
912344b34c
Bug 617272 - AIX compilation error for Firefox-3.6.12 source storage/src/variantToSQLiteT_impl.h", line 56.12: 1540-0274 (S) The name lookup for "sqlit e3_T_null" did not find a declaration; r,a=sdwilsh
2011-01-17 12:25:17 -05:00
Jonas Sicking
69e373af1d
Bug 610823: Change a few users that use nsTArrays as buffers to explicitly use fallible tarray. r=jdaggett a=blocker
2011-01-06 20:45:10 -08:00
Chris Leary
272d457a20
Merge mozilla-central to tracemonkey.
2010-12-29 19:25:04 -05:00
Shawn Wilsher
08e6bfdd2e
Merge Places and mozilla-central
...
a=bsmedberg
2010-12-15 19:24:51 -08:00
Shawn Wilsher
ade39d2c6a
Merge mozilla-central to Places.
2010-12-13 15:08:04 -08:00
Shawn Wilsher
9cdab945a8
Merge mozilla-central into Places.
2010-11-29 08:43:57 -08:00
Asaf Romano
76edc4f7f8
Bug 617071 - SQLiteMutex.h breaks debug builds with system sqlite. r+a=sdwilsh.
2010-12-15 20:57:11 +02:00
Shawn Wilsher
06f60f7a34
Merge mozilla-central to Places
2010-11-10 09:38:08 -08:00
Shawn Wilsher
8c46198937
Merge mozilla-central into places.
2010-10-20 12:33:53 -07:00
Shawn Wilsher
fee260454c
Merging places and mozilla-central.
2010-10-15 09:26:15 -07:00
Shawn Wilsher
ca8b2b3da8
Bug 599970 - Add GetInterface for nsIEventTarget on Connection
...
r=asuth
2010-10-05 15:01:22 -07:00
Chris Jones
28d67e6217
Bug 550611: Make nsTArray optionally infallible. sr=bsmedberg a=blocking
...
--HG--
rename : xpcom/glue/nsTArray.cpp => xpcom/glue/nsTArray-inl.h
2010-11-08 20:48:59 -06:00
Michael Wu
1bef74c070
Bug 597215 - Don't do setGrowthIncrement on Android, r=sdwilsh a=blocking-fennec
2010-10-12 16:20:51 -07:00
Marco Bonardo
0491c32219
Bug 541373 (part 2) - Provide a global VACUUM component. Use idle-daily category. r=sdwilsh a=blocking
2010-10-19 15:46:51 +02:00
Marco Bonardo
f8d95d590c
Bug 541373 (part 1) - Provide a global VACUUM component. r=sdwilsh sr=vlad a=blocking
2010-10-19 15:46:49 +02:00
Marco Bonardo
58c6c10f24
Bug 596970 - ASSERTION: You can't dereference a NULL nsCOMPtr with operator->() in AsyncStatement::~AsyncStatement(). r=asuth a=dietrich
2010-10-07 10:41:27 +02:00
Robert Sayre
edb7aca0d0
merge mozilla-central to tracemonkey.
2010-09-08 10:33:07 -04:00
Robert Sayre
357a4a6366
Merge mozilla-central to tracemonkey.
2010-09-01 22:27:07 -07:00
Taras Glek
f849918830
Bug 581606 - Avoid sqlite fragmentation via SQLITE_FCNTL_CHUNK_SIZE r=asuth sr=shaver a=b6
2010-09-01 20:35:46 -05:00
Ben Turner
f800296d72
Bug 593045 - 'Add SQLite file size quota management to mozStorage'. Missed a comment change. r=ted+asuth, a=blocking2.0+.
2010-09-03 09:12:27 -07:00
Ben Turner
72b198d8d5
Bug 593045 - 'Add SQLite file size quota management to mozStorage'. r=ted+asuth, a=blocking2.0+.
2010-09-03 07:41:55 -07:00
Luke Wagner
5e9978f911
Bug 581263 - remove slow natives (r=waldo,mrbkap)
2010-08-16 12:35:04 -07:00
Shawn Wilsher
31576fbeec
Bug 583882 - Need a way to clone an existing connection.
...
r=asuth
sr=shaver
a=blocking2.0
2010-08-27 12:42:58 -07:00
Shawn Wilsher
d6bf9c5574
Bug 519769 - Open shared/unshared connection with options instead of setting shared state always
...
Use the flags SQLite provides on sqlite3_open_v2 instead of using a mutex to
protect the shared cache state.
r=asuth
a=gavin
2010-08-27 12:42:55 -07:00
Luke Wagner
2fc61cf52e
Bug 609440, part 3 - remove fallible public APIs, update mozilla (r=bent,jst,mrbkap,waldo,sdwilsh)
2010-12-03 00:24:17 -08:00
Igor Bukanov
52ea348c4c
bug 610198 - Replacing JS_GetStringBytes usage with JS_EncodeString. r=gal
2010-11-11 21:40:29 +01:00
David Anderson
7487c14d37
Backed out changeset 8e119f847f97 (build busted)
2010-11-11 11:19:42 -08:00
Igor Bukanov
e32ba97023
bug 610198 - Replacing JS_GetStringBytes usage with JS_EncodeString. r=gal
2010-11-02 15:36:25 +01:00
Robert Sayre
78fcef6d2d
Merge mozilla-central to tracemonkey.
2010-11-09 15:29:44 -05:00
Igor Bukanov
92b67c9caf
bug 607695 - Avoid unnecessary JS_GetStringBytes. r=gal
2010-10-28 17:15:53 +02:00
Doug Turner
9f7d54d9be
Bug 616019 - Maemo - 10mb places.sqlite database due to aggressive file growth. r=sdwilsh a=blocking-fennec
...
--HG--
extra : rebase_source : 0a81467765657bed731e068a5e5d0af404577420
2010-12-09 10:14:16 -08:00
Luke Wagner
c2d405ba7a
Bug 613457 - use *ById JSAPIs in storage (r=sdwilsh)
...
--HG--
extra : rebase_source : bc2548573f500f664b37b24e95bdc3b9502ba28f
2011-03-21 11:37:47 -07:00
Dan Witte
0533b2cfca
Bug 572223 - too much cookies.sqlite io. Part 3: sync read per domain. r=sdwilsh
2010-07-29 12:17:42 -07:00
Steve Fink
aed0c5459e
Bug 580019: Fix functiontimer crash when opening db with NULL filename
2010-08-02 14:29:59 -07:00
Dan Witte
dfcfc976fb
Revert bug 572223 to fix creation of duplicate cookies.
2010-08-01 12:24:38 -07:00
Robert Sayre
073bde8d2b
Merge mozilla-central to tracemonkey.
2010-07-30 21:57:41 -07:00
Dan Witte
e25f157ff9
Bug 572223 - too much cookies.sqlite io. Part 3: sync read per domain. r=sdwilsh
2010-07-29 12:17:42 -07:00
Robert Sayre
55a8586519
Merge mozilla-central to tracemonkey.
2010-07-27 13:09:04 -07:00
Shawn Wilsher
6d9ba47ee5
Bug 578939 - Storage service cannot be initialized off of the main thread.
...
r=asuth
a=blocking2.0
2010-07-24 11:21:17 -07:00
Luke Wagner
99411cc93d
Bug 549143 - fatvals
2010-07-14 23:19:36 -07:00
Robert Sayre
70fc03b113
Merge mozilla-central to tracemonkey.
2010-07-02 17:25:52 -07:00
Shawn Wilsher
e59d57ca10
Bug 575667 - split about:memory reporting into more detailed sections for SQLite
...
r=vlad
a=vlad
2010-07-22 10:08:59 -07:00
Taras Glek
bb78f82fbe
Bug 416330 - Suboptimal SQLite page size r=sdwilsh
2010-07-01 10:57:13 -07:00
Shawn Wilsher
5aafb87384
Backout of bug 416330 so we can freeze for the beta on a CLOSED TREE.
2010-06-28 16:31:47 -07:00
Taras Glek
ce040e2786
Bug 416330 - Suboptimal SQLite page size r=sdwilsh
...
--HG--
extra : rebase_source : 053c7b1d975304ed7d402bb619874c889c71425c
2010-06-28 12:13:26 -07:00
Jeff Walden
52312bac03
Bug 518663 - ES5: Object.getOwnPropertyNames. r=jorendorff
2009-09-24 14:33:14 -07:00
Shawn Wilsher
688f6b6cd2
Bug 571599 - Use sqlite3_unlock_notify
...
sr=vlad
r=bent
r=asuth
2010-06-21 14:23:00 -07:00
Shawn Wilsher
4e43c7eae6
Bug 571581 - Propagate SQLITE_CONSTRAINT as an nsresult
...
r=asuth
sr=vlad
2010-06-16 09:59:24 -07:00
Dave Townsend
07c355da2b
Bug 570529: mozIStorageStatement.execute() should reset itself even if an error occurs. r=sdwilsh
2010-06-07 15:06:56 -07:00
Saint Wesonga
3ed57717d1
Bug 492625 - "Stop using underscores to start #defines" [r=vlad]
...
--HG--
extra : rebase_source : d685fb8bc375ba4fcf97742298e9361ebfe9b851
2010-06-01 08:38:00 -04:00
Chris Jones
8095e43052
Backed out changeset c60e3e48ea38
2010-06-24 19:56:14 -05:00
Taras Glek
065ac23871
Bug 416330 - Suboptimal SQLite page size r=sdwilsh
2010-06-24 16:39:24 -07:00
Ehsan Akhgari
d6b32f425f
Bug 567254 - Crash in Connection::getFilename for memory-based databases; r=sdwilsh
...
--HG--
extra : rebase_source : 9fb1300af8c6b35a4e1aa229af032cd08a76e721
2010-05-20 20:21:09 -04:00
Ehsan Akhgari
a87b134220
Bug 560647 - add startup timeline instrumentation; r=vlad
2010-05-19 19:22:19 -04:00
Vladimir Vukicevic
d562978a21
b=566442; add memory reporters for sqlite; r=sdwilsh
2010-05-19 13:46:08 -07:00
timeless@mozdev.org, Jason Orendorff
4bea23532d
Bug 562866 - StatementParams::NewResolve mishandles JSVAL_IS_STRING(aId). r=sdwilsh.
...
--HG--
extra : rebase_source : f9e1ea925fa38a26c806ba6dbddc52ef83646d55
2010-05-06 13:56:39 -05:00
Daniel Holbert
8d40d741e4
Bug 560383, part 2: (storage directory) Use "!!" for converting int to bool, to avoid MSVC compile warning. r=sdwilsh
2010-05-06 11:53:12 -07:00
Mitchell Field
9818f00bf2
Bug 560095 - Use mozilla::services::GetObserverService(). r=biesi,dveditz,gavin,josh,jst,mrbkap,roc,sdwilsh,shaver,sicking,smontagu,surkov
2010-04-29 18:59:13 +02:00
Marco Bonardo
01e6a8ee80
Bug 559678 - followup, make the warning less scarying. rs=sdwilsh
2010-04-22 14:53:56 +02:00
Marco Bonardo
7a4702f9fa
Bug 559678 - Better errors for Storage transactions misuse. r=asuth
2010-04-16 14:31:18 +02:00
Andrew Sutherland
b4419b8d6f
Bug 555124 - Intermittent "ASSERTION: AsyncStatementSpinner not thread-safe: '_mOwningThread.GetThread() == PR_GetCurrentThread()', file .../mozilla/storage/test/test_true_async.cpp, line 162". null out references on the main thread to avoid destruction on the async thread. r=sdwilsh.
2010-03-29 10:54:41 -07:00
Andrew Sutherland
ddd3c4327f
Bug 507414 - Add a createAsyncStatement API on mozIStorageConnection. r=sdwilsh, sr=vlad.
...
--HG--
rename : storage/src/mozStorageStatementJSHelper.cpp => storage/src/mozStorageAsyncStatementJSHelper.cpp
rename : storage/src/mozStorageStatementJSHelper.h => storage/src/mozStorageAsyncStatementJSHelper.h
rename : storage/src/mozStorageStatementParams.cpp => storage/src/mozStorageAsyncStatementParams.cpp
rename : storage/src/mozStorageStatementParams.h => storage/src/mozStorageAsyncStatementParams.h
2010-03-24 00:32:40 -07:00
Shawn Wilsher
6371523ca7
Bug 552092 - Expose a length property on mozIStorageBindingParamsArray
...
Expose the length so that consumers don't have to track if they added anything
to the array themselves.
r=asuth
sr=rob_strong
2010-03-15 10:23:39 -07:00
Shawn Wilsher
b5e02f4c11
Bug 552003 - Passing an empty mozIStorageBindingParamsArray does not error
...
Throw instead of just asserting, which makes debugging this so much easier.
r=asuth
2010-03-15 10:23:39 -07:00
Shawn Wilsher
e7bf5fc1f2
Bug 496019 - mozilla::storage::Connection::Close can spin a nested event loop
...
Creates a new close method that must be used when using asynchronous statements,
and disallow Close from being called in that case.
r=asuth
sr=vlad
2009-11-09 09:58:34 -08:00
Dan Witte
ddfc2078d1
Fix regression in mozIStorageStatement.bindUTF8StringParameter such that it accepts arbitrary octets by
...
not converting string types. b=544496, r=sdwilsh
2010-02-22 13:57:45 -08:00
Justin Lebar
e730a1afc6
Bug 500328 - Implement History.pushState(), History.replaceState() methods. r=smaug, r=zpao, sr=sicking
2009-09-01 09:45:05 -07:00
Daniel Holbert
46ba50b0cb
Backed out changeset dc7a04be6904 on suspicion of causing bug 543034.
2010-01-29 18:50:46 -08:00
Justin Lebar
a827ba17fc
Bug 500328 - Implement History.pushState(), History.replaceState() methods. r=smaug, r=zpao, sr=sicking
2009-09-01 09:45:05 -07:00
Reed Loden
cdabfc45ae
Backout patch from bug 489897 as the likely cause of pwmgr test failures.
2009-12-31 01:15:11 -06:00
David Dahl ext:(%2C%20Shawn%20Wilsher%20%3Csdwilsh%40shawnwilsher.com%3E)
4a25f2e3a8
Bug 489897 - implement StatementRow::NewEnumerate
...
for (let colName in stmt.row) now works!
r=sdwilsh
r=ddahl
sr=mrbkap
2009-10-12 17:49:00 -05:00
Shawn Wilsher
02575db216
Bug 494828 - Stop using our own mutexes and use SQLite's where possible.
...
Part 2: Use the helper object in a few places where we had our own mutexes.
r=asuth
2009-07-22 15:18:33 -07:00
Shawn Wilsher
9fc75352b9
Bug 525356 - windows debug unit tests: test_connection_executeAsync.js and test_statement_executeAsync.js failing frequently (fatal assertion)
...
Make sure to release the database connection on the thread it was opened on, not
the background thread!
r=asuth
a=beltzner
2009-12-02 10:53:46 -08:00
Shawn Wilsher
7dac22ddd2
Backed out changeset f91a016416d1 (bug 496019)
2009-12-01 15:05:52 -08:00
Shawn Wilsher
09b6e528f9
Bug 496019 - mozilla::storage::Connection::Close can spin a nested event loop
...
Creates a new close method that must be used when using asynchronous statements,
and disallow Close from being called in that case.
r=asuth
sr=vlad
a=dbaron
--HG--
extra : rebase_source : 8470e30ef4ca1e9fb516284cafb77b070e46fde3
2009-11-09 09:58:34 -08:00
L. David Baron
ab0caddb75
Backed out changeset 4a0bf3ffd767 due to test crashes.
2009-11-19 13:51:31 -08:00
Shawn Wilsher
0d37582e30
Bug 525356 - windows debug unit tests: test_connection_executeAsync.js and test_statement_executeAsync.js failing frequently (fatal assertion)
...
Release on the calling thread so when the connections destructor is called, it
is not on the background thread.
r=asuth
2009-11-19 11:49:20 -08:00
Blair McBride
b954b9cae2
Bug 528076 - Unsafe LIKE warning wrongly references mozIStorageConnection::escapeStringForLIKE. r=sdwilsh
2009-11-14 10:15:12 +01:00
Shawn Wilsher
116173a4b7
Backout of bug 496019 and bug 526601 due to window build bustage.
2009-11-09 12:16:39 -08:00
Shawn Wilsher
5281dcc164
Bustage fix for windows.
2009-11-09 10:35:26 -08:00
Shawn Wilsher
e6c35ff3f0
Bug 496019 - mozilla::storage::Connection::Close can spin a nested event loop
...
Creates a new close method that must be used when using asynchronous statements,
and disallow Close from being called in that case.
r=asuth
sr=vlad
2009-11-09 09:58:34 -08:00
Saint Wesonga
fe1b96674d
Bug 479730 - mozStorageConnection::Close logs closing improperly. r=vlad
2009-11-05 14:52:55 +01:00
David Dahl
e55bd8baf9
Bug 524787 - crash [@mozStorageResultSet::GetNextRow(mozIStorageRow**) ]. r=sdwilsh
2009-10-31 11:38:31 +01:00
Marco Bonardo
e68c36ec27
Bug 519326 - Variant.h(152) : warning C4244: '=' : conversion from 'PRInt64' to 'PRInt32', possible loss of data. r=sdwilsh
2009-10-09 22:15:19 +02:00
Dietrich Ayala
b682a0bba3
Bug 419893 - sort out PGO-triggered bugs (r=ted)
...
--HG--
extra : rebase_source : 028cd891e11df11abf768107f64b1d6bca541dca
2009-10-08 11:01:13 -07:00
Robert O'Callahan
6b41eca841
Backed out changeset 59a6c227df86
2009-10-02 15:23:36 +10:00
Shawn Wilsher
168578cfbc
Bug 494828 - Stop using our own mutexes and use SQLite's where possible.
...
Part 2: Use the helper object in a few places where we had our own mutexes.
r=asuth
--HG--
extra : rebase_source : 3f2f703274df0405bc395191dec8f522e5aa4e40
2009-07-22 15:18:33 -07:00
Shawn Wilsher
3889b768e7
Bug 507674 - Safer protection of AsyncExecuteStatements::mState and AsyncExecuteStatements::mCancelRequested
...
This is essentially a backout of bug 506805, followed by changing the locking
protection rules to only protect mCancelRequested writing on the calling thread,
and reading on the background thread.
--HG--
extra : rebase_source : 249a61e40c2fd140527f034e36e8c1a53518baac
2009-09-02 13:30:24 -07:00
Shawn Wilsher
7e79575c8f
Bug 507199 - Fix race condition in finalizing asynchronous storage statements
...
(was "test_browserGlue_corrupt_nobackup_default.js, test_browserGlue_corrupt_nobackup.js, test_browserGlue_shutdown.js randomly crash")
Fixes a race condition with asynchronous statements that causes a crash. We do
not always have access to the background thread, so we should not assume we
always can get it.
2009-08-25 23:54:56 -07:00
Benjamin Smedberg
2e9438fd2f
Followup to bug 398573 - remove REQUIRES from the tree since it is no longer used... automatically generated patch, rs=ted
2009-08-25 08:59:31 -07:00
Jacek Caban
1f66701ce7
Bug 505734 - mozStorageStatementParams.cpp compilation fails on MinGW. r=sdwilsh
2009-08-09 22:30:38 +02:00
Shawn Wilsher
11b33f0ab8
Bug 506805 - Remove locking in AsyncExecuteStatements
...
This removes the use of the shared mutex in AsyncExecuteStatements. We now rely
on PR_AtomicSet and the volatile keyword. This results in zero lock contention
between the calling thread and the background thread if cancel is ever called.
r=asuth
r=bent
sr=vlad
2009-07-29 17:24:50 -07:00
Shawn Wilsher
9981a52b9b
Bug 506959 - AsyncExecuteStatements assumes ms, but calls functions that assume microseconds
...
This fixes the code to use functions that expect milliseconds instead of
microseconds, and updates to use the new TimeStamp and TimeDuration class.
r=asuth
2009-07-28 13:18:10 -07:00
Shawn Wilsher
463b989609
Bug 506022 - Avoid obtaining the database mutex at all costs in Connection::ExecuteAsync
...
Stop calling any SQLite functions that would acquire the database mutex inside
Connection::ExecuteAsync. Additionally, do not actually bind parameters when
the binding functions are called, but rather when we execute (so for async
statements, that will happen on the background thread creating no mutex
contention with the main thread).
r=asuth
2009-07-28 10:21:03 -07:00
Curtis Bartley
1192731c18
Bug 498938 - Add Levenshtein Edit Distance function to Sqlite so we can use it in queries. r=sdwilsh sr=vlad
2009-07-24 11:39:34 -04:00
Shawn Wilsher
5fcdac946b
Backout of bug 494828 and bug 505550 due to orange.
2009-07-23 10:34:54 -07:00
Shawn Wilsher
6631ab6c3b
Bug 505550 - Acquire the db's mutex when cloning statements in Connection::ExecuteAsync
...
Hold the lock around all our API calls so we don't lose so much to the
background thread.
r=asuth
2009-07-22 15:18:33 -07:00
Shawn Wilsher
5a66fb8a7c
Bug 494828 - Stop using our own mutexes and use SQLite's where possible.
...
Part 2: Use the helper object in a few places where we had our own mutexes.
r=asuth
2009-07-22 15:18:33 -07:00
Shawn Wilsher
2d8562eff5
Bug 494828 - Stop using our own mutexes and use SQLite's where possible.
...
Part 1: Create helper objects to make using sqlite3_mutex safer and easier.
r=cjones
2009-07-22 15:18:33 -07:00
timeless@mozdev.org
ecebe2a338
Bug 491196 don't implement static functions in headers
...
r=sdwilsh
Moving JSValStorageStatementBinder to mozStoragePrivateHelpers as bindJSValue
storage/src/mozStorageStatementParams.h: At global scope:
storage/src/mozStorageStatementParams.h:78: warning: ‘PRBool mozilla::storage::JSValStorageStatementBinder(JSContext*, mozIStorageStatement*, int, jsval)’ defined but not used
storage/src/mozStorageStatementParams.h:78: warning: ‘PRBool mozilla::storage::JSValStorageStatementBinder(JSContext*, mozIStorageStatement*, int, jsval)’ defined but not used
You get this once for each file that includes a header that defines a static function which is not used in that file.
2009-07-22 17:31:03 -05:00
Drew Willcoxon
c57a0f0e22
Bug 499990 - Locale-aware collation, r=sdwilsh, sr=vladimir
2009-07-15 10:49:05 -07:00
Makoto Kato
87c3734112
Bug 499268 - storage code for Symbian emulator. r=sdwilsh
2009-06-29 14:42:56 +09:00
Shailen
0b82990ec8
Bug 497823. Fix compilation errors in Stroage on AIX. r=sdwilsh
...
--HG--
extra : rebase_source : 58bdecd2cec8b9a39be37514fa2465015addec42
2009-06-29 10:59:40 +12:00
Shawn Wilsher
7d25df6c45
Bug 500750 - mDBConn is not set to NULL in release builds
...
r=asuth
2009-06-26 15:03:53 -07:00
Drew Willcoxon
010916bdb4
Bug 490867 - Variant fixes: coerce null to empty string, GetIsNull should check correct type, variant base type should be void, r=sdwilsh
...
Adds a NullVariant derived class of Variant_base.
2009-06-24 15:04:49 -07:00
Shawn Wilsher
6cbf5ad014
Bug 490085 - Add ability to bind multiple sets of parameters and execute asynchronously
...
Improves the asynchronous API by allowing multiple parameters to be bound before
executing it. The statement is then executed with each set of parameters
asynchronously.
r=asuth
sr=vlad
2009-06-17 12:12:51 -07:00
Shawn Wilsher
1ef152638f
Bug 488148 - Share the mutex used by AsyncExecuteStatements on Connection
...
Greatly reduces the number of mutexes used when using the asynchronous storage
API.
r=bent
r=asuth
2009-06-17 12:12:43 -07:00
Shawn Wilsher
2c58e01641
Backed out changeset 0997bcc75daf (bug 488148). Silly me - this patch is wrong!
2009-06-19 12:21:44 -07:00
Shawn Wilsher
b85d50d660
Bug 488148 - Share the mutex used by AsyncExecuteStatements on Connection
...
Greatly reduces the number of mutexes used when using the asynchronous storage
API.
r=bent
r=asuth
2009-06-17 12:12:43 -07:00
Shawn Wilsher
93d750bc3e
Bug 485107 - Do not throw in NewResolve
...
This changeset makes sure that we allow for properties to be defined on the
prototype chain for the JS language helpers in storage.
r=bent
2009-06-11 13:18:58 -07:00
Shawn Wilsher
a95e844e10
imported patch storage.remove-statement-state-checks
2009-06-11 13:18:58 -07:00