Commit Graph

323 Commits

Author SHA1 Message Date
Boris Zbarsky
b0259fd19b Bug 504221 part 3. Switch overflowFrames storage to nsFrameList. r=fantasai, r+sr=roc 2009-07-28 08:51:09 -04:00
Michael Kohler
404670f1f3 Bug 106386 - Correct misspellings in source code (old); Part 2; r=timeless 2009-07-27 10:47:02 +02:00
Robert O'Callahan
4ef62fb0ed Bug 371839. Remove ParentDisablesSelection, which is effectively unused. r=bzbarsky
--HG--
extra : rebase_source : 920c501f033e026709ec15792cadbb2f24462a0a
2009-07-27 10:06:30 +12:00
Robert O'Callahan
14dbcb0874 Bug 371839. Simplify SetSelected signature and semantics, and reimplement it in nsTextFrame much more efficiently. r=bzbarsky
--HG--
extra : rebase_source : 18c390e3ebd09de82b1a23699c56b741f928ca37
2009-07-27 10:05:41 +12:00
Robert O'Callahan
fb7ad45e60 Bug 371839. Remove useless SetSelected implementations. r=bzbarsky
--HG--
extra : rebase_source : 57629a43328f3dbc97a5d0595186a32150722db4
2009-07-27 10:03:16 +12:00
Robert O'Callahan
f26c241975 Bug 505184. When 'deflation' of the background area is not required, paint table backgrounds using a dedicated nsDisplayBackground instead of the multipurpose nsDisplayTableBorderBackground. r=fantasai 2009-07-22 12:44:52 +12:00
Daniel Holbert
8a129b1c9f Bug 479166: rename variable "computedPaginatedHeight" to "computedUnpaginatedHeight" and reduce its scope, and also fix some build warnings, all in nsTableCellFrame. r=bernd 2009-07-21 13:05:49 -07:00
Jesse Ruderman
9ee3484d6d Add crashtest for bug 448988 2009-07-14 12:57:09 -07:00
Benjamin Smedberg
369492d616 Bug 503376 - Remove unused CalcAutoMargin function which stopped being used in bug 478614, r=bernd 2009-07-13 12:31:32 -04:00
Bernd
ce52d35f28 bug 240245 remove some bizarre col frame construction code that is never called. r=bzbarsky 2009-07-12 19:47:10 +02:00
Alexander Surkov
df93a01d0c Bug 437980 - 9 tests fail in table_indexes.html chrome test file, r=marcoz, davidb, bernd 2009-06-29 18:54:26 +08:00
Bernd
5c0c166ec7 adopt caption vertical margins to latest CSS2.1 revision, bug 478614, r/sr=dbaron 2009-06-28 15:51:46 +02:00
Bernd
8aa449421d bug 325292 - place the needtocollapse flag on the first inflow so that works in pagination mode r/sr=roc 2009-06-21 18:34:03 +02:00
Bernd
a52d85f388 refactor the setting of continous borders in the border collapse computation bug 452319 r=fantasia sr=roc
* * *
* * *
* * *
* * *
2009-06-21 18:31:40 +02:00
L. David Baron
0d06184f97 Remove support for fallback background colors. (Bug 496721) r+sr=bzbarsky 2009-06-16 08:00:20 -07:00
Robert O'Callahan
8c7da0cfb7 Bug 494667. Don't apply optimization to shrink drawn background area to exclude solid borders, if we're not going to draw those borders (e.g. in tables with collapsing borders). r+sr=dbaron,a=beltzner 2009-05-28 17:01:42 +12:00
Bernd
1b7eae0fba bug 492661 - track the visibility of cols and colgroups independently of the presence of cells r/sr=roc 2009-05-16 16:22:56 +02:00
Arpad Borsos
319919e714 Bug 492520 - Optimize some Frame classes for memory usage; r+sr=roc 2009-05-12 12:13:09 +02:00
Daniel Holbert
0947631c3a Bug 490909: Remove old layout debugging code, patch #2: remove 'VerifyTree' & related code. r+sr=dbaron 2009-05-12 12:03:09 -07:00
Boris Zbarsky
26d5258bfb Bug 490182. Ask to reflow the right frame. r=bernd, sr=dbaron. 2009-05-11 09:17:25 -04:00
L. David Baron
8c38aba811 Switch HTML mochitests from using MochiKit.js to packed.js. (Bug 490955) r=sayrer 2009-05-06 13:46:04 -07:00
Bob Clary
a0f8a81e55 bug 391898 - replace img src=http://i with about:blank to prevent time out during test. 2009-04-24 10:08:26 -07:00
Bob Clary
d8afbb50c2 bug 370360 - crash test by Eli Friedman. 2009-04-24 10:08:17 -07:00
Bob Clary
6e984b43c2 bug 344000 - crash test by Bernd. 2009-04-24 10:08:14 -07:00
Bob Clary
009c46c113 bug 343087 - crash test by Jesse Ruderman. 2009-04-24 10:08:13 -07:00
Bob Clary
ce105717af bug 339246 - crash test by Jesse Ruderman. 2009-04-24 10:08:13 -07:00
Bob Clary
ff9f19ff4c bug 339130 - crash test by Jesse Ruderman. 2009-04-24 10:08:13 -07:00
Bob Clary
6edc8468d3 bug 316636 - crash test by Martijn Wargers, Bernd. 2009-04-24 10:08:09 -07:00
Bob Clary
ec2808d91b bug 308752 - crash test by Jesse Ruderman, Martijn Wargers, Bernd. 2009-04-24 10:08:08 -07:00
Boris Zbarsky
ecaf9149f5 Bug 489479. Make nsTableFrame::InsertFrames handle a framelist that includes both colgroups and rowgroups being inserted at the end of the principal child list. r=bernd, sr=roc 2009-04-23 10:17:46 -04:00
Bernd
d38a1d09be bug 413091 - empty first column needs a cellspacing before as we assume always in the code to have cellspacing on the left and right side, r/sr=dbaron 2009-04-18 10:22:34 +02:00
Boris Zbarsky
8ee479696a Bug 488388. Handle inserts at the end of a colgroup that has anonymous colframe kids. r=bernd, sr=roc 2009-04-15 17:44:53 -04:00
Boris Zbarsky
307ccebf4c Bug 484448. Fix handling of whitespace kids of table-related frames. r=bernd, sr=roc
--HG--
rename : layout/reftests/table-anonymous-boxes/white-space-1.html => layout/reftests/table-anonymous-boxes/white-space-7.html
2009-04-08 12:56:16 -04:00
Boris Zbarsky
d44950aed3 Bug 487899. Start column indices incorrect in nsCellMap::ExpandWithCells if an array with more than one cell is passed in. r=bernd, sr=roc 2009-04-13 11:31:39 -04:00
Boris Zbarsky
25164496ef Backed out changeset 0ea22856b5d9 (bug 484448). 2009-04-08 15:56:43 -04:00
Boris Zbarsky
f70fe28e08 Bug 484448. Fix handling of whitespace kids of table-related frames. r=bernd, sr=roc
--HG--
rename : layout/reftests/table-anonymous-boxes/white-space-1.html => layout/reftests/table-anonymous-boxes/white-space-7.html
rename : layout/reftests/table-anonymous-boxes/white-space-1-ref.html => layout/reftests/table-anonymous-boxes/white-space-ref.html
2009-04-08 12:56:16 -04:00
Jonathan Kew
bdab93a7ca Bug 475968. Eliminate NS_FRAME_OUTSIDE_CHILDREN flag, store small overflow areas cheaply within the frame. r+sr=roc 2009-04-06 12:31:50 +12:00
Arpad Borsos
420adcef91 Bug 481932 - use do_QueryFrame instead of IS_TABLE_CELL + cast; r+sr=roc 2009-03-24 23:10:06 +01:00
Arpad Borsos
b8c7bb681a Bug 481881 - use better template arguments for nsTArray<T> after bug 474369, layout part; r+sr=roc 2009-03-12 08:26:29 +01:00
Karl Tomlinson
6a5bf5d169 backout dac7c3176b33 from bug 481881 2009-03-11 17:09:22 +13:00
Arpad Borsos
27f29d685d Bug 481881 - use better template arguments for nsTArray<T> after bug 474369, layout part r+sr=roc 2009-03-11 15:26:36 +13:00
L. David Baron
fa9a21c33d Implement multiple background layers, implement fallback background color, and make -moz-background-inline-policy no longer be part of the background shorthand. (Bug 322475) r+sr=roc,bzbarsky 2009-02-19 21:29:21 -08:00
L. David Baron
2eb748571c Backed out changeset fde0b361f25e (bug 322475, main patch) due to Mac talos startup failures and hitting the NS_ABORT_IF_FALSE in SetupBackgroundClip, which may be related. 2009-02-19 13:51:46 -08:00
L. David Baron
d9ac02ed8c Implement multiple background layers, implement fallback background color, and make -moz-background-inline-policy no longer be part of the background shorthand. (Bug 322475) r+sr=roc,bzbarsky 2009-02-19 12:33:09 -08:00
L. David Baron
a91aa25ab0 Back out all 8 changesets that I just landed (bugs 477959, 477961, 322475, 478899, 475215, 478156) again, because Talos Try server builds lie about which changesets they're testing. 2009-02-19 09:06:18 -08:00
L. David Baron
51ef1de194 Implement multiple background layers, implement fallback background color, and make -moz-background-inline-policy no longer be part of the background shorthand. (Bug 322475) r+sr=roc,bzbarsky 2009-02-19 07:29:28 -08:00
L. David Baron
8b207bcc51 Revert (back out) the previous 11 changesets (bugs 477959, 477961, 477963, 477962, 322475, 478899, 475215, 478156), due to Mac talos orange with (as usual) no useful diagnostic. 2009-02-18 18:59:47 -08:00
L. David Baron
366992262c Implement multiple background layers, implement fallback background color, and make -moz-background-inline-policy no longer be part of the background shorthand. (Bug 322475) r+sr=roc,bzbarsky 2009-02-18 17:13:25 -08:00
Daniel Holbert
cbad7fb59b whitespace-only: align 'aPresContext' with other parameters in methods within nsTableFrame.cpp 2009-02-18 11:47:22 -08:00
Daniel Holbert
d3052afe52 Bug 478785: Remove unneeded availHeight variable in nsTableCellFrame::Reflow, plus minor whitespace cleanup. r=dbaron 2009-02-16 16:02:21 -08:00
Daniel Holbert
caf6538b6a whitespace only: fix alignment of parameters for nsTableCellFrame::SetSelected 2009-02-16 14:26:57 -08:00
Zack Weinberg
bea9955522 Bug 476557. Update view manager cache of page background color in PresShell::Paint, not nsCSSRendering::PaintBackground; permits a small API cleanup. r+sr=roc
--HG--
extra : rebase_source : dcf1475dd8b695eb18513e97ca35b08a4affd19f
2009-02-16 14:11:34 +13:00
Jesse Ruderman
f154077a31 Add crashtests 2009-02-13 14:54:17 -08:00
Daniel Holbert
aad0f923ea typo fix in a comment: s/glock/block/ CLOSED TREE a=sdwilsh|sheriff 2009-02-12 15:10:59 -08:00
Jesse Ruderman
68344d4b52 Add a bunch of crashtests 2009-02-10 22:18:05 -08:00
Jesse Ruderman
c9eb6349ac Add some crashtests 2009-02-10 16:36:04 -08:00
Michael Ventnor
b480b09ba3 Bug 476738. Implement 'inset' box-shadows. r+sr=roc,r=dbaron 2009-02-10 21:45:13 +13:00
Jesse Ruderman
5f1cc5c3ce Add a bunch of crashtests 2009-02-10 00:09:40 -08:00
Bernd
acce04933d include the border width for border collapsed tables as required by CSS 2.1. We implemented before what CSS 2.0 required and it was ugly, so the spec changed. r=fantasai sr=roc, bug 155955 2009-02-08 17:46:42 +01:00
Bernd
3ba502a047 remove dead debugging code r/sr=bzbarsky bug 475075 2009-02-08 17:45:28 +01:00
Arpad Borsos
b2f9b630db Bug 474369 - get rid of nsVoidArray, layout/tables part. r+sr=roc 2009-02-05 10:09:50 +01:00
Daniel Holbert
f093208f71 Whitespace-only: Fix parameter indentation in nsTableCellFame.cpp 2009-01-14 21:06:03 -08:00
Daniel Holbert
3a78be97fc Whitespace-only: Fix parameter indentation in nsTableRowFrame.cpp and nsTableRowGroupFrame.cpp 2009-01-14 14:16:43 -08:00
L. David Baron
5d6a678da1 Clean up CalcAvailWidth. (Bug 444928) r=bernd 2009-01-13 11:50:40 -08:00
Benjamin Smedberg
24e7cb1f78 Bug 396185 - Make nsIFrame derivatives and helper abstract classes use a different dynamic-cast system than nsISupports:
* we know all types frames may be cast to at compile time, so instead of extensible GUID IIDs, use a big enum (see nsQueryFrame::FrameIID)
* eliminate all vestiges of refcounting, since frames aren't refcounted

Some frames (SVG frames in particular) still implement nsISupports-derived interfaces, for example nsISVGValue. There is a FrameIID for nsISVGValue that lets you go from a frame to the XPCOM interface, but you can't query back.

r+sr=roc

nsITextControlFrame didn't have an IID the first time around, but this wasn't a compile error because nsITextControlFrame::kFrameIID inherited from nsIFormControlFrame::kFrameIID. I've added a static analysis pass to verify the correct behavior, since I can't figure out a way to make the compiler do it.

--HG--
extra : rebase_source : 4894a2ca0278e2ab92f27459db77165f8348cf41
2009-01-12 14:20:59 -05:00
Benjamin Smedberg
50621e4f9f Backed out changeset 4c4df6ed1b41 - Bug 396185 - Make nsIFrame not inherit from nsISupports due to mochitest failures... these appear to be crashes in nsGenericHTMLElement::GetEditorInternal. 2009-01-09 11:35:24 -05:00
Benjamin Smedberg
d0b948876f Bug 396185 - Make nsIFrame derivatives and helper abstract classes use a different dynamic-cast system than nsISupports:
* we know all types frames may be cast to at compile time, so instead of extensible GUID IIDs, use a big enum (see nsQueryFrame::FrameIID)
* eliminate all vestiges of refcounting, since frames aren't refcounted

Some frames (SVG frames in particular) still implement nsISupports-derived interfaces, for example nsISVGValue. There is a FrameIID for nsISVGValue that lets you go from a frame to the XPCOM interface, but you can't query back.

r+sr=roc

This patch locally causes two REFTEST-UNEXPECTED-PASS for Bidi stuff. It's possible that I accidentally fixed a bug, but I'm not sure, so I'm going to wait for the tinderboxes to confirm my local results.
2008-11-05 14:25:30 -05:00
Michael Ventnor
318cfd2e10 Bug 472410. Don't adjust selection colors if the background is a -moz-appearance that we can't know anything about. r+sr=roc 2009-01-09 13:29:38 +13:00
L. David Baron
57a8e776d8 Rename flags and methods from space manager to float manager. (Bug 191448) r+sr=roc 2009-01-04 19:39:54 -05:00
L. David Baron
b3d748ba11 Fix some missed renames from bug 471356. r+sr=bzbarsky 2009-01-04 14:52:38 -05:00
L. David Baron
a5129c520e Fix slight errors when widths can't be round-tripped through floats. (Bug 467141) r+sr=roc 2008-12-04 08:09:53 -08:00
L. David Baron
7aa294ceb7 Remove now-unneeded argument from GetWidthInfo. (Bug 466108) r=dholbert sr=roc 2008-12-04 08:09:52 -08:00
Michael Ventnor
0a7591b341 Bug 453641. Make box-shadow work on tables and table parts. r+sr=roc 2008-12-03 14:20:21 +13:00
Bernd
18e359b826 bug 458924 - activate the DidResizeColumns mechanism when column widths changes in fixed layout. r/sr=dbaron 2008-11-27 18:23:52 -08:00
L. David Baron
17759307a2 Distribute extra space in fixed-layout tables where all columns have widths proportionally rather than equally, for compatibility. (Bug 445142) r=bernd sr=roc a=blocking1.9.1+ 2008-11-25 15:22:39 -08:00
L. David Baron
a5f7856bf5 Back out 6ce5f62a59455c79b3e12414989d3727f283b7c3 due to mac startup failures. 2008-11-25 14:38:06 -08:00
L. David Baron
3cd243672f Distribute extra space in fixed-layout tables where all columns have widths proportionally rather than equally, for compatibility. (Bug 445142) r=bernd sr=roc a=blocking1.9.1+ 2008-11-25 13:27:54 -08:00
L. David Baron
be3321e732 Simplify conditions, part 2, since we're really only trying to avoid IsGeometryDirty if we're not going to need any reflow at all. (Bug 438509) r=dholbert sr=roc a=blocking1.9.1+ 2008-11-25 13:27:53 -08:00
L. David Baron
c0cc02dfd5 Simplify condition, part 1, since mVResize already implies IsGeometryDirty thanks to the code immediately above. (Bug 438509) r=dholbert sr=roc a=blocking1.9.1+ 2008-11-25 13:27:53 -08:00
L. David Baron
3dbd3c34af Avoid exponential growth of special height reflows. (Bug 438509) r=dholbert sr=roc a=blocking1.9.1+ 2008-11-25 13:27:53 -08:00
L. David Baron
58064fc1f3 Remove nsHTMLReflowState::mPercentHeightReflowInitiator, which is write-only. (Bug 438509) r+sr=roc a=blocking1.9.1+ 2008-11-25 13:27:53 -08:00
Robert O'Callahan
a722f955fd Bug 462972 - 'Fix nsChangeHint comparisons'. r=bernd, sr=dbaron 2008-11-04 14:03:14 -08:00
Bernd
4b7f58df3e bug 462849 degenerated colgroups can be empty r/sr=bzbarsky 2008-11-03 19:30:38 +01:00
Robert O'Callahan
e639c5c883 Bug 442304. Don't try to clip table cells in %-overheight situations in quirks mode. (Basically we're just removing a quirk here.) r=bernd,r+sr=dbaron 2008-11-03 14:01:49 +13:00
Bernd
7c0832937a bug 286797 dynamic changes of the border color require a update of the cellmap as there is stored where a new segment starts. This is used by painting. r/sr=bzbarsky 2008-11-02 19:41:35 +01:00
Bernd
62d4cebdde bug 258377 remove inline on PeekStyleData so that it can be called from the layout library r/sr=bzbarsky 2008-11-01 09:52:29 +01:00
Benjamin Smedberg
9696613a50 Relanding bug 461410 - nsILineIterator is never used outside of layout - set nsresults to replicate the existing code more correctly, which fixes the mochitest failures, r+sr=roc with nits noted by Mats Palmgren 2008-10-30 12:17:59 -07:00
Benjamin Smedberg
4214b72dd5 Backed out changeset d4c9a0776667 (deCOM nsILineEnumerator) due to regression from it or bug 461212 2008-10-28 02:49:14 -04:00
Benjamin Smedberg
dd4c950cff Bug 461410 - nsILineIterator is never used outside of layout, and doesn't need to be refcounted: the callers can just destroy it when they're done with it. We can't do this with a virtual destructor, however, because nsTableRowGroupFrame implements the interface directly, while nsLineIterator is a separately-allocated class. So clients are expected to call DisposeLineIterator when they're done with it.
Instead of accessing nsILineIterator using QueryInterface, we add a nsIFrame::GetLineIterator API, which is cleaner and more efficient all at the same time!

r+sr=roc
2008-10-28 00:47:19 -04:00
Bernd
6f6f59a250 mac build bustage disable the code in question 2008-10-26 13:06:28 +01:00
Bernd
d84cc10e42 trying to fix mac burning 2008-10-26 11:56:39 +01:00
Bernd
6777c42861 bug 258377, make border collapsed tables to listen for dynamic border style changes r/sr=bzbarsky 2008-10-26 11:11:34 +01:00
Bernd
b17b2cbcd4 bug 360422 remove obsolete code r/sr=bzbarsky 2008-10-26 10:24:59 +01:00
Bernd
f08db4eb5c bug 451170, avoid hanging by going to the next frame instead of quering the same frame again. r/sr=bzbarsky 2008-10-26 10:20:42 +01:00
Robert O'Callahan
85ea5a3965 Bug 460240. Need to repaint the overflow area if the overflow area changes, the frame has effects/outline/box-shadow, and the frame size has not changed. r+sr=bzbarsky 2008-10-21 20:42:28 +13:00
Mats Palmgren
d7a5093ec9 Subtract the row index from the row count, not the col count. b=284852 r=bernd sr=bzbarsky 2008-10-19 10:25:14 +02:00
Bernd
ffc4c848b4 trigger fixed layout if the width cahnges from auto to fixed, bug 426629r/sr=dbaron 2008-10-18 19:25:26 +02:00
Jesse Ruderman
cff82b676c Add bug 370897 crashtest 2008-10-16 14:49:40 -07:00
Mats Palmgren
f4da1f1107 Regression test for bug 300912. 2008-10-13 01:53:44 +02:00
Arpad Borsos
8b11d938d2 Bug 456388 - Remove PR_STATIC_CALLBACK and PR_CALLBACK(_DECL) from the tree; r+sr=brendan 2008-10-10 17:04:34 +02:00