Edward Lee
fae8b93210
Add the successor ids when adding/removing items as well as both old and new successors when moving.
2009-08-18 18:39:10 -07:00
Edward Lee
b264174b42
When updating the position of an item, move all of its followers with it. Share chain moving logic used for fixing followers on create and updating positions.
2009-08-18 18:36:31 -07:00
Edward Lee
0435aca087
For items that have the correct parent, see if there's an item following it and reposition the chain of items to after the correct parented item. A chain of followers starts at the item with the predecessor annotation and goes until the end of the folder, an item that is looking for a predecessor, or ends up at where we started (the predecessor).
2009-08-17 02:34:03 -07:00
Edward Lee
7a297f3b5f
Simplify the debug output when creating bookmarks and include the parent and position.
2009-08-16 12:39:30 -07:00
Edward Lee
7c3bc745a0
Use the predecessorid to figure out where to put the item or save the predecessor as an annotation.
2009-08-16 12:39:15 -07:00
Edward Lee
96a4461af4
Set the predecessorid when creating records for upload.
2009-08-16 12:39:00 -07:00
Edward Lee
4cb51d9bde
Remove the missing parent annotation after reparenting an orphan.
2009-08-15 14:43:10 -07:00
Edward Lee
306fc8507b
Reparent orphans when creating the parent folder.
2009-08-15 01:07:40 -07:00
Edward Lee
7cc5c17773
Use a shared setGUID for new items and changing guids so that the item always ends up with the GUID (because conflicts shouldn't have been Weave generated).
2009-08-15 01:04:06 -07:00
Edward Lee
004fdf436d
Store the parent GUID as an annotation if the item is missing a parent and share some parent lookup code.
2009-08-15 01:00:46 -07:00
Edward Lee
31270d064c
Move _preprocess to before applyIncoming to share code for create/update/remove.
2009-08-15 01:00:32 -07:00
Edward Lee
cbba430108
Rename weaveId to just GUID and share a id<->guid function across store and tracker.
2009-08-15 00:59:49 -07:00
Edward Lee
fae7aaa071
Temporarily append everything and don't use sortindex for ordering within a folder.
2009-08-15 00:57:09 -07:00
Edward Lee
2335b057db
Get rid of depth and sort on index instead.
2009-08-15 00:56:27 -07:00
Edward Lee
3ca750f464
Remove meta/mini records. Bye!
2009-08-13 18:50:54 -07:00
Edward Lee
39895d48b2
Put Annotations in Svc and expose a get/set Utils.anno call to use from bookmarks.
2009-08-13 17:59:26 -07:00
Edward Lee
983afb76a9
Remove unused bookmark annotations/constants.
2009-08-13 17:43:20 -07:00
Edward Lee
bc5f3d3be8
Bug 507296 - Sync bookmarks and history in batched mode. r=thunder
...
Wrap the original SyncEngine._sync function with a call to runInBatchMode, so SQL disk writes happen at the end of batch mode instead of on every change.
2009-07-30 11:52:26 -07:00
Edward Lee
1a4c241fc9
Change client engine to override findLikeId instead of recordLike to save on some work (iterating over changed ids).
2009-07-28 10:07:07 -07:00
Edward Lee
6ddbaa9a8e
Bug 506795 - Handle adding duplicate logins. r=thunder
...
Refactor reconcile to call findLikeId that by default will look for recordLike in the outgoing queue as it does now. Override findLikeId for password engine to search local logins.
2009-07-28 10:06:02 -07:00
Edward Lee
551f097468
Convert various debug messages to trace.
2009-07-22 21:40:18 -07:00
Edward Lee
4f7ab3c5c2
Remove pref tracker init debug message.
2009-07-14 18:47:29 -07:00
Edward Lee
68d361380a
Bug 504230 - Use Engine's logging level for Store and Tracker
...
Use the log.logger.engine.* prefs to determine what the Store and Tracker should log with. This requires putting the same engine name on each Store/Tracker object, so there's some duplicate string values right now.
2009-07-14 18:34:03 -07:00
Edward Lee
9fde263097
Bug 504216 - Force various engines to be disabled
...
Have the disabled engines return null for enabled instead of the pref's true/false.
2009-07-14 17:03:57 -07:00
Anant Narayanan
7cd35a2c36
Limit form history records (bug 494952, r=thunder)
...
--HG--
extra : rebase_source : c3e983d30a14efd972eea2651a59be76924da256
2009-07-14 12:28:18 -07:00
Edward Lee
5ad22f9709
Bug 479189 - weave does not sync tag smart folders properly
...
Create a new record type, BookmarkQuery, to handle place: uri smart bookmarks. Store what tag name the query wants and lookup the id for that tag on other machines on create/update.
2009-07-13 17:43:15 -07:00
Edward Lee
22570f2932
Bug 503938 - Tags with a single bookmark keep generating new tag ids
...
Share a tagging code for create/update that will tag a dummy uri temporarily while it untags the bookmark to make sure every tag has at least one child during this untag/tag process.
2009-07-13 13:40:49 -07:00
Edward Lee
6ddece8b22
Bug 502482 - error while syncing bookmarks from server
...
Set the item type for generic PlacesItems, but don't do anything when trying to create it.
2009-07-09 17:15:00 -07:00
Edward Lee
5c482eea0d
merge weave. resolve comments added to resource.js.
2009-07-09 11:21:20 -07:00
Edward Lee
1c1025b37d
Convert a log.info to log.debug for passwords so it doesn't clutter the brief log.
2009-06-25 22:52:28 -07:00
Edward Lee
39f333a78e
Bug 500598 - Undefined item in tabContainer.childNodes after closing tabs
...
The childNodes NodeList keeps its indices even after removal, so it's safer to convert the array-like thing into an actual array. Condense the QueryInterface code to the instanceof magic.
2009-06-25 22:46:14 -07:00
Edward Lee
84c52a6411
merge weave. resolve addition of kSpecialIds to bookmarks.js near removal of Async.sugar.
2009-06-23 22:34:57 -07:00
Anant Narayanan
22bd439624
Change priority of some log messages to trace
2009-06-22 18:19:42 -07:00
Edward Lee
eeef9a8201
Bug 487282 - "browser is null" error in tabs.js
...
Share browser detection code for register and unregister tab listeners and better check for tabbrowser windows.
2009-06-22 15:53:42 -07:00
Edward Lee
ad7d001bb3
Bug 498924 - Refactor bookmark special ids out of BookmarksStore
...
Lazily load places ids for a given weave id/place name pair into kSpecialIds and update all consumers. Expose a Svc.Bookmark in utils.
2009-06-17 09:28:15 -07:00
Edward Lee
3ef568c718
Cleanup/refactor followup to bug 481327.
...
Change _ignore to take itemId to find folderId and pull out addChanged/getItemGUID/upScore to addId.
2009-06-17 08:51:54 -07:00
Edward Lee
34400917b0
Bug 481327 - Script gets stuck during startup. r=Mardak
2009-06-17 08:51:54 -07:00
Mikhail Stepura (mishail)
fde4deb743
Bug 486042 - "Load this bookmark in the sidebar" status not synced. r=Mardak
2009-06-16 16:16:39 -07:00
Edward Lee
57adfb688b
merge weave
2009-06-06 13:12:03 -07:00
Edward Lee
df1fc601da
Fix form engine to correctly pass in the engine.
2009-06-05 18:36:31 -07:00
Edward Lee
6bc0e717ec
Clean up various engines to remove Async.sugar and random self/yields.
2009-06-05 15:34:40 -07:00
Edward Lee
68ce1e4224
Change SyncEngine._reconcile to not be async/yield.
2009-06-04 14:18:04 -07:00
Edward Lee
428d54a14a
Change Resource.get() to be sync (no callback) and fix up call sites used for login + sync now.
2009-06-04 10:16:07 -07:00
Wladimir Palant
753b7da199
Bug 495996 - Bookmark observer doesn't implement onBeforeItemRemoved method. r=Mardak
2009-06-02 21:25:55 +02:00
Wladimir Palant
8f33b68063
Bug 495924 - TabTracker wrongly assumes that "this" pointer will be set correctly for event handlers
2009-06-02 11:25:37 +02:00
Anant Narayanan
252a823626
Preference sync (bug #428370 )
2009-05-24 02:11:05 +02:00
Anant Narayanan
dbad6932cb
Use first login found if there are multiple GUIDs
2009-05-24 00:25:30 +02:00
Anant Narayanan
b6a3ce9d6e
Use searchLogins instead of caching passwords (bug #489268 )
2009-05-24 00:03:53 +02:00
Edward Lee
0a32933db7
Bug 493004 - Create stubs of unimplemented engines to list them as disabled (extension, microformat, plugin, theme)
...
Add the 4 engines with just the base code to set their name and register them for Firefox.
2009-05-14 11:50:59 -05:00
Edward Lee
93847aa32d
Bug 493002 - List partially implemented engines (cookies, input history) as disabled
...
Import the outdated engines, but delete their pref so they show up as disabled. Clean up the old engines a little bit so they don't allocate unnecessarily and to not use syncCore.
2009-05-14 11:43:56 -05:00
