Commit Graph

14514 Commits

Author SHA1 Message Date
Nick Alexander
f9ac46bb66 Bug 977161 - Part 3: Allow unhiding hidden devices. r=rnewman
I'd like to make the DialogFragment show icons, last synced times,
number of tabs, etc; but AlertDialog does not handle multi-choice lists
backed by a custom list adapters.  (It does handle single-choice lists
backed by custom list adapters.)  We can implement our own dialog
fragment if and when we want better looks.

I've made this somewhat general so that we can use it from
ShareDialog/SendTab, which currently use AlertDialog.  Using
DialogFragment has two advantages.  First, it smoothly persists across
configuration changes; AlertDialog does not.  Second, it allow us to use
AlertDialog until we implement the improved UI above.
2014-09-16 15:41:14 -07:00
Nick Alexander
b226800b48 Bug 977161 - Part 2: Add a clickable footer showing hidden device count. r=rnewman
This is quite delicate, due to the interactions between
ExpandableListView and the footer views.  At the end of the day, this
uses an Adapter that handles header and footer views as separate
view-group types.  That means working around Android's limitations; see
the comments in the code for the details.

The alternative would be to implement our own wrapping Adapter; or to
boil the specifics of our use case into RemoteTabsExpandableListAdapter.
This is certainly quicker than the former; and, I hope, less error prone
than the latter.
2014-09-16 15:41:13 -07:00
Nick Alexander
f5ab0b7ea2 Bug 977161 - Part 1: Add hide/show context menu items to remote clients. r=rnewman
We're not (yet) using show, but we may as well add it while we're here.
2014-09-16 15:41:12 -07:00
Nick Alexander
9d86f6e029 Bug 977161 - Part 0: Make Remote{Client,Tab} implement Parcelable. r=rnewman
This is necessary to provide the list of clients to another Fragment:
the way to persist "final members" across configuration changes is to
provide the initial data in the Fragment's arguments bundle.

Note: I'd like to see RemoteClient replace ParcelableClientRecord, and
Fennec's clients table replace direct access to Sync's clients table;
but one step at a time.
2014-09-16 15:41:11 -07:00
Nick Alexander
3135852912 Bug 1064304 - Part 3: Persist group collapsed/expanded state in SharedPreferences. r=rnewman 2014-09-16 15:41:10 -07:00
Nick Alexander
319ee1a78a Bug 1064304 - Part 2: Show group collapsed/expanded indicator as appropriate. r=rnewman 2014-09-16 15:41:09 -07:00
Nick Alexander
ed127f151c Bug 1064304 - Part 1: Land home group collapsed and expanded indicator resources. r=rnewman 2014-09-16 15:41:08 -07:00
Nick Alexander
13453ed89f Bug 1064304 - Pre: Align PrefUtils.putStringSet docstring and reality. r=rnewman 2014-09-16 15:41:07 -07:00
Nick Alexander
78a3c01148 Bug 1063765 - Part 2: Adjust top margin for static content on landscape phones. r=antlam
Per discussion with antlam, we shrink the top margin on landscape phones
in the hopes of fitting the content in the window.  On portrait phones
and all tablets, we maintain a larger top margin.
2014-09-16 15:41:07 -07:00
Nick Alexander
cc9b703884 Bug 1063765 - Part 1: Style Remote Tabs static panels for tablets and portrait phones. r=mcomella
This patch does several things:

1) It wraps static panel content in a ScrollView.

2) It tightens the static panels vertically.  We can fit landscape on
many high-end phones by reducing the space before the header and between
the header and the body text slightly.

3) It makes the body text just a little narrower than the button.  The
idea is for the call to action button to dominate the page horizontally.

4) It caps the maximum width of the content in the ScrollView.  I would
have used maxWidth, but that doesn't exist for LinearLayouts (or
ScrollViews).  Instead, I set a maxWidth for every RemoteTabsPanelItem,
which combined with wrap_content on the containing LinearLayout achieves
the same goal.  It's what I intended to do on tablets.
2014-09-16 15:41:05 -07:00
Michael Comella
375b0f2a2f Bug 1001655 - Part 1: Replace applicable Strings in test code with StringHelper references. r=wesj 2014-09-16 13:56:52 -07:00
Chris Kitching
233830b037 Bug 1067025: Abort when no extra_text present in share dialog. r=rnewman 2014-09-14 21:49:45 -07:00
Carsten "Tomcat" Book
0b40ec809f Merge m-c to fx-team 2014-09-16 07:07:55 +02:00
Nigel Babu
489aede8a8 Merge fx-team to m-c with bustage fix, a=merge 2014-09-16 08:43:45 +05:30
Margaret Leibovic
d8219f0f45 Bug 1064880 - Keep track of the current search engine in MainActivity. r=nalexander 2014-09-15 17:26:39 -07:00
Wes Kocher
332233753a Merge m-c to inbound a=merge 2014-09-15 16:41:45 -07:00
Shu-yu Guo
320f4e1440 Bug 1001090 - Part 5: Fix errors in tests throughout the tree. (r=robcee,gavin) 2014-09-15 16:30:47 -07:00
Shu-yu Guo
285e8aa396 Bug 1001090 - Part 4: Fix errors in chrome code. (r=zombie,gavin,fitzgen,dcamp,bgrins,fabrice,gwagner,margaret,mrbkap,mak,njn,vicamo) 2014-09-15 16:30:46 -07:00
Richard Newman
ec672d04e3 Bug 1022472 - Remove margins on default home screen panels. r=wesj
Relanding with follow-up: fix test with incorrect assumptions. r=mfinkle
2014-09-15 10:47:37 -07:00
Richard Newman
bca41139ca Bug 1022472 - Remove margins on default home screen panels. r=wesj 2014-09-15 10:47:37 -07:00
Michael Comella
1fa61010d9 Bug 1066250 - Part 3: Update testSettingsMenuItems. r=lucasr 2014-09-15 08:20:31 -07:00
Michael Comella
c2b692d1c4 Bug 1066250 - Part 2: Remove title in toolbar preference on new tablet. r=lucasr 2014-09-15 08:20:14 -07:00
Michael Comella
6c46770c0f Bug 1066250 - Part 1: Always show the url in the toolbar on new tablet. r=lucasr 2014-09-15 08:15:42 -07:00
dominique vincent
1eb150340a Bug 1062904 - crash in java.lang.NullPointerException: uriString at android.net.Uri.<init>(Uri.java) r=mfinkle 2014-09-09 18:16:45 +02:00
Mark Capella
1c5f67f8c4 Bug 1064657 - Add testSelectionHandler test to ensure readOnly input elements can't be cut, r=wesj 2014-09-15 16:47:25 -04:00
Ryan VanderMeulen
3778cb7fb2 Backed out changeset e016c34c4d52 (bug 1022472) for robocop failures. 2014-09-15 15:29:39 -04:00
Mark Capella
d37d2ef50a Bug 1044940 - Favicons in the bookmarks table should be read and written correctly, r=ckitching 2014-09-14 17:22:19 -07:00
Mark Finkle
a13ba5cc1d Bug 1066671 - Minor test cleanup r=trivial 2014-09-14 11:21:56 -04:00
Mark Finkle
dc00bc0160 Bug 1066671 - Minor cleanup r=wesj 2014-09-14 11:17:15 -04:00
Manu Jain
1b160da21c Bug 1066320 - Crop lightweight theme image if it's larger than the displayable area; r=mfinkle 2014-09-13 14:36:09 -04:00
Phil Ringnalda
9b4aa9966e Merge m-i to m-c, a=merge 2014-09-13 09:28:33 -07:00
Mark Finkle
e39fbeec8b Bug 1020564 - Fix a bad rebase r=me 2014-09-12 22:46:39 -04:00
Michael Comella
03e872a832 Bug 1065712 - Move new_tablet_* resources to *large* directories. r=mhaigh
--HG--
rename : mobile/android/base/resources/color/new_tablet_tab_strip_item_title.xml => mobile/android/base/resources/color-large-v11/new_tablet_tab_strip_item_title.xml
rename : mobile/android/base/resources/drawable-hdpi/new_tablet_tabs_count.png => mobile/android/base/resources/drawable-large-hdpi-v11/new_tablet_tabs_count.png
rename : mobile/android/base/resources/drawable-hdpi/new_tablet_tabs_count_foreground.png => mobile/android/base/resources/drawable-large-hdpi-v11/new_tablet_tabs_count_foreground.png
rename : mobile/android/base/resources/drawable-mdpi/new_tablet_tabs_count.png => mobile/android/base/resources/drawable-large-mdpi-v11/new_tablet_tabs_count.png
rename : mobile/android/base/resources/drawable-mdpi/new_tablet_tabs_count_foreground.png => mobile/android/base/resources/drawable-large-mdpi-v11/new_tablet_tabs_count_foreground.png
rename : mobile/android/base/resources/drawable/new_tablet_tab_strip_divider.xml => mobile/android/base/resources/drawable-large-v11/new_tablet_tab_strip_divider.xml
rename : mobile/android/base/resources/drawable/new_tablet_tab_strip_item_bg.xml => mobile/android/base/resources/drawable-large-v11/new_tablet_tab_strip_item_bg.xml
rename : mobile/android/base/resources/drawable-xhdpi/new_tablet_tabs_count.png => mobile/android/base/resources/drawable-large-xhdpi-v11/new_tablet_tabs_count.png
rename : mobile/android/base/resources/drawable-xhdpi/new_tablet_tabs_count_foreground.png => mobile/android/base/resources/drawable-large-xhdpi-v11/new_tablet_tabs_count_foreground.png
rename : mobile/android/base/resources/layout/new_tablet_tab_strip.xml => mobile/android/base/resources/layout-large-v11/new_tablet_tab_strip.xml
rename : mobile/android/base/resources/layout/new_tablet_tabs_counter.xml => mobile/android/base/resources/layout-large-v11/new_tablet_tabs_counter.xml
2014-09-12 18:28:05 -07:00
Mark Finkle
32798a9452 Bug 1058384 - Switch to a unique ID when registering targets r=wesj 2014-09-12 20:56:42 -04:00
Mark Finkle
bad779a9d7 Bug 1020564 - Change SSDP 'target' references to 'device' to cut down on confusing concepts r=wesj 2014-09-12 20:55:00 -04:00
Chenxia Liu
5c223bfd6a Bug 1059827 - [7" Tablet] First-run window navigation buttons are hidden in landscape. r=wesj 2014-09-12 17:12:33 -07:00
Chenxia Liu
fe74cb1447 Bug 1062257 - Handle HomeFragment deletions by panel/type instead of universally. r=margaret 2014-09-12 17:12:33 -07:00
Monica Chew
bd333be9e6 Bug 1024555: Cancel gethash requests after 5 seconds if they are still pending 2014-09-08 16:44:08 -07:00
Carsten "Tomcat" Book
9005131aba merge m-i to m-c a=merge 2014-09-12 15:07:38 +02:00
Ryan VanderMeulen
6c9fe4b737 Merge m-c to fx-team. a=merge 2014-09-11 19:55:32 -04:00
Ryan VanderMeulen
f5c3ea6bc3 Backed out changeset 8d663f978a22 (bug 960746) for Android 4.0 robocop perma-fail. a=backout 2014-09-11 19:51:56 -04:00
Michael Comella
d9a7d5f709 Bug 960746 - Disable navigation buttons when they are hit until page load. r=lucasr 2014-09-11 12:06:40 -07:00
Richard Newman
52161380b6 Bug 1065531 - crash in java.lang.NoSuchMethodError: android.os.Bundle.getString at org.mozilla.gecko.preferences.GeckoPreferences.setupPreferences. r=nalexander 2014-09-11 11:21:19 -07:00
Carsten "Tomcat" Book
45c370572a Merge m-c to fx-team 2014-09-11 15:41:38 +02:00
Carsten "Tomcat" Book
9f7d9d41c9 merge fx-team to mozilla-central a=merge 2014-09-11 15:29:54 +02:00
Lucas Rocha
b000a1be2a Bug 1065454 - Disable new tablet UI by default (r=mcomella, a=merge) 2014-09-11 14:11:25 +01:00
Lucas Rocha
728d615823 Bug 1063914 - Restore edit mode's [x] icons (r=mcomella) 2014-09-11 13:58:55 +01:00
Lucas Rocha
d3150180ec Merge m-c to larch 2014-09-11 11:11:00 +01:00
Margaret Leibovic
1f606a69cd Bug 1017903 - Load the search service before running open search discovery tests. r=mfinkle 2014-09-11 09:10:28 +02:00
Lucas Rocha
87cb2645c5 Bug 1014987 - Gracefully handle out-of-bounds positions in TabsStripAdapter (r=mcomella) 2014-09-11 00:27:01 +01:00