Commit Graph

1902 Commits

Author SHA1 Message Date
David Zbarsky
6465ff0bc5 Bug 1015433: Backout bug 828169 for regressing text editing 2014-06-04 23:51:34 -04:00
Masayuki Nakano
ef3e68e608 Bug 1008772 part.3 Fix new orages caused by tabbrowser consuming some key events at keydown r=smaug 2014-06-05 11:57:54 +09:00
Phoebe Chang
943fc38329 Bug 924692 - Part 4: Hooks up event handling to TouchCaret; r=roc, bugs 2014-06-03 15:08:54 +08:00
Phoebe Chang
a76e3e825d Bug 924692 - Part 1: Add touch caret rendering support; r=roc 2014-06-03 15:08:25 +08:00
Carsten "Tomcat" Book
aecf14b6d9 Backed out changeset e2a22ba1d1e4 (bug 1015433) for build bustages 2014-05-31 17:06:29 +02:00
David Zbarsky
e8e97fe2ba Bug 1015433: Backout bug 828169 for regressing text editing 2014-05-31 10:49:38 -04:00
Birunthan Mohanathas
562904c002 Bug 869836 - Part 12: Use Assign('c') instead of AssignLiteral("c"). r=ehsan
--HG--
extra : rebase_source : a6b15019cee452973dd8bf3112c15e14175855a9
2014-05-26 21:55:08 +03:00
Carsten "Tomcat" Book
c509721e94 merge b2g-inbound to mozilla-central 2014-05-26 15:26:11 +02:00
Wes Kocher
64719ccbd2 Merge m-c to b2g-inbound 2014-05-23 17:39:48 -07:00
Vincent Chen
7e90a06615 Bug 981477 - Disable B2G emulator reftests that fail oop, r=ahal 2014-05-23 15:56:15 -04:00
Alex Henrie
dc4fdecd9b Bug 997921 - Restore pre-FF29 XUL textbox padding. r=roc 2014-05-23 22:03:54 -06:00
Ehsan Akhgari
897e351e52 Bug 1013664 - Fix bad implicit conversion constructors in XPCOM; r=froydnj
--HG--
extra : rebase_source : e3260a536292175cb1ad23a53dfe9e3f4bb8ff10
2014-05-21 21:33:28 -04:00
Birunthan Mohanathas
411a8639b4 Bug 869836 - Part 3: Use Append('c') instead of AppendLiteral("c"). r=ehsan 2014-05-22 06:48:51 +03:00
Daniel Holbert
c8a003c7a4 backout c3f1ab75ea51 (bug 421436) for regressing bug 439462 2014-05-22 15:10:20 -07:00
Ehsan Akhgari
7a5555425c Bug 1014246 - Don't drop the newline handling preference for the editor on the floor when it gets reinitialized; r=roc 2014-05-22 18:06:44 -04:00
Simon Montagu
afbffbcd64 Remove the hack making all <br> frames 1 app unit wide. Bug 421436, r=roc 2014-05-13 07:12:16 -07:00
Carsten "Tomcat" Book
9c3911b00f Backed out changeset 0aaa18232af4 (bug 421436) for causing reftest failures 2014-05-19 13:11:59 +02:00
Simon Montagu
e283a459e1 Remove the hack making all <br> frames 1 app unit wide, bug 421436, r=roc 2014-05-13 07:12:16 -07:00
Aryeh Gregor
193a107165 Bug 1004522 part 14 - Clean up nsWSRunObject::GetWSPointBefore/After; r=ehsan 2014-05-02 15:15:27 +03:00
Aryeh Gregor
c7cf2e216a Bug 1004522 part 13 - Clean up nsWSRunObject::GetAsciiWSBounds; r=ehsan 2014-05-02 15:15:27 +03:00
Aryeh Gregor
d8ffd04dd3 Bug 1004522 part 12 - Clean up nsWSRunObject::DeleteChars; r=ehsan 2014-05-02 15:15:27 +03:00
Aryeh Gregor
49d78035a4 Bug 1004522 part 11 - Convert nsWSRunObject.mNodeArray to nsTArray<nsRefPtr<Text>>; r=ehsan 2014-05-02 15:15:27 +03:00
Aryeh Gregor
03487c2171 Bug 1004522 part 10 - Clean up nsWSRunObject::CheckLeading/TrailingNBSP, ConvertToNBSP; r=ehsan 2014-05-02 15:15:27 +03:00
Aryeh Gregor
9468818ba8 Bug 1004522 part 9 - Clean up nsWSRunObject::FindRun; r=ehsan 2014-05-02 15:15:27 +03:00
Aryeh Gregor
5009e20abd Bug 1004522 part 8 - Clean up nsWSRunObject::GetCharBefore/After; r=ehsan 2014-05-02 15:15:27 +03:00
Aryeh Gregor
8f33700b35 Bug 1004522 part 7 - Clean up nsWSRunObject::Prior/NextVisibleNode; r=ehsan 2014-05-02 15:15:27 +03:00
Aryeh Gregor
856f9b17b3 Bug 1004522 part 6 - Clean up nsWSRunObject::InsertText; r=ehsan 2014-05-02 15:15:27 +03:00
Aryeh Gregor
d0781e156f Bug 1004522 part 5 - Clean up nsWSRunObject::PrepareToSplitAcrossBlocks; r=ehsan 2014-05-02 15:15:26 +03:00
Aryeh Gregor
922422fe77 Bug 1004522 part 4 - Clean up nsWSRunObject::PrepareToDeleteNode; r=ehsan 2014-05-02 15:15:26 +03:00
Aryeh Gregor
c89265b929 Bug 1004522 part 3 - Clean up nsWSRunObject::PrepareToDeleteRange; r=ehsan 2014-05-02 15:15:26 +03:00
Aryeh Gregor
9fc4716d64 Bug 1004522 part 2 - Clean up nsWSRunObject::DeleteWSForward; r=ehsan 2014-05-02 15:15:26 +03:00
Aryeh Gregor
d42dcea00f Bug 1004522 part 1 - Clean up nsWSRunObject::PrepareToJoinBlocks; r=ehsan 2014-05-02 15:15:26 +03:00
Carsten "Tomcat" Book
282e11ac85 Backed out changeset 1bcdb4573884 (bug 1004522) for bustage on a CLOSED TREE 2014-05-12 14:13:17 +02:00
Carsten "Tomcat" Book
c4404f68c8 Backed out changeset 4b6e7f88a2ed (bug 1004522) 2014-05-12 14:12:56 +02:00
Carsten "Tomcat" Book
0a69c32302 Backed out changeset d50b5064f930 (bug 1004522) 2014-05-12 14:12:55 +02:00
Carsten "Tomcat" Book
92b46f9133 Backed out changeset ae46dc18288d (bug 1004522) 2014-05-12 14:12:53 +02:00
Carsten "Tomcat" Book
d828ad843c Backed out changeset 6081479204a0 (bug 1004522) 2014-05-12 14:12:52 +02:00
Carsten "Tomcat" Book
54a8705622 Backed out changeset 774ba83e548f (bug 1004522) 2014-05-12 14:12:50 +02:00
Carsten "Tomcat" Book
f00cb18776 Backed out changeset 6cc778964f67 (bug 1004522) 2014-05-12 14:12:47 +02:00
Carsten "Tomcat" Book
0587505693 Backed out changeset 59107353aa68 (bug 1004522) 2014-05-12 14:12:44 +02:00
Carsten "Tomcat" Book
bff404c900 Backed out changeset c5a647958511 (bug 1004522) 2014-05-12 14:12:42 +02:00
Carsten "Tomcat" Book
52c7f7b330 Backed out changeset a30efac96e5e (bug 1004522) 2014-05-12 14:12:40 +02:00
Carsten "Tomcat" Book
e389333c55 Backed out changeset e905f03505e3 (bug 1004522) 2014-05-12 14:12:39 +02:00
Carsten "Tomcat" Book
e6b96b4237 Backed out changeset 79a84a415709 (bug 1004522) 2014-05-12 14:12:38 +02:00
Carsten "Tomcat" Book
a17ef01ba3 Backed out changeset 9804226ea5cc (bug 1004522) 2014-05-12 14:12:36 +02:00
Carsten "Tomcat" Book
c5865858ee Backed out changeset 31c65c736f32 (bug 1004522) 2014-05-12 14:12:34 +02:00
Aryeh Gregor
bd7b96bf12 Bug 1004522 part 14 - Clean up nsWSRunObject::GetWSPointBefore/After; r=ehsan 2014-05-02 15:15:27 +03:00
Aryeh Gregor
500cbf12ff Bug 1004522 part 13 - Clean up nsWSRunObject::GetAsciiWSBounds; r=ehsan 2014-05-02 15:15:27 +03:00
Aryeh Gregor
4d0b76a7fc Bug 1004522 part 12 - Clean up nsWSRunObject::DeleteChars; r=ehsan 2014-05-02 15:15:27 +03:00
Aryeh Gregor
4c178c661b Bug 1004522 part 11 - Convert nsWSRunObject.mNodeArray to nsTArray<nsCOMPtr<Text>>; r=ehsan 2014-05-02 15:15:27 +03:00
Aryeh Gregor
335bd1b375 Bug 1004522 part 10 - Clean up nsWSRunObject::CheckLeading/TrailingNBSP, ConvertToNBSP; r=ehsan 2014-05-02 15:15:27 +03:00
Aryeh Gregor
f62792cecb Bug 1004522 part 9 - Clean up nsWSRunObject::FindRun; r=ehsan 2014-05-02 15:15:27 +03:00
Aryeh Gregor
73dbdc9b1d Bug 1004522 part 8 - Clean up nsWSRunObject::GetCharBefore/After; r=ehsan 2014-05-02 15:15:27 +03:00
Aryeh Gregor
928de8c382 Bug 1004522 part 7 - Clean up nsWSRunObject::Prior/NextVisibleNode; r=ehsan 2014-05-02 15:15:27 +03:00
Aryeh Gregor
94e18d98c3 Bug 1004522 part 6 - Clean up nsWSRunObject::InsertText; r=ehsan 2014-05-02 15:15:27 +03:00
Aryeh Gregor
bf00899e48 Bug 1004522 part 5 - Clean up nsWSRunObject::PrepareToSplitAcrossBlocks; r=ehsan 2014-05-02 15:15:26 +03:00
Aryeh Gregor
90d6aed86f Bug 1004522 part 4 - Clean up nsWSRunObject::PrepareToDeleteNode; r=ehsan 2014-05-02 15:15:26 +03:00
Aryeh Gregor
b556f40a93 Bug 1004522 part 3 - Clean up nsWSRunObject::PrepareToDeleteRange; r=ehsan 2014-05-02 15:15:26 +03:00
Aryeh Gregor
7bef2792d3 Bug 1004522 part 2 - Clean up nsWSRunObject::DeleteWSForward; r=ehsan 2014-05-02 15:15:26 +03:00
Aryeh Gregor
13174387f0 Bug 1004522 part 1 - Clean up nsWSRunObject::PrepareToJoinBlocks; r=ehsan 2014-05-02 15:15:26 +03:00
Neil Rashbrook
c1fa4b8acd Bug 1003894 Followup to switch from Text to nsIContent so that we can safely use do_QueryInterface r=ehsan 2014-05-10 21:16:03 +01:00
Ehsan Akhgari
b9c6940210 Bug 1007940 - Improve the performance of editor initialization; r=bzbarsky 2014-05-09 17:02:29 -04:00
Benoit Jacob
2e1ef0025a Bug 1004098 - Make nsTArray use size_t in its interface (32bitness is fine as an internal detail) - r=froydnj, sr=bsmedberg 2014-05-08 21:03:35 -04:00
Chris Peterson
652000d050 Bug 1006982 - Refactor anchor tag utility functions in nsHTMLEditor.cpp. r=ehsan 2014-05-06 21:29:20 -07:00
Chris Peterson
7d29b2efc6 Bug 1006982 - Fix -Wuninitialized warning in libeditor. r=ehsan 2014-05-06 21:07:50 -07:00
Aryeh Gregor
1faa96d784 Bug 1003894 part 5 - Clean up nsWSRunObject::ScrubBlockBoundary; r=ehsan 2014-05-02 14:11:26 +03:00
Aryeh Gregor
c9854c4ffe Bug 1003894 part 4 - Clean up nsWSRunObject::DeleteWSBackward; r=ehsan 2014-05-02 14:11:26 +03:00
Aryeh Gregor
1e5fb889d1 Bug 1003894 part 3 - Clean up nsWSRunObject::InsertBreak; r=ehsan 2014-05-02 14:11:26 +03:00
Aryeh Gregor
c995efe830 Bug 1003894 part 2 - Clean up nsWSRunObject::CheckTrailingNBSPOfRun; r=ehsan 2014-05-02 14:11:26 +03:00
Aryeh Gregor
e1d12854be Bug 1003894 part 1 - Change WSPoint.mTextNode to Text; r=ehsan 2014-05-02 14:11:26 +03:00
Aryeh Gregor
83e86deae0 Bug 1003808 part 10 - Clean up nsWSRunObject::GetPrevious/NextWSNode; r=ehsan 2014-05-02 14:11:26 +03:00
Aryeh Gregor
4d098594d1 Bug 1003808 part 9 - Clean up nsWSRunObject::GetRuns; r=ehsan 2014-05-02 14:11:26 +03:00
Aryeh Gregor
156ab9f00c Bug 1003808 part 8 - Use some more nsINode in nsWSRunObject; r=ehsan 2014-05-02 14:11:26 +03:00
Aryeh Gregor
a7ec952796 Bug 1003808 part 7 - Convert WSFragment members to nsINode; r=ehsan 2014-05-02 14:11:26 +03:00
Aryeh Gregor
6cfdefe422 Bug 1003808 part 6 - Convert nsWSRunObject members to nsINode; r=ehsan 2014-05-02 14:11:26 +03:00
Aryeh Gregor
25174ff482 Bug 1003808 part 5 - Allow nsEditor::IsEditable to take nsINode*; r=ehsan 2014-04-28 19:03:12 +03:00
Aryeh Gregor
ee9f0798da Bug 1003808 part 4 - Clean up nsAutoTrackDOMPoint; r=ehsan 2014-04-28 18:40:28 +03:00
Aryeh Gregor
6a874d1085 Bug 1003808 part 3 - Clean up nsRangeStore; r=ehsan 2014-04-28 18:34:05 +03:00
Aryeh Gregor
dce22d2849 Bug 1003808 part 2 - Clean up nsEditorUtils::IsDescendantOf; r=ehsan 2014-04-28 18:34:05 +03:00
Aryeh Gregor
c1d08075e3 Bug 1003808 part 1 - Clean up DOMPoint; r=ehsan 2014-04-28 18:34:05 +03:00
Aryeh Gregor
2801d99bd8 Bug 1002429 part 9 - Clean up nsHTMLEditor::RebuildDocumentFromSource; r=ehsan 2014-04-28 14:54:47 +03:00
Aryeh Gregor
ab0196e199 Bug 1002429 part 8 - Clean up nsHTMLEditor::CreateElementWithDefaults; r=ehsan 2014-04-28 14:54:47 +03:00
Aryeh Gregor
3499f610a6 Bug 1002429 part 7 - Clean up nsEditor::CreateHTMLContent; r=ehsan 2014-04-28 14:54:47 +03:00
Aryeh Gregor
30ff66c6a7 Bug 1002429 part 6 - Clean up nsHTMLEditor::ReplaceHeadContentsWithHTML; r=ehsan 2014-04-28 14:54:46 +03:00
Aryeh Gregor
b1fc0e892a Bug 1002429 part 5 - Clean up nsHTMLEditor::TabInTable; r=ehsan 2014-04-28 14:54:46 +03:00
Aryeh Gregor
b2efeb3ab1 Bug 1002429 part 4 - Clean up nsHTMLEditor::CollapseSelectionToDeepestNonTableFirstChild; r=ehsan 2014-04-28 14:54:46 +03:00
Aryeh Gregor
d57c018025 Bug 1002429 part 3 - Clean up nsEditor::IsContainer; r=ehsan 2014-04-28 14:54:46 +03:00
Aryeh Gregor
7ee0281914 Bug 1002429 part 2 - Clean up nsHTMLEditor::GetEnclosingTable; r=ehsan 2014-04-28 14:54:46 +03:00
Aryeh Gregor
d256f17a66 Bug 1002429 part 1 - Clean up nsHTMLEditor::GetElementOrParentByTagName; r=ehsan 2014-04-28 14:54:46 +03:00
Aryeh Gregor
4929ccd709 Bug 1001351 - Allow null-safe conversion from nsINode to nsIDOMNode; r=smaug 2014-04-25 13:34:42 +03:00
Aryeh Gregor
47944b3924 Bug 1000959 - nsHTMLEditor.cpp cleanup; r=ehsan 2014-04-25 13:34:42 +03:00
Ehsan Akhgari
50a084ff52 Bug 992118 - Correctly handle the underscore in the LANG environment variable; r=smaug 2014-04-30 18:01:12 -04:00
Birunthan Mohanathas
ff8ce9bd42 Bug 900908 - Part 3: Change uses of numbered macros in nsIClassInfoImpl.h/nsISupportsImpl.h to the variadic variants. r=froydnj 2014-04-27 03:06:00 -04:00
Ehsan Akhgari
78f2d4560c Bug 997805 - Correctly restore the placeholder text after the editor object is re-attached to a text control as a result of a reframe; r=bzbarsky
Recomputing the placeholder visibility does not require the placeholder div
itself to be present, as the only information required for that is the current
value of the text control which is present either way.  This patch fixes
nsTextEditorState::ValueWasChanged and nsTextEditorState::UpdatePlaceholderVisibility
to that effect.

But the real fix is in nsTextEditorState::UpdatePlaceholderText, where after
setting the placeholder text on the anonymous div, we redo the placeholder
visibility computation.  Since this function can be called from
HTMLTextAreaElement::CreatePlaceholderNode during frame construction, the
GetValue function may return the wrong value since the editor has not properly
been set up yet, resulting in this bug.  And this function call is useless
anyway, because changing the placeholder text does not really affect the
result of the visibility computation, so there is no need to do this work
in the first place.
2014-04-25 16:40:44 -04:00
Birunthan Mohanathas
4de1915f30 Bug 900903 - Part 2: Change uses of numbered macros in nsCycleCollectionParticipant.h to the variadic variants. r=smaug 2014-04-25 12:49:00 -04:00
Masayuki Nakano
6de1b7019c Bug 998188 part.1 Add test for this crash on debug build r=ehsan 2014-04-26 08:52:12 +09:00
Wes Kocher
bd1e85ccff Backed out changeset 669fdba2ceef (bug 997805) for reftest bustage on a CLOSED TREE 2014-04-25 15:12:22 -07:00
Ehsan Akhgari
eec70383e0 Bug 997805 - Correctly restore the placeholder text after the editor object is re-attached to a text control as a result of a reframe; r=bzbarsky
Recomputing the placeholder visibility does not require the placeholder div
itself to be present, as the only information required for that is the current
value of the text control which is present either way.  This patch fixes
nsTextEditorState::ValueWasChanged and nsTextEditorState::UpdatePlaceholderVisibility
to that effect.

But the real fix is in nsTextEditorState::UpdatePlaceholderText, where after
setting the placeholder text on the anonymous div, we redo the placeholder
visibility computation.  Since this function can be called from
HTMLTextAreaElement::CreatePlaceholderNode during frame construction, the
GetValue function may return the wrong value since the editor has not properly
been set up yet, resulting in this bug.  And this function call is useless
anyway, because changing the placeholder text does not really affect the
result of the visibility computation, so there is no need to do this work
in the first place.
2014-04-25 16:40:44 -04:00
Aryeh Gregor
45fbfe5e45 Bug 950386 - Move mozilla::Selection to mozilla::dom::Selection; r=ehsan 2014-04-10 19:09:40 +03:00
Aryeh Gregor
2c948ec408 Bug 923376 - Spellcheck all appended nodes, not just the first; r=ehsan 2014-04-06 17:56:08 +03:00