Commit Graph

22 Commits

Author SHA1 Message Date
Xidorn Quan
deb8d88301 Bug 1146103 followup - Add comment mentions upgrading warning and add crashtest for the assertion. 2015-03-31 16:30:29 +11:00
Xidorn Quan
36760511f3 Bug 1146103 - Use NS_WARNING instead of MOZ_ASSERT for bcoord check in ruby text container. r=dbaron 2015-03-31 14:08:03 +11:00
Mats Palmgren
5bd17a127b Bug 1148833 part 3 - Remove nsIFrame::WillReflow and add a non-virtual MarkInReflow method instead that sets NS_FRAME_IN_REFLOW. Call it at the start of Reflow(). r=roc 2015-03-29 22:38:40 +00:00
Cameron McCormack
5c3e7f784f Bug 1120300 - Export WritingModes.h as mozilla/WritingModes.h. r=jfkthame 2015-03-26 18:29:31 +11:00
Jonathan Kew
5e69de6a1f Bug 1141928 part 2 - Correct the position of ruby text frames. r=roc 2015-03-14 16:46:33 +11:00
Xidorn Quan
071c31b4a7 Bug 1135361 - Fix position of ruby annotation in vertical-rl mode when justification is applied to the base. r=jfkthame 2015-02-24 14:46:29 +11:00
Xidorn Quan
91dbc29cc5 Bug 1132008 part 1 - Calculate bsize of rtc according to its children. r=dbaron
--HG--
extra : source : e07fd183c24ea7133faa62bc5837e6d30589f05e
2015-02-17 14:25:18 +13:00
Xidorn Quan
995fd93010 Bug 1115262 - Fix position of ruby annotation when writing mode is vertical-rl. r=jfkthame
--HG--
extra : source : ec2b2922a741fc5a62bc76c716529eda1b7fe5d0
extra : amend_source : 95bc6d9805f2c0cb9c4d76fcebb5defdd6c69660
2015-01-13 20:04:41 +11:00
Xidorn Quan
ab4ff1f1f3 Bug 1055658 part 4 - Revert RubyReflowState. r=dbaron
--HG--
extra : source : 27e60ddbd077439dadd09641ab54fc7eef09c69f
2015-01-13 20:04:41 +11:00
Nigel Babu
98abca37da Backed out 4 changesets (bug 1055658) for M5 bustage on a CLOSED TREE
Backed out changeset 3cbd9323c896 (bug 1055658)
Backed out changeset 99e071295c42 (bug 1055658)
Backed out changeset 55119d19e4c5 (bug 1055658)
Backed out changeset e82f640cb53f (bug 1055658)
2015-01-12 10:43:11 +05:30
Xidorn Quan
6940abf9e0 Bug 1055658 part 4 - Revert RubyReflowState. r=dbaron
--HG--
extra : source : 27e60ddbd077439dadd09641ab54fc7eef09c69f
2015-01-12 14:31:55 +11:00
Xidorn Quan
fe93816785 Bug 1116037 part 12 - Move mLineSize to RubyReflowState. r=dbaron
--HG--
extra : source : 17ad55f13af3e96df7649f968c838bc48b323c68
2014-12-30 11:20:10 +11:00
Xidorn Quan
7f2739eedc Bug 1116037 part 11 - Add RubyReflowState for sharing states between ruby level boxes. r=dbaron
--HG--
extra : source : c4f342ece9c1548053348dbc317d9857cbe790b6
2014-12-30 11:16:30 +11:00
Xidorn Quan
bd4976f4fe Bug 1116037 part 2 - Use frame state bit to mark rtc of span. r=dbaron
--HG--
extra : source : ae8d3b155c8ac5f73992fdb5f23e6be48c884c78
2014-12-29 13:34:07 +11:00
Xidorn Quan
89c95f9472 Bug 1055665 part 3 - Position ruby annotations and set the line size of them correctly. r=dholbert
--HG--
extra : source : c4dff2a39c852a249a5ff6e929780d898ba956ac
2014-12-09 17:47:26 +11:00
Xidorn Quan
6630d62d23 Bug 1052924 - Implement basic line breaking for ruby. r=dbaron
Known problem:
It would cause infinite loop if there is any line break happens inside
ruby base or annotation, or the width of container is not enough for
the widest pair/span. This might be fixed in bug 1098272.
2014-11-26 15:52:50 +11:00
Xidorn Quan
48fadfdbea Bug 1052924 - Resolve some warnings. r=dbaron
Important changes:
  * Change base class of nsRuby{Base,Text}Frame to nsInlineFrame
  * Make ComputeSize of nsRubyFrame and nsRubyBaseContainerFrame behavior like inline frames
2014-11-26 15:52:49 +11:00
Xidorn Quan
17090fbd22 Bug 1052924 - Rewrite reflow code. r=dbaron
Important changes:
  * Avoid using GetPrefISize on the ruby texts in
    nsRubyBaseContainerFrame::Reflow, since the size it produces might
    not match the size produced by Reflow.  The old code calls that on
    all the ruby texts to determine how big they are, then reflows all
    the ruby bases, and then reflows all the ruby texts.  The new code
    instead processes one pair at a time, and for each pair reflows the
    ruby texts and then the ruby base.
  * Change the base class of nsRubyTextContainerFrame from nsBlockFrame
    to nsContainerFrame, and stop constructing an nsBlockReflowState for
    its reflow.
  * Move the code for reflowing ruby texts from nsRubyTextContainerFrame
    and to nsRubyBaseContainerFrame.
  * Fix the regression that ruby text containers contain span are not
    reflowed properly. It is the regression introduced in patch 0.

Known regression:
  * This patch drops centering ruby base and annotation in pairs. This
    should be fixed in bug 1055676 (ruby-align).
2014-11-26 15:52:49 +11:00
Carsten "Tomcat" Book
32825b590d Backed out changeset 357b7bb14462 (bug 1083004) for frequent b2g m-9 test failures 2014-11-12 11:26:12 +01:00
Xidorn Quan
ccaf23b377 Bug 1083004 - Fix crashes for tests. r=dbaron 2014-11-12 17:31:31 +11:00
Susanna Bowen
d4c7a65b4c Bug 1030993 - Basic reflow implementation for ruby frame classes. r=dbaron
To account for spacing between bases or text boxes during reflow, the line
layout which manages the bases updates its inline direction coordinate based on
the preferred inline size for the corresponding text boxes. Next, the base is
reflowed at the correct inline coordinate. Each paired text box is then also
reflowed at the proper inline position determined by (1) the current position of
its corresponding base and (2) its own preferred width.

In computing intrinsic widths, accounting for spacing is less complicated. The
minimum intrinsic width is the width of the widest ruby column, and the
preferred intrinsic width is the sum of all the ruby column widths. Each ruby
column width is the maximum width of its base box and text boxes. These
individual widths are determined using GetPrefISize on the base and text boxes.

Ruby base container frames store a list of pointers to the ruby text container
frames in the segment they denote. This list of pointers is created in the ruby
frame reflow method before calling the reflow method for the ruby base
container. The list exists and is used only during reflow of the main ruby frame
and is cleared before returning from reflow.
2014-08-15 10:34:20 -07:00
Susanna Bowen
4e66a798af Bug 1021952 - Add ruby display values and ruby frames. r=dholbert,bz 2014-07-22 19:08:01 -07:00