Raymond Lee
5c19510c58
Change a var to let.
2010-08-12 14:46:16 +08:00
Raymond Lee
dc1ad35b40
Bug 586522 - Leaks in Tab Candy
2010-08-12 14:39:12 +08:00
Raymond Lee
a77313ad4e
Release some resources on unload
2010-08-12 12:36:58 +08:00
Michael Yoshitaka Erlewine
606e0b8349
Bug 574217: Some touchups based on comments from dolske
2010-08-11 23:08:33 -04:00
Michael Yoshitaka Erlewine
e657eee62c
Fixes for Dolske's strict JS warnings
2010-08-11 22:01:29 -04:00
Michael Yoshitaka Erlewine
84b9f70725
GroupItem: unify title-setting to use setTitle (which in turn uses iQ.val). Note TabItem titles are set using iQ.text, so there is no security issue there.
2010-08-11 21:35:29 -04:00
Ian Gilman
5bf2c27f8d
+ I forgot to update the references to the newly renamed tabview.css files; fixed
2010-08-11 17:00:15 -07:00
Ian Gilman
5b66c2b656
+ Fixes for dolske and dao comments on bug 574217:
...
++ Unnecessary double if in tabbrowser.xml
++ moved body styling into CSS file and simplified
++ CSS comma style
++ Renamed platform.css files to tabview.css
--HG--
rename : browser/themes/gnomestripe/browser/tabview/platform.css => browser/themes/gnomestripe/browser/tabview/tabview.css
rename : browser/themes/pinstripe/browser/tabview/platform.css => browser/themes/pinstripe/browser/tabview/tabview.css
rename : browser/themes/winstripe/browser/tabview/platform.css => browser/themes/winstripe/browser/tabview/tabview.css
2010-08-11 16:51:39 -07:00
Ian Gilman
d14feaee8f
+ More dolske comments for 574217
...
++ Initial developer
++ Cc, Ci, Cu
++ Spacing
++ Commented out code in storage.js
++ DOCTYPE
2010-08-11 15:28:45 -07:00
Michael Yoshitaka Erlewine
3fefad5aab
Bug 582023: making changes requested by Dao. Now iQ + Utils are ready for m-c with r=dao!
2010-08-11 13:06:49 -04:00
Ian Gilman
5060cd7f0e
+ removed profiling code
...
--HG--
extra : rebase_source : 690f1d46c2833ec2e122b53b2fbbc3b5a0e50aec
2010-08-10 18:10:21 -07:00
Ian Gilman
0a89c5909a
+ addressing dao's comments in iQ
...
--HG--
extra : rebase_source : 9fd229f468514fb08326fe292434de45e6167bfb
2010-08-10 16:31:12 -07:00
Michael Yoshitaka Erlewine
3a11cdef26
Bug 582023 cleanup based on comments from Dao on things that are not iQ:
...
- typeof() is not a function
- formatting of && and || at the end of the line
- declaring variables more locally using let in Utils.extend
- the Initial Developer is the Mozilla Foundation
--HG--
extra : rebase_source : d1f9699fb0014c95e336c34d777ce354b141739a
2010-08-10 19:20:05 -04:00
Ian Gilman
160e4ba0ca
+ removed the "beforeclose" event from TabItem and cleaned up the "close" event
...
+ Removed the "urlChanged" event from TabItem; inlining that code instead.
--HG--
extra : rebase_source : a48f380dd98eaaa971e7e0529b6c17b674a02b9f
2010-08-10 15:36:56 -07:00
Ian Gilman
49f9880244
+ TabView actions that require loading the frame (if not loaded) now wait properly until the frame is loaded before continuing. These actions are show, context menu, and "next group" key combo.
...
+ TabView now has explicit show and hide in addition to toggle
+ Cleaned out unused "ui" parameter to the Item drag callback
--HG--
extra : rebase_source : e8ffd468406fe1d0690e29a15ce4b431a0596371
2010-08-10 14:23:53 -07:00
Raymond Lee
ea3e0b1135
Fixed Bug 584627 - Tests for group
2010-08-11 02:39:28 +08:00
Ian Gilman
3381f8595e
+ reversed the argument order for Utils.assert and Utils.assertThrow, per Dao's review
2010-08-10 11:13:10 -07:00
Raymond Lee
7eb0f4ccb0
Removed the remaining Utils.timeout
2010-08-11 00:19:08 +08:00
Michael Yoshitaka Erlewine
4645c92a6b
Bug 582023: rm Utils.timeout
2010-08-10 09:30:23 -04:00
Michael Yoshitaka Erlewine
8bddd0dbe9
Bug 582023: move to use getBoundingClientRect instead of reading off the computed CSS for bounds; simplify getPropertyValue usage (based on comments from Dao)
2010-08-10 09:22:38 -04:00
Edward Lee
69650603da
Address review comments from bug 584532 comment 18: !listeners, event.target, observers function.
2010-08-10 03:05:10 -07:00
Ehsan Akhgari
d6b330e338
Bug 585850 - Rename TabCandy modules from *.js to *.jsm (like the rest of js modules)
...
--HG--
rename : browser/base/content/tabview/modules/AllTabs.js => browser/base/content/tabview/modules/AllTabs.jsm
rename : browser/base/content/tabview/modules/groups.js => browser/base/content/tabview/modules/groups.jsm
rename : browser/base/content/tabview/modules/utils.js => browser/base/content/tabview/modules/utils.jsm
2010-08-09 23:51:23 -04:00
Edward Lee
43b7d40966
Move private variables/methods into local declarations not exported by AllTabs and change the interface to .register("change") instead of .onChange() for bug 584532.
...
--HG--
rename : browser/base/content/AllTabs.js => browser/base/content/tabview/modules/AllTabs.js
extra : rebase_source : 267110a1a1dd8cc8d4188f20285d688b2b901aa1
2010-08-09 17:19:04 -07:00
Ian Gilman
20a7760e76
+ no longer loading the frame at all until the user needs it
2010-08-09 17:24:08 -07:00
Ian Gilman
80b2ae42e5
+ Made the Groups.killNewTabGroup test a little tighter (in case someone has made a group called "new tabs")
...
+ Worked around bug 575672 (CSS transition assert)
--HG--
extra : rebase_source : 6f758e737c2092214ec3185be847f2c5da406be0
2010-08-09 14:57:34 -07:00
Raymond Lee
b24a21ba0d
Bug 585155 - Zoom in animation doesn't work when adding a new tab in tab candy interface
2010-08-09 15:01:30 +08:00
Raymond Lee
0832814e00
Initialize frame if needed when user is switching to another group using keyboard combination
2010-08-09 13:16:39 +08:00
Michael Yoshitaka Erlewine
ac9f4d6a09
rm setSize during tabs' group-removal. Bottom line: tabs no longer shrink and block jerk the dragging when being dragged out of a group.
2010-08-09 00:17:03 -04:00
Michael Yoshitaka Erlewine
79731acdaa
Bug 584699: quick fix to -moz-transform rendering bug
...
--HG--
extra : rebase_source : 89019c5a0acff884ab47f18b96503435c6a56e7e
2010-08-09 00:06:54 -04:00
Raymond Lee
5b0ae1ddd6
Bug 585148 - Showing tabcandy for the first time results in many showOnlyTheseTabs
2010-08-09 11:52:26 +08:00
Michael Yoshitaka Erlewine
25cd73765e
quick touchup to GroupItems.getnextGroupItemTab
2010-08-08 23:41:07 -04:00
Michael Yoshitaka Erlewine
4f7f711946
s/updateTabBarForActiveGroupItem/updateTabBar/; rm some tabs (don't worry, the whitespace kind)
2010-08-08 21:54:22 -04:00
Michael Yoshitaka Erlewine
18ca5dc914
Bug 567391 + 575851: If we enter an orphan tab, only that tab should show up in the tab bar.
2010-08-08 21:49:43 -04:00
Michael Yoshitaka Erlewine
f59d44241d
Bug 575851: Are You Experienced? The New Tab Experience
...
- refine the use of the "active group item", with differential styling, and not clearing when we enter the tab view
- set the active group item in other cases, like when we drag out groups, when we resize or move a group, or when a group is a drop target
2010-08-08 20:27:47 -04:00
Michael Yoshitaka Erlewine
aec521be06
Bug 575851: kill the now defunct New Tab Group.
2010-08-08 18:47:06 -04:00
Michael Yoshitaka Erlewine
355fe0818e
Bug 575851: some touchups to previous New Tab Experience code, based on comments by Ian
2010-08-08 18:32:08 -04:00
Raymond Lee
29c9156549
Ensure the frame is initialized when user accesses the tab context menu
2010-08-09 01:28:24 +08:00
Edward Lee
699692f9eb
Remove unnecessary try/catch wrapping around a timeout-ed call.
...
--HG--
extra : rebase_source : 3b608473ff899668acea4e0e6964734c9db4d01d
2010-08-06 17:16:28 -07:00
Ian Gilman
cd78c7f4dc
+ Started groups.js module (nothing to see yet)
...
+ Fixed assert caused by the recent change from Tabs to AllTabs
2010-08-06 17:02:21 -07:00
Ian Gilman
502cc2969a
+ Renamed Group and Groups to GroupItem and GroupItems, respectively
...
+ Fixed a bug in "group sites"
--HG--
rename : browser/base/content/tabview/groups.js => browser/base/content/tabview/groupitems.js
extra : rebase_source : 06525a410c9f3a7d3a3f3023d6b1b520295a8fe6
2010-08-06 15:46:55 -07:00
Edward Lee
0abeebc996
Prepare for bug 584532 by renaming Tabs and T -> AllTabs, allTabs -> tabs, browsers -> browserWindows, and removing QI(nsIObserver).
...
--HG--
rename : browser/base/content/tabview/modules/tabs.js => browser/base/content/AllTabs.js
extra : rebase_source : 1eedbcbdbda0895f12170f93c55b6946612d8819
2010-08-06 15:19:57 -07:00
Ian Gilman
c6989ca261
+ a little cleanup for Bug 575851 - Implement the revised New Tab Experience
...
--HG--
extra : rebase_source : e0a4063328d2019eaf375a57b85a7b4617fabc4a
2010-08-06 14:22:56 -07:00
Ian Gilman
832cb80a90
+ We now update the thumbnail for the current tab (so the zoom down looks right)
...
--HG--
extra : rebase_source : cb1888e26493760207e9c94697a93b1863036b79
2010-08-05 10:39:33 -07:00
Raymond Lee
bb9eacc9c1
Bug 576408 - Implement the downgraded tab triage experience
2010-08-06 22:17:01 +08:00
Michael Yoshitaka Erlewine
4736622e1b
Bug 575851: new tab experience, part 1:
...
- removed new tab group (you may have to clear storage to get rid of your locked New Tabs group at the bottom of your screen)
- rm various special casing for the new tab group
- new tab experience for tabs-off-of-orphaned-tabs is implemented: they magically turn into a group, and it even snaps!
- broken: new tabs made with no active context
- broken: closing the last tab in a group: should go back to tab candy view
- broken: first run experience grouping of orphaned tabs
2010-08-05 01:43:05 -04:00
Raymond Lee
f87aff3a6f
Bug 582677 - Test for dragging and dropping item from one group to another group
2010-08-05 08:12:08 +08:00
Ian Gilman
badcd877d6
+ Tab thumbnails once again update themselves when their size changes
...
+ TabItem updates (painting, etc) no longer happen when the Tab Candy UI is not visible; they're queued up and happen when you return to the UI
+ Fixed a couple problems with the TabItems pause painting mechanism
+ If a whole bunch of TabItem updates come at the same time, we spread them out (using a heartbeat that lasts until we run out of backlog)
+ This should fix both Bug 580954 (Replace the heartbeat with something smarter) and Bug 583420 (Tab thumbnails don't repaint after being resized)
2010-08-04 16:42:36 -07:00
Ian Gilman
3436bf6284
+ Commented out the "refresh" and "reset" items on the dev menu in response to Bug 584372 (Firefox will crash if either Refresh or Reset in the Dev menu of the Visual Tab Interface is selected); we may bring these back in the future if needed for dev work, but they won't be in the shipping version.
2010-08-04 11:09:06 -07:00
Raymond Lee
c962044a9a
Bug 583711 - name field for tab group in candy
2010-08-04 09:42:46 +08:00
Aza Raskin
2b18a50b6b
+ Also includes the jQuery inclusion text with utils.js
2010-08-02 13:38:29 -07:00