Commit Graph

15 Commits

Author SHA1 Message Date
Birunthan Mohanathas
8c368b6d82 Bug 1221104 - Throw NS_ERROR_NOT_IMPLEMENTED instead of NS_ERROR_UNEXPECTED for PushPermissionDescriptor.userVisible. r=baku
This is merely for clarity. The spec does not require a TypeError to be thrown here.
2015-12-18 15:02:50 +02:00
Birunthan Mohanathas
b5c61ef822 Bug 1221104 - Revoke 'midi' permission queries with TypeError. r=baku
According to the spec, we should reject unsupported permissions with a
TypeError. This removes the 'midi' entry entirely so that we get the expected
behaviour.
2015-12-18 15:02:50 +02:00
Nathan Froyd
e4e2da55c9 Bug 1207245 - part 6 - rename nsRefPtr<T> to RefPtr<T>; r=ehsan; a=Tomcat
The bulk of this commit was generated with a script, executed at the top
level of a typical source code checkout.  The only non-machine-generated
part was modifying MFBT's moz.build to reflect the new naming.

CLOSED TREE makes big refactorings like this a piece of cake.

 # The main substitution.
find . -name '*.cpp' -o -name '*.cc' -o -name '*.h' -o -name '*.mm' -o -name '*.idl'| \
    xargs perl -p -i -e '
 s/nsRefPtr\.h/RefPtr\.h/g; # handle includes
 s/nsRefPtr ?</RefPtr</g;   # handle declarations and variables
'

 # Handle a special friend declaration in gfx/layers/AtomicRefCountedWithFinalize.h.
perl -p -i -e 's/::nsRefPtr;/::RefPtr;/' gfx/layers/AtomicRefCountedWithFinalize.h

 # Handle nsRefPtr.h itself, a couple places that define constructors
 # from nsRefPtr, and code generators specially.  We do this here, rather
 # than indiscriminantly s/nsRefPtr/RefPtr/, because that would rename
 # things like nsRefPtrHashtable.
perl -p -i -e 's/nsRefPtr/RefPtr/g' \
     mfbt/nsRefPtr.h \
     xpcom/glue/nsCOMPtr.h \
     xpcom/base/OwningNonNull.h \
     ipc/ipdl/ipdl/lower.py \
     ipc/ipdl/ipdl/builtin.py \
     dom/bindings/Codegen.py \
     python/lldbutils/lldbutils/utils.py

 # In our indiscriminate substitution above, we renamed
 # nsRefPtrGetterAddRefs, the class behind getter_AddRefs.  Fix that up.
find . -name '*.cpp' -o -name '*.h' -o -name '*.idl' | \
    xargs perl -p -i -e 's/nsRefPtrGetterAddRefs/RefPtrGetterAddRefs/g'

if [ -d .git ]; then
    git mv mfbt/nsRefPtr.h mfbt/RefPtr.h
else
    hg mv mfbt/nsRefPtr.h mfbt/RefPtr.h
fi
2015-10-18 01:24:48 -04:00
Birunthan Mohanathas
3d1abe7b81 Bug 1105827 - Part 11: Use nsRefPtr to store PermissionStatus. r=baku 2015-07-31 14:56:59 -07:00
Birunthan Mohanathas
50000b734f Bug 1105827 - Part 8: Move permission checking into PermissionStatus. r=baku 2015-08-21 19:53:29 -07:00
Birunthan Mohanathas
3bc3901c0e Bug 1105827 - Part 7: Add helpers to convert between PermissionName and permission type. r=baku 2015-08-21 19:53:29 -07:00
Birunthan Mohanathas
648197fb73 Bug 1105827 - Part 6: Add PermissionUtils.h for helper functions. r=baku 2015-08-21 19:53:29 -07:00
Birunthan Mohanathas
199d0bdf4c Backed out changeset 1e13c9c09273 (bug 1105827)
CLOSED TREE
2015-08-11 10:04:36 -07:00
Birunthan Mohanathas
f4a1d6e1ea Backed out changeset 92d2843b5938 (bug 1105827) 2015-08-11 10:04:35 -07:00
Birunthan Mohanathas
f0afbabdb0 Backed out changeset fc34b9b8e874 (bug 1105827) 2015-08-11 10:04:35 -07:00
Birunthan Mohanathas
73b6d07e2c Bug 1105827 - Part 8: Move permission checking into PermissionStatus. r=baku
This is in prepartion of a subsequent change where we will update the state
within PermissionStatus.
2015-07-31 15:53:10 -07:00
Birunthan Mohanathas
e402beda85 Bug 1105827 - Part 7: Add helpers to convert between PermissionName and permission type. r=baku 2015-07-31 15:49:59 -07:00
Birunthan Mohanathas
69401bbf64 Bug 1105827 - Part 6: Add PermissionUtils.h for helper functions. r=baku 2015-07-31 15:49:55 -07:00
Birunthan Mohanathas
4ef1c21f3e Bug 1105827 - Part 3: Implement Permissions.query. r=baku 2015-07-28 06:33:46 -07:00
Birunthan Mohanathas
bd698632d1 Bug 1105827 - Part 2: Add stub Permissions implementation. r=baku 2015-07-28 06:33:46 -07:00