Commit Graph

414 Commits

Author SHA1 Message Date
Nicholas Nethercote
ee41df7dc2 Bug 1127201 (attempt 2, part 1) - Replace most NS_ABORT_IF_FALSE calls with MOZ_ASSERT. r=Waldo. 2015-02-09 14:34:50 -08:00
Andrew McCreight
1ee96e7527 Back out Bug 1127201 (part 2) for various problems. 2015-02-06 15:04:32 -08:00
Nicholas Nethercote
0a02b5d31c Bug 1127201 (part 2) - Convert all NS_ABORT_IF_FALSE calls to MOZ_ASSERT. r=Waldo. 2015-02-04 20:05:36 -08:00
Mike Hommey
50e6916b40 Bug 1126593 - Add a global fallible instance, so that using fallible works directly, everywhere. r=njn 2015-02-02 09:56:13 +09:00
Patrick McManus
fdaefb68d6 bug 1116867 - make nsIProgressEventSink and nsITransportEventSink safely scriptable r=mayhemer r=bz
These scriptable interfaces use uint_64 arguments with sentinel values
of UINT64_MAX. However, UINT64_MAX exceeds MAX_SAFE_INTEGER and cannot
be gatewayed to/from javascript - so they cannot be used
correctly. Change them to use signed 64 bit numbers and -1 as the
sentinnel. C++ implementations ought to be enough to audit as the
special value could never be used correctly in JS anyhow - also
audited OnProgressChange() uses for downstream use of this data.
---
 dom/base/nsXMLHttpRequest.cpp                      | 19 +++++++----
 dom/base/nsXMLHttpRequest.h                        | 10 +++---
 dom/plugins/base/nsPluginStreamListenerPeer.cpp    |  4 +--
 .../webbrowserpersist/nsWebBrowserPersist.cpp      | 14 ++++----
 image/src/imgLoader.cpp                            |  4 +--
 modules/libjar/nsJARChannel.cpp                    |  3 +-
 netwerk/base/public/nsIProgressEventSink.idl       |  8 ++---
 netwerk/base/public/nsITransport.idl               |  8 ++---
 netwerk/base/public/nsNetUtil.h                    | 24 ++++++++++++++
 netwerk/base/src/Dashboard.cpp                     |  2 +-
 netwerk/base/src/nsBaseChannel.cpp                 | 12 +++----
 netwerk/base/src/nsIncrementalDownload.cpp         |  4 +--
 netwerk/base/src/nsSocketTransport2.cpp            |  5 +--
 netwerk/base/src/nsStreamTransportService.cpp      | 38 +++++++++++++---------
 netwerk/base/src/nsTransportUtils.cpp              | 12 +++----
 netwerk/protocol/file/nsFileChannel.cpp            |  8 +++--
 netwerk/protocol/ftp/nsFtpConnectionThread.cpp     |  4 +--
 netwerk/protocol/http/Http2Push.cpp                |  2 +-
 netwerk/protocol/http/Http2Session.cpp             |  2 +-
 netwerk/protocol/http/HttpChannelChild.cpp         | 31 +++++++++---------
 netwerk/protocol/http/HttpChannelChild.h           |  6 ++--
 netwerk/protocol/http/HttpChannelParent.cpp        |  4 +--
 netwerk/protocol/http/HttpChannelParent.h          |  4 +--
 netwerk/protocol/http/NullHttpTransaction.cpp      |  2 +-
 netwerk/protocol/http/PHttpChannel.ipdl            |  2 +-
 netwerk/protocol/http/SpdyPush31.cpp               |  2 +-
 netwerk/protocol/http/SpdySession31.cpp            |  2 +-
 netwerk/protocol/http/TunnelUtils.cpp              |  2 +-
 netwerk/protocol/http/nsAHttpTransaction.h         |  4 +--
 netwerk/protocol/http/nsHttpChannel.cpp            | 30 +++++++++++------
 netwerk/protocol/http/nsHttpConnection.cpp         |  4 +--
 netwerk/protocol/http/nsHttpConnectionMgr.cpp      |  4 +--
 netwerk/protocol/http/nsHttpPipeline.cpp           |  4 +--
 netwerk/protocol/http/nsHttpPipeline.h             |  6 ++--
 netwerk/protocol/http/nsHttpResponseHead.cpp       |  2 +-
 netwerk/protocol/http/nsHttpResponseHead.h         |  2 +-
 netwerk/protocol/http/nsHttpTransaction.cpp        | 32 +++++++++---------
 netwerk/protocol/http/nsHttpTransaction.h          |  2 +-
 netwerk/protocol/wyciwyg/WyciwygChannelChild.cpp   |  2 +-
 netwerk/protocol/wyciwyg/nsWyciwygChannel.cpp      |  3 +-
 netwerk/test/TestIncrementalDownload.cpp           |  7 ++--
 uriloader/base/nsDocLoader.cpp                     | 14 ++++----
 42 files changed, 203 insertions(+), 151 deletions(-)
2015-01-08 14:48:52 -05:00
Christoph Kerschbaumer
8bb0600bb8 Bug 1110469 - Remove NS_OpenURI (r=sworkman) 2015-01-11 20:26:40 -08:00
Ehsan Akhgari
bd52bd3f4e Bug 1118486 - Part 1: Use = delete instead of MOZ_DELETE directly; r=Waldo
Most of this patch (with the exception of dom/bindings/Codegen.py) was
generated by the following bash script:

#!/bin/bash

function convert() {
echo "Converting $1 to $2..."
find . ! -wholename "*nsprpub*" \
       ! -wholename "*security/nss*" \
       ! -wholename "*/.hg*" \
       ! -wholename "*/.git*" \
       ! -wholename "obj-*" \
         -type f \
      \( -iname "*.cpp" \
         -o -iname "*.h" \
         -o -iname "*.cc" \
         -o -iname "*.idl" \
         -o -iname "*.ipdl" \
         -o -iname "*.ipdlh" \
         -o -iname "*.mm" \) | \
    xargs -n 1 sed -i -e "s/\b$1\b/$2/g"
}

convert MOZ_DELETE '= delete'
2015-01-08 23:19:05 -05:00
Christoph Kerschbaumer
bbf8788bc5 Bug 1087738: Make JS callers of ios.newChannel call ios.newChannel2 in modules/ (r=mwu) 2014-10-24 15:06:16 -07:00
Christoph Kerschbaumer
6d6fa71cc0 Bug 1087442 - Attach LoadInfo inside each individual ProtocolHandler - modules/ changes (r=mwu) 2014-12-12 09:07:23 -08:00
Phil Ringnalda
e725b6fdc2 Backed out 15 changesets (bug 1087442)
Backed out changeset 3f4166fb5e37 (bug 1087442)
Backed out changeset 0c9c9123a0a9 (bug 1087442)
Backed out changeset 1d85d298042d (bug 1087442)
Backed out changeset 51f3ce397d68 (bug 1087442)
Backed out changeset f3b81a623692 (bug 1087442)
Backed out changeset 472e8fa74596 (bug 1087442)
Backed out changeset 12f97df7b79c (bug 1087442)
Backed out changeset 253cde88d3c5 (bug 1087442)
Backed out changeset b44f9ebd56cb (bug 1087442)
Backed out changeset 48e412887726 (bug 1087442)
Backed out changeset a2c76343f7a9 (bug 1087442)
Backed out changeset 0b5b07cfef0e (bug 1087442)
Backed out changeset 2931c35342a4 (bug 1087442)
Backed out changeset 681ce9dcad64 (bug 1087442)
Backed out changeset 47c505856954 (bug 1087442)
2014-12-11 21:58:21 -08:00
Christoph Kerschbaumer
ba9a8c86be Bug 1087442 - Attach LoadInfo inside each individual ProtocolHandler - modules/ changes (r=mwu) 2014-12-11 20:46:34 -08:00
Chris Peterson
47091050b7 Bug 1107814 - Part 1: Mark more directories as FAIL_ON_WARNINGS for all compilers. r=gps 2014-12-04 16:24:03 -08:00
Trevor Saunders
dfe4aecd6f bug 1105074 - make more stuff final r=froydnj 2014-11-25 13:56:07 -05:00
Christoph Kerschbaumer
35d8a6d9d1 Bug 1083422 - Add triggering Principal to nsILoadInfo - update callsites (r=bz,sicking) 2014-11-14 08:56:55 -08:00
Christoph Kerschbaumer
b71c277de5 Bug 1067471 - Add newChannel2 to nsIProtocolHandler that takes a loadinfo as an argument (r=sicking) 2014-10-22 17:16:57 -07:00
Christoph Kerschbaumer
897fd1befa Bug 1041180: Remove deprecated nsIChannelPolicy (r=sstamm,jduell,jst) 2014-10-15 19:11:45 -07:00
Andrew Halberstadt
6fe6152e95 Bug 1066735 - Remove root b2g and android specific xpcshell manifests, r=chmanchester 2014-10-07 18:18:28 -04:00
Christoph Kerschbaumer
9cd0a5fc37 Bug 1073282 - Proxy release of mLoadInfo in cannel dtors (r=jduell) 2014-09-29 08:48:11 -07:00
Phil Ringnalda
d9ceb5d4e5 Back out 693507b38116 (bug 1041180) since it doesn't like compiling without its friend
CLOSED TREE
2014-09-25 21:18:01 -07:00
Christoph Kerschbaumer
8afc30d206 Bug 1041180: Remove deprecated nsIChannelPolicy (r=sstamm,jduell,jst) 2014-09-25 16:10:28 -07:00
Carsten "Tomcat" Book
a674cd01fd Backed out changeset 4bb508b6f0c5 (bug 1041180) for XPCshell test failures 2014-09-24 13:13:20 +02:00
Christoph Kerschbaumer
c94caab7aa Bug 1041180: Remove deprecated nsIChannelPolicy (r=sstamm,jduell,jst) 2014-09-24 01:01:07 -07:00
Wes Kocher
f1e3e07ae5 Backed out 2 changesets (bug 1041180) for build bustage on a CLOSED TREE
Backed out changeset 1cfb645267a4 (bug 1041180)
Backed out changeset afc9903ff28f (bug 1041180)
2014-09-23 16:26:49 -07:00
Christoph Kerschbaumer
cded590dd2 Bug 1041180: Remove deprecated nsIChannelPolicy (r=sstamm,jduell,jst) 2014-09-23 09:46:54 -07:00
Christoph Kerschbaumer
8e5a753181 Bug 1038756: Callsites creating a channel in /modules/ (r=mwu) 2014-09-21 09:44:56 -07:00
Josh Matthews
7e273e8979 Bug 1059832 - Disallow initiating asynchronous remote JAR channel requests for synchronous operations. r=jduell 2014-09-15 13:00:08 -04:00
Giovanni Sferro
596d5c0c5c Bug 1050518 - Remove nsICertificatePrincipal. r=keeler 2014-09-10 20:31:00 -04:00
Ehsan Akhgari
6d473e5bb2 Bug 1061061 - Fix more bad implicit constructors in misc. code; r=bsmedberg 2014-09-02 18:24:24 -04:00
Trevor Saunders
e1a88eb1fb bug 1059490 - mark more classes MOZ_FINAL r=froydnj 2014-08-27 14:26:48 -04:00
Ryan VanderMeulen
1f65b337bb Bug 1048579 - Update the nsIChannel UUID. rs=Ms2ger
--HG--
extra : rebase_source : c4032b92e3ced113610ec9c365a5dadea2f57947
2014-08-25 09:55:57 -04:00
Shian-Yow Wu
98b6d14607 Bug 1048615 - Fix crash when simultaneously opening remote JAR file with mEnsureChildFd enabled. r=jduell 2014-08-21 19:09:35 +08:00
Shian-Yow Wu
50beeaff21 Bug 1055966 - Specify limitation of RemoteOpenFileChild::OpenNSPRFileDesc(). r=jduell 2014-08-21 10:13:43 +08:00
Shian-Yow Wu
9c633b780b Backed out changeset 69471d6c631a for missing reviewer name in the commit message. 2014-08-21 09:45:40 +08:00
Shian-Yow Wu
e9b6dc3b14 Bug 1055966 - Specify limitation of RemoteOpenFileChild::OpenNSPRFileDesc(). 2014-08-21 09:40:19 +08:00
Aaron Klotz
647213ddc5 Bug 1054813: Add some missing MutexAutoLocks in nsZipReaderCache; r=mwu
--HG--
extra : rebase_source : 4f9caa7bd4ef1955c204e82bc33835a01d9f1e85
2014-08-19 12:11:03 -06:00
Michael Wu
2a5fa39618 Bug 1036394 - Add support for getting the zip entry from the jar channel, r=jduell 2014-08-04 11:54:28 -04:00
Nicholas Nethercote
ffea0fdbca Bug 1050009 - Initialize pldhash tables with a length, not a capacity. r=roc.
* * *
imported patch rm-dummy-params

--HG--
extra : rebase_source : c25987eb11bae197218d5fc53b77def19afa36ac
2014-08-06 06:31:21 -07:00
Birunthan Mohanathas
a6773b7514 Bug 1047876 - Flatten modules/libjar/zipwriter/{public,src}/ directories. r=glandium
--HG--
rename : modules/libjar/zipwriter/src/StreamFunctions.cpp => modules/libjar/zipwriter/StreamFunctions.cpp
rename : modules/libjar/zipwriter/src/StreamFunctions.h => modules/libjar/zipwriter/StreamFunctions.h
rename : modules/libjar/zipwriter/src/ZipWriterModule.cpp => modules/libjar/zipwriter/ZipWriterModule.cpp
rename : modules/libjar/zipwriter/src/nsDeflateConverter.cpp => modules/libjar/zipwriter/nsDeflateConverter.cpp
rename : modules/libjar/zipwriter/src/nsDeflateConverter.h => modules/libjar/zipwriter/nsDeflateConverter.h
rename : modules/libjar/zipwriter/public/nsIZipWriter.idl => modules/libjar/zipwriter/nsIZipWriter.idl
rename : modules/libjar/zipwriter/src/nsZipDataStream.cpp => modules/libjar/zipwriter/nsZipDataStream.cpp
rename : modules/libjar/zipwriter/src/nsZipDataStream.h => modules/libjar/zipwriter/nsZipDataStream.h
rename : modules/libjar/zipwriter/src/nsZipHeader.cpp => modules/libjar/zipwriter/nsZipHeader.cpp
rename : modules/libjar/zipwriter/src/nsZipHeader.h => modules/libjar/zipwriter/nsZipHeader.h
rename : modules/libjar/zipwriter/src/nsZipWriter.cpp => modules/libjar/zipwriter/nsZipWriter.cpp
rename : modules/libjar/zipwriter/src/nsZipWriter.h => modules/libjar/zipwriter/nsZipWriter.h
2014-08-04 06:55:01 -07:00
Dragana Damjanovic
6eb1ed7b80 Bug 1007020 - Also send progress information when connection is LOAD_BACKGROUND. r=bz 2014-08-01 02:10:00 -04:00
Mike Hommey
42f57b6138 Bug 1043802 - Remove TOOLS_DIRS and TEST_TOOLS_DIRS. r=gps 2014-07-29 08:55:55 +09:00
Mike Hommey
33ef4f2c39 Bug 1041864 - Remove LIBRARY_NAMEs that aren't used. r=mshal 2014-07-23 08:39:56 +09:00
Shian-Yow Wu
b601c06562 Bug 988816 - Allow to keep file descriptor in JAR cache. r=aklotz, jduell 2014-07-18 10:46:24 +08:00
Shian-Yow Wu
a968b880df Bug 988816 - Support multiple OpenNSPRFileOpen() on RemoteOpenFile. r=aklotz, jduell 2014-07-18 10:46:22 +08:00
Birunthan Mohanathas
9a86a1e6df Bug 1038417 - Convert tabs to spaces in moz.build files. r=gps 2014-07-14 15:58:10 -07:00
Andrew McCreight
1ee07d58d6 Bug 1038207 - Fix various classes that reimplement nsISupports. r=ehsan 2014-07-14 12:21:34 -07:00
Boris Zbarsky
f22144a471 Bug 965413 part 3. Add a .loadInfo property to channels. r=mcmanus 2014-07-10 02:56:36 -04:00
Ehsan Akhgari
f64685af92 Bug 1033457 - Use HAVE_SEH_EXCEPTIONS in order to use SEH exceptions in libjar; r=bsmedberg 2014-07-02 14:34:58 -04:00
Jim Blandy
b6b202b6bb Bug 914753: Make Emacs file variable header lines correct, or at least consistent. DONTBUILD r=ehsan
The -*- file variable lines -*- establish per-file settings that Emacs will
pick up. This patch makes the following changes to those lines (and touches
nothing else):

 - Never set the buffer's mode.

   Years ago, Emacs did not have a good JavaScript mode, so it made sense
   to use Java or C++ mode in .js files. However, Emacs has had js-mode for
   years now; it's perfectly serviceable, and is available and enabled by
   default in all major Emacs packagings.

   Selecting a mode in the -*- file variable line -*- is almost always the
   wrong thing to do anyway. It overrides Emacs's default choice, which is
   (now) reasonable; and even worse, it overrides settings the user might
   have made in their '.emacs' file for that file extension. It's only
   useful when there's something specific about that particular file that
   makes a particular mode appropriate.

 - Correctly propagate settings that establish the correct indentation
   level for this file: c-basic-offset and js2-basic-offset should be
   js-indent-level. Whatever value they're given should be preserved;
   different parts of our tree use different indentation styles.

 - We don't use tabs in Mozilla JS code. Always set indent-tabs-mode: nil.
   Remove tab-width: settings, at least in files that don't contain tab
   characters.

 - Remove js2-mode settings that belong in the user's .emacs file, like
   js2-skip-preprocessor-directives.
2014-06-24 22:12:07 -07:00
Benoit Jacob
cf8ca0fea3 Bug 1028588 - Fix dangerous public destructors in libjar/ - r=aklotz 2014-06-24 22:09:14 -04:00
Brian Smith
4212992a61 Bug 1028643: Convert nsISignatureVerifier to use CertVerifier (mozilla::pkix) and move nsISignatureVerifier functionality to nsIDataSignatureVerifier, r=keeler
--HG--
extra : rebase_source : 14f6f5dedd7145d574ac5b4c86b6ad42b6716ae8
extra : histedit_source : f891fbe80c4ca9fc62849bc2d6d8ffad372a6bf0
2014-06-22 18:50:22 -07:00