Commit Graph

8 Commits

Author SHA1 Message Date
Nicholas Nethercote
34ee1047b5 Bug 1037302 - Avoid excess string creation in WifiCommand.jsm's getConnectionInfoICS(). r=hchang.
This changes the code to use search() and indexOf() to find the boundaries of
the relevant values, and substring() to extract them. This reduces the number
of strings created on each invocation by 8x.

The patch changes the behaviour if a key appears more than once. With the old
code the last occurrence would be used. With the new code the first one is
used. Hopefully this doesn't matter.
2014-07-13 22:05:27 -07:00
Jim Blandy
b6b202b6bb Bug 914753: Make Emacs file variable header lines correct, or at least consistent. DONTBUILD r=ehsan
The -*- file variable lines -*- establish per-file settings that Emacs will
pick up. This patch makes the following changes to those lines (and touches
nothing else):

 - Never set the buffer's mode.

   Years ago, Emacs did not have a good JavaScript mode, so it made sense
   to use Java or C++ mode in .js files. However, Emacs has had js-mode for
   years now; it's perfectly serviceable, and is available and enabled by
   default in all major Emacs packagings.

   Selecting a mode in the -*- file variable line -*- is almost always the
   wrong thing to do anyway. It overrides Emacs's default choice, which is
   (now) reasonable; and even worse, it overrides settings the user might
   have made in their '.emacs' file for that file extension. It's only
   useful when there's something specific about that particular file that
   makes a particular mode appropriate.

 - Correctly propagate settings that establish the correct indentation
   level for this file: c-basic-offset and js2-basic-offset should be
   js-indent-level. Whatever value they're given should be preserved;
   different parts of our tree use different indentation styles.

 - We don't use tabs in Mozilla JS code. Always set indent-tabs-mode: nil.
   Remove tab-width: settings, at least in files that don't contain tab
   characters.

 - Remove js2-mode settings that belong in the user's .emacs file, like
   js2-skip-preprocessor-directives.
2014-06-24 22:12:07 -07:00
Vincent Chang
8fb5dc9b5e Bug 774582 - Unable to know if there is a user connected to Wifi tethering network. r=mrbkap 2014-01-22 16:37:40 +08:00
Henry Chang
baf4b1b800 Bug 998892 - Append "interface=XXX" to the WPS PBC/PIN supplicant command only for JB. r=vchang 2014-05-06 15:04:16 +08:00
Henry Chang
7bf37ef48c Bug 811635 - Part 4: Wifi Direct core implementation. r=vchang 2014-01-14 18:23:42 +08:00
Chuck Lee
60595be521 Bug 950124 - Use different powersave command based on sdk version. r=vchang 2014-01-10 12:12:38 +08:00
Henry Chang
6e5f3115ff Bug 912015 - Support multiple wap_supplicant connections. r=mrbkap 2013-10-14 16:33:59 +08:00
Henry Chang
778b45febc Bug 919426 - Part 1: Add new file WifiCommand.jsm. r=vchang
WifiCommand.jsm is used to call the native C API and control wpa_supplicant
2013-09-30 10:59:11 +08:00