Chris Beard
e9ac166a41
* major revision to the login dialog to be more robust, adding error handling, styling and a help link
...
* some minor hacking of the login progress to improve performance
* expanded the application exit sync dialog to be a general modal sync dialog that will display whenever appropriate (e.g. during initial setup, on manual "sync now" requests, and on application exit)
* added a progress meter and status messages to the modal sync dialog to provide users with a better understanding of what's going on, and to assist in debugging
* added ability to cancel a modal sync request, including on application exit. when cancel is clicked on by the user, it will attempt to cancel the sync at the next opportunity (i.e. before the next sync engine is processed)
2008-07-09 17:17:24 -07:00
jonathandicarlo@jonathan-dicarlos-macbook-pro.local
98215f2fc8
Made bookmarkSharingManager._updateOutgoingShare tolerant of outgoing shares that are lacking a server path annotation: it will warn that they're invalid and return, rather than dying.
2008-07-09 16:57:55 -07:00
jonathandicarlo@jonathan-dicarlos-macbook-pro.local
436fb329bb
Made wrapping of outgoing shares not crash if an outgoing share is missing an exptected annotation.
2008-07-09 13:45:10 -07:00
jonathandicarlo@jonathan-dicarlos-macbook-pro.local
3cc4b5541f
Restored a line in bookmarkSharingManager.js which I took out by accident when removing debugging dumps and stuff, changeset 969. It should not have been taken out; without it you get 'mounts undefined' error.
2008-07-09 13:24:49 -07:00
jonathandicarlo@jonathan-dicarlos-macbook-pro.local
a0611ee8e1
I think I have fixed updateIncomingShare now. So everything should work, if I share with a user not myself.
2008-07-08 22:39:05 -07:00
jonathandicarlo@jonathan-dicarlos-macbook-pro.local
7f36e552e6
Removed a bunch of dump statements that were in bookmarkSharingManager for old debugging stuff that is now done; they were just cluttering up the log.
2008-07-08 15:05:24 -07:00
jonathandicarlo@jonathan-dicarlos-macbook-pro.local
cfe420f221
updateOutgoingShare now explicitly encodes data to json before encrypting and uploading.
2008-07-08 14:52:31 -07:00
jonathandicarlo@jonathan-dicarlos-macbook-pro.local
5d937affe2
Fixed a typo in sendXmppNotification call
2008-07-08 14:51:14 -07:00
jonathandicarlo@jonathan-dicarlos-macbook-pro.local
2895b903a2
Fixed another trivial bug in BookmarkSharingManager._stopSharing that was making it fail at sending out the xmpp notification.
2008-07-08 14:19:26 -07:00
jonathandicarlo@jonathan-dicarlos-macbook-pro.local
55ec19cf3c
Fixed some trivial bugs in BookmarkStore._wrapMountOutgoing that were preventing the outgoing share from working properly.
2008-07-08 14:15:55 -07:00
jonathandicarlo@jonathan-dicarlos-macbook-pro.local
2b8d2d7cb3
Factored the sending of xmpp notifications in bookmarkSharingManager out into a separate function, to save some duplicated code and make it easier to break xmpp stuff into a separate class later. Also made the bookmarkSharingManager cache the current weave username, which it uses a lot. Finally it now prepends /user/this._myUsername/ to server URLs to make them into absolute paths before sending them to the sharing partner over xmpp, which fixes a leftover TODO from a copule days ago.
2008-07-08 14:11:21 -07:00
jonathandicarlo@jonathan-dicarlos-macbook-pro.local
1cf9a1dea9
Fixed a bunch of bugs in bookmark share: stuf related to server-side paths being incorrect (because the defaultPrefix in DAV was getting reset to an empty string or was getting applied wrong). Discovered that updateOutgoingShare and updateIncomingShare were both calling the same _wrapMount() function, which was incorrect, so I broke that up and fixed what parts are meant to be outgoing and which incoming.
2008-07-08 01:18:30 -07:00
jonathandicarlo@jonathan-dicarlos-macbook-pro.local
9cfef4be35
Fixed a whole bunch of bugs in bookmark share, mostly related to adding in needed JsonFilters for remote Resources and fixing the server paths which are passed into DAV for the keyring file and encrypted share data files. (Also fixed a minor bug in DAV itself so that mkcol won't quit right away if you pass it something that starts with a slash.)
2008-07-03 17:57:21 -07:00
jonathandicarlo@jonathan-dicarlos-macbook-pro.local
f11ad3f3e3
Updated a couple of comments in bookmark sharing
2008-07-01 14:41:04 -07:00
jonathandicarlo@jonathan-dicarlos-macbook-pro.local
11dda58df6
Fixed yet another typo: this._sharing._share, not this._sharing.share.
2008-07-01 10:35:15 -07:00
jonathandicarlo@jonathan-dicarlos-macbook-pro.local
b7f7372c9f
Fixed typo where undefined value was getting passed into share and stopSharing: should be node.itemId, not node.id
2008-07-01 10:31:16 -07:00
jonathandicarlo@jonathan-dicarlos-macbook-pro.local
fd7f338963
Fixed missing import
2008-07-01 10:27:19 -07:00
jonathandicarlo@jonathan-dicarlos-macbook-pro.local
a410545ba4
Fixed another typo
2008-07-01 10:26:01 -07:00
jonathandicarlo@jonathan-dicarlos-macbook-pro.local
fcb7743ce0
Fixed typo in BookmarkSharingManager._bms initialization
2008-07-01 10:24:52 -07:00
jonathandicarlo@jonathan-dicarlos-macbook-pro.local
10d9360015
Merged
2008-07-01 10:18:43 -07:00
jonathandicarlo@jonathan-dicarlos-macbook-pro.local
ba7249a10a
Made _share() and _stopSharing() take bookmark item ID numbers instead of XUL nodes.
2008-07-01 10:18:35 -07:00
jonathandicarlo@jonathan-dicarlos-macbook-pro.local
aa859a7626
Made _stopSharing and _stopOutgoingShare more fault-tolerant (they will no longer die if the expected annotation is missing.
2008-07-01 09:58:00 -07:00
Dan Mills
802f7a254d
fix cookie command logging; skip cookie commands for items we don't have
2008-06-30 23:26:35 -07:00
jonathandicarlo@jonathan-dicarlos-macbook-pro.local
5d960d2e8f
Combined shareData and stopSharingData into one function to reuse code; made it so that if it gets called when Weave.DAV is already locked, instead of failing it sets up an observer that will trigger the share to happen as soon as the sync-succeeded or sync-failed message is received.
2008-06-30 22:30:04 -07:00
jonathandicarlo@jonathan-dicarlos-macbook-pro.local
dae06b83f1
Added test_bookmark_sharing to version control; note this doesn't pass right now (and in fact the main test is commented out.)
2008-06-30 18:50:06 -07:00
Myk Melez
3f7efe892f
bug 442711: validate virtual tabs to make sure they have the minimal information necessary to recreate them before trying to save them or notify the user about them
2008-06-30 15:13:07 -07:00
Anant Narayanan
7f8e383db6
Fix syntax errors that were causing unit tests to fail
2008-06-30 12:26:41 -07:00
Anant Narayanan
645c447eb6
Fix small bug with PasswordTracker returning scores > 100
2008-06-30 11:33:25 -07:00
Anant Narayanan
f7911b9746
Primitive password tracking support (bug 435320, r=thunder)
2008-06-30 11:19:07 -07:00
Dan Mills
cbd9cd6819
import async module
2008-06-29 17:37:11 -07:00
Dan Mills
a4ae67b71a
define _resetGUIDs in store
2008-06-29 17:36:59 -07:00
Dan Mills
091c571bd1
import async module
2008-06-29 17:36:35 -07:00
Dan Mills
293b220818
use this._lookup instead of command.data for remove commands
2008-06-29 17:36:13 -07:00
Dan Mills
3d16ec76a6
fix cooe engine's resetGUIDs method by importing async module; don't call runInBatchMode in bookmark engine's resetGUIDs, it doesn't work atm
2008-06-29 11:44:27 -07:00
Dan Mills
80417871c4
merge upstream changes
2008-06-29 07:07:11 -07:00
Dan Mills
e03543007a
make resetguids async
2008-06-29 07:00:53 -07:00
Anant Narayanan
d2a1e9e87d
Make PasswordStore process removeCommands correctly (bug 442090, r=thunder)
2008-06-28 01:13:14 -07:00
Anant Narayanan
089c1c0f42
General restructure for performance improvements (bug 441907, r=thunder)
2008-06-27 20:16:43 -07:00
jonathandicarlo@jonathan-dicarlos-macbook-pro.local
448ef4478e
Merged
2008-06-26 17:01:12 -07:00
jonathandicarlo@jonathan-dicarlos-macbook-pro.local
d654677b9a
Fixed several minor bugs with bookmark sharing
2008-06-26 17:00:55 -07:00
Anant Narayanan
62a0ebb31e
Add license headers to all files which didn't have them.
2008-06-26 14:49:01 -07:00
Dan Mills
277753d21a
tone down tab engine debugging output a bit
2008-06-26 14:34:32 -07:00
Justin Dolske
4abaf0f90c
bustage fix: call this.foo(), not foo().
2008-06-25 18:32:59 -07:00
Anant Narayanan
b53674f5dc
Handle removeCommand in FormEngine correctly. (bug 441874, r=thunder)
2008-06-25 17:09:18 -07:00
jonathandicarlo@jonathan-dicarlos-macbook-pro.local
3f37543011
Set up bookmarkEngine._incomingShareOffer to use Myk's new Notification stuff to offer a notification to the user, asking them to accept or reject the incoming share.
2008-06-25 15:54:33 -07:00
Myk Melez
b379fdece8
the tabs engine needs a constant
2008-06-25 13:51:32 -07:00
jonathandicarlo@jonathan-dicarlos-macbook-pro.local
6f37a50f99
The share/stop sharing menu item is now added only to normal bookmark folders: Not to the main bookmark menu or to magic folders like 'recently tagged' or whatever.
2008-06-25 11:58:04 -07:00
jonathandicarlo@jonathan-dicarlos-macbook-pro.local
b24d0c7180
Moved all of the bookmark-share stuff out of the bookmarkEngine class into a new BookmarksSharingManager class.
2008-06-24 21:15:14 -07:00
jonathandicarlo@jonathan-dicarlos-macbook-pro.local
bc4d891c3a
Moved the folder name and annotation for the incoming shares root folder to string constants.
2008-06-24 18:38:29 -07:00
jonathandicarlo@jonathan-dicarlos-macbook-pro.local
fcd94e31e2
Fixed all the places where I was accidentally calling it incomingShareAnno instead of incomingSharedAnno (note the missing letter d). Same for outgoingSharedAnno.
2008-06-24 18:28:01 -07:00
