Commit Graph

1242 Commits

Author SHA1 Message Date
Kyle Huey
cd23534f39 Bug 1188117: Do not allow IDBCursor.delete while cursor update is in progress. r=baku 2015-07-28 15:59:55 -07:00
Kyle Huey
da700e7070 Bug 1180978: Don't proceed with opening an invalidated database. r=janv,baku 2015-07-22 14:46:19 +08:00
Kyle Huey
ad2419041a Bug 1185836. Nuke warnings from orbit. r=me 2015-07-21 17:07:05 +08:00
Kyle Huey
05b4318f16 Bug 1185836: Fix warnings r=me.
CLOSED TREE
2015-07-21 16:52:44 +08:00
Kyle Huey
a341250c52 Bug 1185836: Replace several EnumerateRead calls with the new hashtable iterators. r=baku 2015-07-21 16:38:31 +08:00
Brian Birtles
7e340e3a68 Bug 1182981 part 3 - Use nsTHashtable::Iterator in ActorsParent; r=khuey 2015-07-21 14:46:32 +09:00
Brian Birtles
fbaccb26b4 Bug 1182981 part 4 - Use nsTHashtable::Iterator in IDBDatabase; r=njn 2015-07-21 10:48:54 +09:00
Kyle Huey
b80146459f Bug 1184410: Track whether or not the transaction has been active on the connection thread. r=janv
Because StartTransactionOp is a TransactionDatabaseOperationBase, it is possible for it to never run DoDatabaseWork, if the transaction is invalidated before StartTransactionOp runs. In the case of a readwrite transaction, we'll never BeginWriteTransaction() on the connection.

CommitOp, on the other hand, is a DatabaseOperationBase. It doesn't check IsInvalidatedOnAnyThread before running, so it will try to commit the transaction and the assertions will fire because we never called BeginWriteTransaction.

Reworking the inheritance here, if possible, would be hard. Keeping track of the active state on both the background and connection threads is easy though, and we do this sort of thing all over dom/workers. So do that.

This should resolve several intermittent oranges where MOZ_ASSERT(!mInReadTransaction) fires upon committing a transaction.

CLOSED TREE
2015-07-16 10:34:49 -07:00
Ben Turner
f212e2188f Bug 1179025 - Protect against using cursors on a deleted objectStore/index, r=janv. 2015-07-02 10:47:53 -07:00
Birunthan Mohanathas
47ed3a3675 Bug 1182996 - Fix and add missing namespace comments. rs=ehsan
The bulk of this commit was generated by running:

  run-clang-tidy.py \
    -checks='-*,llvm-namespace-comment' \
    -header-filter=^/.../mozilla-central/.* \
    -fix
2015-07-13 08:25:42 -07:00
Ryan VanderMeulen
84d0af8b83 Backed out changeset d29782c360fe (bug 1180978) for causing indexedDB assertions.
CLOSED TREE
2015-07-10 12:35:15 -04:00
Kyle Huey
a0f305c94f Bug 1180978: Don't proceed with opening an invalidated database. r=janv,baku 2015-07-10 07:38:53 -07:00
Birunthan Mohanathas
924358c88c Bug 1168606 - Part 2: Convert DelayedDeleteRunnable into reusable DelayedActionRunnable class. r=bent 2015-06-09 07:57:19 -07:00
Birunthan Mohanathas
99f0338ef2 Bug 1168606 - Part 1: Extract Cursor response data population into shared function. r=bent 2015-07-07 11:27:04 -07:00
Emanuel Hoogeveen
e1b03075a7 Bug 905127 - Part 1 - Make some functions from nsNetUtil not inline. r=jduell 2015-07-07 04:17:00 +02:00
Ryan VanderMeulen
fe416570a0 Backed out changeset d6063656f171 (bug 1179025) for Werror bustage.
CLOSED TREE
2015-07-06 14:00:58 -04:00
Ben Turner
567c09a6b6 Bug 1179025 - Protect against using cursors on a deleted objectStore/index, r=janv. 2015-07-02 10:47:53 -07:00
Juan Gomez
01df2f691b Bug 1171931 - Refactor duplicated code using XRE_IsParent/ContentProcess. r=froydnj 2015-07-03 18:29:00 -07:00
Jonathan Watt
3c63e694ee Bug 1177688, part 6 - Follow-up to provide a default BlobDirState::eUnknownIfDir arg to BlobImplBase's ctor to avoid excessively specifying the same argument. r=baku 2015-06-23 00:31:40 +01:00
Jonathan Watt
be327740ee Bug 1177688, part 1 - Add API and functionality to the BlobImpl classes so that BlobImpl's that are created from an nsIFile can provide information about whether or not the nsIFile was a directory. r=baku 2015-06-23 00:31:28 +01:00
Martin Thomson
c1cec6411f Bug 1176434 - Enabling indexedDB for content JS sandboxes, r=bent 2015-07-02 13:30:15 -07:00
Ryan VanderMeulen
40909c8563 Backed out changeset c725221a7c45 (bug 1179025) for Werror bustage.
CLOSED TREE
2015-07-02 14:22:28 -04:00
Ben Turner
cd616a463c Bug 1179025 - Protect against using cursors on a deleted objectStore/index, r=janv. 2015-07-02 10:47:53 -07:00
Boris Zbarsky
2221234a15 Bug 1178806. IndexedDB autoincrement overflow should be throwing ConstraintError per spec. r=bent 2015-07-01 00:15:30 -04:00
Boris Zbarsky
059e75af55 Bug 1178803. Fix the handling of the 'length' key in IDB keypaths when operating on a string. r=bent 2015-07-01 00:15:30 -04:00
Jan de Mooij
708e28e6b7 Bug 1177892 part 3 - Remove OBJECT_TO_JSVAL. r=evilpie 2015-06-30 21:09:46 -07:00
Daniel Holbert
d264043149 Bug 1130775 followup: Add 'override' keyword to macro-provided AddRef/Release methods for QuotaClient::GetDirectoryLockListener. rs=ehsan 2015-06-30 10:06:24 -07:00
Jan Varga
138aed340f Bug 1170021 - Part 2: Move DirectoryLock out of QuotaManager class; r=bent 2015-06-30 14:59:53 +02:00
Jan Varga
1585104454 Bug 1130775 - Convert synchronized ops and storage registration into unified directory locks; r=bent 2015-06-30 14:59:27 +02:00
Ryan VanderMeulen
e6131fc8b8 Backed out changeset 8b4e4083639e (bug 1171931) for B2G debug emulator bustage. 2015-06-25 19:48:42 -04:00
Ben Turner
d7fb6b8331 Bug 1147942 - Don't warn when aborting finished IndexedDB transactions, r=janv. 2015-06-25 15:22:59 -07:00
Juan Gomez
2128198065 Bug 1171931 - Refactor duplicated code using XRE_IsParent/ContentProcess. r=froydnj 2015-06-24 14:11:00 -04:00
Ben Turner
081a9e4d1f Bug 1171578 - Avoid crashing if indexedDB is used at a particular point in the worker shutdown sequence, r=baku. 2015-06-22 12:13:38 -07:00
Ben Turner
f9c550b203 Bug 1176165 - Fix the exception codes returned from functions that modify the IndexedDB schema, r=janv. 2015-06-20 09:09:27 -07:00
Ben Turner
126ca3014a Bug 1149815 - Properly handle IDBDatabase.close() called during a versionchange transaction, r=janv. 2015-06-20 09:08:30 -07:00
Ben Turner
ca8933b7dc Bug 1149815 - Don't assume that index creation always succeeds, r=janv. 2015-06-20 09:08:26 -07:00
Ben Turner
be1e03fc98 Bug 1149815 - Guard against using deleted IDBObjectStore and IDBIndex objects, r=janv. 2015-06-20 09:08:23 -07:00
Jan Varga
59af1911ea Bug 1142694 - QuotaManager default/temporary initialization fails on some profiles; r=bent 2015-06-16 06:42:06 +02:00
Jonathan Watt
da1cf1ef55 Bug 1173314 - Make GetMozFullPath and GetMozFullPathInternal const. r=sicking 2015-06-03 01:11:16 +01:00
Jan Varga
5a44475cd5 Bug 1174113 - QuotaManager: Origin initialization fails on moz-safe-about+++home; r=bent 2015-06-12 12:00:53 +02:00
Jan Varga
117b9c1c24 Bug 1161063; r=bent 2015-06-11 22:34:30 +02:00
Fernando Jimenez
fd45d8da7c Bug 1137245 - ServiceWorkerManager should set WorkerPrivate::LoadInfo::mIndexedDBAllowed correctly. r=bent, bkelly 2015-06-11 15:32:54 +02:00
Jan Varga
8975fe6bad Bug 1170746 - Getting mutable files over a cursor crashes the browser; r=bent 2015-06-11 11:49:51 +02:00
Wes Kocher
560c01080f Backed out changeset c4db01ea9e6c (bug 1170746) for test_filehandle_getFile.html orange 2015-06-10 15:08:41 -07:00
Jan Varga
e9f7834cd4 Bug 1170746 - Getting mutable files over a cursor crashes the browser; r=bent 2015-06-10 22:48:06 +02:00
Birunthan Mohanathas
c84827bad2 Bug 968520 - Add mozilla::fallible to FallibleTArray::InsertElementSorted calls. r=froydnj 2015-06-08 13:40:00 -07:00
Ben Turner
5c7efc9f6c Bug 1168166 - Ignore failed IndexedDB optimization if disk is too full, r=janv. 2015-06-08 11:11:18 -07:00
Eric Rahm
9100016c49 Bug 1165515 - Part 13-2: Replace usage of PRLogModuleLevel and PR_LOG_*. rs=froydnj
This is straightforward mapping of PR_LOG levels to their LogLevel
counterparts:
  PR_LOG_ERROR   -> LogLevel::Error
  PR_LOG_WARNING -> LogLevel::Warning
  PR_LOG_WARN    -> LogLevel::Warning
  PR_LOG_INFO    -> LogLevel::Info
  PR_LOG_DEBUG   -> LogLevel::Debug
  PR_LOG_NOTICE  -> LogLevel::Debug
  PR_LOG_VERBOSE -> LogLevel::Verbose

Instances of PRLogModuleLevel were mapped to a fully qualified
mozilla::LogLevel, instances of PR_LOG levels in #defines were mapped to a
fully qualified mozilla::LogLevel::* level, and all other instances were
mapped to us a shorter format of LogLevel::*.

Bustage for usage of the non-fully qualified LogLevel were fixed by adding
|using mozilla::LogLevel;| where appropriate.
2015-06-03 15:25:57 -07:00
Eric Rahm
6d13987359 Bug 1165515 - Part 3: Convert PR_LOG_TEST to MOZ_LOG_TEST. r=froydnj 2015-06-03 15:22:28 -07:00
Carsten "Tomcat" Book
9432818a46 Backed out 14 changesets (bug 1165515) for linux x64 e10s m2 test failures
Backed out changeset d68dcf2ef372 (bug 1165515)
Backed out changeset 7c3b45a47811 (bug 1165515)
Backed out changeset b668b617bef2 (bug 1165515)
Backed out changeset d0916e1283a2 (bug 1165515)
Backed out changeset ac4dc7489942 (bug 1165515)
Backed out changeset e9632ce8bc65 (bug 1165515)
Backed out changeset c16d215cc7e4 (bug 1165515)
Backed out changeset e4d474f3c51a (bug 1165515)
Backed out changeset d87680bf9f7c (bug 1165515)
Backed out changeset b3c0a45ba99e (bug 1165515)
Backed out changeset 9370fa197674 (bug 1165515)
Backed out changeset 50970d668ca1 (bug 1165515)
Backed out changeset ffa4eb6d24b9 (bug 1165515)
Backed out changeset 5fcf1203cc1d (bug 1165515)
2015-06-02 13:05:56 +02:00