Edward Lee
1ce05d4603
Bug 549633 - Standardize record creation so all SyncEngines encrypt data [r=mconnor]
...
Always add the id and encryption value so client and delete records can be encrypted.
2010-03-05 14:46:48 -08:00
Edward Lee
a9c2e6c4c2
Bug 549632 - Remove storage cache, which is mostly un/incorrectly used [r=mconnor]
...
Remove incorrectly used cache from some engines and clean up references from SyncEngine.
2010-03-05 14:43:11 -08:00
Edward Lee
da13b169a2
Revert svc/svc == null change from 87f9860d8e5a.
2010-03-02 11:22:20 -08:00
Paul O’Shannessy
137de41059
Refactor fake services so it's easier to add more [r=Mardak]
...
Created a FakeSvc object to put fake services into.
2010-03-02 11:07:30 -08:00
Paul O’Shannessy
b7bcf45891
Bug 548910 - Don't sync file:// urls [r=mconnor]
...
Added file.* to the filter.
2010-02-26 13:52:37 -08:00
Paul O’Shannessy
b5463708b7
Bug 547827 - JavaScript strict warning: modules/util.js, line 617: reference to undefined property thisObj[name] [r=Mardak]
...
Check that name is a property of thisObj before trying to access it.
2010-02-23 13:10:32 -08:00
Paul O’Shannessy
f39831ac01
Bug 546397 - Exception: Clients.getClients()[Clients.clientID] is undefined [r=Mardak]
...
Overrode _wipeClient in ClientEngine; treat resetting the same as wiping.
2010-02-19 13:36:42 -08:00
Paul O’Shannessy
6ab312f3e7
Bug 546807 - Tabs from other computers: "Restore Session" [r=Mardak]
...
Filter out all about:* urls vefore syncing, including the specific case here: about:sessionrestore.
2010-02-19 11:32:20 -08:00
Paul O’Shannessy
d367359168
Bug 545756 - Get rid of quit-application observer [r=Mardak]
...
Stop observing 'quit-application', remove handling from observe, and remove WeaveSvc.isQuitting
--HG--
extra : rebase_source : e52fab892127d4ddd9a7312e74202cc3e09b2c8c
2010-02-12 12:04:06 -08:00
Edward Lee
3273de6ac1
Bug 545785 - Actively remove passwords that we don't want to sync
...
Check if we haven't deleted yet, and if not, grab the guids for weave credentials and delete them from the server.
2010-02-11 17:14:57 -08:00
Edward Lee
1ad29052b7
Bug 545767 - Clean up various names/strings needed for each set of engines/stores/trackers
...
Pass the engine name when constructing a subclass engine and construct the store/tracker with the same name.
2010-02-11 15:29:15 -08:00
Edward Lee
b8de893593
Bug 545764 - Convert constructor -> _init pattern to just use constructor
...
Inline various _init calls and do super's init with <Super>.call(this, args..). Add various get/set sugar to those missing e.g., meta.keyring. Also simplify crypto record creation by setting cleartext in the parent.
--HG--
extra : rebase_source : 6c9a9f210f8f46ac338adb84188538e7353c9673
2010-02-11 15:25:31 -08:00
Paul O’Shannessy
a3f801887c
Bug 545487 - Cleanup TabTracker_observe [r=Mardak]
...
Remove the "load" event listener and don't QI since we don't need to.
2010-02-11 15:08:28 -08:00
Edward Lee
e238de1fc6
Bug 545701 - explicitly exclude Weave password/passphrase from pw sync
...
Don't include weave passwords when getting all ids and ignore their changes.
2010-02-11 15:05:22 -08:00
Edward Lee
6f05b94887
Bug 533207 - wyciwyg:// URLs should not be synced as-is
...
Filter out tabs that start with wyciwyg:.
2010-02-11 14:28:35 -08:00
Edward Lee
ed5e098629
Bug 544068 - Assume moved bookmarks should be where they're moved
...
Don't keep the annotation around in-case the predecessor/parent finally syncs because the user positioned it otherwise.
2010-02-03 15:34:42 -08:00
Edward Lee
2a92715bee
Bug 541722 - updating out of date machine can cause data to be reverted
...
Don't have each engine reset their last sync but still have the service clear out its cached data (keys, records).
2010-02-03 15:23:58 -08:00
Edward Lee
a371ae83ae
Reverse thresholds to make more sense for single vs multi.
2010-01-26 12:08:41 -08:00
Edward Lee
91b160ab92
Bug 541766 - Logging in with email address kinda works but not
...
Detect finding cluster failure due to invalid username and treat like failed login.
2010-01-25 10:30:31 -08:00
Edward Lee
39e968e8de
Bug 531489 - weave lost bookmarks with same url
...
Do dupe detection for bookmarks like how we do folders/separators but check against the url/title. Add parentName to bookmark records, so bump version.
2010-01-25 09:33:49 -08:00
Edward Lee
4cbaa75427
Lower tab logging to trace when wrapping tabs.
2010-01-21 09:59:27 -08:00
Edward Lee
8dfdbe920a
Bug 526937 - Bookmarks are re-uploaded when they get visited
...
Don't mark item as changed on a favicon notification to avoid churn that can result in merge messing up bookmark ordering.
2010-01-19 11:24:00 -08:00
Mike Connor
d8ffe9498d
Bug 524221 - Weave's current auto-login behavior is super-annoying if you have a master password. r=Mardak
...
Only autoconnect if the master password has already been entered and autoretry later if not.
2010-01-07 16:13:44 -08:00
Edward Lee
e8ccb18a12
Bug 536595 - Sync fewer items per data type on mobile
...
Just sync a flat 50 instead of .1 of 1500 to avoid increasing slowdown when processing many items.
2010-01-06 10:00:05 -08:00
Edward Lee
def7a2495e
Bug 536594 - Warn on record creation failure but continue the sync
...
Wrap createRecord and encrypt incase an engine fails to create one or more of the records similar to how process incoming records are wrapped.
2010-01-06 09:59:05 -08:00
Edward Lee
c53310f982
Bug 536596 - Don't force garbage collections on every record processed
...
Remove the forceGC at the end of each onProgress from Collections and let normal actions trigger GC.
2010-01-06 09:57:05 -08:00
Edward Lee
48b1cf979f
Bug 537954 - Some tabs don't get synced
...
Listen for load before adding the unload listener (and the Tab listeners).
2010-01-06 09:54:15 -08:00
Edward Lee
934cd0c6ea
Bug 536457 - Include the version when pinging
...
Append a v=<version> to include the version and make it easier to add things in the future.
2009-12-22 13:46:34 -08:00
Edward Lee
3f5007dd67
Bug 535670 - Poor UX on password change while connected
...
Detect if there was a login failure when opening the prefs and re-use the first-sign-in flow and feedback instead of using the change pwd/pph dialog.
2009-12-18 16:22:59 -08:00
Edward Lee
fdaee13190
Bug 535722 - Reduce the amount of logging for default log levels
...
Include the URI on success/fail requests and only trace log the onStartRequest. Switch various debug messages to trace and remove importing Log4Moz in fx-weave-overlay and generic-change. Drop the rootLogger to Debug to not log trace messages from unpreffed loggers.
2009-12-17 18:51:55 -08:00
Edward Lee
6247e3cccf
Bug 534459 - Can't reset password
...
Update the preference to point to the new password reset page on auth.smc, and for now, just open it per mconnor's suggestion.
2009-12-17 18:40:29 -08:00
Edward Lee
d3218dee1f
Bug 535479 - Be smarter in getting rid of the "remote tabs" notification
...
Add a tri-state pref that is unset, 0, or a number (modified time in seconds) and don't show the notification if it's in the "0" state. Unset pref means no modified time has been saved, and a non-0 state is the modified time of the last synced tab. So when tabs arrive with a different modified time, switch to the 0 state. Additionally, still remember if the user ever dismissed the notification and never show it again.
2009-12-17 12:20:07 -08:00
Mike Connor
fa35c938a6
bug 535562 - fix typo failure
2009-12-17 10:34:36 -05:00
Edward Lee
16a6c51fc6
Bug 535477 - Always sync tabs but inform Fennec users that recent tabs need syncing
...
Remove special casing of tabs prefs and remove tabs.backup to simplify the UI logic. Also remove dynamically enabling/disabling based on number of clients. For Fennec, show a notification about recent tabs need syncing.
2009-12-16 19:15:18 -08:00
Edward Lee
81644b3217
Bug 535476 - Ping the server once a day to help count active daily clients
...
Fetch info/collections? with an extra "?" once a day on a normal sync so that it gets the same data but is easily differentiated in access logs.
2009-12-16 19:08:36 -08:00
Edward Lee
ca77bf9f03
Add pref for prefs logger and remove lightweight persisted prefs as those will be generated.
2009-12-15 14:51:16 -08:00
Edward Lee
33626cced1
Bug 532175 - Send event when Weave is ready to register new engines
...
Notify with "weave:service:ready" so observers can lazily load and wait to add engines, Weave UI.
2009-12-15 14:21:13 -08:00
Edward Lee
1213f59b7e
Bug 534923 - Only show Mobile Bookmarks if there are mobile bookmarks
...
Fix up existing users as well as only creating the place query under AllBookmarks if there are mobile bookmarks.
2009-12-15 14:21:13 -08:00
Edward Lee
cee1a6e884
Bug 534944 - Avoid loading/importing weave files until necessary to speed up fennec startup
...
Have importing service.js trigger startup instead of only starting up from Weave.js, which now is used as a backup kickstarter. Only call import(service.js) when necessary from various Fennec files.
2009-12-15 14:21:12 -08:00
Edward Lee
baf9c41432
Bug 534687 - Weave's pref syncing can sync lightweight themes in a broken fashion
...
Trigger lightweight theme manager's currentTheme setter when changing the usedThemes pref.
2009-12-14 16:05:07 -08:00
Edward Lee
4bdfeb9b77
Remove engines from failing load tests now that engines are gone.
2009-12-11 11:32:23 -08:00
Edward Lee
c77f5b2807
Have wipeRemote wipe just the engines' data and make sure the clients process the command.
2009-12-10 18:39:51 -08:00
Edward Lee
950b52b559
Bug 533475 - Improve language for Fennec tab sync page
...
Detect if tabs sync is pending or if tabs are all open or there's no tab data to show the appropriate message.
2009-12-10 18:37:30 -08:00
Edward Lee
a48b0da141
Bug 532936 - Add root level node for bookmarks synced from Fennec
...
Create a mobile root in Firefox and link it to the Library UI as a query that fixes its own title if changed. Mark the mobile root on Firefox/Fennec as special so Weave uses "mobile" for the guid in the record, and items will appear in the appropriate folder.
--HG--
extra : rebase_source : fbd3afa2647204a370f7dacdf9d824e462ebb9b9
2009-12-10 16:12:14 -08:00
Mike Connor
6d3bbf8523
bug 533759 - delay real startup for 10 seconds on Fennec to get away from startup
2009-12-10 12:20:16 -08:00
Mike Connor
67b481e440
bug 533573 - use aria attributes to make the radiobuttons accessible
2009-12-09 15:23:48 -08:00
Mike Connor
37eb805bd1
bug 526078 - add accesskeys throughout the prefpane and wizard
2009-12-08 17:51:00 -08:00
Mike Connor
c12a983183
Bug 533580 - strip busted tbird support
2009-12-08 16:09:26 -08:00
Edward Lee
6f16e5f19c
Bug 532770 - Allow tab sync's filtered urls to be set by pref
...
Expose engine.tabs.filteredUrls as a string to be used as regex and filter case insensitively.
2009-12-03 14:54:23 -08:00
Mike Connor
5e69a1396b
bug 526078 - fix up some wording
...
--HG--
extra : rebase_source : dc6c4ee2acdbcff567dd185cb528636dbcc1702c
2009-12-03 17:24:41 -05:00
Mike Connor
ccf44215ac
bug 530824 - close window and start syncing much sooner when setting up second machine
...
--HG--
extra : rebase_source : 10919d9957e323e0f12f5ca1b67e5fe9f8294288
2009-12-03 15:03:39 -05:00
Edward Lee
88aab17b7b
Bug 532722 - Use AddonOptionsLoad event to update Weave options
...
Make the weave add-on guid available as a constant and watch for AddonOptionsLoad with the matching addonID.
2009-12-03 12:14:56 -08:00
Mike Connor
2008fc3a0d
bug 530813 - better explanation of Sync and some iterations on bug 530824, just close the prefwindow on wizard finish
...
--HG--
extra : rebase_source : b9385c93b85f7707c839a4978102d243616ec27e
2009-12-03 01:52:17 -05:00
Edward Lee
4676b9cb18
Bug 488922 - Treat bookmarks restore specially
...
Add observers for bookmarks-restore-* and ignore changes during import and trigger a fresh start on success.
2009-12-02 19:20:44 -08:00
Edward Lee
c52dbbee72
Bug 532449 - Tabs don't sync until 4 syncs have happened
...
Always update the lastModified time to avoid tabs only sometimes getting updated.
2009-12-02 19:03:27 -08:00
Edward Lee
0da867fd27
Bug 532570 - "keyring doesn't contain a key" when signing-in with a differently-cased username
...
Make sure username is always lowercase so that pubkey uri, storage uri, etc. are all the same no matter how the user logged in. Server needs to be wiped to make sure existing keys with other casing are removed.
2009-12-02 18:25:18 -08:00
Edward Lee
835dcd80cf
Bug 531005 - Sync is not working after update IWeaveCrypto.unwrapSymmetricKey NS_ERROR_FAILURE
...
Avoid concurrent key generation by updating meta/global immediately after resetting the client and have wipeServer not delete the meta collection. Also on detecting a syncid mismatch, sleep to allow remote keypair to be uploaded, and don't force a mismatch on upgrade.
2009-12-02 17:57:13 -08:00
Edward Lee
86d2294e4d
Bug 531005 - Sync is not working after update IWeaveCrypto.unwrapSymmetricKey NS_ERROR_FAILURE
...
Check that the cryptometa is unwrappable when syncing; if not purge the key and data and make a new crypto record.
2009-12-02 17:25:14 -08:00
Edward Lee
bef67b3db3
Bug 532173 - Don't sync tabs of some pages (weave firstrun, about:blank)
...
Ignore certain filtered urls when creating a list of tabs for remote machines.
2009-12-02 14:46:02 -08:00
Edward Lee
08eca0017c
Bug 530717 - sync after wipe local should always replace local values with remote
...
Always take the incoming item after a wipe and otherwise do the normal reconcile.
2009-12-02 14:44:52 -08:00
Edward Lee
c5bc7653dd
Bug 531239 - clear out duplicate/old machines from Clients record
...
Get rid of persistent storage for clients and tabs to always fetch fresh records.
2009-12-02 14:44:17 -08:00
Mike Connor
be7bc3506f
bug 530820 - add confirmation, error feedback, and attempt to provide some clarity that the user can't recover pp
2009-12-02 11:30:16 -05:00
Mike Connor
1d722a7043
bug 531205 - show bookmarks/history/passwords for local and remote devices for remote when wiping
2009-12-01 15:39:43 -05:00
Igor Velkov
f0ff5ea6b0
Bug 526521 - Can't open preferences in SeaMonkey 2.0.1pre. r=Mardak
...
Reorganize fx-prefs to overlay itself so seamonkey can reference the same id and add Tabs sync.
2009-12-01 11:49:23 -08:00
Edward Lee
a46e202447
Share tab-gathering code for both createRecord and locallyOpenTabMatches.
2009-12-01 11:36:56 -08:00
Edward Lee
78b1fdad91
Provide a fake service for platforms that don't have the service like Private Browsing (for Fennec/Seamonkey).
2009-11-30 14:36:03 -08:00
Edward Lee
74e2b05d84
Bug 531943 - Sync scheduled by global threshold during private browsing
...
Use checkSyncStatus instead of directly calling syncOnIdle or scheduleNextSync so that we only schedule if we're okay to sync.
2009-11-30 14:03:59 -08:00
Edward Lee
8b1c00090a
Bug 530863 - Global threshold update causes multiple syncs to fire
...
Make sure we only add one idle observer by keeping a flag.
2009-11-30 13:35:20 -08:00
Edward Lee
eb87765d7b
Bug 530823 - Engines need to be able to specify a prefName for sharing prefs (different history types)
...
Use prefName for checking if an engine is enabled and have forms share a prefName with history.
2009-11-30 12:15:18 -08:00
Edward Lee
d851be860d
Remove unused SnapshotStore. (Bug 524916)
2009-11-25 17:59:26 -08:00
Edward Lee
d4295ef8e9
Remove unused prefs and imports. (Bug 524916)
...
--HG--
extra : rebase_source : 074e542f63ee840b61db7fe63a6c3540c13a31a5
2009-11-25 17:49:15 -08:00
Mike Connor
7e923534c2
archive local bookmarks before wiping
...
--HG--
extra : rebase_source : dd54af2118cf60c9e4f4b3bf08b7a5c61e9e78b8
2009-11-25 17:09:32 -08:00
Mike Connor
86380e1e7c
bug 530832 - make Merge more prominent, and clearly the recommended choice, with crisper wording
...
--HG--
extra : rebase_source : 68fdf9035bf3354a99c93b5050eb4af58c54a072
2009-11-25 17:08:51 -08:00
Edward Lee
7820fd7df1
Bug 530904 - tabs list style doesn't match fennec lists
...
Make headers larger, adjust text margins, add nokia sans font family.
2009-11-25 16:59:02 -08:00
Edward Lee
2fdb62dc1e
Bug 530926 - remove "Weave /" from tab list page title
2009-11-25 15:25:55 -08:00
Edward Lee
df947df75e
Bug 531177 - Tabs don't sync from firefox (when there's lots of tabs)
...
Simplify tab record to just use deferGetSet like the other records and sort tabs based on their last usage to pick out a subset.
2009-11-25 15:22:45 -08:00
Edward Lee
dd2f688ee2
Bug 531171 - Tabs don't always update
...
Only expose that the tab engine knows about the current client's tabs, so always create/apply incoming and only create records tabs for local.
2009-11-25 15:17:39 -08:00
Edward Lee
877e53a9da
Bug 531170 - Tabs don't sync from fennec
...
Add listeners for Fennec tab events the same way we do it for Firefox and share listener logic for various event types.
--HG--
extra : rebase_source : 685e45c16052db3d285c25c68db47680b7d15f72
2009-11-25 15:14:56 -08:00
Mike Connor
12dbb0ded4
bug 530822 - make label more explicit, simplify branding
...
--HG--
extra : rebase_source : 9a6950423fa7999db0640562471cf41a60b3fd44
2009-11-24 18:55:59 -08:00
Mike Connor
02d4b443f4
bug 528483 - fix prefpane to use the backup pref when numClients = 1
...
--HG--
extra : rebase_source : ae74e04326f09cf8237dc7c82fe10ae7c4aa10ac
2009-11-24 17:54:06 -08:00
Mike Connor
1ebdd8a56d
bug 527517 - replace Connected As with Current User to remove ambiguity
...
--HG--
extra : rebase_source : 0c5f37c23490120048d8e7cc408667b00ab644a9
2009-11-24 16:02:56 -08:00
Mike Connor
f4d942624f
bug 527504 - overlay macBrowserOverlay so menu works on all windows that include
...
--HG--
extra : rebase_source : 1c95c891e89557f87539a66b678e3b54d659ce39
2009-11-24 15:50:51 -08:00
Edward Lee
b4233752d2
Bug 524916 - remove any/all code/images/strings that we aren't using anymore
...
Remove unused sync engines (cookies, extensions, input, microformats, plugins, themes).
2009-11-24 16:02:55 -08:00
Edward Lee
b4be46694e
Bug 515593 - audit set of prefs we're syncing
...
Add in prefs that are linked to the Firefox Preferences UI.
2009-11-24 14:53:59 -08:00
Edward Lee
c05e0c5f94
Remove trailing whitespace from the codebase.
2009-11-20 14:34:20 -08:00
Edward Lee
d032f1effe
Bug 527790 - Allow client names to be different from the default "Firefox"
...
Generate a client name based on the logged in username, appname, hostname, and profile name.
2009-11-19 23:31:04 -08:00
Edward Lee
c9efc4abfe
Bug 514545 - weave mangles bookmarks
...
For both folders and separators, use the parent name (not guid) in addition to the item's title/position to determine if it's a dupe. This modifies the bookmark format for folders and separators, so a storage version bump is needed.
2009-11-19 21:34:17 -08:00
Edward Lee
ca40cd161d
Bug 528543 - Set default extensions.weave.client.name so it shows up in about:config
...
Just default to "Firefox" as both desktop and mobile are branded "Firefox".
2009-11-19 15:34:29 -08:00
Edward Lee
8dc5ba767c
Bug 527786 - Help users recover/remember the secret phrase
...
Show some help text if the passphrase is incorrect as well as showing the reset secret link on failure.
2009-11-19 13:59:11 -08:00
Edward Lee
276ae4f932
Bug 516098 - Weave sync fails without any obvious reason, when I've upgraded one machine but not another
...
Detect if sync failed because it's out of date and show a warning notification with a button to open the add-on manager's extension view.
2009-11-18 16:59:34 -08:00
Edward Lee
0342adbfbc
Bug 528539 - Start over should warn about incorrect username/password before prompting for secret phrase
...
Show Connecting... when signin in on page 0 and Verifying... when checking the passphrase on page 1.
2009-11-18 14:42:13 -08:00
Edward Lee
19934febcc
Bug 507666 - Handle deleting places history
...
Use onBeforeDeleteURI to get the page's GUID and upload the delete record and process it by removing the page.
2009-11-18 11:47:25 -08:00
Edward Lee
ac2b6c824d
Bug 529103 - Removing folders must use removeItem not removeFolder
...
Switch to Svc.Bookmark.removeItem from this._bms.removeFolder.
2009-11-18 10:24:09 -08:00
Edward Lee
bf1a8ee4ec
Add missing fennec-tabs.dtd for bug 529104.
2009-11-18 10:21:20 -08:00
Edward Lee
b9f1c4dc0e
Bug 525786 - Weave's log has a record of private browsing start/stop times
...
Switch some messages like private browsing, network change to trace and make the default service.main level Debug instead of Trace.
2009-11-16 17:11:10 -08:00
Mike Connor
823840eb81
bug 528541 - enforce length and uniqueness, tweak description to be clearer/less wordy
2009-11-14 13:40:39 -05:00
Anant Narayanan
fc0bdbe851
Sync Personas by defaul for Firefox 3.6 (bug #527729 )
2009-11-13 18:00:42 +01:00
Edward Lee
cc9e18c9bf
Comment out some trace logging in service.main for now (they always appear).
2009-11-12 19:25:43 -08:00
Edward Lee
6f813c7ec8
Bug 528356 - Bump storageAPI version to 1.0
2009-11-12 16:35:56 -08:00
Edward Lee
8bcc3584b3
Bug 526942 - Try to sync tabs when viewing remote tabs
...
Try fetching tabs when loading the remote tabs view and if the sync got new tabs, reload the page.
2009-11-12 15:18:43 -08:00