Commit Graph

111 Commits

Author SHA1 Message Date
Scott Johnson
fe9e70e605 Bug 730559: Limit the number of columns during layout of column sets to prevent hang. [r=mats]
In nsRuleNode, when we parse a number of columns from a CSS style sheet, we enforce
a rule that the number of columns cannot exceed 1000. This patch simply enforces
the same rule when we decide that the column count will be generated based on
the available width (e.g. the column-count property has a value of 'auto').
2013-05-31 10:51:43 -05:00
Scott Johnson
2995ec3fd9 Bug 857324: Make column set reflow continue without balancing rather than restarting if computed height is exceeded. [r=mats] 2013-04-24 10:02:36 -05:00
Ryan VanderMeulen
3ca8177657 Backed out changeset f31e6ad99dfe (bug 857324) for Android reftest-3 failures.
CLOSED TREE
2013-04-23 21:10:48 -04:00
Scott Johnson
eabfc6a062 Bug 857324: Make column set reflow continue without balancing rather than restarting if computed height is exceeded. [r=mats] 2013-04-23 15:46:08 -05:00
Scott Johnson
3879b1bba6 Bug 861182: Pull knownFeasibleHeight and knownInfeasibleHeight into ReflowConfig so they can be used outside of nsColumnSetFrame::Reflow(). [r=roc] 2013-04-16 07:52:51 -05:00
Scott Johnson
e031980f73 Bug 861181: Separate interface from implementation for nsColumnSetFrame. [r=roc] 2013-04-16 07:52:49 -05:00
Scott Johnson
b303b4dcb2 Bug 600100, Part 2: Force a vertical resize even if our available height hasn't changed in anonymous blocks of a column set so we don't crash. [r=mats] 2013-04-08 13:38:33 -05:00
Mats Palmgren
7fa166a5f5 Bug 729519 - Allocate heap nsFrameLists from the shell arena. r=bzbarsky
"new nsFrameList()" becomes "new (shell) nsFrameList()".
"delete list" becomes "if (list) list->Delete(shell)" - note also that
an additional assertion was added that list is empty when deleted.

"nsAutoPtr<nsFrameList> list(StealSomeFrames())" becomes
"AutoFrameListPtr list(aPresContext, StealSomeFrames())"
2013-04-01 17:26:02 +02:00
Scott Johnson
ff3ba1992e Bug 600100, Part 1: Return a status of NS_FRAME_NOT_COMPLETE during reflow of nsBlockFrame if we have a next continuation with pushed floats to prevent crashing in columns. [r=dbaron] 2013-03-19 09:05:05 -05:00
Scott Johnson
a6c26d7c4b Backed out changeset 3b18c328b316 (bug 600100) to fix commit message DONTBUILD. 2013-03-19 09:43:27 -05:00
Scott Johnson
7cb809091c Bug 600100, Part 1: Return a status of NS_FRAME_NOT_COMPLETE during reflow of nsBlockFrame if we have a next continuation with pushed floats to prevent crashing in columns. 2013-03-19 09:05:05 -05:00
Scott Johnson
b068d15168 Bug 846575: Clean up nsColumnSetFrame by adding an isBalancing convenience member to ReflowConfig. [r=fantasai] 2013-03-08 09:43:46 -06:00
Scott Johnson
e73d17f2cb Bug 810726: Simplify logic for handling too many columns to prevent crash. [r=roc] 2013-03-06 08:20:24 -06:00
Scott Johnson
98e927363b Backout ddb4df63c258 on a CLOSED TREE due to ARM v6 bustage. 2013-03-04 16:50:40 -06:00
Scott Johnson
4090852fe0 Bug 810726: Simplify logic for handling too many columns to prevent crash. [r=roc] 2013-03-04 14:15:18 -06:00
Scott Johnson
73cf89a288 Bug 724978: Make nsColumnSetFrame handle absolutely positioned children without crashing. [p=ehsan, r=fantasai] 2013-02-28 19:56:48 -08:00
L. David Baron
5ef4421fa5 Bug 781360 patch 3: Rename {nsIFrame,nsStyleContext,nsComputedDOMStyle}::GetStyle* to Style*, since they can never return null. r=dholbert
Except for the changes in:
  layout/generic/nsIFrame.h (part)
  layout/style/nsComputedDOMStyle.h (all)
  layout/style/nsRuleNode.cpp (part)
  layout/style/nsStyleContext.cpp (part)
  layout/style/nsStyleContext.h (part)
(see patch 3b in the bug), this patch was written with the sed script:
s/\<GetStyle\(Font\|Color\|List\|Text\|Visibility\|Quotes\|UserInterface\|TableBorder\|SVG\|Background\|Position\|TextReset\|Display\|Content\|UIReset\|Table\|Margin\|Padding\|Border\|Outline\|XUL\|SVGReset\|Column\)\>/Style\1/g
2013-02-16 13:51:02 -08:00
Robert O'Callahan
013943dc4f Bug 840902. Part 2: Remove nsresults from various display list methods. r=mattwoodrow
--HG--
extra : rebase_source : de498510bf8d85d9b0b2fab0137ef3be01c9adfa
2013-02-15 00:12:27 +13:00
Robert O'Callahan
a2485753ff Bug 840902. Part 1: Stop checking the results of various display list methods. r=mattwoodrow
--HG--
extra : rebase_source : 50a3d6809ef76a25a3d02d91f2873d9ba11fdc56
2013-02-15 00:08:08 +13:00
L. David Baron
b387f0fbea Bug 841789, patch 1: Rename nsIFrame::GetStyleContext() to nsIFrame::StyleContext() since it can never return null. r=dholbert
This makes it conform to our convention that getters returning pointers
that can never be null do not begin with "Get".
2013-02-15 21:38:33 -08:00
Daniel Holbert
dc869880a7 Bug 836957 part 2: Remove unnecessary nsIFrame::GetSkipSides() overrides whose implementations are in .cpp files. r=mats 2013-02-04 08:17:20 -08:00
Mats Palmgren
d5826be6d7 Bug 786533 - Replace NS_MIN/NS_MAX with std::min/std::max and #include <algorithm> where needed. r=ehsan 2013-01-15 13:22:03 +01:00
Mats Palmgren
d60d23096a Bug 822053 - Nested balancing column sets restriction shouldn't affect non-balancing column sets. r=roc 2012-12-27 22:24:08 +01:00
L. David Baron
7c9e487c8c Bug 809533, patch 2: Don't null-check inside NS_New*Frame. r=roc 2012-11-07 11:55:53 -08:00
Mats Palmgren
01cc61dab4 Bug 806056 - Make nsContainerFrame destroy abs/fixed pos. child frames unless a derived class already did so. Assert that there are no abs/fixed pos. child frames in nsFrame::DestroyFrom(). r=roc 2012-11-02 01:52:59 +01:00
Isaac Aggrey
0cc4b12d36 Bug 791906: Replace NSPR integer limit constants with stdint ones; r=ehsan 2012-09-28 01:57:33 -05:00
Matt Woodrow
1d675c61d6 Bug 539356 - Part 9c - Remove old invalidation code. r=bz 2012-08-29 17:39:31 +12:00
Ed Morley
5a3b322459 Revert mozilla-inbound to e4dd1fa6d222 for crashes and test failures on a CLOSED TREE 2012-09-27 16:34:46 +01:00
Matt Woodrow
49d4c24594 Bug 539356 - Part 9 - Implement DLBI. r=roc,bz,jwatt 2012-08-29 17:38:58 +12:00
Ehsan Akhgari
8c296bbcd4 Bug 579517 - Part 1: Automated conversion of NSPR numeric types to stdint types in Gecko; r=bsmedberg
This patch was generated by a script.  Here's the source of the script for
future reference:

function convert() {
echo "Converting $1 to $2..."
find . ! -wholename "*nsprpub*" \
       ! -wholename "*security/nss*" \
       ! -wholename "*/.hg*" \
       ! -wholename "obj-ff-dbg*" \
       ! -name nsXPCOMCID.h \
       ! -name prtypes.h \
         -type f \
      \( -iname "*.cpp" \
         -o -iname "*.h" \
         -o -iname "*.c" \
         -o -iname "*.cc" \
         -o -iname "*.idl" \
         -o -iname "*.ipdl" \
         -o -iname "*.ipdlh" \
         -o -iname "*.mm" \) | \
    xargs -n 1 sed -i -e "s/\b$1\b/$2/g"
}

convert PRInt8 int8_t
convert PRUint8 uint8_t
convert PRInt16 int16_t
convert PRUint16 uint16_t
convert PRInt32 int32_t
convert PRUint32 uint32_t
convert PRInt64 int64_t
convert PRUint64 uint64_t

convert PRIntn int
convert PRUintn unsigned

convert PRSize size_t

convert PROffset32 int32_t
convert PROffset64 int64_t

convert PRPtrdiff ptrdiff_t

convert PRFloat64 double
2012-08-22 11:56:38 -04:00
Daniel Holbert
d63af71024 Bug 783700: Switch nsColumnSetFrame::BuildDisplayList() to use nsFrameList::Enumerator for walking its child frames. r=dbaron 2012-08-17 18:12:01 -07:00
Aryeh Gregor
e2dd9c2028 Bug 626472 part 3 - Remove nsnull for good; r=ehsan 2012-08-12 13:43:47 +03:00
Ms2ger
331accfcb4 Bug 780387 - Part b: Stop using PRIntn; r=bsmedberg 2012-08-09 09:09:40 +02:00
Scott Johnson
efacdced83 Bug 779566: Remove code from nsColumnSetFrame that aligns RTL columns to the left of the frame. [r=roc] 2012-08-01 20:37:23 -05:00
Scott Johnson
b429511c66 Backed out changeset da35ab16d9fa to change commit message. 2012-08-01 20:35:01 -05:00
Scott Johnson
f14ec310f1 Bug 779566: Remove code from nsColumnSetFrame that aligns RTL columns to the left of the frame. 2012-08-01 20:20:01 -05:00
Scott Johnson
c5aaabe440 Bug 764567: Implement column-fill part of CSS3 multicol spec, now with regression fixes [r=roc]. 2012-07-31 11:21:19 -05:00
Aryeh Gregor
57c0ad57fb Bug 777292 part 2 - Change all nsnull to nullptr 2012-07-30 17:20:58 +03:00
Mats Palmgren
dd549d9e2b Bug 616722 - Make ColumnSetFrame a block margin root. Make the first column a margin root at the top edge, and the last column at the bottom. r=roc 2012-07-20 14:27:04 -04:00
Ehsan Akhgari
6ef72aef93 Backout changeset f568fc280fb0 (bug 539356) because of performance and correctness regressions 2012-07-03 20:24:55 -04:00
Matt Woodrow
1f0dbc7c74 Bug 539356 - Part 9 - Implement DLBI. r=roc,bz,jwatt 2012-06-30 15:06:11 +12:00
Scott Johnson
9852f66001 Bug 733614: Whitespace change after backout of bug 695222. [r=none, whitespace-only, DONTBUILD] 2012-06-13 12:14:31 -05:00
Scott Johnson
d4d53d2412 Bug 733614: Backout changes from bug 695222 for mozilla 16 branch [r=dbaron]. 2012-06-13 11:00:56 -05:00
Gervase Markham
87620f5676 Bug 716478 - update licence to MPL 2. 2012-05-21 12:12:37 +01:00
Mats Palmgren
0ac9e5026b Bug 725376 - Don't do column balancing deeper than 2 nested levels to avoid hang. r=roc 2012-02-18 02:34:21 +01:00
Mats Palmgren
3b7a577cde Bug 725376 - Don't do column balancing deeper than 5 nested levels to avoid hang. r=roc 2012-02-12 22:21:51 +01:00
Phil Ringnalda
e66d5e8494 Back out 1cd8c9b40035 (bug 725376), df43cc1f72e1 (bug 725535), and 8a820e4ee7f6 (bug 726364) for reftest orange 2012-02-12 14:01:58 -08:00
Mats Palmgren
80cecffade Bug 725376 - Don't do column balancing deeper than 5 nested levels to avoid hang. r=roc 2012-02-12 22:21:51 +01:00
Scott Johnson
0a202e6b66 Bug 718516: Replace call of FinishReflowWithAbsoluteFrames() with FinishAndStoreOverflow() for nsColumnSetFrame to prevent crash. [r=ehsan] 2012-02-10 11:06:23 -06:00
Ed Morley
051b38fe95 Backout 9062b3e04318 (bug 718516) for reftest failures 2012-02-08 00:56:56 +00:00