Commit Graph

928 Commits

Author SHA1 Message Date
Shawn Wilsher
4710dc3be6 Bug 478948 - SQL statements not finalized warnings during shutdown
r=mak
2009-02-20 14:25:45 -08:00
Marco Bonardo
4662ddb1aa Bug 478218 - onQuit expiration is not working, changes are never synced to disk, r=dietrich a=blocking191 2009-02-16 12:09:19 +01:00
Drew Willcoxon
8b31027ba9 Bug 455315 - when removing a bookmark we recalculate frecency with wrong isBookmark, r=dietrich 2009-02-16 12:09:19 +01:00
Shawn Wilsher
62e4ff7c7e Bug 468705 - cache the result of _getSyncTableStatement in nsDBFlush
We can avoid some of the statement parsing, which will help mobile out!
r=mak
2009-02-13 18:01:55 -05:00
Marco Bonardo
d40d34bee0 Bug 477739 - Exception when clicking star icon (no editBookmarkPanel, broken JSON backup), r=dietrich a=blocking191 2009-02-12 12:32:52 +01:00
Marco Bonardo
d6266d9563 Bug 477916 - Don't allow removing the Places root through bookmarks API, r+a191=dietrich 2009-02-11 11:53:35 +01:00
Marco Bonardo
10063403f7 Bug 477793 - Make sure preventive maintenance cannot act on roots, r=sdwilsh a=blocking191 2009-02-11 11:53:35 +01:00
Marco Bonardo
a8b322321a bug 474582 - Disable lastModifiedTime check to try fixing test orange on Linux 2009-02-09 21:49:17 +01:00
Marco Bonardo
8af19aa0fb Bug 474582 - With initial migration Shiretoko doesn't import favorites from Internet Explorer 7 anymore, r=dietrich 2009-02-09 19:16:02 +01:00
Edward Lee
4384aa6ca1 Bug 476297 - Switch frecency idle timer to idle-daily observer. r=dietrich 2009-02-07 15:51:19 -06:00
Edward Lee
0a8120c04c Bug 477295 - Clean up unnecessary assignments of NS_ConvertUTF*. r=sdwilsh 2009-02-06 18:18:16 -06:00
Dietrich Ayala
0198490a4d backing out bug 432706, causes multiple regressions 2009-02-04 09:49:58 -08:00
Marco Bonardo
e21b0af40d merge backout 2009-02-04 15:27:48 +01:00
Marco Bonardo
658f27c658 Backed out changeset 1cf6c5b25fe5 due to crashes on linux unit test boxes 2009-02-04 15:27:18 +01:00
Marco Bonardo
e80ecb6157 Bug 474582 - With initial migration Shiretoko doesn't import favorites from Internet Explorer 7 anymore, r=dietrich 2009-02-04 13:47:13 +01:00
Marco Bonardo
5d511f3bb1 Bug 475824 - preventive maintenance has low possibilites to be run, r=dietrich 2009-02-04 13:47:13 +01:00
Shawn Wilsher
8075a939ec Bug 476292 - Crashes on startup on OS X and Linux [@ nsNavBookmarks::IsRealBookmark] [@ PL_DHashTableOperate]
This fixes a crash when we initialize nsNavBookmarks with a database that is out
of date (the schema version is less than the current one).  Because the bookmark
service initializes the history service in its Init method, and the history
service tries to get the bookmark service if the database needs an upgrade, we
try to re-enter the bookmark service's constructor.  Bad things happen.

Adds a test to ensure that we don't do this again.

r=dietrich
r=MaK77
2009-02-03 21:58:21 -05:00
Drew Willcoxon
a284ae1506 Bug 444179 - Library>Views>Sort>Sort by Tags does nothing, r=mak77 2009-01-30 13:34:38 +01:00
Jeff Muizelaar
a7c6031376 nsNavHistory::AddDocumentRedirect doesn't handle INTERNAL redirects - bug 475069 r=mak77 2009-01-29 14:26:04 -05:00
Shawn Wilsher
4756beb1ae Bug 449406 - bookmarks of TRANSITION_DOWNLOAD and TRANSITION_EMBED don't show up in the location bar if they've been visited
This adds a new function to nsNavBookmarks that determines if a place id is a
"real" bookmark (not a livemark child).  It also makes a number of places use
this new function to unify and simplify a number of code paths.

Additionally, it changes how frecency is calculated for bookmarked items.  If a
visit is bookmarked (aIsBookmarked is true in CalculateFrecencyInternal), the
visited bookmark bonus is now added for all visits.  The visit bonus was also
cut in half for bookmarks so TRANSITION_BOOKMARK will still end up with the same
value (150).

r=dietrich
r=MaK77
2009-01-27 21:01:33 -05:00
Gavin Sharp
b34e772a9e Bug 474538 - nsIBrowserHistory::removePagesFromHost documentation is crazy, r=sdwilsh 2009-01-23 12:52:14 +01:00
Daniel Holbert
2a7d88e05a Bug 473236 - Remove executable bit from files that don't need it. (Only changes file mode -- no code changes.) r=bsmedberg 2009-01-21 22:55:08 -08:00
Drew Wilcoxon
43ac281f8c Bug 370197 - Places query serialization needs tests . r=mak77 2009-01-21 12:39:07 +01:00
Marco Bonardo
30a58baa84 Bug 466422 - Clicking history - show all history doesn't show any history, r=dietrich 2009-01-21 12:39:07 +01:00
Marco Bonardo
1f6a3a7d4c Bug 474334 - "place:" is a valid query to deserialize and should not cause an "ignoring unknown key:" warning, r=dietrich 2009-01-21 12:39:07 +01:00
Edward Lee
a0fa2b97c8 Bug 471903 - pref urlbar.autocomplete.enabled is no longer implemented. r=dietrich
Bug 472943 - Two confusable preferences, "browser.urlbar.search.sources" and "browser.urlbar.default.behavior", should be unified

--HG--
rename : toolkit/components/places/tests/autocomplete/test_search_sources.js => toolkit/components/places/tests/autocomplete/test_enabled.js
2009-01-21 02:00:04 -06:00
Fred Jendrzejewski
7d5761cdfa Bug 461047 - Replace nsStringArray with nsTArray<nsString>. r+sr=roc 2009-01-18 21:14:14 +01:00
Marco Bonardo
9e51b8a061 Bug 471084 - Importing a large bookmarks JSON backup makes Firefox crash (out of memory), r=dietrich 2009-01-17 15:45:37 +01:00
Marco Bonardo
9952bff6eb Bug 452000 - Sort by keyword in Library does not work, r=dietrich 2009-01-17 15:45:37 +01:00
Robert O'Callahan
1a9b00de4e Backed out changeset 8019a959aade 2009-01-16 22:20:33 +13:00
Fred Jendrzejewski
b79ad6fa55 Bug 461047. Replace nsStringArray with nsTArray<nsString>. r+sr=roc
--HG--
extra : rebase_source : 7a20af24c97867efbb28dafa6a70ea1b4cf00e58
2009-01-16 20:51:04 +13:00
Neil Rashbrook
db65d28baa Bug 470586 - Crash calling removePagesFromHost when sidebar is showing pages grouped by day and site, r=sdwilsh 2009-01-15 15:37:33 +01:00
Drew Willcoxon
2ad84319b7 Bug 463674 - changeBookmarkURI() doesn't update internal bookmark hash, r=mak77 2009-01-15 15:37:33 +01:00
Ben Turner
a5644a9c39 Merge backout 2009-01-14 18:24:18 -08:00
Ben Turner
0f0d556f13 Backed out changeset 96a66c1a50bd for failing unit tests. 2009-01-14 18:23:21 -08:00
Neil Rashbrook
a3a6522f11 Bug 473157 Sorting shouldn't affect grouping containers, only uris r=dietrich 2009-01-14 22:38:30 +00:00
Neil Rashbrook
cc742092ce Bug 470586 Can crash removing all pages from a host when the sidebar is grouped r=sdwilsh 2009-01-14 22:33:37 +00:00
Drew Willcoxon
c149de9294 Bug 412132 - after changing a bookmark's location, need to update the frecency of the "old" uri, r=dietrich 2009-01-13 11:48:27 +01:00
Marco Bonardo
4c89a6229d Bug 454977 - remove INSERT OR REPLACE to avoid error prone paths with views, r=dietrich 2009-01-13 11:48:25 +01:00
Phil Ringnalda
2dff174183 I would not have choosen the weekend before a freeze for so much CLOSED TREE 2009-01-11 20:12:32 -08:00
Robert Kaiser
0b557fdaa3 bug 471886 - Make places autocomplete tests even more robust against default prefs, r=Mardak 2009-01-10 16:29:17 +01:00
Edward Lee
e10c805dd2 Bustage fix Bug 463483 (finalized typed query statement) 2009-01-07 16:53:54 -08:00
Edward Lee
a5317482ad Bug 426864 - Only show user typed history pages for the urlbar dropdown. r=dietrich 2009-01-07 15:47:58 -08:00
Edward Lee
dacf203db8 Bug 463483 - matchOnlyTyped no longer honored with special filters. r=dietrich
Bug 463558 - Switch matchOnlyTyped to restrict.typed "~" (default.behavior + 32)
2009-01-07 15:47:56 -08:00
Marco Bonardo
3b1f2a552d Bug 468400 - xpcshell-simple/test_places/unit/test_adaptive.js | *** TIMEOUT ***: The test timed out while polling database, r=sdwilsh 2009-01-08 00:37:01 +01:00
Marco Bonardo
1d07d32522 Bug 466407 - History menu often shows duplicated items, r=dietrich 2009-01-08 00:37:01 +01:00
Marco Bonardo
6fa7b73e03 Bug 471547 - move PlacesDBUtils getters to avoid possible leaks, r=sdwilsh 2009-01-08 00:37:01 +01:00
Marco Bonardo
83a374cd4f Bug 470429 - nsPlacesDBFlush::onItemAdded should not sync if the item is a container, r=sdwilsh 2009-01-08 00:37:00 +01:00
Marco Bonardo
248d436712 Bug 462765 - instant-apply muddies the MRU folder list in the bookmark properties dialog, r=dietrich 2009-01-08 00:37:00 +01:00
mak77@bonardo.net
1c24addb1a Bug 470348 - clear private data on shutdown does not delete history if "ask me before..." is enabled (r=dietrich, gavin) 2009-01-06 12:41:08 -08:00
Dietrich Ayala
9659c3c58d Bug 464486 - lots of bookmark corruption reported via user support (r=marco, sdwilsh) 2009-01-03 09:26:11 -08:00
Ehsan Akhgari
6f93e82b41 Bug 471018 - Warning: nsFaviconService.cpp: outparam 'aHasData' not written on NS_SUCCEEDED(return value); r=dietrich 2009-01-03 07:42:34 +03:30
Dietrich Ayala
c01314e672 Bug 432706 - Deleting/adding/updating a large quantity of bookmarks/history is very slow due to updating observers (r=marco) 2009-01-02 11:03:38 -08:00
Marco Bonardo
0cafd269c4 Bug 470707 - [SeaMonkey] test_download_history.js fails now, r=dietrich 2008-12-30 22:42:23 +01:00
Marco Bonardo
e6b8308902 Bug 466564 - RemoveDuplicateURIs is not aware of temp views, r=dietrich 2008-12-30 22:42:23 +01:00
Marco Bonardo
be7aeedd0c Bug 464438 - move EnsureCurrentSchema into migration path, r=dietrich 2008-12-30 22:42:23 +01:00
Marco Bonardo
485f62946f Bug 439129 - Clearing browsing history does not hide livemarks children from the location bar, r=dietrich 2008-12-30 22:42:22 +01:00
Dietrich Ayala
17dd8776c4 Bug 414715 - Notify the user if places.sqlite is locked and bookmarks and history will not work (relanding w/ leak fix, r=marco, r=gavin, l10n-r=pike) 2008-12-30 13:44:55 +01:00
Dietrich Ayala
44e08929e7 backout bug 414715 due to leaks 2008-12-29 17:22:39 -08:00
Dietrich Ayala
c51318949c Bug 414715 - Notify the user if places.sqlite is locked and bookmarks and history will not work (relanding w/ leak fix, r=marco, r=gavin, l10n-r=pike) 2008-12-29 14:49:05 -08:00
Robert Kaiser
a855c51d33 bug 469593 - test_423060.xul fails on SeaMonkey, r=gavin
--HG--
rename : toolkit/components/places/tests/chrome/Makefile.in => browser/components/feeds/test/chrome/Makefile.in
rename : toolkit/components/places/tests/chrome/sample_feed.atom => browser/components/feeds/test/chrome/sample_feed.atom
rename : toolkit/components/places/tests/chrome/test_423060.xul => browser/components/feeds/test/chrome/test_423060.xul
2008-12-23 15:58:44 +01:00
Marco Bonardo
952200fe50 Bug 470455 - test_database_sync_embed_visits.js leaks, r=sdwilsh 2008-12-22 11:07:21 +01:00
Shawn Wilsher
c80ee6de74 Bug 469972 - leaking the places database connection in strange situations; r=dietrich 2008-12-20 01:46:04 +01:00
Marco Bonardo
dce47704f5 Bug 458849 - transition download visits saved when "Keep my history..." is unchecked, r=sdwilsh 2008-12-19 13:36:15 +01:00
Dietrich Ayala
a81ff7e680 imported patch backout-bug414715 2008-12-18 17:09:25 -08:00
Dietrich Ayala
3299fb830d Bug 414715 - Notify the user if places.sqlite is locked and bookmarks and history will not work (r=marco, r=gavin, l10n-r=pike) 2008-12-18 13:47:48 -08:00
Dietrich Ayala
5dfe4f0055 Bug 469102 - Places Tag Autocomplete breaks with certain tags (Regex escaping) (r=marco) 2008-12-18 12:33:47 -08:00
Marco Bonardo
da6bfbbb37 Bug 453529 - Retain embed visits and places into the temp table in memory, r=sdwilsh 2008-12-17 11:41:44 +01:00
Marco Bonardo
c13d5fd1dd Bug 469062 - test_multiple_visits_around_sync.js leaks now, r=sdwilsh 2008-12-17 11:41:44 +01:00
Marco Bonardo
17817e4af5 Bug 431548 - Tagging history item takes a long time without progress indication (slight hang / freeze of UI), r=dietrich 2008-12-17 11:41:43 +01:00
Marco Bonardo
b9fdc603d8 Bug 469301 - PRBool violation in mDatabaseStatus, r=dietrich 2008-12-13 10:57:30 +01:00
Shawn Wilsher
4d53994a50 Bug 460300 - Expire favicons when they expire from cache, and when the cache is cleared
This makes favicons expire from the favicon service much less often.  They are
now expired when the cache headers says they expire, or one week - whichever is
shorter.  Additionally, all favicons expire when the cache is cleared.
r=MaK77
2008-12-11 15:01:10 -05:00
Marco Bonardo
45b8f132d3 Bug 468836 - Existing tags no longer show and cannot be edited, r=dietrich 2008-12-11 15:23:25 +01:00
Robert Sayre
38305f3678 backout bug 468836, checked in on persistent orange. 2008-12-11 02:44:01 -08:00
Marco Bonardo
1006ee8d3a Bug 468836 - Existing tags no longer show and cannot be edited, r=dietrich 2008-12-11 01:32:24 +01:00
Edward Lee
cdd08cee41 Bug 463459 - Use a separate pref instead of empty restrict/match values to specify defaults. r=dietrich, a1.9.1=beltzner 2008-12-10 10:58:43 -06:00
Robert Kaiser
b6de2bc403 fix up my test bustage by removing a spurious { the review didn't catch, not sure why I did put it there, sorry. 2008-12-10 14:33:52 +01:00
Robert Kaiser
309980c5e5 bug 468341 - Some toolkit places tests fail on SeaMonkey unit test boxes - make tests mor tolerant to default prefs, non-override DOM error messages, non-existing browser-specific services and protcol defintions, r=sdwilsh a=tests-only 2008-12-10 13:18:14 +01:00
Marco Bonardo
6d9599a014 followup to Bug 431558 - implement preventive maintenance for places.sqlite, remove observer on test finish, r=sdwilsh 2008-12-10 11:44:01 +01:00
Dietrich Ayala
7a9981ce5f Bug 463513 - Tagging service could hold a fixed cache instead of an open node, r=mak77 2008-12-10 11:40:13 +01:00
Shawn Wilsher
bf0e65a35b Bug 466582 - smarter handling of remote chrome (and not allowing it)
This adds a new flag, URI_IS_LOCAL_RESOURCE, to nsIProtocolHandler that allows
something of this protocol to be registered in chrome.

This changeset removes a runtime check every time we open a chrome channel to
see if it is remote to a registration time check that checks flags.  The old
code could be easily worked around, and allowed for remote resources to be used.

r=bsmedberg
r=bz
sr=bz
2008-12-09 16:27:42 -05:00
Marco Bonardo
475620037e Bug 465510 - random failures on test_database_sync_after_addVisit.js, r=sdwilsh 2008-12-09 21:39:32 +01:00
Marco Bonardo
d68f8a9e09 Bug 467971 - random failures on test_multiple_visits_around_sync.js, r=sdwilsh 2008-12-09 21:39:32 +01:00
Marco Bonardo
0dd8a6691d Bug 431558 - implement preventive maintenance for places.sqlite, r=dietrich 2008-12-09 21:39:32 +01:00
Shawn Wilsher
6ea17d3edc Backed out changeset b6f762fde736 (bug 466582) for unit test orange. 2008-12-08 18:51:46 -05:00
Shawn Wilsher
52fa025019 Bug 466582 - smarter handling of remote chrome (and not allowing it)
r=bsmedberg, r=bz, sr=bz
2008-12-08 17:14:14 -05:00
Daniel Holbert
ca3e28538e Bug 418643 trivial follow-up: Remove unneded 'typedef' token, in 'typedef struct folderChildrenInfo { ...', to fix compiler warning. r=sdwilsh 2008-12-07 11:56:39 -08:00
Marco Bonardo
2a4f1b3c4e ug 466303 - When removing bookmark backups remove also old html ones, r=dietrich 2008-12-05 16:27:23 +01:00
Marco Bonardo
c53ec05b07 Bug 460119 - Convert autocomplete feedback increase to an async query, r=dietrich 2008-12-04 16:41:06 +01:00
Marco Bonardo
4069663e3a Bug 423139 - BOOKMARK_REDIRECT_TIME_THRESHOLD is weird, r=dietrich 2008-12-04 16:11:04 +01:00
Marco Bonardo
b74ce92e03 Bug 460830 - Tag containers and queries have bogus QUERY_TYPE definition, r=dietrich 2008-12-04 16:01:19 +01:00
Marco Bonardo
d984c838eb Bug 463863 - Download history not shown in Places history, r=dietrich, ui-r=beltzner 2008-12-04 13:59:04 +01:00
Marco Bonardo
b2e922b709 backing out bug 414715 due to possible Ts regression 2008-11-27 16:10:36 +01:00
Dietrich Ayala
9f81601ddc Bug 414715. Notify the user if places.sqlite is locked. r=pike, r=mak77, ui-review=faaborg, a=blocking-firefox3.1 2008-11-26 20:59:47 -05:00
mak77@bonardo.net
3d576ef8ce Bug 463471 - temp tables are not correctly synced to disk when the user clear private data on shutdown (r=sdwilsh, r=dietrich) 2008-11-13 22:45:49 -08:00
Ehsan Akhgari
a89e46f55a Bug 461710 - Write an automated test to ensure that visited link coloring is turned off in private browsing mode (further fixes); r=dietrich (NPOTB) 2008-11-13 23:12:03 +03:30
Dietrich Ayala
d6bf19faab Fix for bug 445704 (JSON bookmarks backup has localized filename (and can't be easily restored). r=zeniko, a=beltzner. 2008-11-13 17:54:25 +01:00
Marco Bonardo
45455110de backout test for bug 463471 causing orange 2008-11-13 11:33:01 +01:00
Dietrich Ayala
127a3341a9 [mq]: backout-bug-463471 2008-11-12 23:50:19 -08:00
Marco Bonardo
36f739f320 Bug 463471 - temp tables are not correctly synced to disk when the user clear private data on shutdown, r=dietrich, sdwilsh a=beltzner 2008-11-12 21:50:02 +01:00
Marco Bonardo
20ae2fab49 Bug 462366 - correct bogus importBookmarksHTML behaviour, r=dietrich a=beltzner 2008-11-12 21:45:53 +01:00
Edward Lee
a246ed282d Bug 463661 - Create a pref to control the location bar search sources (history, bookmark, both, none). r=dietrich, a1.9.1b2=beltzner
Bug 463535 - Continuing search immediately after changing prefs give wrong results
2008-11-10 10:04:36 -06:00
Marco Bonardo
d2ef7735fd Bug 459493 - remove placesBackground, r+a=mconnor 2008-11-06 23:22:10 +01:00
mak77@bonardo.net
234918c058 Bug 418643 - Bookmark folder deletion executes too many SQL statements (r=dietrich) 2008-11-05 14:02:12 -08:00
Dietrich Ayala
029ea93f23 Bug 419792 - Use optimized query to get tags for nsNavHistoryResultNode (r=mano) 2008-11-05 10:20:00 -08:00
Dietrich Ayala
81891e2697 Bug 457473 - Bookmark copy creates bookmark with duplicate guid - regression in FF 3.0.3 (r=mano) 2008-11-05 10:15:49 -08:00
Shawn Wilsher
0a32f72c76 Bug 453180 - Adding moz_annos_placeattributeindex should be done in migration code not shutdown
r=dietrich
2008-11-03 22:41:16 -05:00
Shawn Wilsher
1f89b4462e Bug 453179 - Remove unused indecies in a migration code path - not shutdown
r=dietrich
2008-11-03 22:41:15 -05:00
Shawn Wilsher
cf48f23ca7 Bug 453177 - Move moz_places.user_title removal back to MigrateV6Up
r=dietrich
2008-11-03 22:41:15 -05:00
Ehsan Akhgari
5fdab7c48c Bug 461710 - Write an automated test to ensure that visited link coloring is turned off in private browsing mode; r=dietrich 2008-11-04 02:52:23 +03:30
Ehsan Akhgari
a2e1bc51b4 Bug 248970 - Private Browsing mode (global toggle for saving/caching everything) [Places unit test fix]; r=dietrich 2008-11-04 02:52:22 +03:30
Ehsan Akhgari
4770654ff7 Bug 248970 - Private Browsing mode (global toggle for saving/caching everything) [unit test API changes]; r,sr=mconnor 2008-11-04 02:52:22 +03:30
Dietrich Ayala
46b4a3eec0 Bug 462379 - (NS_ERROR_FAILURE) [nsINavBookmarksService.insertBookmark] when trying to star a bookmark (r=sdwilsh, for marco, sdwilsh) 2008-10-31 17:59:38 -07:00
Dietrich Ayala
15440bfcb0 Bug 415960 - bookmark tags edit control should provide autocomplete (r=mano, core by asouzis@users.sf.net) 2008-10-31 09:16:22 -07:00
Dietrich Ayala
b6d5857bc6 backing out bug 462379 due to persistent test failures 2008-10-30 23:11:04 -07:00
Edward Lee
7314b9afe4 More bug 462379 followup (both == 2) rs=sdwilsh 2008-10-30 20:30:35 -05:00
Dietrich Ayala
f1def076d9 bug 462379 followup (for sdwilsh@forerunnerdesigns.com) 2008-10-30 16:36:14 -07:00
Shawn Wilsher
a2d0e846cb Bug 462379 - (NS_ERROR_FAILURE) [nsINavBookmarksService.insertBookmark] when trying to star a bookmark
r=dietrich
2008-10-30 17:20:33 -04:00
Marco Bonardo
8d17009bde Bug 462206 - finalize statements in nsPlacesDBFlush, r=sdwilsh 2008-10-30 09:51:34 +01:00
Marco Bonardo
3e6ce6e98a Bug 462205 - add statementCallback interface to nsPlacesDBFlush, r=sdwilsh 2008-10-30 09:45:21 +01:00
Marco Bonardo
bd5be67a29 Bug 462204 - Don't try to cancel a not existant timer in nsPlacesDBFlush, r=sdwilsh 2008-10-30 09:42:36 +01:00
Marco Bonardo
04d3fb42d9 Bug 462213 - make migrateV8 tolerant to downgrade-upgrade paths, r=sdwilsh 2008-10-30 09:37:49 +01:00
Shawn Wilsher
ffb57e62b1 Bug 462047 - nsPlacesDBFlush.js should have an error handler.
This changeset adds the handleError method from mozIStorageStatementCallback to
nsPlacesDBFlush so we can report errors to the error console if they occur.
r=dietrich
2008-10-28 17:44:35 -04:00
Marco Bonardo
f118fc44e0 Bug 460947 - fsync stuff has a wrong query for expiration sites cap
r=dietrich
2008-10-27 18:52:23 -04:00
Marco Bonardo
ed77be778c Bug 459934 - should lazy-load places autocomplete statements
r=dietrich
r=sdwilsh
2008-10-27 18:52:23 -04:00
Shawn Wilsher
53d9ccaa7e Bug 459789 - lazily get mDB[Invalid|Old]Frecencies
r=dietrich
2008-10-27 18:52:23 -04:00
Shawn Wilsher
d3792f99c1 Bug 459788 - Lazily get mDBBookmarkToUrlResult
r=dietrich
2008-10-27 18:52:23 -04:00
Shawn Wilsher
53bf616b5a Bug 459786 - lazily get mDBVisitTo[Visit|URL]Result
r=dietrich
2008-10-27 18:52:23 -04:00
Shawn Wilsher
5c893a5e9c Bug 459787 - remove mDBUrlToUrlResult
This changeset removes an unused query that was in the startup path.
r=dietrich
2008-10-27 18:52:22 -04:00
Shawn Wilsher
c7e57e1cb1 Bug 459781 - create our string bundle in a more sane way
This changeset only creates the string bundle when we need it, and only in one
place as opposed to two separate places.
r=dietrich
2008-10-27 18:52:22 -04:00
Shawn Wilsher
d3d72c5b09 Bug 459776 - date formatter is unused
This changeset removes a small part of code that places does in startup that is
not used or needed.
r=dietrich
2008-10-27 18:52:22 -04:00
Shawn Wilsher
34a4755e8b Bug 459773 - Creating a collation is expensive
This makes a lazy getter for getting our collation saving us about 3% of places
startup time.
r=dietrich
2008-10-27 18:52:21 -04:00
Marco Bonardo
27bd310336 Bug 455474 - cleanup nsNavBookmarks::Init
r=dietrich
2008-10-27 18:52:21 -04:00
Marco Bonardo
e8ac5aeecb Bug 459491 - nsPlacesDBFlush could use async queries instead of background thread
r=sdwilsh

--HG--
rename : toolkit/components/places/tests/background/head_background.js => toolkit/components/places/tests/sync/head_sync.js
rename : toolkit/components/places/tests/background/test_database_sync_after_addBookmark.js => toolkit/components/places/tests/sync/test_database_sync_after_addBookmark.js
rename : toolkit/components/places/tests/background/test_database_sync_after_addBookmark_batched.js => toolkit/components/places/tests/sync/test_database_sync_after_addBookmark_batched.js
rename : toolkit/components/places/tests/background/test_database_sync_after_addVisit.js => toolkit/components/places/tests/sync/test_database_sync_after_addVisit.js
rename : toolkit/components/places/tests/background/test_database_sync_after_addVisit_batched.js => toolkit/components/places/tests/sync/test_database_sync_after_addVisit_batched.js
rename : toolkit/components/places/tests/background/test_database_sync_after_modifyBookmark.js => toolkit/components/places/tests/sync/test_database_sync_after_modifyBookmark.js
rename : toolkit/components/places/tests/background/test_database_sync_after_quit_application.js => toolkit/components/places/tests/sync/test_database_sync_after_quit_application.js
rename : toolkit/components/places/tests/background/test_multiple_bookmarks_around_sync.js => toolkit/components/places/tests/sync/test_multiple_bookmarks_around_sync.js
rename : toolkit/components/places/tests/background/test_multiple_visits_around_sync.js => toolkit/components/places/tests/sync/test_multiple_visits_around_sync.js
2008-10-27 18:52:21 -04:00
Shawn Wilsher
866c0b3978 Bug 459315 - Wrap favicon work in a transaction
This wraps a series of statements that run on the main thread to reduce the
number of fsyncs that end up happening.
r=dietrich
2008-10-27 18:52:21 -04:00
Shawn Wilsher
2a07d62a96 Bug 459299 - nsNavHistory::SetPageTitleInternal is slow
This caches a statement that is created any time a pages title changes.  The
creation of the statement took roughly 66% of the functions execution time
according to shark.
It also removes a transaction that was not needed in this method.
r=dietrich
2008-10-27 18:52:21 -04:00
Marco Bonardo
f6e56b6916 Bug 456029 - optimize the temp table triggers
This changeset makes the triggers work much faster which should greatly reduce
the timings of adding a visit and a bookmark.
r=sdwilsh
2008-10-27 18:52:21 -04:00
Shawn Wilsher
7a2e763702 Bug 450290 - Sync the temp tables to the permanent tables.
This changeset adds code that is run at app-startup that will flush out changes
to the temporary tables into the permanent ones.  For moz_places, this is done
whenever we sync moz_historyvisits and when we add or modify a bookmark.  For
moz_historyvisits, this is done on a timer controlled by the preference
places.syncDBTableIntervalInSecs.
Changeset includes full test coverage for the above behaviors.
r=dietrich
r=Mak77
2008-10-27 18:52:20 -04:00
Marco Bonardo ext:(%2C%20Shawn%20Wilsher%20%3Csdwilsh%40shawnwilsher.com%3E)
3fc608c2a6 Bug 449640 - Modify the places backend to use the temporary tables &
Bug 450705 - Optimize the query changes from the temp table rewrite
This changeset merges patches from two bugs to actually use the temporary tables
created for places.
Bug 449640 patch by Shawn Wilsher <sdwilsh@shawnwilsher.com>
r=dietrich, r=Mak77
Bug 450705 patch by Marco Bonardo <mak77@bonardo.net>
r=sdwilsh, r=dietrich, r=Mardak
2008-10-27 18:52:20 -04:00
Shawn Wilsher
825b607244 Bug 449086 - Create temporary tables for frequently used places tables
This changeset creates two temporary tables that will be used when inserting
data into moz_places and moz_historyvisits.  This will reduce the number of
writes as well as the number of fsyncs that happen.
r=dietrich
2008-10-27 18:52:19 -04:00
Ehsan Akhgari
229637b291 Bug 248970 - Private Browsing mode (global toggle for saving/caching everything) [places part]; r=dietrich 2008-10-20 00:44:59 +03:30
Shawn Wilsher
5edc587690 Backout places fsync changes 2008-10-17 12:29:34 -04:00
Marco Bonardo
877c2f729e followup to bug 459934, fix memory leak, mpa=mano, for post facto review 2008-10-17 08:56:25 -04:00
Marco Bonardo
4d5942f11f Bug 459934 - should lazy-load places autocomplete statements
r=dietrich
r=sdwilsh
2008-10-17 06:12:53 -04:00
Shawn Wilsher
8cb912ef64 Bug 459789 - lazily get mDB[Invalid|Old]Frecencies
r=dietrich
2008-10-17 06:12:53 -04:00
Shawn Wilsher
10cebaa66f Bug 459788 - Lazily get mDBBookmarkToUrlResult
r=dietrich
2008-10-17 06:12:53 -04:00
Shawn Wilsher
2f47ae77b2 Bug 459786 - lazily get mDBVisitTo[Visit|URL]Result
r=dietrich
2008-10-17 06:12:53 -04:00
Shawn Wilsher
653538e53f Bug 459787 - remove mDBUrlToUrlResult
This changeset removes an unused query that was in the startup path.
r=dietrich
2008-10-17 06:12:53 -04:00
Shawn Wilsher
bb7e0e8c36 Bug 459781 - create our string bundle in a more sane way
This changeset only creates the string bundle when we need it, and only in one
place as opposed to two separate places.
r=dietrich
2008-10-17 06:12:53 -04:00
Shawn Wilsher
d9d1b7f304 Bug 459776 - date formatter is unused
This changeset removes a small part of code that places does in startup that is
not used or needed.
r=dietrich
2008-10-17 06:12:52 -04:00
Shawn Wilsher
1d0921f3e0 Bug 459773 - Creating a collation is expensive
This makes a lazy getter for getting our collation saving us about 3% of places
startup time.
r=dietrich
2008-10-17 06:12:52 -04:00
Marco Bonardo
867daf5b5f Bug 455474 - cleanup nsNavBookmarks::Init
r=dietrich
2008-10-17 06:12:52 -04:00
Marco Bonardo
53ea567322 Bug 459491 - nsPlacesDBFlush could use async queries instead of background thread
r=sdwilsh

--HG--
rename : toolkit/components/places/tests/background/head_background.js => toolkit/components/places/tests/sync/head_sync.js
rename : toolkit/components/places/tests/background/test_database_sync_after_addBookmark.js => toolkit/components/places/tests/sync/test_database_sync_after_addBookmark.js
rename : toolkit/components/places/tests/background/test_database_sync_after_addBookmark_batched.js => toolkit/components/places/tests/sync/test_database_sync_after_addBookmark_batched.js
rename : toolkit/components/places/tests/background/test_database_sync_after_addVisit.js => toolkit/components/places/tests/sync/test_database_sync_after_addVisit.js
rename : toolkit/components/places/tests/background/test_database_sync_after_addVisit_batched.js => toolkit/components/places/tests/sync/test_database_sync_after_addVisit_batched.js
rename : toolkit/components/places/tests/background/test_database_sync_after_modifyBookmark.js => toolkit/components/places/tests/sync/test_database_sync_after_modifyBookmark.js
rename : toolkit/components/places/tests/background/test_database_sync_after_quit_application.js => toolkit/components/places/tests/sync/test_database_sync_after_quit_application.js
rename : toolkit/components/places/tests/background/test_multiple_bookmarks_around_sync.js => toolkit/components/places/tests/sync/test_multiple_bookmarks_around_sync.js
rename : toolkit/components/places/tests/background/test_multiple_visits_around_sync.js => toolkit/components/places/tests/sync/test_multiple_visits_around_sync.js
2008-10-17 06:12:52 -04:00
Shawn Wilsher
f5d2e83ae5 Bug 459315 - Wrap favicon work in a transaction
This wraps a series of statements that run on the main thread to reduce the
number of fsyncs that end up happening.
r=dietrich
2008-10-17 06:12:52 -04:00
Shawn Wilsher
4d5fb2f862 Bug 459299 - nsNavHistory::SetPageTitleInternal is slow
This caches a statement that is created any time a pages title changes.  The
creation of the statement took roughly 66% of the functions execution time
according to shark.
It also removes a transaction that was not needed in this method.
r=dietrich
2008-10-17 06:12:52 -04:00
Marco Bonardo
b71369cd19 Bug 456029 - optimize the temp table triggers
This changeset makes the triggers work much faster which should greatly reduce
the timings of adding a visit and a bookmark.
r=sdwilsh
2008-10-17 06:12:52 -04:00
Shawn Wilsher
4f97936d8c Bug 450290 - Sync the temp tables to the permanent tables.
This changeset adds code that is run at app-startup that will flush out changes
to the temporary tables into the permanent ones.  For moz_places, this is done
whenever we sync moz_historyvisits and when we add or modify a bookmark.  For
moz_historyvisits, this is done on a timer controlled by the preference
places.syncDBTableIntervalInSecs.
Changeset includes full test coverage for the above behaviors.
r=dietrich
r=Mak77

--HG--
rename : toolkit/components/places/tests/unit/head_bookmarks.js => toolkit/components/places/tests/background/head_background.js
2008-10-17 06:12:51 -04:00
Marco Bonardo ext:(%2C%20Shawn%20Wilsher%20%3Csdwilsh%40shawnwilsher.com%3E)
5715c324ab Bug 449640 - Modify the places backend to use the temporary tables &
Bug 450705 - Optimize the query changes from the temp table rewrite
This changeset merges patches from two bugs to actually use the temporary tables
created for places.
Bug 449640 patch by Shawn Wilsher <sdwilsh@shawnwilsher.com>
r=dietrich, r=Mak77
Bug 450705 patch by Marco Bonardo <mak77@bonardo.net>
r=sdwilsh, r=dietrich, r=Mardak
2008-10-17 06:12:51 -04:00
Shawn Wilsher
5790687517 Bug 449086 - Create temporary tables for frequently used places tables
This changeset creates two temporary tables that will be used when inserting
data into moz_places and moz_historyvisits.  This will reduce the number of
writes as well as the number of fsyncs that happen.
r=dietrich
2008-10-17 06:12:50 -04:00
Shawn Wilsher
810e90b149 Bug 460315 - set journal_mode to TRUNCATE
Sets the journal_mode to the places database to TRUNCATE
r=dietrich
2008-10-16 15:59:33 -04:00
Marco Bonardo
564c306794 Bug 458683 - Backup only uri nodes into tag containers, r=dietrich 2008-10-14 17:24:08 +02:00
Neil Rashbrook
b50d21d9c9 Bug 459571 Places autocomplete results contain incorrect search string r=sdwilsh,mardak 2008-10-14 14:54:17 +01:00
Marco Bonardo
3b22c3d551 Bug 457698 - nsNavHistoryFolderResultNode::OnItemAdded ignores dynamic containers, r=dietrich 2008-10-13 18:14:50 +02:00
Marco Bonardo
6d926ff1b7 Bug 457686 - appendURINode should not append to a dynamic container if we are inside an excludeItems query, r=dietrich 2008-10-13 18:06:50 +02:00
Marco Bonardo
56441e9d6e Bug 457681 - if ExcludeReadOnlyFolders is false, readonly dynamic containers are still excluded, r=dietrich 2008-10-13 17:58:36 +02:00
Marco Bonardo
b1351fc910 Bug 457677 - PlacesUtils ignores dynamic containers, r=dietrich 2008-10-13 17:54:25 +02:00
Marco Bonardo
68881489cf Bug 458013 - QueryResultNode Tag refresh optimization is useless as it is, r=dietrich 2008-10-13 14:11:27 +02:00
Ben Turner
311284ddff Bug 455436 - "XPConnect insists on using its own error reporter even when another is already set." r+sr=jst. 2008-10-12 11:32:34 -07:00
Arpad Borsos
8b11d938d2 Bug 456388 - Remove PR_STATIC_CALLBACK and PR_CALLBACK(_DECL) from the tree; r+sr=brendan 2008-10-10 17:04:34 +02:00
Daniel Holbert
72c410a648 Bug 458167 - (comments-only changes) Grammar Nazi Vol1: s/it's/its/ for the posessive version of the word, and a few other misc comment-typos, in these directories: accessible browser config profile rdf toolkit tools xpcom xpfe 2008-10-01 23:49:45 -07:00
Marco Bonardo
bd07734758 Bug 448584 - Don't save invalid uri nodes while doing a JSON backup (don't stop while saving data), r=dietrich 2008-09-30 10:41:36 +02:00
Dietrich Ayala
89c275d5aa Bug 420331 - wyciwyg: uris show up in location bar (r=mardak) 2008-09-29 23:46:52 -07:00
Dietrich Ayala
2fa7f086c3 test for bug 331459 - Places query ignores onlyBookmarked 2008-09-29 23:28:08 -07:00
Dietrich Ayala
5d9c44b264 pushing test for bug 433317, forgot to check-in initially 2008-09-29 23:22:46 -07:00
Marco Bonardo
a599a40812 Follow-up to Bug 329534 - Live bookmarks load way too aggressively. Try to workaround possible VM timers bugs that could cause test failures. r=dietrich 2008-09-30 01:24:44 +02:00
Takeshi Ichimaru
820d6827ba Bug 329534 - Live bookmarks load way too aggressively (lock up/hang/freeze browser), r=dietrich, mak77 2008-09-27 13:05:28 +02:00
Shawn Wilsher
abd0d61c89 Backed out changeset ebafcda56f98 (bug 456910)
Backed out for Tp regression (bug 457288)
2008-09-26 15:55:03 -04:00
Shawn Wilsher
af8e0300cd Bug 456910 - Stop using exclusive locking in places
This allows us to greatly reduce the number of fsyncs when upgrading to sqlite.
The perf loss in no longer using this locking is not significant (10^-6 %).
r=dietrich
2008-09-25 13:50:41 -04:00
Marco Bonardo
77bb2e6d9c Bug 407468 - Livemark loading and failed to load messages should be static menuitems from menu.xml, original patch by Michael Schonfeld <dev@schonfeld.org>, r=mano 2008-09-25 12:30:33 +02:00
Marco Bonardo
5edd5fff2c Bug 418671 - Clean up places views drag and drop code, r=mano 2008-09-19 17:47:45 +02:00
Shawn Wilsher
5d3ab665f0 backout merge 2008-09-18 15:05:36 -04:00
Shawn Wilsher
9bf0fdc3ad backout merge 2008-09-18 15:03:15 -04:00
Shawn Wilsher
f46423d1af Backed out changeset eb14737f8488 (places fsync work) 2008-09-18 15:02:55 -04:00
Shawn Wilsher
9bc5bb6827 backout merge 2008-09-18 15:02:17 -04:00
Shawn Wilsher
47008f4df3 Backed out changeset c99b7659dc0a (places fsync work) 2008-09-18 15:01:51 -04:00
Shawn Wilsher
8df9786bcd backout merge 2008-09-18 15:01:01 -04:00
Shawn Wilsher
900250bc91 Backed out changeset f3c9af143cc1 (places fsync work) 2008-09-18 15:00:30 -04:00
Shawn Wilsher
09255da4ab Backed out changeset dabae13daacb 2008-09-18 14:47:31 -04:00
Shawn Wilsher
f909f6ff81 Test breakage fix from bug 449640 2008-09-18 13:51:33 -04:00
Shawn Wilsher
16fef55947 Bug 450290 - Sync the temp tables to the permanent tables.
This changeset adds code that is run at app-startup that will flush out changes
to the temporary tables into the permanent ones.  For moz_places, this is done
whenever we sync moz_historyvisits and when we add or modify a bookmark.  For
moz_historyvisits, this is done on a timer controlled by the preference
places.syncDBTableIntervalInSecs.
Changeset includes full test coverage for the above behaviors.
r=dietrich
r=Mak77

--HG--
rename : toolkit/components/places/tests/unit/head_bookmarks.js => toolkit/components/places/tests/background/head_background.js
2008-09-18 11:10:47 -04:00
Marco Bonardo ext:(%2C%20Shawn%20Wilsher%20%3Csdwilsh%40shawnwilsher.com%3E)
ec97557606 Bug 449640 - Modify the places backend to use the temporary tables &
Bug 450705 - Optimize the query changes from the temp table rewrite
This changeset merges patches from two bugs to actually use the temporary tables
created for places.
Bug 449640 patch by Shawn Wilsher <sdwilsh@shawnwilsher.com>
r=dietrich, r=Mak77
Bug 450705 patch by Marco Bonardo <mak77@bonardo.net>
r=sdwilsh, r=dietrich, r=Mardak
2008-09-18 11:10:34 -04:00
Shawn Wilsher
a981391a48 Bug 449086 - Create temporary tables for frequently used places tables
This changeset creates two temporary tables that will be used when inserting
data into moz_places and moz_historyvisits.  This will reduce the number of
writes as well as the number of fsyncs that happen.
r=dietrich
2008-09-18 11:10:09 -04:00
Marco Bonardo
1d4ddeb7ae Bug 430442 - Undo and redo in the library are sometimes not correctly working, r=dietrich 2008-09-11 16:16:54 +02:00
Phil Ringnalda
b65979710c Bug 454360 - Use Components.results.NS_BINDING_ABORTED instead of hardcoding the value, r=gavin 2008-09-09 21:33:27 -07:00
Ted Mielczarek
468a3823fc bug 447642 - get rid of --disable-mochitest, replace MOZ_MOCHITEST with ENABLE_TESTS. r=bsmedberg 2008-09-09 13:59:11 -04:00
Serge Gautherie
d583b6d94c Bug 450938 - "test_417228-other-roots.js:89: strict warning: assignment to undeclared variable excludedFolderId"; Av1; r=mano 2008-09-07 16:46:41 +02:00
Marco Bonardo
016e09eab3 Bug 451499 - wrong folder icon appears on smart bookmarks, r=dietrich 2008-09-06 17:21:55 +02:00
Shawn Wilsher
c7fa5f7164 Bug 453181 - Remove code that is labeled REMOVE ME
This changeset removes a bunch of code that was labeled REMOVE ME with a release
stated.  All those releases have passed, so let's get rid of the code.
r=dietrich
2008-09-05 12:20:40 -04:00
Oleg Romashin
77c933f0f8 Bug 453821 - Places building in embedding-minimal profile failed. r=edilee. 2008-09-05 17:49:49 +03:00
Shawn Wilsher
6f881e6434 Bug 451590 - nsNavHistory needs nsIClassInfo with THREADSAFE flag
This changeset marks nsNavHistory as threadsafe so we can use the database
connection on more than one thread in JS.  It also adds assertions on every
other public API to ensure that it is only running on the main thread.
r=dietrich
r=bent
2008-09-04 18:11:14 -04:00