Commit Graph

83 Commits

Author SHA1 Message Date
Benjamin Smedberg
24e7cb1f78 Bug 396185 - Make nsIFrame derivatives and helper abstract classes use a different dynamic-cast system than nsISupports:
* we know all types frames may be cast to at compile time, so instead of extensible GUID IIDs, use a big enum (see nsQueryFrame::FrameIID)
* eliminate all vestiges of refcounting, since frames aren't refcounted

Some frames (SVG frames in particular) still implement nsISupports-derived interfaces, for example nsISVGValue. There is a FrameIID for nsISVGValue that lets you go from a frame to the XPCOM interface, but you can't query back.

r+sr=roc

nsITextControlFrame didn't have an IID the first time around, but this wasn't a compile error because nsITextControlFrame::kFrameIID inherited from nsIFormControlFrame::kFrameIID. I've added a static analysis pass to verify the correct behavior, since I can't figure out a way to make the compiler do it.

--HG--
extra : rebase_source : 4894a2ca0278e2ab92f27459db77165f8348cf41
2009-01-12 14:20:59 -05:00
Benjamin Smedberg
50621e4f9f Backed out changeset 4c4df6ed1b41 - Bug 396185 - Make nsIFrame not inherit from nsISupports due to mochitest failures... these appear to be crashes in nsGenericHTMLElement::GetEditorInternal. 2009-01-09 11:35:24 -05:00
Benjamin Smedberg
d0b948876f Bug 396185 - Make nsIFrame derivatives and helper abstract classes use a different dynamic-cast system than nsISupports:
* we know all types frames may be cast to at compile time, so instead of extensible GUID IIDs, use a big enum (see nsQueryFrame::FrameIID)
* eliminate all vestiges of refcounting, since frames aren't refcounted

Some frames (SVG frames in particular) still implement nsISupports-derived interfaces, for example nsISVGValue. There is a FrameIID for nsISVGValue that lets you go from a frame to the XPCOM interface, but you can't query back.

r+sr=roc

This patch locally causes two REFTEST-UNEXPECTED-PASS for Bidi stuff. It's possible that I accidentally fixed a bug, but I'm not sure, so I'm going to wait for the tinderboxes to confirm my local results.
2008-11-05 14:25:30 -05:00
L. David Baron
b3d748ba11 Fix some missed renames from bug 471356. r+sr=bzbarsky 2009-01-04 14:52:38 -05:00
L. David Baron
23d4f4d4b2 Stop using nsAreaFrame for anything other than xul:label, which is the only thing for which it does anything different from nsBlockFrame, and rename it accordingly. (Bug 471356) r+sr=roc
--HG--
rename : layout/generic/nsAreaFrame.cpp => layout/xul/base/src/nsXULLabelFrame.cpp
rename : layout/generic/nsAreaFrame.h => layout/xul/base/src/nsXULLabelFrame.h
2008-12-29 10:07:38 -05:00
Olli Pettay
c7eb44efac Bug 469720 - tabindex of -1 set in javascript ignored on file input, r+sr=bz 2008-12-17 09:33:33 +02:00
Boris Zbarsky
d674c8ca02 Bug 433616 part 1. Make it possible to create a document viewer with no parent widget or container, and make various code saner about handling null document/prescontext/documentviewer containers. r=roc, sr=jst 2008-09-28 15:14:28 -04:00
Boris Zbarsky
012ae72fd1 Backing out changesets 2ea77fa990af, 7d2d8869e73c, 93441e4f521e, 43d2ee100f3b, a2d84821ea71 to see whether they're causing the Windows Txul or Mac Tp regressions 2008-09-29 08:51:29 -04:00
Boris Zbarsky
10026a0921 Bug 433616 part 1. Make it possible to create a document viewer with no parent widget or container, and make various code saner about handling null document/prescontext/documentviewer containers. r=roc, sr=jst 2008-09-28 15:14:28 -04:00
Taras Glek
c26ce8e1ab bug 450777:deCOMtaminate nsNodeInfoManager::GetNodeInfo r+sr=jst 2008-09-12 15:32:18 -07:00
Robert O'Callahan
923872866b Bug 331088. Handle file-control frame being torn down while the dialog is up. r=smaug,sr=mats 2008-08-15 22:21:31 +12:00
jst@mozilla.org
54ae1d2978 Landing fix for bug 419716. Make us consistently deal how we're pass param tags to object tags when parsing XHTML. Patch by mrbkap@gmail.com and bent.mozilla@gmail.com, r+sr=jonas@sicking.cc, a=beltzner 2008-04-17 15:30:51 -07:00
timeless@mozdev.org
d7e775a7be Bug 394114 Interfaces missing from various QI implementations. r=jag sr=jag a=dsicore 2008-04-06 05:28:34 -07:00
timeless@mozdev.org
f33eb4a3b4 reverting, wrong patch, missing AMBIGUOUS 2008-03-19 14:55:22 -07:00
timeless@mozdev.org
8074fda8ae Bug 394114 Interfaces missing from various QI implementations. r=jag sr=jag a=dsicore 2008-03-19 14:19:35 -07:00
Olli.Pettay@helsinki.fi
84616fb3fc Bug 411212, cannot prevent file-picker from showing on <INPUT TYPE=FILE>, r+sr=roc+bzbarsky, a=mtschrep 2008-01-10 13:55:38 -08:00
reed@reedloden.com
3dac8e3cc2 Bug 409587 - "input[type="file"] cropped when narrow width specified" [p=kinetik@flim.org (Matthew Gregan) r+sr=roc a1.9=beltzner] 2008-01-07 14:18:06 -08:00
reed@reedloden.com
f1b1304be3 Bug 363696 - "Crash [@ nsHTMLReflowState::ComputeContainingBlockRectangle] with file upload control in xul" [p=kinetik@flim.org (Matthew Gregan) r=bzbarsky sr=roc a=blocking1.9+] 2007-11-26 19:35:50 -08:00
aaronleventhal@moonset.net
de32cb5f0a Bug 385070. Accessible subtrees for anonymous content need to be shut down. Patch by Evan Yan. r=aaronlev, r+sr=roc for layout part, a=dsicor 2007-11-20 12:39:36 -08:00
Evan.Yan@Sun.COM
42d1005186 back out patch of bug 385070 which broke accessible tree, to make nightly build safe 2007-11-16 01:12:58 -08:00
aaronleventhal@moonset.net
6c34d177ea Bug 385070. Nodes in anonymous content trees that are hidden not being shut down. Patch by Evan Yan. r=aaronlev, r+sr=roc, a=mconnor 2007-11-15 17:38:33 -08:00
neil@parkwaycc.co.uk
d3fd192a81 Bug 399968 Back out some parts from bug 258875 that have no effect r+sr+a=roc 2007-10-19 01:51:27 -07:00
aaronleventhal@moonset.net
56404d7111 bug 397644. File control not exposed correctly to a11y apis. r+sr+a=roc 2007-09-27 18:09:14 -07:00
bzbarsky@mit.edu
89ed6ace4a When a file has already been selected, correctly prefill the filepicker with that file. Bug 374013, r+sr=sicking, a=dbaron 2007-08-14 11:42:10 -07:00
bzbarsky@mit.edu
21e0d65a42 Introduce a setter for nsHTMLReflowState::mComputedHeight so that we're sure to
update the resize flags properly.  Bug 388084, r+sr+a=dbaron
2007-08-02 11:08:05 -07:00
bzbarsky@mit.edu
ebb6687f3d Update the visual look of a file input when privileged script sets its value.
Bug 387978, r+sr=sicking
2007-07-13 21:46:09 -07:00
jwalden@mit.edu
e3c4baccae Bug 348748 - Replace all instances of NS_STATIC_CAST and friends with C++ casts (and simultaneously bitrot nearly every patch in existence). r=bsmedberg on the script that did this. Tune in next time for Macro Wars: Episode II: Attack on the LL_* Macros. 2007-07-08 00:08:04 -07:00
mats.palmgren@bredband.net
db689821bf Cleanup implementations of QueryInterface. b=385750 r+sr=dbaron r+sr=jst 2007-07-03 19:15:31 -07:00
Olli.Pettay@helsinki.fi
7ec10e025c Bug 363089, Remove nsIDOMEventReceiver (this time passes mochitest), r+sr=jst 2007-05-14 02:11:38 -07:00
Olli.Pettay@helsinki.fi
f29b4e2b1b backout Bug 363089 2007-05-11 06:34:05 -07:00
Olli.Pettay@helsinki.fi
91a5c67cd1 Bug 363089, Remove nsIDOMEventReceiver, r+sr=jst 2007-05-11 04:15:11 -07:00
bzbarsky@mit.edu
2fd17c94d8 Rename nsIFrame::GetPresContext to nsIFrame::PresContext. Bug 376042, patch byTaras Glek <tglek@mozilla.com>, rs=roc. 2007-03-30 14:11:41 -07:00
hg@mozilla.com
465265d0d4 Free the (distributed) Lizard! Automatic merge from CVS: Module mozilla: tag HG_REPO_INITIAL_IMPORT at 22 Mar 2007 10:30 PDT, 2007-03-22 10:30:00 -07:00