Commit Graph

22 Commits

Author SHA1 Message Date
Karl Tomlinson
1b9df1cee4 b=481751 block-height line-height for text input and strut baseline for textarea r=bz,sr=dbaron
--HG--
extra : rebase_source : 1241360066ea9387d15c71936da9468399240640
2009-05-19 10:13:12 +12:00
L. David Baron
200ef7b5a1 Fix miscellaneous typos in comments that I've had in my tree for ages. 2009-04-22 10:13:48 -07:00
Benjamin Smedberg
24e7cb1f78 Bug 396185 - Make nsIFrame derivatives and helper abstract classes use a different dynamic-cast system than nsISupports:
* we know all types frames may be cast to at compile time, so instead of extensible GUID IIDs, use a big enum (see nsQueryFrame::FrameIID)
* eliminate all vestiges of refcounting, since frames aren't refcounted

Some frames (SVG frames in particular) still implement nsISupports-derived interfaces, for example nsISVGValue. There is a FrameIID for nsISVGValue that lets you go from a frame to the XPCOM interface, but you can't query back.

r+sr=roc

nsITextControlFrame didn't have an IID the first time around, but this wasn't a compile error because nsITextControlFrame::kFrameIID inherited from nsIFormControlFrame::kFrameIID. I've added a static analysis pass to verify the correct behavior, since I can't figure out a way to make the compiler do it.

--HG--
extra : rebase_source : 4894a2ca0278e2ab92f27459db77165f8348cf41
2009-01-12 14:20:59 -05:00
Benjamin Smedberg
50621e4f9f Backed out changeset 4c4df6ed1b41 - Bug 396185 - Make nsIFrame not inherit from nsISupports due to mochitest failures... these appear to be crashes in nsGenericHTMLElement::GetEditorInternal. 2009-01-09 11:35:24 -05:00
Benjamin Smedberg
d0b948876f Bug 396185 - Make nsIFrame derivatives and helper abstract classes use a different dynamic-cast system than nsISupports:
* we know all types frames may be cast to at compile time, so instead of extensible GUID IIDs, use a big enum (see nsQueryFrame::FrameIID)
* eliminate all vestiges of refcounting, since frames aren't refcounted

Some frames (SVG frames in particular) still implement nsISupports-derived interfaces, for example nsISVGValue. There is a FrameIID for nsISVGValue that lets you go from a frame to the XPCOM interface, but you can't query back.

r+sr=roc

This patch locally causes two REFTEST-UNEXPECTED-PASS for Bidi stuff. It's possible that I accidentally fixed a bug, but I'm not sure, so I'm going to wait for the tinderboxes to confirm my local results.
2008-11-05 14:25:30 -05:00
L. David Baron
2c2f6ed495 Change the binding parent for native anonymous content to work like the binding parent for XBL anonymous content, and be the parent of the anonymous content subtree rather than the root of the anonymous content subtree. (Bug 436453) r=bzbarsky,smaug,surkov sr=bzbarsky 2008-07-22 21:50:20 -07:00
Zack Weinberg
3197060cbd Delete nsLayoutUtils::GetAbsoluteCoord(); fold logic into callers and simplify. (Bug 437335) r+sr=dbaron 2008-07-17 16:37:12 -07:00
Robert O'Callahan
711fe3ad50 Backing out bug 421436 due to regression bug 439462 2008-06-17 10:39:30 +12:00
Robert O'Callahan
9915b4d25f Bug 421436. Remove hack that gives <br> 1-appunit width in standards mode; it's no longer necessary and it can cause subtle bugs. r+sr=dbaron 2008-06-14 20:48:07 +12:00
Robert O'Callahan
5cc4ce74b7 Bug 439004. Check whether there's logically empty content already placed on the line instead of just checking whether the line has advanced horizontally. r+sr=dbaron. 2008-06-14 20:28:07 +12:00
aaronleventhal@moonset.net
78b991a539 Bug 409473. New crash caused by bug 405248. r+sr=roc, a=blocking1.9 2008-01-14 06:34:40 -08:00
roc+@cs.cmu.edu
ccb6bf3bdb Bug 392829. Clean up nsLineLayout code that's not used (or at least used differently). r+sr+a=dbaron 2007-10-01 19:36:26 -07:00
roc+@cs.cmu.edu
bfd939088e Bug 96041. Compute precise glyph extents for high-quality text, and when requested. r=vlad,r+sr=dbaron 2007-09-23 19:19:14 -07:00
roc+@cs.cmu.edu
c11d00e32d Backing out due to test bustage 2007-09-22 06:28:16 -07:00
roc+@cs.cmu.edu
d72a839c93 Bug 96041. Compute true glyph bounding metrics. r=vlad,dbaron,sr=dbaron 2007-09-22 05:43:52 -07:00
roc+@cs.cmu.edu
f467e1f991 Bug 389421. Rework word selection, in particular so that layout.word_select.stop_at_punctuation is applied to boundaries between punctuation and non-punctuation, and all Unicode punctuation is treated as punctuation. 2007-08-29 20:10:19 -07:00
jwalden@mit.edu
e3c4baccae Bug 348748 - Replace all instances of NS_STATIC_CAST and friends with C++ casts (and simultaneously bitrot nearly every patch in existence). r=bsmedberg on the script that did this. Tune in next time for Macro Wars: Episode II: Attack on the LL_* Macros. 2007-07-08 00:08:04 -07:00
dbaron@dbaron.org
ad3d506605 Make text-indent contribute to intrinsic widths, and handle negative text-indent and negative margin properly by distinguishing forced and optional breaks when accumulating minimum widths. b=368155 r+sr=roc 2007-06-21 15:32:47 -07:00
dbaron@dbaron.org
93042a4e45 Don't propagate line layout in reflow state when we're not in the line. b=320502 r+sr=roc 2007-05-17 23:04:04 -07:00
bzbarsky@mit.edu
64c3e5df8a Make computed style handle eStyleUnit_Chars. Bug 371043, r+sr=dbaron 2007-05-04 23:09:50 -07:00
bzbarsky@mit.edu
685a823789 Make computed style handle "normal" for line-height by computing an actualnumeric height. Bug 371041, r+sr=dbaron 2007-05-04 22:30:10 -07:00
hg@mozilla.com
465265d0d4 Free the (distributed) Lizard! Automatic merge from CVS: Module mozilla: tag HG_REPO_INITIAL_IMPORT at 22 Mar 2007 10:30 PDT, 2007-03-22 10:30:00 -07:00