OS_LIBS for libraries that are not part of the gecko tree, EXTRA_LIBS for
libraries, such as NSPR, that are in the tree, but are not handled by
moz.build just yet. Those EXTRA_LIBS may also come from a system library.
However, in cases where the expanded variables are always empty for the
in-tree case, OS_LIBS is used (as for, e.g. MOZ_ZLIB_LIBS). OS_LDFLAGS is
used exclusively for non-library linker flags.
Always pass EXTRA_LIBS before OS_LIBS on linker command lines.
Forbid EXTRA_DSO_LDOPTS, SHARED_LIBRARY_LIBS and LIBS in Makefiles.
We're going to want to check whether a channel has an existing owner in some cases, but some channels currently assert if you just ask them whether they have an owner.
The -*- file variable lines -*- establish per-file settings that Emacs will
pick up. This patch makes the following changes to those lines (and touches
nothing else):
- Never set the buffer's mode.
Years ago, Emacs did not have a good JavaScript mode, so it made sense
to use Java or C++ mode in .js files. However, Emacs has had js-mode for
years now; it's perfectly serviceable, and is available and enabled by
default in all major Emacs packagings.
Selecting a mode in the -*- file variable line -*- is almost always the
wrong thing to do anyway. It overrides Emacs's default choice, which is
(now) reasonable; and even worse, it overrides settings the user might
have made in their '.emacs' file for that file extension. It's only
useful when there's something specific about that particular file that
makes a particular mode appropriate.
- Correctly propagate settings that establish the correct indentation
level for this file: c-basic-offset and js2-basic-offset should be
js-indent-level. Whatever value they're given should be preserved;
different parts of our tree use different indentation styles.
- We don't use tabs in Mozilla JS code. Always set indent-tabs-mode: nil.
Remove tab-width: settings, at least in files that don't contain tab
characters.
- Remove js2-mode settings that belong in the user's .emacs file, like
js2-skip-preprocessor-directives.
* * *
Bug 493701 - part 3: add and use a BackwardIterator::Remove method; r=bzbarsky
--HG--
extra : rebase_source : 87e4e490602c10d7c833179901d85b9e3901e727
* * *
Bug 493701 - part 3: add and use a BackwardIterator::Remove method; r=bzbarsky
--HG--
extra : rebase_source : c2d74a5605dd81907cf2e6412a2f4202451d4a1f
* Unify OS_FILE_ILLEGAL_CHARACTERS
* Provide KNOWN_PATH_SEPARATORS in addition to FILE_PATH_SEPARATOR.
* Update nsExternalAppHandler to use KNOWN_PATH_SEPARATORS instead of
FILE_PATH_SEPARATOR when removing path separators.
* Fix DownloadsIPC.jsm when compiling with MOZ_DEBUG (would throw on undefined download.id).
* Add test for stripping out illegal characters when downloading.
