Commit Graph

10 Commits

Author SHA1 Message Date
Matthew Schranz
87bb64c61e Bug 725289 - Removed moz prefix in Blob.mozSlice. r=sicking
--HG--
rename : dom/workers/test/fileReadMozSlice_worker.js => dom/workers/test/fileReadSlice_worker.js
rename : dom/workers/test/fileMozSlice_worker.js => dom/workers/test/fileSlice_worker.js
rename : dom/workers/test/test_fileReadMozSlice.xul => dom/workers/test/test_fileReadSlice.xul
rename : dom/workers/test/test_fileMozSlice.xul => dom/workers/test/test_fileSlice.xul
2012-02-16 11:22:25 +01:00
Matt Woodrow
4afe3a9c83 Bug 718334 - Fix some tests to make them work with Skia. r=roc 2012-01-23 14:08:17 +13:00
Malini Das
02665c9658 Bug 367393 - Add a packed MochiKit that contains only SimpleTest dependencies- plain 1/1. r=jmaher, a=test-only 2011-08-12 12:21:42 -04:00
Kyle Huey
601d68ae79 Bug 648997: Implement BlobBuilder spec as MozBlobBuilder. r=sicking.
Note that there is one key difference between this implementation and the spec.  In this patch MozBlobBuilder.getBlob("content/type"); returns a Blob and clears the MozBlobBuilder.  In the spec the BlobBuilder is not cleared.  Thus,

let bb = new MozBlobBuilder();
MozBlobBuilder.append("foo");
let blob1 = MozBlobBuilder.getBlob("content/type");
// blob1 contains "foo"
MozBlobBuilder.append("bar");
let blob2 = MozBlobBuilder.getBlob("content/type");
// blob2 contains "bar", the spec says it should contain "foobar".

IMO, the spec behavior optimizes for the wrong case.  BlobBuilder will probably be used mostly as a one-shot API.  Additionally, the spec requires the BlobBuilder to hang on to potentially large amounts of memory between the getBlob() call and when the BlobBuilder is GCd.

These issues have been raised on the listserv.
2011-05-20 10:18:45 -07:00
Kyle Huey
0018d52058 Backed out changeset b8404a1d3153 2011-05-20 17:00:13 -07:00
Kyle Huey
7da7ee7e4b Bug 648997: Implement BlobBuilder spec as mozBlobBuilder. r=sicking.
Note that there is one key difference between this implementation and the spec.  In this patch mozBlobBuilder.getBlob("content/type"); returns a Blob and clears the mozBlobBuilder.  In the spec the BlobBuilder is not cleared.  Thus,

let bb = new mozBlobBuilder();
mozBlobBuilder.append("foo");
let blob1 = mozBlobBuilder.getBlob("content/type");
// blob1 contains "foo"
mozBlobBuilder.append("bar");
let blob2 = mozBlobBuilder.getBlob("content/type");
// blob2 contains "bar", the spec says it should contain "foobar".

IMO, the spec behavior optimizes for the wrong case.  BlobBuilder will probably be used mostly as a one-shot API.  Additionally, the spec requires the BlobBuilder to hang on to potentially large amounts of memory between the getBlob() call and when the BlobBuilder is GCd.

These issues have been raised on the listserv.
2011-05-20 10:18:45 -07:00
Jonas Sicking
913afe451c Bug 649672: Make File.slice arguments match Array.slice and prefix File.slice. r=khuey 2011-04-13 14:34:36 -07:00
Serge Gautherie
e8f8328986 Bug 621414 - mochitests-1: test_fileapi_slice.html logs 12 _very_ (too) long lines; (Av1a) Better differentiate check logs, Stop generating raw-binary and/or over-long log lines.
rs=jonas a=(test only).
2011-01-05 12:35:55 +01:00
Jonas Sicking
6948fc9a18 Bug 609030: Update createBlobURL/revokeBlobURL to it's final name. r=jst a=blocker 2010-11-23 00:50:55 -08:00
Jonas Sicking
e7e13b2084 Bug 575946: Implement File.slice. r=khuey sr=biesi a=beltzner 2010-10-13 16:25:33 -07:00