Commit Graph

28 Commits

Author SHA1 Message Date
Patrick Brosset
81d28fa9c5 Bug 1213651 - Avoid server round-trips when displaying animated dom nodes; r=tromey
The main change here is that nodeFronts that have already been displayed
in the timeline are stored in a WeakMap so they can be retrieved from it
next time they're displayed and avoid a server-side round trip which, in
turn, causes the UI to flicker.

The other change is that now, it is possible to tell the animations actor
what is the current walker actor, which allows animation player actors to
directly send the NodeActor ID as part of their forms. Which, in most cases,
completely eliminates the server round-trip, because the corresponding
NodeFronts are already known on the client, so we get them from there.

The last change done here is that AnimationTargetNode now becomes a thin
wrapper on top of the new DomNodePreview component that was extracted so
it can be reused in other places.
2016-01-21 13:19:58 +01:00
Marco Bonardo
28fa46af58 Bug 1230471 - Basic eslint fixes in places. r=mconley 2015-12-10 06:46:49 -05:00
Georg Fritzsche
d1598486c5 Bug 1240091 - Enable linting on more toolkit modules. r=Mossop 2016-01-15 19:20:44 +01:00
Mark Banner
d78c368f6d Bug 1232707 - Build changes to support Loop imported as an add-on. r=mikedeboer,r=glandium 2016-01-14 17:53:32 +00:00
Dave Townsend
9a9c995e2e Bug 1231956: Add devtools to .eslintignore. r=pbrosset
Devtools has a lot of eslint failures right now that would block us from turning
on compile time eslint checks in bug 1229588. For now I'd like to just ignore
the directory and then you can work to clean up the warnings and re-enable
checks at whatever pace you like.
2016-01-11 14:28:54 -08:00
Dave Townsend
e95e6d463f Bug 1238781: Add pre-processed pref file to .eslintignore. r=felipe 2016-01-11 15:35:50 -08:00
Dave Townsend
7ce0e0df27 Bug 1237340: Fix browser and toolkit eslint failures. r=Felipe 2016-01-06 10:10:35 -08:00
Kris Maglione
adff616086 Bug 1230776: Support scripts from HTML files in eslint. r=gps
Also removes related unused variables in mach_commands.py.
2015-12-05 13:17:49 -08:00
Gijs Kruitbosch
267ab11843 Bug 1233492 - make browser/experiments eslintable, r=felipe 2015-12-17 19:42:24 +00:00
Gijs Kruitbosch
026227ff36 Bug 1233470 - make browser/modules eslintable, r=Mossop 2015-12-17 18:31:08 +00:00
Dave Townsend
a8294561b9 Back out the videocontrols piece of bug 1231828 due to b2g breakage and add to the ignore list. r=backout 2015-12-16 12:45:58 -08:00
Patrick Brosset
3a25a5d01b Bug 1229859 - Massively reduce the number of eslint errors in devtools by ignoring lib files, adding missing .eslintrc files and making some rules be warnings; r=Mossop 2015-12-10 15:46:32 -05:00
Robert Helmer
aa5747656e Bug 1230861 - remove add-ons manager from ESLint ignore file. r=mossop 2015-12-06 17:59:36 -08:00
Marco Bonardo
6c5284557e Bug 1230549 - Storage should pass more eslint rules. r=yoric 2015-12-04 17:00:03 +01:00
Kris Maglione
f80fb4d160 Bug 1229874: Part 3 - Enable ESLint in WebExtension code. r=billm
The base .eslintrc is essentially a merge of the root Toolkit .eslintrc and
the devtools .eslintrc, with some minor changes to match our prevalent style.

For the most enforces the coding styles that we've been using most
consistently. There are a couple of significant differences, though:

 * The rule for opening brace alignment can only be applied globally, and
   doesn't make exceptions for top-level functions. I chose to turn it on, and
   change the brace style of existing top-level functions that violated it,
   since the rule seemed worth using, and that's the direction most Toolkit JS
   code has been headed anyway.

 * The rule for switch/case statements requires an added indentation level for
   case statements. Most of our switch statements did not use an extra level
   of indentation, and I initially wrote the rule to enforce that style, until
   I came across case statements that used blocks, and required the extra
   indentation level for sanity.
2015-12-02 16:58:53 -08:00
Dave Townsend
571cd2744f Bug 1229519: Fix miscellaneous parts of toolkit to pass eslint checks. r=MattN 2015-12-03 10:02:45 -08:00
Dave Townsend
07d8547db4 Backed out 5161ded671e0 for causing Mulet failures 2015-12-03 20:01:43 -08:00
Dave Townsend
fb10bf6f67 Bug 1229519: Fix miscellaneous parts of toolkit to pass eslint checks. r=MattN 2015-12-03 10:02:45 -08:00
Wes Kocher
67553a15ae Merge m-c to fx-team, a=merge 2015-12-03 16:12:01 -08:00
Fabrice Desré
7f31dc18b2 Bug 1229620 - Replace #ifdefs in b2g/ code by AppConstants r=timdream 2015-12-03 09:14:07 -08:00
Robert Helmer
5ea55b3f3c bug 1228792 - remove addons manager from eslint ignore r=mossop 2015-12-02 18:41:58 -08:00
Felipe Gomes
f03bf6cd19 Bug 1229603 - Make most of browser/base lintable by removing non-standard syntax. r=Mossop 2015-12-02 17:51:26 -02:00
Michael Comella
5e8d648b31 Bug 1229433 - Ignore HomeProvider in eslint. r=nalexander 2015-12-01 10:06:52 -08:00
Mark Banner
8c586cb57d Bug 1229004 - Rename the libs directory to vendor in browser/extensions/loop/standalone/content. r=dmose 2015-12-01 14:47:50 +00:00
Mark Banner
b1da94ea1d Bug 1228628 - Add a minimal .eslintrc configuration for browser and start linting a few browser files with basic rules. r=Mossop 2015-11-30 11:42:25 +00:00
Phil Ringnalda
490fc101a5 Back out 343223ce6b34 (bug 1228628) for Experiments xpcshell bustage
CLOSED TREE
2015-11-27 20:55:17 -08:00
Mark Banner
c2c03779e5 Bug 1228628 - Add a minimal .eslintrc configuration for browser and start linting a few browser files with basic rules. r=Mossop 2015-11-27 22:37:38 +00:00
Dave Townsend
8735758c91 Bug 1228628: Move all eslintignore rules to the top-level of the tree. r=mconley 2015-11-27 09:39:59 -08:00