Commit Graph

835 Commits

Author SHA1 Message Date
Ms2ger
9414376b01 Bug 677101, part b - Remove nsContentUtils.h includes from headers; r=volkmar 2011-08-11 15:29:50 +02:00
Fabien Cazenave
d46ef85530 Bug 442186 - execCommand justify* fails on first line of contenteditable; r=ehsan
Given the way GetPromotedPoint / IsNodeInActiveEditor are designed, when the
selection is in the first child element of the active editing host the
selection is extended outside of editor node.

As a result, `GetNodesFromSelection' (which is called at the beginning of
`WillAlign') returns two nodes:
1. an empty text node, which is enclosed in a <div style="text-align: ***">;
2. the first child element, which is destroyed when it's a <div>;

Proposed solution:
#1 can be avoided by checking that the node is editable in `WillAlign';
#2 can be avoided by not dropping <div> blocks in `RemoveAlignment'.
This is an opportunity to simplify `RemoveAlignment' a bit.
2011-08-10 19:03:34 -04:00
Graeme McCutcheon
1e5935a446 Bug 483651 - Trailing <br> node not removed when it should be; r=ehsan 2011-08-12 15:53:10 -04:00
arno renevier
2485241198 Bug 338427 - Spellchecker should respect the langi attribute; r=ehsan 2011-08-12 15:12:45 -04:00
Ian Neal
081ca4e9b3 Test for Bug 291780 - List outdent is not working properly r=ehsan 2011-08-10 00:14:58 +01:00
Ian Neal
49689844b3 Test for Bug 290026 - Outdent of List does not work properly r=ehsan 2011-08-10 00:14:53 +01:00
Ehsan Akhgari
6690ac6ddf Merge the latest green changeset on mozilla-inbound to mozilla-central 2011-08-09 08:09:13 -04:00
Jan Varga
5020b003ce Bug 617528 Part 2 - Core implementation r=smaug
--HG--
rename : content/html/content/test/test_bug418756.html => content/html/content/test/test_checked.html
2011-08-08 19:31:32 +02:00
Fabien Cazenave
5dd43c9b97 Bug 674861 - contentEditable lists should not be splittable; r=ehsan
In design mode, pressing [Return] twice in a list (ol, ul, dl) splits the list
and inserts a paragraph. When the list is the active editing host, it should not
be split.
2011-08-02 15:04:43 -04:00
Henri Sivonen
0176915bb7 Bug 596182 - Make fragment parsers global. Remove resulting dead code. r=Olli.Pettay, r=bzbarsky. 2011-08-01 10:48:24 +03:00
Henri Sivonen
147c3287ec Bug 482909 part 2 - Implement an HTML/SVG/MathML sanitizer independently of parsers or serializers. r=bzbarsky. 2011-07-29 14:48:04 +03:00
Michael Wu
6a28121ce1 Bug 671417 - Incorrect use of PRBool when other types are more appropriate or vice versa, r=bz,ehsan,dwitte,joe,vlad,luke,mak,roc 2011-07-26 23:43:37 -07:00
Fabien Cazenave
0999dbd2e1 Bug 620319 - crash [@ nsHTMLEditor::GetInlinePropertyBase] if !aAttribute; r=ehsan
Adds a null check to avoid dereferencing a null pointer.

--HG--
extra : rebase_source : 75b97cafad2318af60956d88d12da51a00224949
2011-07-26 18:09:12 -04:00
Fabien Cazenave
bf28416694 Bug 620283 - crash [@ nsHTMLEditor::RemoveStyleInside] if !aAttribute; r=ehsan
Adds a null check to avoid dereferencing a null pointer.

--HG--
extra : rebase_source : ba8bfcabbc2f17b0b0cea1d90dbed54a8471bad9
2011-07-26 18:08:55 -04:00
Fabien Cazenave
9e280efb90 Bug 460740 - [contentEditable] invalid results when pressing Enter in a bunch of different cases; r=ehsan
In some situations, pressing Enter in a contentEditable node fails:
 * in an editable paragraph, list item or header, pressing Enter
   creates another editable block;
 * in an inline editable node, pressing Enter does nothing.

That's because nsHTMLEditRules::WillInsertBreak doesn't check for the active
editing host. This patch should fix it.
2011-07-26 17:38:23 -04:00
Jonathan Kamens
e4101fc489 Bug 489202 - selection moves to top when html containing meta, link, or style elements is pasted or inserted; r=ehsan 2011-07-26 13:59:50 -04:00
Michael Wu
706be3a5e8 Bug 671185 - Incorrect return of NS_ERROR_* codes in functions returning PRBool, r=mak,ehsan,taras,biesi,pike,khuey,dholbert,josh,bjacob,bsmith 2011-07-25 21:57:58 -07:00
Fabien Cazenave
2c92600954 Bug 688599 - do not expand selection for deletion outside of the active editing host; r=ehsan
When a selection in an inline element is to be deleted, it is first expanded to
the parent block in order not to leave any empty inline element. This patch
ensures that the selection cannot be expanded outside of the contentEditable
element (active editing host).
2011-07-25 17:11:46 -04:00
Ehsan Akhgari
cadef9ec48 Merge mozilla-central and mozilla-inbound 2011-07-24 12:52:51 -04:00
Joel Maher
344f4a7302 Bug 666654 - split eventutils.js functions that are chrome only into chromeutils.js. r=ted, a=test-only 2011-07-23 09:02:40 -04:00
Ms2ger
2a3176b2ee Bug 666665 - Remove isindex content code; r=sicking+hsivonen 2011-07-23 11:45:38 +02:00
Fabien Cazenave
81bff8a94d Bug 449243 - contentEditable: insert <p> instead of <br>; r=ehsan
In editable elements, create a paragraph instead of a <br> node
when [Return] is pressed:
 * once in a header node (<h[1..6]>);
 * twice in a list item node (<li>).
2011-07-22 12:19:17 -04:00
Joel Maher
c3a05191bb Bug 666649 - remove enablePrivilege from various places in the harness and chrome tests. r=ted, a=test-only 2011-07-21 16:21:25 -04:00
Mounir Lamouri
2e1dfaef9e Bug 669310 - Fixes various includes and forward declarations. f=Ms2ger r=jst 2011-07-20 12:18:54 -07:00
Ehsan Akhgari
ee5215c7a6 Revert to changeset e0ce7821fce1 because the latest push broke all of the builds DONTBUILD 2011-07-19 16:25:54 -04:00
Mounir Lamouri
5937d63965 Bug 669310 - Fixes various includes and forward declarations. f=Ms2ger r=jst 2011-07-19 11:22:43 -07:00
Mounir Lamouri
b088e154d6 Backed out bug 669310, bug 668013, bug 667887 and bug 669886 due to build bustage. 2011-07-19 10:49:48 -07:00
Mounir Lamouri
d2f5a3b4c3 Bug 669310 - Fixes various includes and forward declarations. f=Ms2ger r=jst 2011-07-18 17:05:10 -07:00
arno renevier
ba6b969048 Bug 417418 - do not treat context click as double click anymore in editor; r=ehsan 2011-07-18 14:42:56 -04:00
Ehsan Akhgari
13c7a908e4 Backout changeset 65e0d40a57b7 (bug 417418) because of unit test failure 2011-07-18 16:29:22 -04:00
arno renevier
89a10e6166 Bug 417418 - do not treat context click as double click anymore in editor; r=ehsan 2011-07-18 14:42:56 -04:00
Ehsan Akhgari
a6b5feed16 Bug 671672 - Reduce a bunch of console spam in debug builds caused by the HTML editor; r=roc 2011-07-14 17:06:37 -04:00
Ehsan Akhgari
4a9dec68d7 Bug 414526 - Backspace at the beginning of a contenteditable element or delete at the end of one should not affect the rest of the contenteditable elements on the page; r=roc
The main fix here involves the introduction of the nsHTMLEditor::IsNodeInActiveEditor
API.  This API returns true if the current selection in the document falls
inside the active editable section.  The patch adds a bunch of checks using
this API to various places in the code to make sure that editing operations do
not escape their editing host.

There are also some unrelated fixes to range promotion code which fix the
bugs that have existed in that code before, but because of the lack of this
check were not uncovered before.

This patch also removes the nsTextEditUtils::InBody API which only made sense
in designMode documents, and was insufficient for contenteditable elements.
2011-07-14 11:25:07 -04:00
Ms2ger
7a41ef9f3e Bug 670499 - Make nsEditor::CreateEventListeners return void; r=ehsan 2011-07-15 12:18:35 +02:00
Simon Montagu
ae37ce037d Undefine caret bidi level during reflow instead of on text entry. Bug 664087, r=roc 2011-07-05 08:42:32 +03:00
Jonas Sicking
5491caaaf4 Bug 661297 Part 1: Remove Add/RemoveEventListenerByIID API. r=smaug 2011-08-08 11:26:26 -07:00
Ehsan Akhgari
c6e514aa14 Bug 549262 - Enable the (shift-)space shortcut key for scrolling up/down in pages containing editable elements; r=roc
--HG--
extra : rebase_source : 99706dd2e678052b345b011ea76f17370ad1a227
2010-09-06 16:59:41 -04:00
Ehsan Akhgari
beba2dbb1d Bug 439808 - Make sure that deleting a selection works in inline contenteditable elements which have a non-editable parent block; r=roc
--HG--
extra : rebase_source : 74d3df996b904032696000daa532d217140d3b2d
2011-06-29 21:01:59 -04:00
Jonas Sicking
cc14f402b6 Bug 663461 Part 1: Remove Add/RemoveEventListenerByIID from editor. r=smaug 2011-06-27 16:34:54 -07:00
Wolfgang Germund
db7ef51c94 Bug 664095 - Remove the override stylesheets when the editor is detached from the document as opposed to when it's destroyed for compatibility with the expected behavior from Composer; r=ehsan 2011-06-24 13:55:43 -04:00
Jonas Sicking
5e5e6bd544 Bug 658714 Part 10: Remove nsIDOM3EventTarget/nsIDOMEventGroup. r=smaug 2011-06-23 19:18:02 -07:00
Jonas Sicking
864793d608 Bug 658714 Part 9: Don't use EventGroups for system-group. r=smaug 2011-06-23 19:18:02 -07:00
Jonas Sicking
26f99e3cdb Bug 658714 Part 7: DeCOMtaminate nsEventListenerManager. r=smaug 2011-06-23 19:18:01 -07:00
Jonas Sicking
6a04ff1d9f Bug 658714 Part 6: Fixups after search'n'replace s/nsPIDOMEventTarget/nsIDOMEventTarget/. r=smaug 2011-06-23 19:18:01 -07:00
Jonas Sicking
e3f6b769a1 Bug 658714 Part 5: Search'n'replace nsPIDOMEventTarget to nsIDOMEventTarget. r=smaug 2011-06-23 19:18:00 -07:00
Jonas Sicking
8fed9108b1 Bug 658714 Part 1: Merge nsPIDOMEventTarget into nsIDOMEventTarget. r=smaug,bent 2011-06-23 19:17:58 -07:00
Ehsan Akhgari
38dc29243c Merge the last green changeset on mozilla-inbound to mozilla-central 2011-06-20 16:06:04 -04:00
Ed Morley
576fc154e6 Bug 665359 - Remove unused variable res from nsHTMLEditor::AddPositioningOffset; r=ehsan
DONTBUILD
2011-06-20 14:53:51 -04:00
Ehsan Akhgari
49d9a2f639 Bug 660199 - Avoid using invalid C++ casts when registering/unregistering editor event listeners; r=roc 2011-06-20 09:55:22 -04:00
Joel Maher
a184675917 Bug 664165 - move editor/libeditor/html/tests/test_contenteditable_text_input_handling.html to mochitest-chrome. r=masayuki, a=test-only 2011-06-19 11:56:44 -04:00
Masayuki Nakano
db1e5b26fa Bug 664437 editor should use mozilla::Preferences r=ehsan 2011-06-17 09:59:29 +09:00
Jonas Sicking
17ec46a39a Bug 659053 Part 1: Merge nsIDOM3Node into nsIDOMNode. Also removes Node.getFeature. r=peterv 2011-06-14 00:56:48 -07:00
Matt Brubeck
830f102cc9 Bug 663959 - Mark crashtests as asserting intermittently [r=ehsan] 2011-06-13 14:24:04 -07:00
Joel Maher
5b6fcbed46 Bug 663215 - move test_selection_move_commands.xul to mochitest-chrome. r=roc, a=test-only 2011-06-10 11:11:45 -04:00
Dominic Fandrey
0ab2f46136 Bug 645398 - Substitute PR_(MAX|MIN|ABS|ROUNDUP) macro calls; r=roc 2011-06-02 14:56:50 +02:00
Masayuki Nakano
85c451e309 Bug 660121 Remove all pref related methods from nsContentUtils r=roc 2011-05-29 08:42:57 +09:00
Ms2ger
35e44f908f Bug 659113 - Remove nsIDOMNSHTMLDocument; r=bz 2011-05-28 09:43:57 +02:00
Ehsan Akhgari
01360016f7 Bug 634406 - Don't select past the trailing BR node in text fields when performing the SelectAll operation; r=roc 2011-05-25 16:30:14 -04:00
Ehsan Akhgari
319dc53b8e Bug 658516 - nsHTMLEditRules.cpp:5810:52: warning: comparison between signed and unsigned integer expressions. r=roc
--HG--
extra : rebase_source : 6772483c9ca0eb23444850db1f30f0144516a861
2011-05-25 10:10:45 +02:00
Masayuki Nakano
49814a538d Bug 659536 part.2 Replace nsContentUtils::GetIntPref() with Preferences::GetInt() or Preferences::GetUint() r=roc 2011-05-25 15:32:00 +09:00
Ms2ger
d823c7ef2c Bug 657210 - Address review comment 2011-05-23 18:54:57 +02:00
Ms2ger
c36c459144 Bug 657210 - Outparamdel nsEditor::GetPresShell; r=ehsan 2011-05-22 14:43:13 +02:00
Craig Topper
4e38ca20a7 Bug 658143 - Part 1: Changes nsCOMPtr<nsFrameSelection> to nsRefPtr. r=roc 2011-05-18 20:10:49 -07:00
Ms2ger
3388f3994d Bug 657160 - Remove NS_NewCaret; r=ehsan,roc 2011-05-15 12:17:09 +02:00
Ms2ger
48b02e4f5a Bug 657160 - Remove NS_NewTextEditRules; r=ehsan 2011-05-15 12:16:45 +02:00
Ms2ger
63679730f9 Bug 657160 - Remove NS_NewHTMLEditRules; r=ehsan 2011-05-15 12:15:35 +02:00
Ms2ger
f828b0aa18 Bug 656996 - Remove NS_NewHTMLCSSUtils; r=ehsan 2011-05-15 12:07:30 +02:00
Ms2ger
d5df8a6e33 Bug 655514 - Remove nsIDOMDocumentTraversal; f=ehsan r=jonas 2011-05-15 12:07:30 +02:00
Ehsan Akhgari
15252ef290 Bug 612129 - Set the initial selection range to the beginning of the text field in order to be more compatible with other browsers; r=roc 2011-05-12 09:52:38 -04:00
Masayuki Nakano
9a56e9598d Bug 655918 Clean up the composition string when whole characters of it are refused due to maxlength r=ehsan 2011-05-11 13:52:45 +09:00
Ed Morley
082d53f39b Bug 655756 - Remove final XP_MAC remnants; r=josh 2011-05-10 20:24:48 +02:00
Mounir Lamouri
7211c91c57 Bug 514437 - Content part of the progress element. r=smaug 2011-04-09 10:22:02 -07:00
Matt Brubeck
1b17575132 Back out changeset bfb48178c8ec (finish backing out bug 514437) to fix tests on a CLOSED TREE. 2011-05-09 19:38:05 -07:00
Jonas Sicking
549cf0a0a2 Bug 643786. Don't fire DOMNodeRemoved when removing the editor created <br>. r=ehsan 2011-05-09 12:33:04 -07:00
Jonas Sicking
0e17979856 Bug 650493 Part 1: Simplify mutation events by firing all but DOMNodeRemoved off of script runners, and DOMNodeRemoved before starting any update batches or aquiring any state. r=smaug/peterv 2011-05-09 12:33:03 -07:00
Mounir Lamouri
dd977ba6ef Bug 514437 - Content part of the progress element. r=smaug 2011-04-09 10:22:02 -07:00
Sebastian Kromp
d80897722a Bug 633750 - deCOM nsIHTMLEditRules and move methods to nsHTMLEditRules. r=ehsan 2011-05-07 10:04:56 +02:00
Ed Morley
81db8d5e09 Bug 654737 - Remove WinCE code from editor/*; r=ehsan 2011-05-06 11:05:57 +02:00
Ms2ger
941e819c63 Bug 616684 - Remove support for DOM Views; r=sicking,ehsan 2011-04-24 08:54:25 +02:00
Neil Rashbrook
fefcb1dbbc Bug 647682 Can't copy and paste local links in <editor> documents r=ehsan f=bz 2011-04-28 20:59:45 +01:00
Ehsan Akhgari
d2a61eb331 Backout changeset 13f6847dd840 (bug 616684) because it changes code semantics in a bad way, which results in problems like the crash in bug 652580, possibly among others 2011-04-25 17:05:17 -04:00
Ms2ger
295bf7256b Bug 616684 - Remove support for DOM Views; r=sicking 2011-04-24 08:54:25 +02:00
Mounir Lamouri
db44db0ebe Merge cedar with mozilla-central. 2011-04-22 15:25:11 +02:00
David Zbarsky
5ecf0a2bd3 Bug 610305: decom nsEventStateManager r=smaug 2011-04-21 19:35:52 +02:00
Ehsan Akhgari
540b4161a5 Bug 649797 - Rewrite the test for bug 600570 in a way that doesn't trigger the assertion which can never happen on the web; r=roc
--HG--
extra : rebase_source : 8f21974f360f1e9806a1b7cfefb7d1733513d22f
2011-04-21 10:25:34 -04:00
Mounir Lamouri
b4cf8cd184 Backed out changeset c1a7c1bc1aeb due to busted build. 2011-04-20 22:26:06 +02:00
David Zbarsky
c4d29900ed Bug 610305: decom nsEventStateManager r=smaug 2011-04-20 21:42:33 +02:00
Ehsan Akhgari
680e9b757e Bug 649012 - Fix some flaky mochitests which rely on non-zero timeout values; rs=ted 2011-04-16 19:39:34 -04:00
Ehsan Akhgari
c1e4d5e196 Backed out changeset d407ee4dabcc because it causes some tests to go orange 2011-04-16 23:47:06 -04:00
Ehsan Akhgari
3938fc6c75 Bug 649012 - Fix some flaky mochitests which rely on non-zero timeout values; rs=ted 2011-04-16 19:39:34 -04:00
Ehsan Akhgari
1eafc52dd0 Bug 650083 - nsEditor.cpp:1147: warning: unused variable 'rv'; r=roc 2011-04-14 23:45:24 -04:00
Ehsan Akhgari
f9088e8fe4 Bug 649566 - @keyframe(s) missing from <style> sanitizing code in nsHTMLFragmentContentSink; r=bzbarsky 2011-04-13 18:12:32 -04:00
Ehsan Akhgari
4153f12b55 Bug 617539 - Remove nsIEditor_MOZILLA_2_0_BRANCH; r=roc 2011-04-11 16:00:32 -04:00
Peter Van der Beken
afdf1551f1 Fix for bug 584048 (Clean up cycle collection code) - remove NS_IMPL_CYCLE_COLLECTING_ADDREF_AMBIGUOUS/NS_IMPL_CYCLE_COLLECTING_RELEASE_AMBIGUOUS. r=bent. 2011-03-06 12:11:31 +01:00
Ehsan Akhgari
b4def61223 Bug 646194 - Fix the bound checking when deleting previous words to prevent crashes when the caret is at the beginning of an editable area; r=roc 2011-04-06 11:28:08 -07:00
Sebastian Kromp
c90dd3913b Bug 633066: Remove nsICiter and make nsInternetCiter a static class. r=ehsan 2011-03-31 07:32:13 -04:00
Kyle Huey
29d5f43cb5 Merge m-c to bs. 2011-03-31 07:17:15 -04:00
Ehsan Akhgari
5199d98d91 Bug 645914 - Do not eat the white-space when doing word selection if the eaten whitespace is a newline character and we have been instructed not to jump between lines; r=roc
This fixes a bug in selecting words at the end of lines in textarea's for Windows.
2011-03-30 11:56:48 -04:00
Kyle Huey
75ee2642d1 Merge m-c to bs. 2011-03-26 12:12:37 -04:00
Ehsan Akhgari
b50ffe71b6 Bug 611457 - Move the object which is supposed to survive the function's return out of the function so that a possible garbage collection doesn't collect it before it should be used; r=roc a=test-only 2011-03-12 00:07:37 -05:00
Ehsan Akhgari
b8feac7449 Bug 618041 - Move the object which is supposed to survive the function's return out of the function so that a possible garbage collection doesn't collect it before it should be used; r=roc a=test-only 2011-03-12 00:11:01 -05:00
Ehsan Akhgari
af800fd6a1 Bug 636465 - Reset the spellchecking override status when detaching an editor object from the content node; r,a=roc 2011-03-01 15:04:42 -08:00
Neil Rashbrook
42274702a1 Bug 635420 - Clicking on content within Normal tab of Composer and stops switching to other tabs; r=ehsan a=bsmedberg 2011-02-28 13:04:05 -08:00
Jesse Ruderman
75fe047e55 Add bug number to comment. a=NPOTB DONTBUILD 2011-02-24 13:43:48 -08:00
Ehsan Akhgari
1989a9bf06 Bug 636074 follow-up: move the assertion count adjustment because a test was added in between 2011-02-23 15:28:33 -08:00
Kyle Huey
d50f7a5a54 Bug 636107 - Part 2: Maintain better hygiene by not passing uninitialized pointer values around; r=ehsan a=blocking-final+ 2011-02-23 07:20:58 -05:00
Ehsan Akhgari
bcb0f84a06 Bug 636074 - Part 1: Forget the transaction pointer when creating transaction objects in order to pass it to the caller instead of swapping it with random values; r=roc a=blocking-final+ 2011-02-23 14:22:07 -08:00
Ehsan Akhgari
c6ae64d9aa Bug 635757 - Adjust the assertion count as a result of bug 633738; r=roc a=test
DONTBUILD this simple assertion annotation adjustment!
2011-02-21 23:53:40 -05:00
Mats Palmgren
7958218e24 Bug 635636 - Don't return a value from void function. a=bustage 2011-02-21 21:43:54 +01:00
Mats Palmgren
b765f11bf5 Bug 635636 - Crash [@ nsHTMLEditRules::DocumentModifiedWorker] with navigated-away designMode document; r,a=ehsan 2011-02-21 15:34:16 -05:00
Ehsan Akhgari
075288f489 Bug 635532 - Don't try to hide the editor anonymous UIs during the cycle collection unlink phase needlessly. r=roc,jst, a=blocker 2011-02-19 21:43:07 -08:00
Kyle Huey
8408dbe11c Bug 633709: Actually commit the test. r+a=ehsan 2011-02-19 18:40:52 -05:00
Kyle Huey
da2a416c73 Bug 633709: Convert bogus assert into a warning. r+a=ehsan
--HG--
extra : rebase_source : 5928d5a4309bd98e0cf4cd3041f36ba64d992706
2011-02-19 17:49:23 -05:00
Kyle Huey
846a72981f Bug 633709: Fix editor's handling of txn objects. r+a=ehsan
--HG--
extra : rebase_source : c44055ca4378a8213e3b60b61b16df8dd9758a88
2011-02-19 17:18:37 -05:00
Kyle Huey
015e84ddd4 Bug 633709: Test.
--HG--
extra : rebase_source : 6bae5d01331df279551577606806fc35d91993a3
2011-02-19 17:04:26 -05:00
Peter Van der Beken
2552abd64a Fix for bug 633738 (quora.com bloats out of control (part 3)) - mark some known assertions caused by bug 439258. r=bz, a=jst. 2011-02-17 12:19:13 +01:00
Peter Van der Beken
d78216fbaf Fix for bug 633738 (quora.com bloats out of control (part 3)) - make nsHTMLEditor participate in CC, clear editor from SHistory if we're not storing anything else. r=jst, a=jst. 2011-02-16 13:07:47 +01:00
Serge Gautherie
c690e45a6f Bug 634626 - test_bug366682 failures because spellchecking is disabled; (Bv1) s/CR+LF/LF/g, Remove ending whitespaces.
r=jmaher (a=test-only).
DONTBUILD
2011-02-17 20:19:35 +01:00
Ehsan Akhgari
4d76d777f1 Back out changeset 0fd8793db7f3 (bug 633738) because of various oranges in different test suites on multiple platforms; a=orange 2011-02-14 18:45:23 -05:00
Peter Van der Beken
b9ca9b2552 Fix for bug 633738. Fix leak due to session history code keeping an editor alive too long. Patch by peterv and bz, r=jst@jstenback.com, a=blocker 2011-02-14 14:26:14 -08:00
Mounir Lamouri
d33f310364 Bug 629845 (2/2) - GetRoot() returning null isn't unexpected. r=ehsan a=blocking-final 2011-02-11 02:01:49 +01:00
Mounir Lamouri
350253af3e Bug 629845 (1/2) - Don't make nsHTMLDocument::EditingStateChanged fails if BeginningOfDocument fails. r=ehsan a=blocking-final 2011-02-11 01:59:37 +01:00
Ehsan Akhgari
9bd0f72c58 Bug 336091 - Initialize the out parameters of nsEditor::GetStartNodeAndOffset correctly; r,a=roc
--HG--
extra : rebase_source : 7ae5b960263f2412c21b0cbcebf6f95a4ddb2e73
2011-02-09 14:07:56 -05:00
Ehsan Akhgari
fa1dcf4c12 Bug 632326 - Synthesize a Paste command instead of calling the internal goDoCommand in the test for bug 520189; r=roc a=test-only 2011-02-08 21:50:51 -05:00
Ehsan Akhgari
395dbdf918 Merge cedar into mozilla-central 2011-03-25 14:21:07 -04:00
Benjamin Smedberg
92bd44c461 Bug 617539 - Remove branch interfaces, nsIHTMLEditor_MOZILLA_2_0_BRANCH, straight backout of revision e9d979b4b4a0, r=ehsan 2011-03-25 11:03:33 -04:00
Matheus Kerschbaum
255f1d6b3c Bug 634807 - Remove MOZ_PLAINTEXT_EDITOR_ONLY; r=khuey 2011-03-24 19:59:00 -04:00
arno renevier
0a36ca716b Bug 497115 - nsHTMLEditor.cpp contains unnecessary includes; r=peterv sr=peterv 2011-03-23 23:23:39 -04:00
Ehsan Akhgari
eaafa97906 Test case for bug 638596; r=roc 2011-03-04 13:44:25 -08:00
Ehsan Akhgari
8d74540d77 Test case for bug 635636; r=roc 2011-02-21 16:58:07 -05:00
Ehsan Akhgari
d98dd1278c Bug 642704 - Part 3: Remove test_set.py because it confuses our mochitest suite runner, and we don't need it to run the BrowserScope RichText2 suite; r=roc 2011-03-19 16:45:29 -04:00
Ehsan Akhgari
11e4fe7769 Bug 642704 - Part 2: Add a test driver to run the BrowserScope RichText2 test suite as a mochitest; r=roc 2011-03-19 16:44:30 -04:00
Ehsan Akhgari
705f18833c Bug 642704 - Part 1: Import the BrowserScope RichText2 test suite files into the tree; r=roc 2011-03-18 18:15:24 -04:00
Ehsan Akhgari
ba2ed13afe Bug 642588 - Clean up the drag & drop caret on the editor correctly when the mouse leaves the editable field; r=roc 2011-03-18 14:57:02 -04:00
Ehsan Akhgari
e4ad8f774b Bug 640321 - Register the mouse event handlers for the editor in the system group; r=roc 2011-03-16 15:34:30 -04:00
Ehsan Akhgari
7a77702d1e Bug 641466 - Correct the array bounds checking so that the last surrogate pair in a textbox can be deleted correctly; r=roc 2011-03-16 15:34:29 -04:00
Ehsan Akhgari
b528286d7e Bug 639695 - Reconnect the HTML editor to the new presentation of a contenteditable document when it changes; r=roc
This fixes things such as the caret not showing up after the presshell for a
document containing a contenteditable element is recreated.
2011-03-11 18:45:20 -05:00
Ehsan Akhgari
c06813a2c5 Bug 407127 - Part 6: Remove the presshell argument to nsIEditor::Init as it's no longer necessary; r=roc 2011-03-11 00:40:31 -05:00
Ehsan Akhgari
c504ea4d07 Bug 407127 - Part 5: Fix the editor to not rely on cached presshells and selection controllers, because they may not always be valid; r=roc 2011-03-11 00:40:31 -05:00
Ehsan Akhgari
bb48d9cae8 Bug 407127 - Part 4: Avoid using the presshell needlessly because it may not always be available; r=roc 2011-03-11 00:40:30 -05:00
Ehsan Akhgari
343b9d2aa6 Bug 407127 - Part 3: Get the selection controller for HTML editors from the presshell, instead of holding on to a presshell reference masked as a selection controller; r=roc 2011-03-11 00:40:30 -05:00
Ehsan Akhgari
6ef553932d Bug 407127 - Part 2: Refactor the editor so that it only touches mSelConWeak in GetSelectionController, to make removing it for HTML editors easier; r=roc 2011-03-11 00:40:30 -05:00
Ehsan Akhgari
586a904360 Bug 407127 - Part 1: Refactor the editor so that it only touches mPresShellWeak in GetPresShell, to make removing it easier; r=roc 2011-03-11 00:40:30 -05:00
Boris Zbarsky
890788b82e Bug 632904. Check IsEditable(), not content states, if we care about editability. r=ehsan,masayuki 2011-03-23 10:45:21 -04:00
Chris Jones
8991442744 Rollup of bug 615386, parts 1-6. Teach the reftest harness about <browser remote>. r=dbaron,roc,ted a=a
--HG--
rename : layout/tools/reftest/reftest.js => layout/tools/reftest/reftest-content.js
2011-02-03 13:54:10 -06:00
Chris Leary
86d81ea3d6 Merge tracemonkey to mozilla-central. (a=blockers) 2011-01-31 19:43:36 -08:00
Jonas Sicking
6c6a7cea3e Disallow content access to chrome functions without __exposedProps__ (bug 628410, r=gal). 2011-01-29 18:47:17 -08:00
Ehsan Akhgari
561113cc04 Bug 628980 - browserscope richedit tests load http://www.google.com/intl/en_ALL/images/logo.gif over the network; r=roc a=NPOTB 2011-01-27 00:26:33 -05:00
Ehsan Akhgari
b1d2463ed9 Bug 629172 - Fix the regression in switching the text input direction using Cmd/Ctrl+Shift+X; r=roc a=blocking-final+
--HG--
extra : rebase_source : 57471865db00c1efa07bb746df42de8278027b36
2011-01-27 00:26:33 -05:00
Ehsan Akhgari
3f40511a92 Bug 626411 - Selecting a section of URL, then clicking "Delete" stays at refresh, instead of "go"; r=roc a=blocking-final+
--HG--
extra : rebase_source : 09c7a68d030c819afe7086fe22f2c83620e881eb
2011-01-19 19:25:03 -05:00
Ehsan Akhgari
bde6418f39 Bug 625452 - Make sure all plaintext editor commands generate trusted input events; r=roc a=blocking-final+ 2011-01-15 23:16:45 -05:00
Ehsan Akhgari
d48edb3f7d Bug 622371 - Only set the selection to the beginning of the editable document if the editor is being initialized by entering designMode; r=bzbarsky a=blocking-final+ 2011-01-06 17:13:51 -05:00
Ehsan Akhgari
b3f2d74515 Bug 620906 - Back out part of bug 289384 to make sure that scrollbars work in CKEditor fields again; r=roc a=blocking-final+ 2011-01-11 16:00:44 -05:00
timeless@mozdev.org
186210bc44 Bug 620423 - nsHTMLEditor::ParseCFHTML foolishly checks aStuffToPaste instead of *aStuffToPaste; r=neil a=roc 2011-01-11 10:20:31 -05:00
Ehsan Akhgari
3d3c16632b Bug 623193 - Fennec crash [@ nsEditor::InsertTextIntoTextNodeImpl ]; r,a=roc 2011-01-09 20:14:58 -05:00
Jonathan Kew
a9323f7452 bug 332636 - fix editor's handling of surrogate-pair combining marks with backspace. r=ehsan a=roc 2010-12-16 14:17:41 -08:00
Ehsan Akhgari
22f13c2a13 Bug 527935 - Part 4: Make sure that the input event after paste operations; r=roc a=blocking-final+ 2010-12-17 14:47:11 -08:00
Ehsan Akhgari
9a4fb543ef Bug 527935 - Part 3: Generate the input event for editor IME transaction commits if needed; r=roc a=blocking-final+ 2010-12-17 14:47:11 -08:00
Ehsan Akhgari
393e54e609 Bug 527935 - Fire the input event for text controls with the correct trusted-ness status; r=roc a=blocking-final+ 2010-12-07 01:30:05 -05:00
Jonathan Kew
6531a7f776 Backed out changeset 1958ebae93cc for causing mochitest orange. a=backout 2010-12-16 15:15:35 -08:00
Jonathan Kew
7a31c3e079 bug 332636 - fix editor's handling of surrogate-pair combining marks with backspace. r=ehsan a=roc 2010-12-16 14:17:41 -08:00
Shawn Wilsher
ade39d2c6a Merge mozilla-central to Places. 2010-12-13 15:08:04 -08:00
Shawn Wilsher
5f893d748b Merge mozilla-central into Places. 2010-12-07 15:06:32 -08:00
Shawn Wilsher
2ed7d826a8 Merge mozilla-central into Places 2010-12-06 09:48:54 -08:00
Shawn Wilsher
9cdab945a8 Merge mozilla-central into Places. 2010-11-29 08:43:57 -08:00
Ehsan Akhgari
1935188b81 Bug 616590 - Prevent documents loaded in mail editors to set up their own editors using the designMode or contentEditable APIs; r=bzbarsky a=blocking-final+ 2010-12-06 14:27:14 -05:00
Ehsan Akhgari
f6d6332349 Bug 612625 - intermittent orange: test_bug607584.xul continues executing after we've left the page, mostly showing up in test_bug171813.html; r=roc a=test-fix 2010-11-17 18:23:18 -05:00
Ehsan Akhgari
2c680fd98b Bug 612565 - Don't recurse into document modification listeners for editable documents if the modification to the document is made on the bogus BR node; r=roc a=blocking-beta8+
This fixes an unresponsive script dialog error for Etherpad pages (possibly among other websites).
2010-11-16 15:43:46 -05:00
Ehsan Akhgari
04410d797d Bug 609632 followup: Make dropping arbitrary image files on editable areas actually work; r=roc a=blocking-beta8+ 2010-11-16 13:54:31 -05:00
Ehsan Akhgari
6d13ead610 Bug 609632 - More embarrassments, shame on me; a=shameful-ehsan 2010-11-15 18:13:25 -05:00
Ehsan Akhgari
4c0a7351e5 Bug 609632 - Build bustage fix; a=bustage
--HG--
extra : rebase_source : 7ee1c79f086687781405bdcd8567924d674e3711
2010-11-15 18:01:45 -05:00
Ehsan Akhgari
46c9a77f82 Bug 609632 - Insert image files dropped onto editable areas as data: URI images; r=roc a=blocking-beta8+
--HG--
extra : rebase_source : 7ec1941c8052c352e6304fd8affe89d890b1ae1b
2010-11-06 18:49:26 -04:00
Ehsan Akhgari
00d37a174f Bug 611182 - Part 7: Don't notify the edit rules object for document modifications outside of the editable area; r=bzbarsky a=blocking-beta8+ 2010-11-13 15:12:15 -05:00
Ehsan Akhgari
9cd1d8318f Bug 611182 - Part 6: Actually allow the bogus node to be deleted from the document, and check if the parent is modifiable when inserting an element to prevent a bogus node being inserted under a contenteditable="false" element; r=bzbarsky a=blocking-beta8+
This fixes a failure in layout/reftests/bugs/579985-1.html, and is tested by it.
2010-11-12 10:38:14 -05:00
Ehsan Akhgari
8571ba00c8 Bug 611182 - Part 4: Add some more tests; r=bzbarsky a=blocking-beta8+ 2010-11-11 16:40:55 -05:00
Ehsan Akhgari
8376c423de Bug 611182 - Part 3: Handle dynamic changes to the editable documents and create/remove the bogus node if needed; r=bzbarsky a=blocking-beta8+ 2010-11-11 16:40:52 -05:00
Ehsan Akhgari
0450182992 Bug 611182 - Part 2: Correct the definition of EndOfDocument for the HTML editor in order to fix some tests which have been relying on the bogus node existing in non-empty editable documents; r=bzbarsky a=blocking-beta8+ 2010-11-11 16:40:55 -05:00
Ehsan Akhgari
81e5001ae0 Bug 611182 - Backspace key does not work without typing something first (test cases); r=bzbarsky a=blocking-beta8+ 2010-11-11 14:09:09 -05:00
Ehsan Akhgari
bb6861f7b5 Bug 601881 - video and audio should never play automatically in editor; r=bzbarsky,cpearce a=bsmedberg
--HG--
rename : content/media/test/test_play_events.html => content/media/test/test_autoplay_contentEditable.html
2010-10-14 20:13:29 -04:00
Ehsan Akhgari
0908325de2 Bug 551704 - Part 5: Move breakIsVisible to nsIHTMLEditor_MOZILLA_2_0_BRANCH to make sure that nsIHTMLEditor does not change for Gecko 2.0; r=bzbarsky a=blocking-betaN+
This patch should be backed out on trunk when Gecko 2.0 has been branched.
2010-11-09 21:00:26 -05:00
Ehsan Akhgari
cea63fedad Bug 551704 - Part 4: Set the selection to the beginning of the document when we're entering the design mode; r=bzbarsky a=blocking-betaN+ 2010-11-08 18:30:28 -05:00
Ehsan Akhgari
844dd2ffc0 Bug 551704 - Part 3: Don't copy invisible BR nodes to the clipboard for editable elements, to make us more compatible with WebKit and Opera; r=bzbarsky a=blocking-betaN+ 2010-11-06 18:49:26 -04:00
Ehsan Akhgari
472326895e Bug 551704 - Part 2: Don't replace newline characters with BR nodes in preformatted editable fields; r=roc a=blocking-betaN+ 2010-11-06 18:49:26 -04:00
Ehsan Akhgari
e588665b2b Bug 551704 - Part 1: Don't initialize the selection needlessly if the editable area is not focused; r=roc a=blocking-betaN+ 2010-11-06 18:49:26 -04:00
Ehsan Akhgari
311cff87c3 Bug 372345 - [Midas] text cursor overrides CSS mouse cursor styles for some elements; r=bzbarsky a=blocking-final+
--HG--
extra : rebase_source : 502e9561f1a91464b8de502eb44098ab126d3930
2010-10-29 12:30:15 -04:00
Ms2ger
859896ba2e Bug 606717 - Comparison between signed and unsigned integers in nsTextEditRules::CollapseSelectionToTrailingBRIfNeeded; r=ehsan a=bsmedberg 2010-11-04 16:45:39 -04:00
Ms2ger
1dc17b150a Bug 605177 - Fix a number of build warnings in editor/; r=ehsan a=bsmedberg 2010-11-04 16:44:46 -04:00
Ehsan Akhgari
e810187573 Bug 512717 - Don't handle files being dropped in an editable area; r=peterv f=sicking a=bsmedberg 2010-11-02 22:57:17 -04:00
Ehsan Akhgari
fe769d8443 Bug 607584 - Part 3: HTML test case; r=roc a=test-only 2010-10-29 13:01:49 -04:00
Daniel Glazman
0e38cc4a77 Bug 607584 - Part 2: XUL test case; r=ehsan a=test-only 2010-10-29 12:36:21 -04:00
Daniel Glazman
ac5d79b1f8 Bug 607584 - CR in a paragraph with an id attribute creates a second paragraph of same id; r=ehsan a=roc 2010-10-29 12:35:27 -04:00
Ehsan Akhgari
26b56e6566 Bug 542317 - Caret missing when an iframe is put into design mode when it already has focus; r=roc a=blocking-final+ 2010-10-29 12:30:52 -04:00
Ehsan Akhgari
a3d62c2955 Bug 603292 - PRUint32 countU < 0 is useless in nsHTMLEditor::AddNewStyleSheetToList; r=roc a=bsmedberg 2010-10-12 18:30:41 -04:00
Ehsan Akhgari
c5d807f1c7 Bug 605138 - Scripts from topix.net apparently causing page to scroll down when opening; r=roc a=blocking-final+ 2010-10-21 16:56:20 -04:00
Ehsan Akhgari
22cdd2dc8b Bug 606295 - Don't attempt to remove the edit action listener from nsPlaintextEditor's dtor; r,a=roc 2010-10-22 16:51:06 -04:00
Ehsan Akhgari
1bd8b7c9e7 Bug 613130 - Don't sanitize style nodes and attributes in the sanitizing parser if we have not found any unsafe properties; r=roc,bzbarsky a=blocking-final+ 2010-11-24 13:31:52 -05:00
Neil Deakin
2eeca289de Bug 527749 - Drag events out of order; r=smaug,dao a=blocking-betaN+ 2010-12-03 11:19:55 -05:00
Ehsan Akhgari
11b6d633e6 Bug 615015 followup - Adjust the assertion count which now happens in editor/libeditor/html/crashtests/467647-1.html too; a=orange-fix 2010-12-03 11:15:06 -05:00
Ehsan Akhgari
ed92562d68 Bug 615015 - "ASSERTION: bad action nesting!"; r,a=roc
--HG--
extra : rebase_source : 3e972a7f5dad81b5cba1b8ee93c16798fdc809c2
2010-12-01 00:24:09 -05:00
Ehsan Akhgari
ef612c0f0a Bug 615450 - Prevent the reinitialization of the HTML editor while an editor operation is in progress on a document; r,a=roc
This should prevent crashes, update view count and edit action nesting count mismatches, and more!

--HG--
extra : rebase_source : af1397b3c8de19d936ca70690a6f7ed284cc5d00
2010-11-30 23:21:32 -05:00