Commit Graph

57 Commits

Author SHA1 Message Date
Masayuki Nakano
553922eee1 Bug 554822 Caret should refer the actual text color instead of the value of CSS color property r=roc 2010-04-01 11:35:48 +09:00
Masayuki Nakano
313a3bd180 Bug 554822 backout the previous patch 2010-04-01 02:31:06 +09:00
Masayuki Nakano
55bbbc0a73 Bug 554822 Caret should refer the actual text color instead of the value of CSS color property r=roc 2010-04-01 02:12:43 +09:00
Craig Topper
1921815643 Bug 253889: DeCOMtaminate nsIPresShell - IsPaintingSuppressed(). r=roc
--HG--
extra : rebase_source : 9ee8283e8bce33402893ae5316f89c9f699a1236
2010-03-31 08:43:49 -04:00
Kyle Huey
afc6c6ca2d Backed out changeset 4b8936ac4a31 2010-03-30 19:56:44 -04:00
Craig Topper
6c9540a26d Bug 253889: More deCOMtamination of nsIPresShell. r=roc 2010-03-28 19:21:11 -04:00
Mats Palmgren
3d99a509c5 Bug 544852, part 4: Add nsCaret::GetGeometryForFrame. r=roc 2010-03-14 23:56:26 +01:00
Mats Palmgren
6490d07773 Bug 544852, part 3: Merge UpdateHookRect into UpdateCaretRects. r=roc 2010-03-14 23:54:11 +01:00
Mats Palmgren
cdfd5e672d Bug 544852, part 2: Use nsCaret::GetGeometry. r=roc 2010-03-14 23:52:45 +01:00
Mats Palmgren
549893b6d7 Bug 544852, part 1: Remove nsCaret::GetCaretCoordinates. r=roc 2010-03-14 23:52:07 +01:00
Robert O'Callahan
f07ee1400d Bug 539323. Position the caret at the content-edge of its container frame, not the border-edge. r=mats 2010-03-05 11:52:59 +13:00
Mats Palmgren
fa91c35561 Null-check the root pres context result. Unregister the plugin frame earlier, at Stop instead of Destroy time. b=521426 r=roc 2010-01-26 14:10:12 +01:00
Robert O'Callahan
492587f2be Bug 526394. Part 24: Create sane nsCaret::GetGeometry API to obsolete nsCaret::GetCaretCoordinates. r=mats 2010-01-12 10:45:16 +13:00
Robert O'Callahan
07db346518 Bug 526394. Part 20: Convert more code in caret and docshell. r=mats 2009-09-09 17:40:02 +12:00
Mats Palmgren
00302efc79 Flag nsCaret::mPendingDraw if the on-cycle draw was suppressed; update the caret when the pres shell tells us that painting is unsuppressed. b=520720 r=roc 2009-10-16 12:55:32 +02:00
Mats Palmgren
31d408bca4 Adjust the caret y-position for zero-height inlines. b=503531 r=roc 2009-09-29 23:07:05 +02:00
Mats Palmgren
948203eb7d Replace PR_MIN/PR_MAX with NS_MIN/NS_MAX. b=512106 r=roc 2009-09-16 17:01:36 +02:00
Robert O'Callahan
10c5d8e3f1 Bug 352093. Part 8: Fix view returned for eToplevelWindowCoordinates. r=bzbarsky 2009-07-22 12:45:07 +12:00
Peter Van der Beken
58e796a645 Fix for bug 308736 (Caret is invisible when entering an empty designmode field.). r/sr=roc.
--HG--
extra : rebase_source : ef79a8ef7cb96c0efcdccc967370fcdf8f07eba4
2009-06-19 18:31:49 +02:00
Robert O'Callahan
19082bf736 Bug 406646. Make sure to only search *visible* popups for mouse event targets. r=enndeakin
--HG--
extra : rebase_source : bd0825d6a6469a10dcdd9e4ae9e9c91dcbafbe99
2009-02-24 21:25:25 +13:00
Benjamin Smedberg
24e7cb1f78 Bug 396185 - Make nsIFrame derivatives and helper abstract classes use a different dynamic-cast system than nsISupports:
* we know all types frames may be cast to at compile time, so instead of extensible GUID IIDs, use a big enum (see nsQueryFrame::FrameIID)
* eliminate all vestiges of refcounting, since frames aren't refcounted

Some frames (SVG frames in particular) still implement nsISupports-derived interfaces, for example nsISVGValue. There is a FrameIID for nsISVGValue that lets you go from a frame to the XPCOM interface, but you can't query back.

r+sr=roc

nsITextControlFrame didn't have an IID the first time around, but this wasn't a compile error because nsITextControlFrame::kFrameIID inherited from nsIFormControlFrame::kFrameIID. I've added a static analysis pass to verify the correct behavior, since I can't figure out a way to make the compiler do it.

--HG--
extra : rebase_source : 4894a2ca0278e2ab92f27459db77165f8348cf41
2009-01-12 14:20:59 -05:00
Benjamin Smedberg
50621e4f9f Backed out changeset 4c4df6ed1b41 - Bug 396185 - Make nsIFrame not inherit from nsISupports due to mochitest failures... these appear to be crashes in nsGenericHTMLElement::GetEditorInternal. 2009-01-09 11:35:24 -05:00
Benjamin Smedberg
d0b948876f Bug 396185 - Make nsIFrame derivatives and helper abstract classes use a different dynamic-cast system than nsISupports:
* we know all types frames may be cast to at compile time, so instead of extensible GUID IIDs, use a big enum (see nsQueryFrame::FrameIID)
* eliminate all vestiges of refcounting, since frames aren't refcounted

Some frames (SVG frames in particular) still implement nsISupports-derived interfaces, for example nsISVGValue. There is a FrameIID for nsISVGValue that lets you go from a frame to the XPCOM interface, but you can't query back.

r+sr=roc

This patch locally causes two REFTEST-UNEXPECTED-PASS for Bidi stuff. It's possible that I accidentally fixed a bug, but I'm not sure, so I'm going to wait for the tinderboxes to confirm my local results.
2008-11-05 14:25:30 -05:00
Simon Montagu
89eb38e82f Fix compiler warnings in nsCaret.cpp. Bug 470574, r+sr=dbaron 2008-12-28 04:08:22 -08:00
Simon Montagu
70d49c14fa Make display of the directional hook on the caret dependent on the bidi.browser.ui pref. Bug 418513, r=uriber, sr=roc (for core) r=mano, gavin.sharp (for browser) 2008-12-14 01:05:39 -08:00
Robert O'Callahan
f79290bb0e Bug 450930. Fire a DOM event when painting so that content and chrome can track what's being repainted. r=smaug,sr=dbaron 2008-09-18 21:47:21 +12:00
Arpad Borsos
eef0edf9d5 Bug 454766 - Add suggested parentheses to layout/; r+sr=roc; (with nits by sgautherie) 2008-09-15 17:40:25 +02:00
Oleg Romashin
8e95c02743 Bug 453826 - MOZ_XUL define required for nsCaret::IsMenuPopupHidingCaret. r+sr=roc 2008-09-08 15:23:38 +03:00
Masayuki Nakano
41bdf942b6 Bug 449955 – Remove #ifdef of nsCaret.cpp for IME r+sr=roc 2008-08-13 10:55:39 +09:00
John Daniels
ef0fee1d70 Bug 419532 – deCOMtaminate nsICaret. r+sr=roc 2008-07-16 12:52:01 +02:00
Karuna (karunasagark@gmail.com)
22a214272c Bug 409331. Instead of QIing to nsBlockFrame in various places, call an nsLayoutUtils method to do it. r+sr=roc 2008-07-14 10:10:23 +12:00
Michael Ventnor
fc2e1b57c0 Bug 118308, NS_THEME_TEXTFIELD_CARET implementation (GTK), r+sr=roc 2008-06-23 11:50:52 +03:00
Simon Montagu
dfcf9f51e9 Remove unnecessary argument from SetBidiEnabled. Bug 435856, r+sr=roc 2008-06-16 02:28:17 -07:00
gavin@gavinsharp.com
29184ef30a Bug 430785: Caret not visible with right-clicking on a text input, patch by Martijn Wargers <martijn.martijn@gmail.com>, r+sr=roc, a=damon 2008-04-30 09:54:16 -07:00
roc+@cs.cmu.edu
fd6e0971c3 Bug 335359. Make the caret thicker when it's at a Kanji character. r+sr=mrbkap,a=damon 2008-04-22 20:13:55 -07:00
roc+@cs.cmu.edu
24c2f98e82 Bug 420987. The caret size should be specified in CSS pixels and it should be rounded like borders --- rounding down to the nearest device pixel, but not down to zero. r+sr=mrbkap,a=schrep 2008-04-14 14:09:23 -07:00
reed@reedloden.com
9eb7749c18 Bug 427163 - "Crash [@ nsContentUtils::ContentIsDescendantOf] with contenteditable, right-clicking and document.write" (add null check) [p=chris@pearce.org.nz (Chris Pearce [cpearce]) r+sr=roc a1.9=damons] 2008-04-08 23:16:09 -07:00
reed@reedloden.com
daf0485896 Bug 420499 - "Caret browsing mode wrongly engaged" (Mochitest) [p=chris@pearce.org.nz (Chris Pearce [cpearce]) r+sr=roc a=blocking1.9+] 2008-04-08 11:52:48 -07:00
reed@reedloden.com
c0dd86e5fd Bug 420499 - "Caret browsing mode wrongly engaged" [p=chris@pearce.org.nz (Chris Pearce [cpearce]) r+sr=roc a=blocking1.9+] 2008-04-01 01:35:11 -07:00
roc+@cs.cmu.edu
bc1e698534 Bug 400057. Make nsBlockInFlowLineIterator useful for finding the line containing a frame, searching across block continuations and their overflow lines. Use it in various places, especially in textrun construction. r+sr=dbaron 2008-02-27 01:53:48 -08:00
reed@reedloden.com
d36fe99b43 Bug 394473 - "caret/cursor in View Source is invisible since 20070628 {not rendered, seen, can't, cannot, shown, displayed}" [p=chris@pearce.org.nz (Chris Pearce [cpearce]) r=peterv r+sr=roc a1.9=beltzner] 2008-02-26 17:49:46 -08:00
Olli.Pettay@helsinki.fi
2976ce8f18 Bug 368760, r=mats, sr=roc, a=blocking1.9+ 2007-11-22 12:47:33 -08:00
reed@reedloden.com
42fe9864cd Bug 394473 - "caret/cursor in View Source is invisible since 20070628 {not rendered, seen, can't, cannot, shown, displayed}" [p=cpearce r=peterv sr=roc a1.9=schrep] 2007-11-12 21:42:52 -08:00
roc+@cs.cmu.edu
912edaa201 Bug 403048. Be more careful about looking for the line containing the caret. r+sr=mrbkap 2007-11-08 17:59:20 -08:00
reed@reedloden.com
5dbce5ddb5 Bug 336408 - Allow the caret to be positioned at the end of trimmed whitespace, as if the whitespace wasn't trimmed [p=roc r=smontagu sr=mrbkap a=blocking1.9+] 2007-11-07 20:07:00 -08:00
tglek@mozilla.com
fdf793303e Clean up prbool misuse in layout. bug 398312, r+sr+a=dbaron 2007-10-09 17:00:05 -07:00
joshmoz@gmail.com
7c16a06018 remove XP_MAC usage. b=281889 r=cbarrett sr=roc a=roc 2007-10-01 16:20:37 -07:00
philringnalda@gmail.com
48c8d7714f Bug 390423 - Simplify the signature of nsIFrame::GetPointFromOffset, patch by Ben Karel <web+moz@eschew.org>, r=aaronlev/elif, sr=roc, a1.9=dbaron 2007-08-16 20:43:00 -07:00
mrbkap@gmail.com
3aef7dc520 Redragging over empty text field doesn't show drag caret, except for the last text field. bug 390228, r+sr=roc a=dbaron 2007-08-13 14:33:25 -07:00
mrbkap@gmail.com
0154383393 Clamp the caret's position so that we always draw within the nearest scrollframe. Not doing this allows the scrollframe to clip the caret, causing it to not show up at all. bug 335560, r+sr=roc 2007-08-13 13:51:16 -07:00