Commit Graph

2744 Commits

Author SHA1 Message Date
masayuki@d-toybox.com
3ea5191188 Bug 421353 Moving the mouse over text hyperlinks which become underlined spikes cpu usage r=roc+stuart, sr=roc, a1.9=beltzner 2008-03-29 14:25:15 -07:00
masayuki@d-toybox.com
1ff185aac0 Bug 424989 Cannot use reconversion of IMEs from system menu at the focus being on textarea r+sr=roc, b1.9=jonas 2008-03-29 12:38:05 -07:00
stefanh@inbox.com
d0fc5ed166 Bug 420726 - Use system background color for odd tree rows. ui-r=beltzner, r=josh+Mano, sr=roc, a1.9=beltzner. 2008-03-29 04:43:31 -07:00
reed@reedloden.com
601e529c06 Back out Robert O'Callahan's patch from bug 421885 due to reftest failure. 2008-03-28 02:32:03 -07:00
reed@reedloden.com
ddba94bd6d Bug 421885 - "Google reader search results have strange red line and broken border around them" [p=roc@ocallahan.org (Robert O'Callahan [roc]) r=vlad a=blocking1.9+] 2008-03-28 01:54:27 -07:00
reed@reedloden.com
7ffca204c7 Bug 421885 - "Google reader search results have strange red line and broken border around them" [p=roc@ocallahan.org (Robert O'Callahan [roc]) r=vlad a=blocking1.9+] 2008-03-28 01:40:02 -07:00
jruderman@hmc.edu
80bd571b8c Add reftests for the Wikipedia jiggling text bug. 2008-03-27 23:08:16 -07:00
karlt+@karlt.net
1b91c2f7bb Add mroot and bevelled mfrac width tests. 2008-03-27 15:52:58 -07:00
karlt+@karlt.net
ff916b3fa4 Correction to mroot width calculation. b=363240 r+sr=roc 2008-03-27 15:47:08 -07:00
uriber@gmail.com
93c58b6cbd Only join ancestor inline frames for frames that are last children. bug=424631, r=smontagu, sr=dbaron, blocking1.9=vladimir 2008-03-27 12:27:32 -07:00
dtownsend@oxymoronical.com
d4be62f77d Marking test from bug 424074 as failing on linux 2008-03-27 02:17:19 -07:00
jruderman@hmc.edu
27d6d56cb6 Add crashtest 2008-03-27 00:03:22 -07:00
joshmoz@gmail.com
2b63edc0c2 Scrollbar thumb is drawn with wrong size for custom scrollbars. b=424074 r=josh sr=vlad 2008-03-26 22:36:20 -07:00
bmlk@gmx.de
ce0b61a41b lookup all columns for possible originating cells, bug 423514 r/sr=bzbarsky a=mtschrep 2008-03-26 22:03:02 -07:00
jruderman@hmc.edu
7f27919501 Add crashtest 2008-03-26 21:53:01 -07:00
jruderman@hmc.edu
18ef573771 Adding crashtest 2008-03-26 21:27:43 -07:00
jruderman@hmc.edu
e06fb83304 Add crashtests 2008-03-26 21:09:57 -07:00
jruderman@hmc.edu
227e680d84 Add crashtest 2008-03-26 21:06:24 -07:00
jruderman@hmc.edu
79d9a4aa5f Add a crashtest. 2008-03-26 20:59:36 -07:00
jruderman@hmc.edu
d928e86923 Add crashtest. 2008-03-26 20:55:48 -07:00
jruderman@hmc.edu
3cba3d9d9a Add crashtest 2008-03-26 20:52:06 -07:00
jruderman@hmc.edu
79c3f5e7d6 Add crashtest 2008-03-26 20:33:09 -07:00
jruderman@hmc.edu
c46802513e Add reftest 2008-03-26 20:25:24 -07:00
jruderman@hmc.edu
9173f6ba79 Add crashtests 2008-03-26 20:23:23 -07:00
jruderman@hmc.edu
1732cb4d46 Adding a crashtest. 2008-03-26 19:57:55 -07:00
jruderman@hmc.edu
e1ea66f86c Adding crashtest 2008-03-26 18:03:02 -07:00
jruderman@hmc.edu
9b816f15d4 Add crashtest 2008-03-26 17:28:43 -07:00
jruderman@hmc.edu
f66480d963 Add crashtests 2008-03-26 17:24:55 -07:00
bent.mozilla@gmail.com
c83d448e96 Bug 425289 - "Mousing over plugins on Mac/Linux leaks and prevents plugin from shutting down". r+sr=jst, a=schrep. 2008-03-26 17:24:31 -07:00
jruderman@hmc.edu
f2aede83f9 Add reftest (mostly for an assertion, but also making sure it's blank) 2008-03-26 17:01:27 -07:00
jruderman@hmc.edu
a2e7301a9f Add crashtest 2008-03-26 16:54:47 -07:00
jruderman@hmc.edu
1b8ebfc7ac Add a crashtest. 2008-03-26 16:31:18 -07:00
jruderman@hmc.edu
106aa88b4f Add crashtest 2008-03-26 16:27:23 -07:00
jruderman@hmc.edu
9f6fd24893 Add crashtest. 2008-03-26 15:03:26 -07:00
jruderman@hmc.edu
c8d7a3eaca Add crashtest 2008-03-26 14:31:37 -07:00
karlt+@karlt.net
4e6626ae86 Prefix msqrt with a multiplier as Mac's font and antialiasing causes the radical symbol to affect two pixels to the left of content by up to 8/256. 2008-03-25 21:47:17 -07:00
karlt+@karlt.net
c5b3380c6e Bug 363240 - incorrect MathML <mtable> width and position (nsMathMLContainerFrames have zero preferred width Test widths of table cells with msqrt, mfenced, and stretchy mo, and mo with l/rspace. 2008-03-25 20:39:36 -07:00
jonas@sicking.cc
ab63e6a20a fix redness, forgot this part 2008-03-25 19:59:16 -07:00
karlt+@karlt.net
a2ecae57ca Need some space between the overline and "h" for Mac's fonts and antialiasing. 2008-03-25 19:51:45 -07:00
karlt+@karlt.net
a15b004ac1 Bug 421955: combining mark at start of text run rendered as NUL hex box or garbage 2008-03-25 18:30:39 -07:00
reed@reedloden.com
4167b1253b Bug 423385 - "floating parent does not size correctly with floating child using negative margin" [p=roc@ocallahan.org (Robert O'Callahan [roc]) r+sr=dbaron a1.9b5=beltzner] 2008-03-25 16:19:46 -07:00
uriber@gmail.com
a35f550c56 Reftest for bug 423676 2008-03-25 13:07:16 -07:00
mats.palmgren@bredband.net
0400be05d0 Track event loop nesting level and delay stopping a plugin until it's safe. b=420886 r+sr=jst a1.9b5=beltzner 2008-03-25 09:56:04 -07:00
gavin@gavinsharp.com
1acf9eb941 reftest adjustments for bug 417178 (pending r=dbaron/roc) 2008-03-25 09:50:30 -07:00
reed@reedloden.com
5e63772b54 Back out Robert O'Callahan's patch from bug 423385 due to mochitest failure. 2008-03-24 23:26:53 -07:00
reed@reedloden.com
9d3d47e5fe Bug 417178 - "Google reader does not show subscribed topics in ff3b3 at certain zoom levels" [p=roc@ocallahan.org (Robert O'Callahan [roc]) r+sr=dbaron a1.9b5=mconnor] 2008-03-24 21:55:47 -07:00
reed@reedloden.com
1791d22006 Bug 423385 - "floating parent does not size correctly with floating child using negative margin" [p=roc@ocallahan.org (Robert O'Callahan [roc]) r+sr=dbaron a1.9b5=beltzner] 2008-03-24 21:50:12 -07:00
dholbert@cs.stanford.edu
2de08e5ba8 Bug 423599: Make native theming stuff use full padding when in XUL, and reduced padding when in HTML. Patch by _FrnchFrgg_ <frnchfrgg-mozbugs@altern.org>, r=ventron sr=vlad a1.9b5=beltzner. Reftest by me, r=bz a1.9b5=beltzner 2008-03-24 17:34:27 -07:00
reed@reedloden.com
afc1413921 Back out Robert O'Callahan's patch from bug 417178 due to mochitest failure. 2008-03-24 01:41:13 -07:00
reed@reedloden.com
cbe8463a59 Bug 423676 - "weirdness with layout and selection of mixed-direction text" [p=uriber@gmail.com (Uri Bernstein) r=smontagu sr=roc a1.9b5=schrep] 2008-03-24 00:30:49 -07:00
reed@reedloden.com
11f6a8b813 Bug 417178 - "Google reader does not show subscribed topics in ff3b3 at certain zoom levels" [p=roc@ocallahan.org (Robert O'Callahan [roc]) r+sr=dbaron a1.9b5=mconnor] 2008-03-24 00:29:30 -07:00
jst@mozilla.org
14b80d26bc Landing followup fix for bug 402983 and re-enabling the new stricter file URI security policies. r+sr=bzbarsky@mit.edu 2008-03-22 09:50:47 -07:00
dbaron@dbaron.org
ba6523bcb0 Add a code comment from work on 413027. 2008-03-21 21:50:58 -07:00
dbaron@dbaron.org
59589b592c Some more grid reftests from work on 413027. 2008-03-21 21:49:51 -07:00
bmlk@gmx.de
230b1fc082 use the firstinflow when looking up rowgroups bug 424291 r/sr=bzbarsky a=mtschrep 2008-03-21 13:37:31 -07:00
Olli.Pettay@helsinki.fi
8ef915d47c Bug 395609, r=roc+sicking, sr=sicking, a=beltzner 2008-03-21 04:18:10 -07:00
uriber@gmail.com
a48e811e61 follow-up on bug 423130 to fix Windows breakage 2008-03-21 01:39:16 -07:00
uriber@gmail.com
82137ae23b In bidi resolution, convert inline bidi continuations not at the end of a bidi run into fluid continuations. bug=423130 r=smontagu sr=dbaron a19b5=dsicore 2008-03-21 01:17:41 -07:00
dbaron@dbaron.org
75424965d9 Add bug number for failing tests. 2008-03-20 20:19:28 -07:00
dbaron@dbaron.org
0cfa54de30 Add additional tests with opacity to exercise the cases where we construct TableBackgroundPainters from row or row group frames. 2008-03-20 20:05:21 -07:00
dbaron@dbaron.org
06705510dc Additional fix on top of roc's patch for bug 421069 to fix the regression it caused. r=dholbert approval1.9b5=damon 2008-03-20 18:19:13 -07:00
dbaron@dbaron.org
128863679e Don't do translation during table border painting. b=421069 Patch by Robert O'Callahan <roc@ocallahan.org>. r+sr=dbaron approval1.9b5=damon 2008-03-20 18:18:30 -07:00
dbaron@dbaron.org
0f9e43b689 Add some reftests for table background painting. (These tests catch the regression from the previous patch in bug 421069.) 2008-03-20 18:17:09 -07:00
dbaron@dbaron.org
f4e917a5d5 Add reftests for bug 421069. 2008-03-20 18:15:40 -07:00
Olli.Pettay@helsinki.fi
6d32891dbb Bug 421209, r=cpearce, sr=jst, a=beltzner 2008-03-20 13:24:36 -07:00
dbaron@dbaron.org
c633f035a4 Backing out bug 421069 (which I landed earlier today for roc) because it caused bug 424016. 2008-03-19 22:58:00 -07:00
dholbert@cs.stanford.edu
e70fa35d2a Bug 423345: Use mIsCreatingPrintPreview, not mIsDoingPrintPreview, to check if we're setting up a print-preview page. r+sr=vlad a=blocking1.9+ 2008-03-19 16:04:40 -07:00
dbaron@dbaron.org
9e7d833654 Don't do translation during table border painting. b=421069 Patch by Robert O'Callahan <roc@ocallahan.org>. r+sr=dbaron 2008-03-19 16:02:38 -07:00
dbaron@dbaron.org
03a41137b3 Add another reftest for 413027. 2008-03-19 15:31:45 -07:00
dbaron@dbaron.org
9c075744cf Add some basic reftests for XUL grid. 2008-03-19 15:29:31 -07:00
dbaron@dbaron.org
f31447da64 Fixing asymmetry between what timeless landed for bug 394114 and what he backed out. 2008-03-19 15:05:04 -07:00
timeless@mozdev.org
f33eb4a3b4 reverting, wrong patch, missing AMBIGUOUS 2008-03-19 14:55:22 -07:00
timeless@mozdev.org
90f2f08b18 reverting 2008-03-19 14:44:51 -07:00
jwatt@jwatt.org
b74560ae07 Bug 421584. SVG that is filtered does not repaint correctly when filtered elements change/move. Patch by Robert Longson longsonr@gmail.com, r=jwatt@jwatt.org, sr=roc@ocallahan.org, a=blocking1.9 2008-03-19 14:27:33 -07:00
timeless@mozdev.org
8074fda8ae Bug 394114 Interfaces missing from various QI implementations. r=jag sr=jag a=dsicore 2008-03-19 14:19:35 -07:00
dholbert@cs.stanford.edu
203b5735e3 Bug 417356: Define & use "UnwriteableMargin" PrintSettings pref, to make Linux printing work more like Mac printing (keeping us from printing right up against the edge of the page) Orig Patch: [r=ventron sr=roc] Updates: [r=ventron r+sr=vlad] a=blocking1.9+ 2008-03-19 13:51:42 -07:00
jst@mozilla.org
d1dd3d9620 Fixing bug 422926 (and also bugs 420886 and 423260). Don't do delayed stops of plugins unless we're deleting the frame, as some plugins apparently can't handle that. r+sr=jonas@sicking.cc 2008-03-19 12:43:10 -07:00
aaronleventhal@moonset.net
14247d2b05 Bug 423681. Accessible text events broken. r=sicking, sr=bz, a=schrep 2008-03-18 18:37:09 -07:00
jwatt@jwatt.org
9f26d651b3 Bug 423436. Elements embedding SVG by reference don't resize if they depend on intrinsic percentage width/height. r+sr=dbaron@mozilla.com, blocking1.9=me 2008-03-18 17:11:01 -07:00
reed@reedloden.com
6248dff561 Bug 392233 - "Text kerning broken by scaling/viewBox (space between letters or letters above each other)" [p=roc@ocallahan.org (Robert O'Callahan [roc]) r=longsonr sr=vlad a=blocking1.9+] 2008-03-18 12:50:29 -07:00
reed@reedloden.com
cb78ef1dde Bug 415257 - "Editable trees: input sized wrongly and rows jumping with flexible and non-flexible treecols" [p=paul.rouget@gmail.com (Paul Rouget) r+sr=Neil a1.9=beltzner] 2008-03-18 12:41:34 -07:00
roc+@cs.cmu.edu
acfc191b35 Backing out bug 392233 again 2008-03-18 01:37:48 -07:00
roc+@cs.cmu.edu
90ecd7d2cc Bug 392233. Relanding ... make SVG text build textruns taking into account the current transform's scale. Also refactors code to simplify everything. r=longsonr,sr=vlad 2008-03-18 00:42:07 -07:00
karlt+@karlt.net
ada80919ce Move Place() from nsIMathMLFrame to nsMathMLContainerFrame b=363240, r+sr=roc 2008-03-17 22:57:35 -07:00
karlt+@karlt.net
6c6cd3ed3e Move Place() from nsIMathMLFrame to nsMathMLContainerFrame b=363240, r+sr=roc 2008-03-17 22:26:05 -07:00
karlt+@karlt.net
11f89ddd6a Add GetIntrinsicWidth for <msqrt>. b=363240, r+sr=roc 2008-03-17 22:06:23 -07:00
karlt+@karlt.net
e4c30bc0d5 Move Place() from nsIMathMLFrame to nsMathMLContainerFrame b=363240, r+sr=roc 2008-03-17 21:52:48 -07:00
roc+@cs.cmu.edu
249d6834b0 Oops, adding reftest files for bug 422394 2008-03-17 20:25:36 -07:00
roc+@cs.cmu.edu
52d11f6718 Backing out bug 392233. 2008-03-17 19:36:17 -07:00
roc+@cs.cmu.edu
8dc31a31ac Bug 422394. Fix tab width calculation so we never fail to advance. r=smontagu 2008-03-17 18:48:22 -07:00
roc+@cs.cmu.edu
146c08904d Bug 392233. Take the current contxt scale into account when constructing textruns for SVG, and simplify the SVG text code. r=longsonr,sr=vlad 2008-03-17 18:45:05 -07:00
longsonr@gmail.com
27cd40b49e Bug 423071 - SVG bad clippath rendering when changed via DOM. r+sr=roc,a1.9=blocking1.9+ 2008-03-17 12:55:36 -07:00
longsonr@gmail.com
d50ea86b40 Bug 419746 - SVG crash in gfxASurface::SetDeviceOffset() via nsSVGMaskFrame::ComputeMaskAlpha(). r+sr=vladimir,a1.9=blocking1.9+ 2008-03-17 10:15:43 -07:00
jruderman@hmc.edu
12bd73342f Add a "!=" reftest that will fail is msub and msup break (like in bug 345564) 2008-03-16 22:34:37 -07:00
bzbarsky@mit.edu
71f4c3f4b8 Comment fix 2008-03-16 17:22:54 -07:00
dbaron@dbaron.org
93f3933849 Add simplified version of test that we can currently pass. 2008-03-16 14:20:53 -07:00
dbaron@dbaron.org
3efad80ec8 Fix bug in test. 2008-03-16 14:20:35 -07:00
dbaron@dbaron.org
ce89f4930f Add reftest for CSS 2.1, section 10.3.3. 2008-03-16 14:13:00 -07:00
reed@reedloden.com
adc33685ef Bug 422614 - "CVS remove old stuff from layout/tools" [p=alfredkayser@gmail.com (Alfred Kayser) r=roc a1.9=beltzner] 2008-03-16 14:08:00 -07:00
bzbarsky@mit.edu
b607f1de90 Invalidate tables a little harder. Bug 421632, r+sr=roc 2008-03-16 13:32:48 -07:00
karlt+@karlt.net
dfa2f4c0f0 mi elements for which default values for mathvariant should have no effect 2008-03-15 19:26:32 -07:00
karlt+@karlt.net
7647ac9bdc Only change the style of default mathvariant <mi> elements to italic when there is a corresponding italic Mathematical Alphanumeric Symbol. Accept non-BMP characters in nsMathMLOperator::LookupInvariantChar. Update the mathvariant entries in mathfont.properties from PUA characters to their Plane 1 Unicode assignments (remainder of bug 289938). b=413115, r+sr=roc. 2008-03-15 19:10:47 -07:00
jruderman@hmc.edu
5300fa0e04 Add crashtest 2008-03-15 04:14:04 -07:00
mats.palmgren@bredband.net
baa6fb0fd0 Fix a compile warning. b=399694 r+sr=dbaron a1.9=damons 2008-03-15 02:01:36 -07:00
mats.palmgren@bredband.net
1b90e26ff7 Make nsStyleChangeList own a reference to nsIContent pointers in its list. b=399694 r+sr=dbaron a1.9=damons 2008-03-15 02:01:18 -07:00
jonas@sicking.cc
da4cab3b75 Bug 401155: Make it safe to create a wrapper for an object at any time by making sure wrapping doesn't write script. Also set up a service that tries to keep track of when it's safe to execute script. r=bz sr=jst 2008-03-14 16:08:57 -07:00
bzbarsky@mit.edu
7b83e29004 Don't use fieldset pref widths as min widths, since pref widths can be unconstrained. Incidentally makes it possible for text to legends to wrap if the page wants it to. Bug 404123 and bug 354502, r+sr=dbaron, a=beltzner. 2008-03-14 13:48:23 -07:00
reed@reedloden.com
170c0984dc Bug 395454 - "[Mac] Have one file, scrollbars.css" [p=mozcbarrett@gmail.com (Colin Barrett [cbarrett]) r=Enn r=Neil sr=roc a1.9=damons] 2008-03-14 08:24:50 -07:00
reed@reedloden.com
f7bade2b02 Bug 311366 - "should make custom elements able to contain blocks (<section>)" [p=mrbkap@gmail.com (Blake Kaplan) r=sicking sr=jst a1.9=beltzner] 2008-03-14 08:15:29 -07:00
martijn.martijn@gmail.com
e8ea49f32b Modified test for bug 396024, this should not cause problems anymore now that bug 407080 is fixed 2008-03-14 08:12:20 -07:00
smontagu@smontagu.org
7c4c877c83 Testcase for bug 128896. 2008-03-14 08:03:33 -07:00
jwatt@jwatt.org
ca6acd6147 Bug 421780. NPOB. Add public domain dedication comment to two tests for Joe Drew (his tests). 2008-03-14 07:49:57 -07:00
dholbert@cs.stanford.edu
dfa358c900 Backing out Bug 417356, due to pagination reftest failures. 2008-03-14 01:50:13 -07:00
roc+@cs.cmu.edu
43eb2ffe91 Bug 404140. Avoid assertions about comparing line iterators from different lists by comparing nsLineBox* pointers. r+sr=dbaron 2008-03-14 01:12:25 -07:00
dholbert@cs.stanford.edu
b847cc90cc Bug 417356: Define & use "UnwriteableMargin" PrintSettings pref, to make Linux printing work more like Mac printing (keeping us from printing right up against the edge of the page) r=ventron sr=roc a=blocking1.9+ 2008-03-14 00:48:04 -07:00
dholbert@cs.stanford.edu
52a3ff9796 Bug 421239: Remove broken/brittle optimization of guessing (incorrectly) whether a line might be empty, when we're determining whether we need to mark next line's margin as dirty. r+sr=roc, a=blocking1.9+ 2008-03-14 00:21:15 -07:00
karlt+@karlt.net
5deea10aba GetIntrinsicWidth for mroot, mfenced, and mfrac. b=363240, r+sr=roc 2008-03-13 22:02:49 -07:00
karlt+@karlt.net
2071d69173 nsMathMLChar::GetMaxWidth and stretchy <mo> GetIntrinsicWidth implementations. Rename MAXSIZE_IS_EXPLICIT to MAXSIZE_IS_ABSOLUTE. Avoid unsigned/signed warnings with 1<<31. b=363240, r+sr=roc 2008-03-13 21:05:43 -07:00
jst@mozilla.org
a5b6672d1f Fixing bug 416953. Do plugin destruction off of an event whenever possible (which is pretty much always). r+sr=jonas@sicking.cc 2008-03-13 20:31:35 -07:00
dholbert@cs.stanford.edu
3287a6868e Bug 407080: Disallow print-preview while page is loading. (Re-landing with broken mochitest disabled) r+sr=roc, a=blocking1.9+ 2008-03-13 14:12:55 -07:00
stefanh@inbox.com
7984e34c0c Bug 421814 - Use HITheme to draw backgrounds for groupboxes. r=josh+Mano, sr=roc, a1.9=dsicore. 2008-03-13 13:24:29 -07:00
dbaron@dbaron.org
3bc7dd28e0 Fix buggy test; rgb() non-% arguments are required to be integers. a=tests 2008-03-13 08:24:22 -07:00
dbaron@dbaron.org
950ba556ce Don't make overflow:-moz-hidden-unscrollable affect layout. b=411213 r+sr=roc a=beltzner 2008-03-13 08:23:27 -07:00
roc+@cs.cmu.edu
a5d01c093e Backing out 413027 again. 2008-03-13 02:14:16 -07:00
roc+@cs.cmu.edu
69064e9603 Bug 413027. The XUL pref and min height for a CSS block should be its height when reflowed at its preferred width, NOT the height of the tallest line. r+sr=dbaron. Relanding with additional XUL box layout fix to increase the frame size to the minimum size required by children even if they don't change size during layout, and a fix to scrollframes so they don't depend on being able to set a size for scrollbars less than their minimum size. r+sr=dbaron 2008-03-13 01:40:43 -07:00
karlt+@karlt.net
b64fb6eb32 Remove some unused nsGlyphTable methods. b=363240, r+sr=roc 2008-03-12 21:50:44 -07:00
reed@reedloden.com
965cbb1d62 Bug 192631 - "Animated images stop animating after Print / Print Preview" [p=martijn.martijn@gmail.com (Martijn Wargers) r+sr=roc a1.9=damons] 2008-03-12 19:58:34 -07:00
masayuki@d-toybox.com
821cf1156c Bug 417014 Need blacklist system for underline offset adjusting of CJK fonts which have wrong underline offset r=roc+stuart, sr=roc, b1.9=stuart 2008-03-12 19:36:58 -07:00
dbaron@dbaron.org
a03c0aa905 Don't do floating point assignment from uninitialized data, since it can crash. b=422011 r+sr=bzbarsky a=damon 2008-03-12 15:05:27 -07:00
dbaron@dbaron.org
4f711db346 Don't let the pres context's visible area get permanently set to an unconstrained height when we call ResizeReflow with an unconstrained height during SizeToContent. b=371508 r+sr=roc a=blocking1.9+ 2008-03-12 15:04:45 -07:00
dholbert@cs.stanford.edu
ee909b17b6 Bug 422484: Add parens around macro if conditions. Patch by David Mandelin <dmandelin@mozilla.com> r=benjamin a1.9=dsicore 2008-03-12 14:47:11 -07:00
dholbert@cs.stanford.edu
87e0492872 Disabling failing reftest 386339.html. (See Bug 422454) 2008-03-12 10:22:49 -07:00
reed@reedloden.com
1c9b9b3e93 Bug 421780 - "SVG <image> has stopped working" (reftests for resizing a 1x1 image) [p=joe@drew.ca (Joe Drew [JOEDREW!]) r=longsonr] 2008-03-12 10:21:26 -07:00
reed@reedloden.com
235b45658f Bug 421780 - "SVG <image> has stopped working" (use the native size of the current frame instead of its scaled size) [p=joe@drew.ca (Joe Drew [JOEDREW!]) r=longsonr sr=vlad a=blocking1.9+] 2008-03-12 10:19:51 -07:00
smontagu@smontagu.org
479ae9823b Enable bidi processing if there are right-to-left characters in print headers or footers. Bug 421690, r+sr=roc, blocking1.9=damon 2008-03-12 00:56:38 -07:00
roc+@cs.cmu.edu
60d05a4f07 Bug 413027 backed out again 2008-03-11 19:01:17 -07:00
roc+@cs.cmu.edu
ea712ce519 Bug 413027. The XUL pref and min height for a CSS block should be its height when reflowed at its preferred width, NOT the height of the tallest line. r+sr=dbaron. Relanding with extra instrumentation in the strangely-failing mochitest test_bug199692.xul 2008-03-11 18:05:26 -07:00
roc+@cs.cmu.edu
8dfb75f0cd Bug 420351. Don't let empty list-bullets make a line non-empty. r+sr=dbaron 2008-03-11 17:46:18 -07:00
jruderman@hmc.edu
736a43a02c Add crashtest 2008-03-11 17:44:46 -07:00
uriber@gmail.com
dce1edd834 Don't reserve space for start (end) margin on the first- (last-) in-flow if it has a previous (next) bidi continuation. bug=421419 r+sr=dbaron a1.9=dsicore 2008-03-11 14:54:34 -07:00
jruderman@hmc.edu
26941b2224 Add reftest 2008-03-11 11:24:02 -07:00
roc+@cs.cmu.edu
b099594232 Backing out 420351 2008-03-11 03:44:32 -07:00
roc+@cs.cmu.edu
8a3b8b1390 Backing out bug 413027 2008-03-11 01:36:01 -07:00
roc+@cs.cmu.edu
74d8a4f62e Bug 413027 reftest 2008-03-11 00:46:40 -07:00
roc+@cs.cmu.edu
7464d60332 Bug 413027. The XUL min-size and pref-size for a CSS block should just be its height when reflowed at its preferred width --- NOT the height of the tallest line, that is insane. r+sr=dbaron 2008-03-11 00:38:26 -07:00
roc+@cs.cmu.edu
65180d9a75 Bug 420351. Empty bullets cannot make a line non-empty. r+sr=dbaron 2008-03-11 00:36:03 -07:00
jonas@sicking.cc
47a2cff0da Back out due to failed mochitest 2008-03-10 19:18:15 -07:00
jonas@sicking.cc
4b8f2cdf7a Bug 401155: Make sure plugins and XBL constructors not execute when creating a script wrapper if it's not safe to execute scripts. r=bz sr=jst. 2008-03-10 17:49:19 -07:00
mozilla@weilbacher.org
8aea370edc [OS/2] Bug 369791: adapt plugin code to compile with cairo-os2, this in principle allows plugin content to be printed and windowless plugins to display, r=mkaply, a1.9+=damons 2008-03-10 17:10:55 -07:00
dholbert@cs.stanford.edu
61fc354af4 Bug 407243 reftest, to define current behavior. 2008-03-10 15:11:16 -07:00
dbaron@dbaron.org
b76ec670c5 Test selector serialization too. 2008-03-09 18:10:03 -07:00
roc+@cs.cmu.edu
11aa232422 Bug 403181. Pass the desired source rectangle for background images down into nsThebesImage and ensure we don't sample outside it. Back out a bad pixman patch that caused regressions, and adjust image encoding tests so they don't depend on the regression. Also switchs some reftests to quirks mode so that the 1-appunit width of <br>s doesn't bite us. r=vlad,sr=dbaron 2008-03-09 14:55:05 -07:00
jruderman@hmc.edu
72906022c3 Add a crashtest 2008-03-08 22:37:45 -08:00
jruderman@hmc.edu
728e86591d Add crashtest 2008-03-08 22:32:28 -08:00
dbaron@dbaron.org
93fe3229b3 Separate the tests so that they really test what they were intended to test. 2008-03-08 14:41:47 -08:00
dbaron@dbaron.org
b8aa468035 Unbreak test that I broke while addressing review comments. a=test-only 2008-03-08 14:22:09 -08:00
jst@mozilla.org
69dc88b93a Followup fix for bug 393845, fixing minor issue found by jag, no functional change. 2008-03-08 11:04:40 -08:00
reed@reedloden.com
76242a95fb Bug 412954 - "menus should have Menu, PopupMenu or DropdownMenu window type" [p=ventnor.bugzilla@yahoo.com.au (Michael Ventnor) r+sr=roc a1.9=beltzner] 2008-03-08 03:32:25 -08:00
reed@reedloden.com
5e3b4d1415 Bug 418543 - "remove -moz-pre-wrap" [p=taken.spc@gmail.com (KUROSAWA, Takeshi) r+sr=roc a1.9=beltzner] 2008-03-08 01:44:35 -08:00
bmlk@gmx.de
a9dad73560 There is no height greater than unconstrained height, bug 402872, r/sr=roc a=beltzner 2008-03-08 01:12:30 -08:00
vladimir@pobox.com
7799aa92fb b=418882, crash on www.rhein-zeitung.de, potential fix; r+sr=roc 2008-03-07 16:58:57 -08:00
dbaron@dbaron.org
a0ae7c66c4 Add reftests for baseline-alignment aspects of bug 402940 fixes. 2008-03-07 14:27:08 -08:00
jst@mozilla.org
cb76f98a7a Fixing bug 393845. Crash with Windows Media Player 10 plugin when stopping plugin. r+sr=bzbarsky@mit.edu 2008-03-07 13:32:49 -08:00
bzbarsky@mit.edu
9a9b16c7e5 Make sure to do saturating adds on possibly-unconstrained nscoords. Bug 421404, r=dholbert, sr=roc, a=beltzner 2008-03-07 13:20:03 -08:00
dbaron@dbaron.org
6dfd3f8a50 Give radio buttons and checkboxes a useful baseline, and switch checkboxes from text-bottom to baseline alignment (to match radios). b=402940 r+sr=bzbarsky a=blocking1.9+ 2008-03-07 09:57:34 -08:00
jwatt@jwatt.org
c6621839de Bug 421464. The 'type' attribute on <style> should be optional. r=longsonr@gmail.com, sr=roc@ocallahan.org, blocking1.9=me 2008-03-07 02:16:05 -08:00
surkov.alexander@gmail.com
17652cbd2d Bug 416742 - Regression: multiple rowgroups interfere with getColumnAtIndex(), r=bernd, sr=roc, a=beltzner 2008-03-07 02:14:35 -08:00
roc+@cs.cmu.edu
72bddc7c36 Backing out Bug 403181. JPEG encoding test failure :-( 2008-03-07 01:28:34 -08:00
roc+@cs.cmu.edu
18b5f6db55 Bug 403181. Various fixes to image rendering. Most importantly, we track the desired subimage of a CSS background image and ensure we don't sample outside it. r=vlad,sr=dbaron 2008-03-07 00:34:12 -08:00
karlt+@karlt.net
423c6ce2f9 Don't try to Place() invisible operators. b=420420 r+sr=roc a=beltzner 2008-03-06 22:37:23 -08:00
karlt+@karlt.net
4260e2c912 Bug 416549 - MathML does not render properly with text-align:justify. Patch by Frédéric WANG <fwsmail35@aol.com>, r=karlt, sr=roc 2008-03-06 19:47:11 -08:00
karlt+@karlt.net
88cb41a133 Backing out previous revision (b=416549) due to a reftest hang on qm-centos5-01 2008-03-06 16:19:00 -08:00
karlt+@karlt.net
6e07d7b64d Backing out previous revision (b=420420) due to reftest hang on qm-centos5-01 2008-03-06 16:14:56 -08:00
jruderman@hmc.edu
621c9391bc Fix XML parsing errors in tests: apparently comments have to go *after* the ?xml version? thing Fix XML parsing errors in tests: apparently comments have to come *after* the '?xml version="1.0"?' thing. 2008-03-06 15:59:35 -08:00
Olli.Pettay@helsinki.fi
5bdf2e94cf Bug 421294, Crash [@ DocumentViewerImpl::GetCopyable], r+sr=jst, a=beltzner 2008-03-06 15:05:35 -08:00
karlt+@karlt.net
dd94eb4942 Don't try to Place() invisible operators. b=420420 r+sr=roc a=beltzner 2008-03-06 14:21:07 -08:00
karlt+@karlt.net
ce3034771d Bug 416549 - MathML does not render properly with text-align:justify. Patch by Frédéric WANG <fwsmail35@aol.com>, r=karlt, sr=roc 2008-03-06 13:59:03 -08:00
vladimir@pobox.com
26262aaee9 b=417246, wrong border size rendering in some cases ; r=roc 2008-03-05 23:58:58 -08:00
vladimir@pobox.com
c8cf53147c reftest analyzer improvements; npotb, a=dbaron 2008-03-05 23:36:20 -08:00
vladimir@pobox.com
8ee725091d b=418915, plugin print rendering coordinates incorrect on win32; r+sr=roc 2008-03-05 23:06:46 -08:00
vladimir@pobox.com
104f6a38a1 b=415854, make single-pixel optimized images release memory; patch from joe@drew.ca; r+sr=vlad 2008-03-05 22:51:13 -08:00
jwalden@mit.edu
716029f2f9 Bug 420243 - Fix an arithmetic mistake in SVGTextContentElement.getSubStringLength. r+sr=roc, a=beltzner 2008-03-05 18:10:43 -08:00
dbaron@dbaron.org
4b445ab6b3 Fix greediness of A ~ B C selector matching. b=420814 r+sr=bzbarsky a=beltzner 2008-03-05 16:06:15 -08:00
dbaron@dbaron.org
7003061847 Fix the weird Get* API on nsStyleSides in favor of returning structs by value, to avoid further occurrences of bug 420069. b=420069 r+sr=roc a=beltzner 2008-03-05 16:05:26 -08:00
dbaron@dbaron.org
d2fe1a813b Update properties that are ignored when 'Allow pages to choose their own colors' is unchecked for the splitting of left/right border properties and the introduction of start/end border properties. b=419167 Patch by Bernd Mielke <bernd_mozilla@gmx.de>. r+sr=dbaron a=beltzner 2008-03-05 16:03:50 -08:00
masayuki@d-toybox.com
2533703600 Bug 405308 [text-decoration] Link underline disappears (or is misaligned 1px) when scrolling r+sr=roc, a1.9=beltzner 2008-03-05 11:24:44 -08:00
bent.mozilla@gmail.com
fb447201e2 Bug 420803 - Fix for bug 413268 keeps a DOM window alive until shutdown. r=enn, sr=jst, a=blocking1.9+. 2008-03-04 15:27:02 -08:00
joshmoz@gmail.com
df3cd329a5 take key modifiers from the current event not the current hardware state. b=320746 r=smichaud sr=roc 2008-03-04 09:58:52 -08:00
roc+@cs.cmu.edu
4815c48c47 Backing out 403181 again 2008-03-04 01:36:07 -08:00
roc+@cs.cmu.edu
d8ef70bf14 Bug 403181. Track which subimage of an image we want to draw and copy it to a temporary surface if necessary to prevent sampling of pixels outside the subimage when zooming. Also, enable EXTEND_PAD or SetFilter(0) if the context has a transformation that's not a simple translation, since that might induce cairo to sample pixels outside the source (sub)image. r=vlad,sr=dbaron 2008-03-04 00:21:34 -08:00
dholbert@cs.stanford.edu
898cea883b Backing out bug 407080 to investigate breakage of mochitest test_bug396024.html 2008-03-03 22:11:54 -08:00
dholbert@cs.stanford.edu
57c4c6eade Bug 407080: Disallow print-preview if page is loading. r+sr=roc, a=blocking1.9+ 2008-03-03 17:05:27 -08:00
roc+@cs.cmu.edu
cfdcd1fbe2 Bug 392809. Fix word-based caret movement around punctuation and whitespace. r=smontagu,a=beltzner 2008-03-03 00:37:34 -08:00
roc+@cs.cmu.edu
d5a6cd23c7 Bug 403181 backout 2008-03-02 18:38:19 -08:00
roc+@cs.cmu.edu
528b547d86 Bug 403181. Use a temporary surface to prevent sampling of pixels outside the intended source rectangle when zooming the image in some cases. r=vlad,sr=dbaron,a=beltzner 2008-03-02 17:01:14 -08:00
dholbert@cs.stanford.edu
65a3300338 Bug 418766: Use width, not height, as a quick proxy for whether a line is empty. r+sr=roc, a=beltzner 2008-02-29 13:45:43 -08:00
vladimir@pobox.com
4aa4bceacd b=419383, extract native vista toolbar styles and expose to themes ; r+sr=roc; a=beltzner 2008-02-28 21:10:38 -08:00
jst@mozilla.org
16e1932c1a Fixing bug 410946. Prevent plugins from being destroyed while there's code from those plugins on the stack. r+sr=bzbarsky@mit.edu, a=beltzner@mozilla.com 2008-02-28 18:06:00 -08:00
dbaron@dbaron.org
ef4c9abc72 Add better reftest coverage for intrinsic width computation of horizontal padding, border, and margin on inlines. b=420069 sheriff-a=sayrer 2008-02-28 17:52:09 -08:00
dbaron@dbaron.org
38ba81cbd4 Fix bug under some valid types of optimization where we cross margin and padding. b=420069 r+sr=roc a1.9b4=damons a-sheriff=sayrer 2008-02-28 17:52:06 -08:00
roc+@cs.cmu.edu
49a25bd74b disable test for bug 405952 until I can fix the test 2008-02-28 13:58:01 -08:00
roc+@cs.cmu.edu
76c8339f01 Bug 405952. Add scrollbar width to pref and min widths for overflow:scroll elements but for no other overflow values. r+sr=bzbarsky,dbaron,dholbert, a=beltzner 2008-02-28 12:37:06 -08:00
dbaron@dbaron.org
cb1f666485 Add testcase for computing the shrink-wrapping size of table outer frames correctly. b=363402 2008-02-28 09:55:29 -08:00
dbaron@dbaron.org
898743fc16 Compute the shrink-wrapping size of table outer frames correctly. b=363402 r+sr=roc a1.9b4=beltzner 2008-02-28 09:55:04 -08:00
masayuki@d-toybox.com
3dcfbbf7fc Bug 418470 Go to line in View Source broken (NS_ERROR_UNEXPECTED at nsISelectionController.scrollSelectionIntoView) (retry) r+sr=roc, a1.9b4=beltzner 2008-02-28 07:28:37 -08:00
masayuki@d-toybox.com
f6e10b8d70 backing out the previous patch, becaused qm-centos5-01 dep unit test is orange 2008-02-28 05:59:25 -08:00
masayuki@d-toybox.com
22b844e897 Bug 418470 Go to line in View Source broken (NS_ERROR_UNEXPECTED at nsISelectionController.scrollSelectionIntoView) r+sr=roc, a1.9b4=beltzner 2008-02-28 03:01:56 -08:00
uriber@gmail.com
951d3bd501 reftest for bug 412093. 2008-02-27 12:06:22 -08:00
karlt+@karlt.net
9cfde0fffe Include lspace and rspace in GetIntrinsicWidth. b=363240 r+sr=roc 2008-02-27 02:47:43 -08:00
roc+@cs.cmu.edu
e6eabd1d25 Bug 412093. Fix background images on bidi-split inlines to show the chunks in visual order. patch by Uri Bernstein, r+sr=roc 2008-02-27 02:46:29 -08:00
karlt+@karlt.net
2651ea9c59 Get*Width for nsMathMLContainerFrame base class. b=363240 r+sr=roc 2008-02-27 02:45:36 -08:00
roc+@cs.cmu.edu
a3b0d9b560 Bug 317189. Do the second-scroll-to-anchor on onload (i.e. subresources have loaded), not just when the document has finished loading. Also, don't do it at all if the user has scrolled manually between the first anchor scroll and the second. r+sr=dbaron 2008-02-27 02:01:17 -08:00
roc+@cs.cmu.edu
bc1e698534 Bug 400057. Make nsBlockInFlowLineIterator useful for finding the line containing a frame, searching across block continuations and their overflow lines. Use it in various places, especially in textrun construction. r+sr=dbaron 2008-02-27 01:53:48 -08:00
roc+@cs.cmu.edu
705c2058b7 Bug 416168. Ensure that the overflow rect for a frame always includes (0,0) even if the frame rect is empty. Also ensures that if the frame rect is empty but has non-zero dimension on one axis, the overflow rect includes that size. A scrolled view for such a frame also includes that size to ensure width:0,height:Npx and width:Npx,height:0 frames are scrollable by that amount. r+sr=dbaron 2008-02-27 01:46:22 -08:00
roc+@cs.cmu.edu
26de5ff636 Bug 419531 reftest 2008-02-27 01:41:08 -08:00
roc+@cs.cmu.edu
e29a1f3193 Bug 419531. Don't wipe out stored tab widths during text intrinsic size calculation. r+sr=dbaron 2008-02-27 01:29:46 -08:00
roc+@cs.cmu.edu
0689f4c34f Bug 417255. Rework getClientRects/getBoundingClientRect/offset* code to use a generic rectangle iterator API which drills down through anonymous blocks, fixing IE compat. r+sr=dbaron 2008-02-27 01:26:15 -08:00
reed@reedloden.com
ad47a157a8 Back out Smaug's patch from bug 395609 due to a Txul regression. 2008-02-26 19:51:00 -08:00
dbaron@dbaron.org
73bfb3b850 Remove expected failure fixed by bug 363248. 2008-02-26 19:02:45 -08:00
dbaron@dbaron.org
809b049508 Make the reference match the expected behavior of the testcases per changes in bug 363248. 2008-02-26 19:01:05 -08:00
dbaron@dbaron.org
6447298324 Fix horizontal positions of top and bottom captions in the presence of non-left-aligned tables. b=363248,386704 r+sr=roc a=blocking1.9+ 2008-02-26 18:03:11 -08:00
dbaron@dbaron.org
bef42eb600 Prevent margin expansion from interfering with table caption position. Based on patch by Mats Palmgren. b=363248 r+sr=roc a=blocking1.9+ 2008-02-26 18:02:50 -08:00
dbaron@dbaron.org
a6ec36aaa1 Make 'top' and 'bottom' captions follow the CSS2.1 behavior and put the old behavior into 'top-outside' and 'bottom-outside'. b=363248,386704 r+sr=roc a=blocking1.9+ 2008-02-26 18:02:20 -08:00
dbaron@dbaron.org
5ddc11de0c Split nsTableOuterFrame::OuterReflowChild. b=363248,386704 r+sr=roc a=blocking1.9+ 2008-02-26 18:01:33 -08:00
dougt@meer.net
47947ce309 use of max(a,b) is confusing windows mobile compiler. b=419653, r=dbaron, a=beltzner 2008-02-26 17:51:57 -08:00
reed@reedloden.com
d36fe99b43 Bug 394473 - "caret/cursor in View Source is invisible since 20070628 {not rendered, seen, can't, cannot, shown, displayed}" [p=chris@pearce.org.nz (Chris Pearce [cpearce]) r=peterv r+sr=roc a1.9=beltzner] 2008-02-26 17:49:46 -08:00
Olli.Pettay@helsinki.fi
9d20321d7a Bug 395609, r=roc, sr=sicking 2008-02-26 15:48:49 -08:00
mats.palmgren@bredband.net
a907d70ffb Fix a compile warning. b=417895 r+sr=roc a=blocking1.9 2008-02-26 07:04:33 -08:00
mats.palmgren@bredband.net
9e192bb576 Make nsTypedSelection ctors initialize all members (fixes an UMR) and reorder members to save space. b=417895 r+sr=roc a=blocking1.9 2008-02-26 07:04:14 -08:00
Olli.Pettay@helsinki.fi
67622f2077 Bug 411054, Audit IsNativeAnonymous()/GetBindingParent() uses, r+sr=sicking 2008-02-26 04:40:18 -08:00
reed@reedloden.com
70e372f1fb Bug 410114 - "Simplify nsTransform2D" [p=alfredkayser@gmail.com (Alfred Kayser) r+sr=roc a1.9=damons] 2008-02-26 01:42:36 -08:00
roc+@cs.cmu.edu
4d2c5dd483 Bug 408898. Aggressively SetWindow when paining on Mac with CG to prevent plugins drawing in the wrong place. patch by Matthew Gregan, r+sr=roc 2008-02-26 01:09:05 -08:00
karlt+@karlt.net
aab5b28c72 don't use frame origin offsets to store ascents. b=363240, r+sr=roc 2008-02-25 20:19:36 -08:00
jruderman@hmc.edu
ddae8e0524 Add crashtests 2008-02-25 16:54:14 -08:00
dbaron@dbaron.org
722e419bf7 Fix handling of 'right'-derived static positions (mostly for RTL) when containing block has asymmetric border. b=419072 r+sr=roc a=damons 2008-02-25 13:16:21 -08:00
roc+@cs.cmu.edu
ee0b9041fc Bug 417967. Align subframe drawing so that drawing at (0,0) relative to the root view's origin is aligned to a pixel boundary. r+sr=bzbarsky 2008-02-24 17:39:34 -08:00
roc+@cs.cmu.edu
79fa927cd8 Reftest for bug 376375. 2008-02-24 17:36:41 -08:00
roc+@cs.cmu.edu
ac43fde6ea Bug 416752. Use the scrollbar min-height/min-width to establish the minimum scrollport size, not the pref-height/pref-width. r+sr=dbaron 2008-02-24 17:21:08 -08:00
dbaron@dbaron.org
36bfec9f1f Fix regression handling auto margins on absolutely positioned elements. b=419060 r+sr=roc a=blocking1.9+ 2008-02-24 10:28:57 -08:00
fantasai.cvs@inkedblade.net
adcaddd746 fixed positioned elements print only on first and last pages b=417676 r+sr=roc 2008-02-24 04:19:17 -08:00
Olli.Pettay@helsinki.fi
5ad351df5f Bug 418457, Remove support for onbeforecopy/cut/paste until we have a better implementation, r+sr=sicking 2008-02-24 02:55:37 -08:00
reed@reedloden.com
eda8f31292 Bug 419080 - "build with undefined CSS_REPORT_PARSE_ERRORS broken" [p=romaxa@gmail.com (romaxa) r+sr=bzbarsky a1.9=beltzner] 2008-02-23 23:39:47 -08:00
reed@reedloden.com
b7eaeb04c9 Bug 383267 - "When fontHeight is very large, pagescroll height(pageincrement value) is too small" [p=masa141421356@gmail.com (Masahiro Yamada) r+sr=roc a1.9=beltzner] 2008-02-23 23:35:08 -08:00
reed@reedloden.com
40b710e021 Bug 391559 - "Incorrect ordered-list numbering within -moz-column-* (and/or numbering changes when clicked)" [p=craig.topper@gmail.com (Craig Topper) r+sr=roc a1.9=beltzner] 2008-02-23 23:31:29 -08:00
vladimir@pobox.com
43b70c1702 b=381661, reenable bilinear image filtering [mq]: 381661-enable-bilinear.patch ; r=stuart 2008-02-23 14:30:57 -08:00
uriber@gmail.com
8c675558f6 Add a comment and assertion to the fix for bug 370174. r+sr=roc on the original patch. blocking1.9=dbaron 2008-02-23 02:54:29 -08:00
roc+@cs.cmu.edu
ef81289627 Bug 407095. Reflow in more situations where horizontal scrollbar appears or disappears. May hurt Tp, let's watch. r+sr=dbaron,a=damon 2008-02-23 02:15:59 -08:00
reed@reedloden.com
2eeb348daf Bug 419000 - "Remove SVG_DEBUG_PRINTING (as it blocks nsTransform2D cleanup)" [p=alfredkayser@gmail.com (Alfred Kayser) r+sr=roc a1.9=damons] 2008-02-23 01:25:37 -08:00
jruderman@hmc.edu
6591bb1911 Add crashtest 2008-02-22 16:14:17 -08:00
dbaron@dbaron.org
94f8a038ab Correct comments in reference renderings to reflect additional bug. 2008-02-22 14:36:58 -08:00