I moved the JAR out of the root directory because I didn't want
multiple copies of things in robocop/ appearing in IntelliJ, although
this turns out to not be strictly necessary. Keeping it as part of a
general push to move things out of the root dumping ground.
- A telemetry probe for when a user clicks to unblock an image.
- A second probe for sending the size of the image being unblocked.
Since we don't have information on the image size the best option
was to make make an XHR HEAD request. We make an approximation
of the image size from the content length which we send in kB.
- Replaced bool pref for int list option: Never, Always, or Only over Wi-Fi
- Pref browser.image_blocking.enabled -> browser.image_blocking
- Converted the early return to check for cellular as well.
- Note that in the cellular check, I do not consider LINK_TYPE_USB as "cellular".
- Tested this on a physical device with all combinations
of WiFi ON/OFF (falling back to cellular and each menu state.
- Tested if menu options work as well for each state mentioned above.
Using systrace, I took 2 traces before and after. Using the slowest
of both traces, the first three measure passes had the following
improvements in CPU time:
1) 20.583ms -> 13.149ms
2) 1.695ms -> 0.827ms (1/2)
3) 22.146ms -> 11.602ms (1/2)
This is to be expected – RelativeLayout requires two measure passes
so it makes sense to approximately half the measure times.
DONTBUILD NPOTB on a CLOSED TREE
The patch is horrific, but it's just find-and-replace of the test
runner class name, followed by organizing the imports (in the way that
IntelliJ likes them.)
This exports the buildDir to Robolectric via an Android-Gradle
buildConfigField, and then lightly massages the existing test runner
to use the exported value.
This is the last Gradle project that isn't in the srcdir. Since base/
doesn't have the correct package prefix directory structure, we still
need to symlink, but we only need one link. This effectively
deprecates |mach gradle-install|.
This should improve the robustness of our Gradle configuration,
ensuring that we always have projects to import. Since
settings.gradle executes very early in the IDE import project
sequence: before Gradle project evaluation time, and thus before any
Gradle task is executed, we should always see a complete project. (It
was possible to see incomplete Gradle configurations if |mach
gradle-install| hadn't been run at just the right time.)
The new format is:
$DeviceName
$url
If "$DeviceName" is not available, "$BrandName" (e.g. Firefox, Nightly) is
used.
Multiple received tab notifications are not aggregated.
The Preferences Activity looks as desired.
We can't get the main activity to have the desired looks because bug 1220309
prevents us from changing the Action Bar back button color from white so we
went with the default style which looks *alright*.
