Commit Graph

206 Commits

Author SHA1 Message Date
mozilla.mano@sent.com
67258253c1 Bug 388695 - getBookmarkIdsForURI should sort by relevance. r=dietrich, sayrer. 2007-07-22 16:25:49 -07:00
sspitzer@mozilla.org
0b0adb6c68 fix for bug #389032: problems when changing search scope within Bookmarks Manager
r=mano
2007-07-21 01:34:42 -07:00
sspitzer@mozilla.org
4b984102cc fix for bug #388860: New folder button on Add Bookmark panel does nothing.
r=mano
2007-07-21 01:30:07 -07:00
sspitzer@mozilla.org
fa011e030d backing out, tree is closed 2007-07-19 21:22:07 -07:00
sspitzer@mozilla.org
79ba6b5ec5 fix for bug #388860: New folder button on Add Bookmark panel does nothing
r=dietrich
2007-07-19 21:18:44 -07:00
mozilla.mano@sent.com
15f04b5ba3 Backing out bug 388695 due to tinderbox suckage. 2007-07-18 21:01:53 -07:00
mozilla.mano@sent.com
bdd104cfbc Fix orange from bug 388695. 2007-07-18 19:50:58 -07:00
mozilla.mano@sent.com
292f2e1daa Bug 388337 - Pasting a folder which contains sub-folders fails. r=sspitzer. 2007-07-18 14:39:23 -07:00
philringnalda@gmail.com
dc70d1612e Bug 386392 followup, make bookmark sidebar and bookmarks as home page work post-MOZ_PLACES_BOOKMARKS, r=gavin 2007-07-17 21:31:07 -07:00
mozilla.mano@sent.com
0419606b62 Bug 386392 - Drop pre places/places-bookmarks support from browser/. r=gavin. 2007-07-17 14:08:24 -07:00
mozilla.mano@sent.com
fe83315080 We don't implement classinfo after all (i.e. shut the console errors), follow-up patch on bug 376004. 2007-07-16 12:47:19 -07:00
mozilla.mano@sent.com
7df9db0546 Fix missed caller to use the new service (bug 376004), patch by Steve Won <swon@mozilla.com>, r=me. 2007-07-16 12:37:51 -07:00
mozilla.mano@sent.com
f8417811ce Missing changes for bug 376004. 2007-07-15 13:11:35 -07:00
mozilla.mano@sent.com
79feca49e7 Bug 376004 - Places Transactions must not live in the window global scope. patch by Steve Won and me. 2007-07-15 02:44:50 -07:00
sspitzer@mozilla.org
bfecea6b96 fix for bug #387952: Folder annotations should be kept intact for delete / undo transactions
patch=Christine Yen <cyen@mozilla.com>
r=sspitzer
2007-07-13 21:17:51 -07:00
sspitzer@mozilla.org
e13da5f762 fix for bug #378558: Organize Bookmarks - paste doesn't work after cut
includes fixes for:

bug #341953:  unable to paste links into the organize bookmarks dialog
bug #383044:  Drag-and-drop bookmark creation should support meta-data
bug #385381:  Paste doesn't work in the bookmarks Manager during copy if item is modified between copy and paste

r=sspitzer
2007-07-13 17:25:26 -07:00
philringnalda@gmail.com
f013da0b9d Bug 387833 - Cannot add keyword bookmark (because (get|set)PageAnnotationString is noscript now), r=mano 2007-07-11 23:05:15 -07:00
sspitzer@mozilla.org
ca17cee351 fix for bug #387172: text in search box in bookmark manager doesn't update until I switch folders
patch=Steve Won <swon@mozilla.com>
r=sspitzer
2007-07-11 19:09:47 -07:00
sspitzer@mozilla.org
74ae517038 code cleanup for bug #387203: getFolderContents() returns the root result node instead of the result itself.
r=mano
2007-07-11 18:18:20 -07:00
mozilla.mano@sent.com
0f3555aa18 Bug 385828 - Insertion, removal and move operations of items should update the last-modified field of their containing folder. r=dietrich. 2007-07-11 15:38:13 -07:00
sspitzer@mozilla.org
fc1606d42d fix for bug #331307: Bookmarks toolbar chevron is left-aligned instead of right-aligned
patch=Steve Won <swon@mozilla.com>
r=mano
2007-07-11 12:59:14 -07:00
mozilla.mano@sent.com
501fbf8e09 Bug 331654 - Provide a way to handle annotations values in a type-agnostic way. r=dietrich. 2007-07-11 02:57:59 -07:00
sspitzer@mozilla.org
a70e7bcb8b fix for bug #385990: bail out early of command updating for history queries
r=dietrich
2007-07-10 09:20:54 -07:00
mozilla.mano@sent.com
07b1baf1c4 Bug 386876 - hide the always disabled 'New Bookmark...' menu item from the history sidebar. r=sspitzer. 2007-07-09 15:54:58 -07:00
thunder@mozilla.com
4c812e94be Bug 334408: Fix broken test. r=gavin 2007-07-08 20:56:44 -07:00
thunder@mozilla.com
e249c6ee74 Bug 334408: Import/export the last charset used to bookmarks.html. r=mano 2007-07-08 19:22:50 -07:00
philringnalda@gmail.com
812d6a9f76 Bug 327748 - Bookmark Properties dialog missing keyboard accesskeys, patch by Ehsan Akhgari <ehsan.akhgari@gmail.com>, r=mano 2007-07-08 18:36:03 -07:00
jwalden@mit.edu
e3c4baccae Bug 348748 - Replace all instances of NS_STATIC_CAST and friends with C++ casts (and simultaneously bitrot nearly every patch in existence). r=bsmedberg on the script that did this. Tune in next time for Macro Wars: Episode II: Attack on the LL_* Macros. 2007-07-08 00:08:04 -07:00
sspitzer@mozilla.org
b301ce9ef5 fix for bug #373207 l10n: rename entity / properties that changed due to bug #373211 (search.all.label, cmd.find.label, places.title, etc)
patch=Steve Won <swon@mozilla.com>

r=sspitzer
2007-07-06 18:17:21 -07:00
sspitzer@mozilla.org
a2f891b8b3 fix for bug #334244: Click-drag-release on bookmarks toolbar folder drags the folder
patch=Steve Won <swon@mozilla.com>

r=dietrich
2007-07-06 18:12:37 -07:00
sspitzer@mozilla.org
bc972863cd fix for bug #386705: Description field of new bookmark is not populated even though it has <META name="description" content="...">
fix by=Marco Bonardo <mak77@supereva.it>

r=sspitzer
2007-07-03 08:39:33 -07:00
mozilla.mano@sent.com
7b934b2314 Bug 262329 - Sort By Name should sort between separators. r=sspitzer. 2007-07-01 05:23:38 -07:00
mozilla.mano@sent.com
9e50ac2d58 Bug 386159 - Menu-view performance improvements. r=dietrich, a=mconnor. 2007-06-28 13:33:21 -07:00
dietrich@mozilla.com
d429b8c71d backing out, per mano 2007-06-28 11:56:37 -07:00
dietrich@mozilla.com
f812d9d6ea Bug 386159 Menu-view performance improvements (for mano, r=dietrich) 2007-06-28 11:22:37 -07:00
mozilla.mano@sent.com
f136101493 Attempt to fix bug 385545 - toolbar folder contents aren't visible some time after loading. r=dietrich, a=mconnor. 2007-06-27 23:50:46 -07:00
sspitzer@mozilla.org
a4c02456ab fix for bug #381751: when I drop a bookmark or link in the sidebar or bookmark manager dialog, it frequently doesn't go where I expect it to go
fix for bug #385970:  Drag and drop around folders reacts incorrectly to mouse position

fix for bug #382679:  moving items in the organizer down are off by 1

patch by=Christine Yen <cyen@mozilla.com>

r=sspitzer
2007-06-26 18:38:50 -07:00
dtownsend@oxymoronical.com
4dad1c1885 Bug 247116 - Web pages bounce/shake/jump (places version of patch). r=mano 2007-06-26 18:13:28 -07:00
sspitzer@mozilla.org
2aafb0b267 fix for bug #382118: New separators cannot be deleted
patch=Christine Yen <cyen@mozilla.com>

r=sspitzer
2007-06-26 17:02:17 -07:00
sspitzer@mozilla.org
590f31b086 fix for bug #383840: problems when manually importing bookmarks exported from places based bookmark builds
fix for bug #381225:  on import, places bookmarks builds attempt to merge in bookmarks.html, where firefox 2 appends bookmarks

fix for bug #380449:  potential data loss on export of LAST_MODIFIED, DATE_ADDED and ICON_URI attributes

r=dietrich
2007-06-25 19:38:34 -07:00
mozilla.mano@sent.com
1b25d4835a Bug 385614 - Assert like mad when deleting Livemarks from left pane in the BM. r=dietrich. 2007-06-24 17:00:17 -07:00
sspitzer@mozilla.org
853359a4e9 fix for bug #384731: "Bookmark This Page" throws exception on close in bookmarkProperties.js if you have "bookmarkPropertiesDialog/lastUsed" annotations that point to itemIds for folder that don't exist
fix for bug #384733:  "Add Bookmark" dialog truncated if you have "bookmarkPropertiesDialog/lastUsed" annotations that point to itemIds for folder that don't exist

r=mano
2007-06-22 16:19:47 -07:00
sspitzer@mozilla.org
9cffddc61a backing out fix for bug #373944 as it causes a performance regression, see bug #385208 2007-06-20 15:46:54 -07:00
sspitzer@mozilla.org
ae49d2b81b fix for bug #373944: revert the workarounds for bug #373719, bug #373721, bug #374150 and bug #374166 caused by bug #267833.
Now that bug #373756, it is safe to do this.  But note, even when I revert the fix for bug #373756, I am not seeing the problems we saw after bug #267833 first landed.

r=mano
2007-06-20 00:43:51 -07:00
mozilla.mano@sent.com
a956febc57 Fix typo. 2007-06-20 00:27:41 -07:00
sspitzer@mozilla.org
7228bda8ed fix for bug #380735: Persist open state of the "age in days" and "site" containers in the history sidebar
r=dietrich
2007-06-19 22:19:06 -07:00
sspitzer@mozilla.org
8847d7a2d8 fix for bug #383572: changes made to bookmarks don't show in bookmark searches / Crash [@ nsCOMArray_base::InsertObjectAt nsNavHistoryFolderResultNode::OnItemChanged] deleting "ghost" bookmark
r=dietrich
2007-06-19 09:25:11 -07:00
sspitzer@mozilla.org
dc733c8c66 supplimental checkin for bug #383681: While BM is in a sorted view, adding a new separator is added below the position index, not the bookmark.
r=mano
2007-06-19 09:13:19 -07:00
sspitzer@mozilla.org
d4db964d77 fix for bug #383681: While BM is in a sorted view, adding a new separator is added below the position index, not the bookmark.
disable the "insert separator" from a sorted view and from views that are excluding items.

patch=Christine Yen <cyen@mozilla.com>

r=sspitzer
2007-06-18 21:19:39 -07:00
mozilla.mano@sent.com
df5b1d76e7 Bug 384936 - Folders in bookmarks menu are inaccessible after moving a bookmark to/in the menu. r=sspitzer. 2007-06-18 19:25:41 -07:00
sspitzer@mozilla.org
006402d0e9 fix for bug #384671: when resetting the history sidebar view, don't use applyFilter()
this is needed for bug #380735, for when we persist day and host container
open state in the history sidebar.

additionally, call load() instead of using .place directly to avoid doing queriesToQueryString() only to call queryStringToQueries().

r=mano
2007-06-18 18:31:51 -07:00
mozilla.mano@sent.com
24c272f8c2 Bug 384763 - left click broken in bookmarks menu. r=ssptizer. 2007-06-18 17:16:09 -07:00
sspitzer@mozilla.org
0314d1b6da fix for bug #384677: for history sidebar and history menu, don't specify begin / end times
r=dietrich
2007-06-18 17:08:17 -07:00
kherron@fmailbox.com
264271c49e Backing out patch for bug 376991. 2007-06-17 08:09:44 -07:00
kherron@fmailbox.com
629f5b5d26 Bug 367991 - Remove the places-specific calendar widget. Patch by Asaf Romano <mano@mozilla.com>, r=sspitzer. 2007-06-17 05:52:56 -07:00
mozilla.mano@sent.com
2104094fcf Bug 384690 - bookmarks menu is broken. r=dietrich. 2007-06-16 20:14:08 -07:00
kherron@fmailbox.com
3ef7e96849 Bug 381329 - Build fails with GCC-4.3 due to extra semi-colons and '-pedantic' flag. Patch by Art Haas <ahaas@airmail.net>. r+sr=roc. 2007-06-16 12:53:59 -07:00
sspitzer@mozilla.org
2f0c4a4330 fix for bug #382136: in Bookmarks Menu - delete separator at bottom position, deletes bookmark
r=dietrich
2007-06-15 22:07:42 -07:00
sspitzer@mozilla.org
623aced10e fix for bug #384670: current collection searches in bookmark organizer window search all of bookmarks
r=dietrich
2007-06-15 22:03:40 -07:00
mozilla.mano@sent.com
7d4df6bb57 Bug 384515 - ASSERT: null node when moving the root node in a places tree. r=dietrich. 2007-06-15 18:55:15 -07:00
mozilla.mano@sent.com
56a3006a8d Bug 337855 - Don't rebuild places menus on each open. patch by seth, dietrich & me, r=dietrich/me. 2007-06-15 18:53:06 -07:00
sspitzer@mozilla.org
8e07a8d6d4 fix for bug #381416: Sort order is not remembered by Bookmarks Manager when the View menu is usedpatch=Christine Yen <cyen@mozilla.com>r=sspitzer 2007-06-12 08:40:07 -07:00
sspitzer@mozilla.org
40ceec3b70 fix for bug #383762: "Sort by Name" doesn't work properly with non-ascii characters.patch=Pavel Cvrcek <bugs@jasnapaka.com>r=sspitzer 2007-06-12 08:24:44 -07:00
mozilla.mano@sent.com
0379949225 Bug 381878 - click on a folder in the bookmarks toolbar and then hover over the overflow arrow it doesn't expand. r=ssptizer. 2007-06-11 22:28:20 -07:00
mozilla.mano@sent.com
25393cf047 Bug 382888 - BM menu not working when DM is focused. r=gavin. 2007-06-11 22:24:58 -07:00
sspitzer@mozilla.org
722f5b8433 fix for regression bug #383529: after rebuilding the toolbar, "Open <feed name>" loads bogus address.r=dietrich 2007-06-06 19:00:05 -07:00
mozilla.mano@sent.com
4d33bc373e Bug 383328 - no 'open in tabs' menu item for folders / livemarks in bookmark toolbar overflow chevron. r=sspitzer. 2007-06-05 16:26:26 -07:00
mozilla.mano@sent.com
d485243cf3 Bug 381534 - cannot drag and drop url from location bar to bookmarks toolbar. r=sspitzer. 2007-06-05 16:24:39 -07:00
mozilla.mano@sent.com
b34f3a837c Bug 382073 - Bookmarks Service batch update API is a footgun. r=sayrer/mrbkap, a=mconnor. 2007-05-31 17:44:43 -07:00
mozilla.mano@sent.com
29b143d626 Bug 374613 - the context menu of places bookmarks with live titles is missing the 'reload' option. patch from Steve Won <swon@mozilla.com>, r=me, a=mconnor. 2007-05-31 17:39:09 -07:00
dietrich@mozilla.com
f49133d34f Bug 380232 occasionally not able to open the bookmarks dialog or subscribe to a feed url (using live bookmarks) [Remote chrome not allowed] (r=mano) 2007-05-31 12:13:15 -07:00
mozilla.mano@sent.com
2b3a27413f Bug 382101 - Cannot move bookmark folder to the 'root'. r=sspitzer. 2007-05-30 17:34:13 -07:00
sspitzer@mozilla.org
ea05cf85cb fix for bug #379591: places toolbar.xml should just change existing button itemChanged()r=mano 2007-05-30 09:17:34 -07:00
sspitzer@mozilla.org
216e23344d fix for bug #382195: clicking the "show all bookmark folders" button is slow when we're opening to the bookmarks root.r=mano/dietrich 2007-05-30 09:08:11 -07:00
mozilla.mano@sent.com
c7e487c482 Bug 382261 - Cannot move bookmarks toolbar folder. r=sspitzer. 2007-05-29 17:29:54 -07:00
sspitzer@mozilla.org
46a65c45cd fix for bug #381750: with lots of bookmarks, opening up the bookmark manager dialog is slowr=dietrich 2007-05-27 20:57:20 -07:00
sspitzer@mozilla.org
36437f7205 fix for bug #381894: Some Live Bookmarks only show in the places organizer.also, there was a crash lurking in the export code when we didn't have a feed uri.r=sayrer 2007-05-27 20:50:34 -07:00
sspitzer@mozilla.org
f09f8a8eef fix for bug #382178: unable to clear a livemark's "site location" in the bookmark properties dialogr=mano 2007-05-27 16:36:57 -07:00
sspitzer@mozilla.org
4786dbc7ba fix for bug #380702: right click, "Reload live Bookmark" of livemark on personal toolbar adds blank items to the personal toolbar.r=mano 2007-05-27 12:28:40 -07:00
sspitzer@mozilla.org
fa77da2d7f fix for bug #381624: history sidebar slower the first time you open it (or on startup), then when you switch history views.fix for regression bug #381896: history sidebar not sorted properly the first time you open itr=dietrich, mano 2007-05-25 16:50:21 -07:00
rflint@ryanflint.com
89b164dd07 Bug 381903 - WARNING: Components.reportError deprecated, use Components.utils.reportError in treeView.js. Patch by Ryan Jones <sciguyryan@gmail.com>, r=mano 2007-05-25 02:45:19 -07:00
sspitzer@mozilla.org
d3a6564b46 fix for bug #380230: personal toolbar overflow chevron not updatingr=dietrich 2007-05-24 23:11:02 -07:00
dietrich@mozilla.com
4dd4308599 Bug 381378 export is unacceptably slow for large bookmarks collections (r=mano) 2007-05-24 22:41:49 -07:00
sspitzer@mozilla.org
4a525be3ab fix for bug #381624: history sidebar slower the first time you open it (or on startup), then when you switch history viewsr=mano 2007-05-23 19:27:32 -07:00
jminta@gmail.com
f914a54187 Bug 381485 [Mac] Rename 'Get Info' back to 'Properties', r=mano 2007-05-23 06:19:41 -07:00
sspitzer@mozilla.org
9ab4f9d82c fix for bug #381624: history sidebar slower the first time you open it (or on startup), then when you switch history viewsr=mano 2007-05-22 18:44:36 -07:00
mozilla.mano@sent.com
fcf315384a Bug 372508 - rename insertItem to insertBookmark and add a title parameter. r=dietrich. 2007-05-22 18:06:31 -07:00
mozilla.mano@sent.com
fb0664a9e6 Bug 371823 - Optimize item moves. r=sspitzer. 2007-05-22 15:03:53 -07:00
sspitzer@mozilla.org
767defa6da fix for bug #368240: A link on the bottom of the history list takes long to loadr=mano 2007-05-22 13:36:43 -07:00
sspitzer@mozilla.org
a61bcd2baa fix for bug #381594: not warning user about loading js / data urlsr=dietrich 2007-05-22 13:19:45 -07:00
philringnalda@gmail.com
37bb18dcbe Bug 381335 typo fix, irc-r=mano 2007-05-20 18:38:50 -07:00
mozilla.mano@sent.com
ce228c8079 Bug 381281 - Cannot reorder bookmarks. r=sspitzer. 2007-05-20 15:27:04 -07:00
mozilla.mano@sent.com
a4805be4dd Bug 381335 - Fix various js warnings in places front-end code. patch from Henrik Skupin <hskupin@gmail.com>, r=me. 2007-05-20 08:18:41 -07:00
sayrer@gmail.com
5027b97c3d Bug 381239. Null out members of PrefHandler to break reference cycles. r=dietrich 2007-05-19 20:33:04 -07:00
jminta@gmail.com
af7f11f1ff Bug 381217 places exported bookmarks.html missing classic 'This is an automatically generated file' HTML comment, r=mano 2007-05-19 18:00:19 -07:00
mozilla.mano@sent.com
2af0609eee Bug 381218 - Organizer's view menu is broken. r=sspitzer. 2007-05-19 17:44:57 -07:00
mozilla.mano@sent.com
a5b97a3f54 Yet another attempt to fix result & result nodes leaks (see bug 381239 comment 13) 2007-05-19 13:29:48 -07:00
mozilla.mano@sent.com
c595ac3dea missing semicolon 2007-05-19 12:55:37 -07:00
mozilla.mano@sent.com
adbab58705 Break cycles between the xbl views to history results (bug 381239). 2007-05-19 12:54:10 -07:00
sspitzer@mozilla.org
2af310476a fix for bug #371827: places bookmarks need additional metadate for lastModified and dateAdded.fix for bug #381209: don't write out ID attributes to bookmarks.html, as it will confuse Firefox 2.patch by dietrich, sspitzer. r=mano,dietrich,sspitzer 2007-05-18 17:40:55 -07:00