Commit Graph

216 Commits

Author SHA1 Message Date
Benjamin Smedberg
24e7cb1f78 Bug 396185 - Make nsIFrame derivatives and helper abstract classes use a different dynamic-cast system than nsISupports:
* we know all types frames may be cast to at compile time, so instead of extensible GUID IIDs, use a big enum (see nsQueryFrame::FrameIID)
* eliminate all vestiges of refcounting, since frames aren't refcounted

Some frames (SVG frames in particular) still implement nsISupports-derived interfaces, for example nsISVGValue. There is a FrameIID for nsISVGValue that lets you go from a frame to the XPCOM interface, but you can't query back.

r+sr=roc

nsITextControlFrame didn't have an IID the first time around, but this wasn't a compile error because nsITextControlFrame::kFrameIID inherited from nsIFormControlFrame::kFrameIID. I've added a static analysis pass to verify the correct behavior, since I can't figure out a way to make the compiler do it.

--HG--
extra : rebase_source : 4894a2ca0278e2ab92f27459db77165f8348cf41
2009-01-12 14:20:59 -05:00
Benjamin Smedberg
50621e4f9f Backed out changeset 4c4df6ed1b41 - Bug 396185 - Make nsIFrame not inherit from nsISupports due to mochitest failures... these appear to be crashes in nsGenericHTMLElement::GetEditorInternal. 2009-01-09 11:35:24 -05:00
Benjamin Smedberg
d0b948876f Bug 396185 - Make nsIFrame derivatives and helper abstract classes use a different dynamic-cast system than nsISupports:
* we know all types frames may be cast to at compile time, so instead of extensible GUID IIDs, use a big enum (see nsQueryFrame::FrameIID)
* eliminate all vestiges of refcounting, since frames aren't refcounted

Some frames (SVG frames in particular) still implement nsISupports-derived interfaces, for example nsISVGValue. There is a FrameIID for nsISVGValue that lets you go from a frame to the XPCOM interface, but you can't query back.

r+sr=roc

This patch locally causes two REFTEST-UNEXPECTED-PASS for Bidi stuff. It's possible that I accidentally fixed a bug, but I'm not sure, so I'm going to wait for the tinderboxes to confirm my local results.
2008-11-05 14:25:30 -05:00
Benjamin Smedberg
720c4f5577 Bug 472348 - Some unused variables found by combing the warning database, rs=bz 2009-01-06 14:25:58 -05:00
Tyler [Triage]
a0ce012f99 Bug 471154 - remove editor readme from mozilla-central; r=daniel 2008-12-30 06:29:45 +01:00
Boris Zbarsky
c07452f1f9 Bug 467647. Fix editor leak in error conditions. r+sr=peterv 2008-12-28 11:10:49 -08:00
Olli Pettay
4bb69ed3fb Bug 432025 - Crash [@ CallQueryInterface<nsIDOMElement, nsIContent>], r+sr=peterv 2008-12-27 21:13:49 +02:00
Robert O'Callahan
a3a3951684 Bug 459613. When we tear down a textcontrol frame, tell its editor that we're blowing away the frame tree so it doesn't try to clear the spellcheck selection, which not only wastes time but does GetPrimaryFrame for during frame destruction which is a no-no. r+sr=mats 2008-12-12 21:34:43 +13:00
Olli Pettay
74e208a642 Bug 449006, r+sr=peterv 2008-12-10 18:46:36 +02:00
Sylvain Spinelli
a5672f5802 Bug 366682 - spellCheckRange : scan only the first word of a text node and stop; r+sr=roc 2008-12-06 19:39:47 +01:00
Markus Stange
76daa5a7da Bug 463042 - Smooth scrolling isn't working with the scrollbar or the keyboard arrows, r+sr=roc 2008-12-02 14:18:08 +01:00
Theppitak KaroonboonyananTheppitak Karoonboonyanan
847fd40c16 Bug 461816 - pressing Ctrl-U in password dialog asserts and then crashes; r+sr=peterv 2008-12-04 14:17:48 +01:00
Ted Mielczarek
a82f5ca414 bug 432415 - strip trailing newlines when editor.singleline.pasteNewlines == 2 (Copy pasting a cell from an xls/ods file adds an extra space at the end). r+sr=neil, a=beltzner 2008-11-19 12:12:30 -05:00
Phil Ringnalda
bbe7e1d08a Bug 461888 - Remove unused PACKAGE_FILE and PACKAGE_VARS and .pkg files, mozilla-central part, r=bsmedberg 2008-11-03 19:46:28 -08:00
Chris Pearce
c4eb79e541 Bug 432225 - Spell Checker does not always identify misspelled words; r+sr=peterv 2008-11-01 01:30:45 +01:00
Asaf Romano
3ef8941de2 Comment fix 2008-10-20 18:32:50 +02:00
Asaf Romano
52487616c6 Bug 460595 - Cannot drag text selection in input control. r=smaug, sr=neil. 2008-10-20 18:29:55 +02:00
Asaf Romano
c380bb39b5 Typos fix for bug 459323 2008-10-18 19:45:47 +02:00
Asaf Romano
ea32ac412c Bug 459323 - Drag and Drop in input controls is broken. r=smaug, sr=sicking. 2008-10-17 22:04:55 +02:00
Theppitak Karoonboonyanan
018ec4b25f Bug 157546. The 'delete' key should delete an entire cluster. r=peterv,r+sr=roc 2008-10-16 20:44:32 +13:00
Olli Pettay
9d96a5cb3f bug 302775 - extractContents doesn't work if start and end node of a Range object is an attribute node, r=peterv, sr=sicking 2008-10-15 12:40:28 +03:00
Mats Palmgren
17b4fed484 Improve the editor selection/movement tests. b=455818 r=roc 2008-10-11 05:24:12 +02:00
Mats Palmgren
16c50aefb9 Don't insert a <br> when deleting all content in an inline contenteditable element. b=456244 r+sr=peterv 2008-10-11 04:38:47 +02:00
Taras Glek
c51f841035 Bug 455806: outparamdel nsIPrivateTextEvent r+sr=jst 2008-10-09 16:31:19 -07:00
Taras Glek
a282d4a876 Bug 455943: outparamdel nsIPrivateTextRangeList r+sr=jst 2008-10-09 16:30:48 -07:00
Neil Deakin
e48764cbae Bug 454986, multiple images being dropped, r+sr=neil 2008-09-19 11:26:49 -04:00
Robert O'Callahan
3710c8dff3 Comment out tests instead of using todo. 2008-09-18 15:18:27 +12:00
Robert O'Callahan
c9cae47fa0 Bug 454004. Disable tests that fail on Windows. 2008-09-18 13:43:10 +12:00
Robert O'Callahan
34d5a63301 Bug 454004 - Ctrl+Home / Ctrl+End don't work in Mail Compose window; r+sr=mats.palmgren 2008-09-18 01:28:17 +02:00
Neil Deakin
b62c16559f Bug 454595, improve editor drag and drop code, r+sr=neil 2008-09-13 18:09:20 -04:00
Ted Mielczarek
468a3823fc bug 447642 - get rid of --disable-mochitest, replace MOZ_MOCHITEST with ENABLE_TESTS. r=bsmedberg 2008-09-09 13:59:11 -04:00
Arpad Borsos
4b171f9d59 Bug 414046 - Remove nsPresShell::GetLayoutObjectFor(), r/sr=roc 2008-09-04 22:32:39 +02:00
Mark Banner
41e23d2acb Bug 445146 Move editor/ui from mozilla-central to comm-central, build changes r=ted, move r/sr=Neil 2008-09-03 14:35:28 +01:00
Neil Deakin
7ad96d6b3e Bug 356295. Implement HTML5 drag-drop. r=smaug,neil,sr=roc 2008-08-27 08:07:27 -04:00
Boris Zbarsky
fc1785cbc1 Backed out changeset 6958399a2eb1 o try to fix failed mochitests on Windows and Linux 2008-08-25 11:08:28 -04:00
Neil Deakin
7c92721496 Bug 356295. Implement HTML5 drag-drop API. r=smaug,sr=roc 2008-08-25 21:56:29 +12:00
Dave Camp
66ad0d3422 Backed out changeset 30d900751ca9 to fix unit test orange (Bug 356295) 2008-08-19 17:55:30 -07:00
Neil Deakin
f58dac1bbf Bug 356295. Implement HTML5 drag-drop. r=smaug,sr=roc 2008-08-20 10:31:45 +12:00
Robert O'Callahan
1499813be0 Bug 118704. Get the document title from the DOM instead of storing it in the document object. Relanding with hopeful leak fix. r+sr=jst 2008-08-18 14:10:28 +12:00
Karsten Düsterloh
e897be84fc Bug 446281: double id cleanup, part 3: editor window; r=stefanh, sr=Neil 2008-08-17 23:57:37 +02:00
Karsten Düsterloh
dc0f8376b5 Bug 450647: EditorCommandsOverlay.xul is unused and should be removed; r/sr=Neil 2008-08-17 16:14:55 +02:00
Robert O'Callahan
65a0e17d1b Backing out bug 118704 to try to fix Windows leak orange 2008-08-16 23:27:40 +12:00
Robert O'Callahan
21fbc52690 Bug 118704. Get the document title from the DOM instead of storing it as a string in the document. r+sr=jst 2008-08-16 21:01:52 +12:00
Masayuki Nakano
41bdf942b6 Bug 449955 – Remove #ifdef of nsCaret.cpp for IME r+sr=roc 2008-08-13 10:55:39 +09:00
Benjamin Smedberg
e8fa485944 From bug 449561, bug 445949, and others: let's just ditch nsDerivedSafe since the class of errors it's trying to protect against are uncommon in today's world. r=dbaron 2008-08-11 11:05:58 -04:00
Masayuki Nakano
446176f140 Bug 449012 – Remove legacy Reconversion/QueryCaretRect Events r=ere+roc, sr=roc 2008-08-09 11:46:30 +09:00
Masayuki Nakano
fdb1760a4d Bug 447945 IME candidate list is positioned to wrong place when the caret is in <panel> r=roc+katakai, sr=roc 2008-07-31 01:12:49 +09:00
stefanh@inbox.com
0508b90ed0 Bug 435079 (Composer pref pane migration), landing missing bits from prev. m-c landing. Original patch: r+sr=Neil. 2008-07-29 16:22:45 +02:00
L. David Baron
2c2f6ed495 Change the binding parent for native anonymous content to work like the binding parent for XBL anonymous content, and be the parent of the anonymous content subtree rather than the root of the anonymous content subtree. (Bug 436453) r=bzbarsky,smaug,surkov sr=bzbarsky 2008-07-22 21:50:20 -07:00
Stefan
655cc04686 Bug 435079 - Migrate Composer's New Page Settings prefs to the new prefpane
r=NeilAway, sr=NeilAway
2008-07-17 12:04:44 -04:00