Ehsan Akhgari
6e51f00ed1
Bug 1188203 - Fix more constructors in XPCOM; r=froydnj
2015-07-28 12:24:37 -04:00
Kyle Huey
5381a1f36f
Bug 1186780: Replace EnumerateRead with new iterators in cycle collection code. r=mccr8
2015-07-26 19:29:52 -07:00
Nicholas Nethercote
5916737ae6
Bug 1187767 - Ensure PLDHashTable's generation is always updated when the entry store is modified. r=froydnj.
2015-07-26 19:57:23 -07:00
Honza Bambas
07fc6c3685
Bug 1024056 - Simple ASCII lexical analyzer. r=nfroyd
2015-07-27 05:07:00 -04:00
Carsten "Tomcat" Book
32eafbd4af
Backed out changeset 1ca5723f69d4 (bug 1186780) for dom crashes
2015-07-27 08:01:09 +02:00
Kyle Huey
ebd7c7a59e
Bug 1186780: Replace EnumerateRead with new iterators in cycle collection code. r=mccr8
2015-07-26 19:29:52 -07:00
Nicholas Nethercote
8c51fea88e
Bug 1187197 (part 3) - Convert pldhash.{cpp,h} to C++ style comments. r=froydnj.
2015-07-23 23:13:11 -07:00
Nicholas Nethercote
891f872d0b
Bug 1187197 (part 2) - Put function return types on their own line. r=froydnj.
2015-07-23 23:13:10 -07:00
Nicholas Nethercote
0eec64ec51
Bug 1187197 (part 1) - Move comments from PL_DHashTable* functions to the equivalent methods. r=froydnj.
...
Because the PL_DHashTable* functions will go away eventually (bug 1121760).
2015-07-23 21:43:48 -07:00
Michael Layzell
5621bebdfc
Bug 1159433 - Part 4: Mark nsTAutoString_CharT and nsAutoArrayBase as non-memmovable; r=froydnj
2015-07-24 19:15:40 -04:00
Michael Layzell
edac1d6cf7
Bug 1159433 - Part 3: Make nsTArray_CopyChooser only accept memmovable argument types by default; r=froydnj
2015-07-24 19:15:23 -04:00
Michael Layzell
52acf71f79
Bug 1123907 - Part 2: Add MOZ_NEEDS_NO_VTABLE_TYPE to Attributes.h, and use it to verify the EntryType argument of nsTHashtable; r=ehsan
2015-07-24 19:14:09 -04:00
Xidorn Quan
3023bb4d58
Bug 1187201 - Add char16 wrapper constructor for NS_ConvertUTF16toUTF8 in external string API. r=froydnj
2015-07-24 23:06:50 +10:00
Julian Seward
1b533ff884
Bug 1183093 - Uninitialised value use in Probe::Trigger. r=dteller.
2015-07-24 11:45:50 +02:00
Nate Hughes
14332a5af7
Bug 986302 - Add memory reporting for HPACK tables r=hurley r=njn
2015-07-17 14:38:10 -07:00
Nicholas Nethercote
b51a99e1d5
Bug 1181443 (part 2) - Use nsTHashtable::Iterator in TestHashtables.cpp. r=froydnj.
2015-07-23 02:36:13 -07:00
Nicholas Nethercote
b1a271ed78
Bug 1181443 (part 1) - Use nsTHashtable::Iterator in nsCheapSet. r=froydnj.
...
nsCheapSet is used little enough that I didn't bother creating an iterator for
it.
I removed the dependency on PLDHashOperator by introducing nsCheapSetOperator,
which is equivalent.
2015-07-23 02:35:27 -07:00
Andrew McCreight
e40986f583
Bug 931571, part 15 - Remove extra spaces in nsVariant macros. r=froydnj
2015-07-23 12:28:30 -07:00
Andrew McCreight
37e9703046
Bug 931571, part 14 - Delete various ways to copy or move nsDiscriminatedUnion. r=froydnj
...
nsDiscriminatedUnion owns memory without using smart pointers, so implementing anything
that would copy or move around one of these will require some care. Just forbid these
for now.
2015-07-23 12:28:30 -07:00
Andrew McCreight
708b3f5da4
Bug 931571, part 13 - Add a destructor for nsDiscriminatedUnion. r=froydnj
...
The existing nsDiscriminateUnions either always call Cleanup() when they
are about to go away, or they only handle scalar values so it is safe to
call Cleanup() on them without worrying about another discriminated union
having taken over any memory owned by this union.
2015-07-23 12:28:30 -07:00
Andrew McCreight
549a807921
Bug 931571, part 12 - Add nsDiscriminatedUnion::GetType(). r=froydnj
...
This is not quite enough to make the data members private because
XPCVariant pokes around to do some JS array stuff.
2015-07-23 12:28:30 -07:00
Andrew McCreight
34efb30120
Bug 931571, part 11 - Turn nsDiscriminatedUnion's Traverse function into a method. r=froydnj
2015-07-23 12:28:30 -07:00
Andrew McCreight
3cbbce0b13
Bug 931571, part 10 - Turn SetFromVariant into a method. r=froydnj
2015-07-23 12:28:30 -07:00
Andrew McCreight
753e925a63
Bug 931571, part 9 - Turn most of the nsVariant setters into nsDiscriminated methods. r=froydnj
...
This also adds a new nsDiscriminatedUnion method SetFromDOMString, as somebody added an nsVariant method without the corresponding helper.
2015-07-23 12:28:30 -07:00
Andrew McCreight
000a18bbde
Bug 931571, part 8 - Turn ConvertToISupports, ConvertToInterface and ConvertToArray to methods. r=froydnj
2015-07-23 12:28:30 -07:00
Andrew McCreight
51fedecbfb
Bug 931571, part 7 - Turn ConvertTo*String and ToString into methods. r=froydnj
2015-07-23 12:28:30 -07:00
Andrew McCreight
ecda5f23fb
Bug 931571, part 6 - Make ConvertToID and String2ID into methods. r=froydnj
2015-07-23 12:28:30 -07:00
Andrew McCreight
3f5ef7e2c8
Bug 931571, part 5 - Turn basic ConvertTo functions into methods. r=froydnj
2015-07-23 12:28:30 -07:00
Andrew McCreight
9e77e4be3a
Bug 931571, part 4 - Fix some spacing inside macros.
...
There's more that could be done to fix the style, but this was bothering me.
2015-07-23 12:28:30 -07:00
Andrew McCreight
59986fc413
Bug 931571, part 3 - Rename return value of macro generated methods. r=froydnj
2015-07-23 12:28:29 -07:00
Andrew McCreight
06c877e501
Bug 931571, part 2 - Convert Cleanup() and FreeArray() to methods. r=froydnj
2015-07-23 12:28:29 -07:00
Andrew McCreight
0f713cbe02
Bug 931571, part 1 - Use a constructor for nsDiscriminatedUnion. r=froydnj
2015-07-23 12:28:29 -07:00
Bobby Holley
0e832fdd23
Bug 1161831 - Generate an extra macro to declare a non-virtual variant of an interface. r=billm
...
This allows us to have a shared superclass that implements the guts of a shared
superinterface, without having the superclass actually inherit the superinterface
(which leads to annoying and unnecessary diamond-inheritance).
2015-07-21 12:57:20 -07:00
Andrew McCreight
a561aa462b
Bug 1179924 - Create a more modern JS object holder for cross-thread references to JS objects. r=smaug
2015-07-21 11:31:44 -07:00
Birunthan Mohanathas
94c853eedb
Bug 1185589 - Properly handle self-assignment in nsTArray::operator=. r=mccr8
2015-07-21 09:42:58 -07:00
Andrew McCreight
28c1f59f2b
Bug 1185144 - nsConsoleService::LogMessageWithMode() should release the retired message on the main thread. r=froydnj
...
Also, add release asserts that the other methods that addref or release console messages are only run on the main thread.
Finally, add an assert that nsScriptErrorWithStack is only created on the main thread.
2015-07-21 07:50:09 -07:00
Carsten "Tomcat" Book
69f364f210
Backed out changeset 8b90b21e0c64 (bug 986302) for static build failures
2015-07-21 08:53:37 +02:00
Nate Hughes
17ce4e8545
Bug 986302 - Add memory reporting for HPACK tables. r=hurley r=njn
2015-07-17 14:38:10 -07:00
Nicholas Nethercote
105ab2586a
Bug 1185399 (part 2) - Remove macros from pldhash.cpp. r=froydnj.
2015-07-20 17:15:00 -07:00
Nicholas Nethercote
aefb809e48
Bug 1185399 (part 1) - Remove macros from pldhash.h. r=froydnj.
2015-07-20 17:06:38 -07:00
Kyle Huey
b8d33919e9
Bug 1185470: Remove 'Get' prefixes from hashtable iterator methods. r=froydnj
2015-07-20 20:21:28 +08:00
Carsten "Tomcat" Book
e268f9c147
merge mozilla-inbound to mozilla-central a=merge
2015-07-20 11:36:42 +02:00
Victor Porof
dd9c146536
Bug 1183228 - Use separate files for AutoTimelineMarker and AutoGlobalTimelineMarker, r=smaug
2015-07-17 15:51:39 -04:00
Andrew McCreight
691be28839
Bug 1184695 - Fix some indentation in nsHashPropertyBag. r=poiru
2015-07-16 17:50:43 -07:00
Ehsan Akhgari
41912c83ec
Bug 1123386 - Part 3: Mark DoNothingCallback::Callback as override in order to fix a build issue in warnings as errors mode
2015-07-17 22:19:57 -04:00
Wes Kocher
f3e6712718
Merge m-c to inbound, a=merge CLOSED TREE
2015-07-15 16:41:49 -07:00
Wes Kocher
98b135f0e3
Merge fx-team to central, a=merge
2015-07-15 16:33:58 -07:00
Benoit Girard
ac1eee9519
Bug 1182516 - Fix mid-air conflict with 3fd2ab6cb762 on a CLOSED TREE. r=bustage
2015-07-15 18:08:25 -04:00
Ryan VanderMeulen
a68f3127f6
Merge m-c to fx-team. a=merge
2015-07-15 13:30:09 -04:00
Ryan VanderMeulen
605353eabf
Merge b2g-inbound to m-c. a=merge
2015-07-15 13:25:56 -04:00
Kan-Ru Chen
1d505b3429
Bug 1181518 - Change the reason for memory-pressure fired during priority change. r=gsvelto
2015-07-15 17:07:39 +08:00
Benoit Girard
0d865b0172
Bug 1182516 - Add Chaos Mode environment variable MOZ_CHAOSMODE. r=roc
2015-07-14 17:29:23 -04:00
Ben Kelly
1d6f011995
Bug 1173912 Fail opaque responses for client requests. r=ehsan
2015-07-14 13:11:26 -07:00
Ben Kelly
7d248a15f8
Bug 1173934 Show a message if a docshell fails to load due to SW intercept failure. r=ehsan r=jdm
2015-07-14 13:11:26 -07:00
Ryan VanderMeulen
8b4859a34c
Merge m-c to inbound. a=merge
2015-07-15 13:26:44 -04:00
Peter Elmers
90309d8599
Bug 1183291 - Factor idl-parser into a Python package. r=khuey
...
Move Python code into an xpidl subdirectory, and include a setup.py to allow
inclusion from pip install or requirements files. Change build directory
variables appropriately.
2015-07-13 13:09:11 -07:00
Jeff Muizelaar
1f2e10f9ba
Bug 1178426. Add GfxInfo to ServicesList.h. r=nfroyd
2015-07-08 16:51:09 -04:00
Andrew McCreight
efe14768b4
Bug 1182318 - Part 2: Remove Closure from CycleCollectedJSRuntime. r=smaug
...
Closure is now just a wrapper around a single boolean, so instead pass a pointer to the boolean.
2015-07-14 08:01:00 -04:00
Andrew McCreight
a440e4df12
Bug 1182318 - Part 1: Remove Closure::mCb. r=smaug
...
This field no longer needs to be passed in the closure thanks to the iterator.
2015-07-14 08:01:00 -04:00
Olli Pettay
784107ead5
Bug 1182277, don't leak when using nsAutoTArray inside nsTArray, r=nfroyd
2015-07-14 17:05:10 +03:00
Nicholas Nethercote
2aa81ecf68
Bug 1180122 - Make Chaos Mode affect PLDHashTable's iterators. r=froydnj.
...
This makes the code less elegant, but that's unavoidable.
2015-07-03 00:27:27 -07:00
Alexandre Poirot
653adb0d6f
Bug 814497 - Cleanup console service cache when a window is destroyed. r=nfroyd
2015-07-09 06:49:00 -04:00
Birunthan Mohanathas
47ed3a3675
Bug 1182996 - Fix and add missing namespace comments. rs=ehsan
...
The bulk of this commit was generated by running:
run-clang-tidy.py \
-checks='-*,llvm-namespace-comment' \
-header-filter=^/.../mozilla-central/.* \
-fix
2015-07-13 08:25:42 -07:00
Michael Layzell
fdcc8755b3
Bug 1028132 - Remove mozilla::HasDangerousPublicDestructor<T>. r=mccr8
2015-07-07 18:45:00 -04:00
Nicholas Nethercote
b30e0fc39c
Bug 1182926 - Fix "observer-service-suspect" bustage. r=poiru.
2015-07-12 15:55:27 -07:00
Nicholas Nethercote
047ce23ad8
Bug 1181411 - Test some expected aborts in PLDHashTable. r=glandium.
2015-07-12 18:50:21 -07:00
Wes Kocher
781244249b
Backed out changeset adf95d1cd0aa (bug 1173934) for fetch-frame-resource.https.html WPT orange and test_synthesized_response.js S4 orange CLOSED TREE
2015-07-10 15:59:01 -07:00
Wes Kocher
f2c450e6c8
Backed out changeset df6593df027b (bug 1173912)
2015-07-10 15:58:24 -07:00
Ben Kelly
44931bb4b8
Bug 1173912 Fail opaque responses for client requests. r=ehsan
2015-07-10 14:28:32 -07:00
Ben Kelly
6ff3ab6e72
Bug 1173934 Show a message if a docshell fails to load due to SW intercept failure. r=ehsan r=jdm
2015-07-10 14:28:32 -07:00
Wes Kocher
5fe15ee75d
Backed out changeset 9814f77d258b (bug 1179924) for frequent random serviceworkers failures CLOSED TREE
2015-07-10 12:48:34 -07:00
Andrew McCreight
8b32bfc1cd
Bug 1179924 - Create a more modern JS object holder for cross-thread references to JS objects. r=smaug
2015-07-10 07:41:33 -07:00
Nicholas Nethercote
1e82056a83
Bug 1181445 (part 13) - Use nsBaseHashTable::Iterator in xpcom/ds/. r=froydnj.
2015-07-09 16:54:59 -07:00
Nicholas Nethercote
00c571d40d
Bug 1181445 (part 12) - Use nsBaseHashTable::Iterator in xpcom/threads/. r=froydnj.
2015-07-09 16:54:59 -07:00
Nicholas Nethercote
007bfec9d7
Bug 1181445 (part 11) - Use nsBaseHashTable::Iterator in xpcom/glue/. r=froydnj.
2015-07-09 16:54:59 -07:00
Nicholas Nethercote
6aa796e98a
Bug 1181445 (part 10) - Use nsBaseHashTable::Iterator in CycleCollectedJSRuntime. r=mccr8.
2015-07-09 16:54:59 -07:00
Nicholas Nethercote
16b5e58866
Bug 1181445 (part 9) - Use nsBaseHashTable::Iterator in nsConsoleService. r=froydnj.
2015-07-09 16:54:59 -07:00
Nicholas Nethercote
85c9fe03d6
Bug 1181445 (part 8) - Use nsBaseHashTable::Iterator in SystemMemoryReporter. r=froydnj.
2015-07-09 16:54:59 -07:00
Nicholas Nethercote
5fab70f466
Bug 1181445 (part 7) - Use nsBaseHashTable::Iterator in xpcom/reflect/. r=froydnj.
2015-07-09 16:54:59 -07:00
Nicholas Nethercote
fa9f361c39
Bug 1181445 (part 6) - Use nsBaseHashTable::Iterator in xpcom/components/. r=froydnj.
...
Note that enumfunc_pentries and persistent_userstruct are unused, and so could
be removed.
2015-07-09 16:54:59 -07:00
Nicholas Nethercote
7c6fd99057
Bug 1181445 (part 5) - Use nsTHashTable::Iterator in nsTHashtable.h. r=mccr8.
...
This is a particularly nice example of how iterators can be so much nicer than
Enumerate()-style functions:
1 file changed, 4 insertions(+), 33 deletions(-)
2015-07-09 16:54:59 -07:00
Nicholas Nethercote
beb2574643
Bug 1181445 (part 4) - Use nsTHashTable::Iterator in nsCategoryManager. r=froydnj.
2015-07-09 16:54:58 -07:00
Nicholas Nethercote
57355d86b6
Bug 1181445 (part 3) - Use nsTHashTable::Iterator in nsObserverService. r=froydnj.
2015-07-09 16:49:32 -07:00
Nicholas Nethercote
37437f9afd
Bug 1181445 (part 2) - Use nsTHashTable::Iterator in nsMemoryReporterManager. r=froydnj.
2015-07-08 22:32:39 -07:00
Nicholas Nethercote
426b2f28c8
Bug 1181445 (part 1) - Implement iterators for nsTHashtable and nsBaseHashtable. r=froydnj.
...
nsBaseHashtable has both EnumerateRead() and Enumerate(). A comment claims that
the latter locks the table, but this is false, so I removed the comment. Other
than that the only notable difference between them is that they have slightly
different types for dealing with values (|UserDataType| vs |DataType&|) so I've
implemented both GetUserData() and GetData(), allowing either type to be used.
2015-07-07 20:47:59 -07:00
Jim Mathies
f7fdc6ece7
Bug 1128454 - Add crash report annotations for plugin bridge operation failures. r=billm
2015-07-09 19:07:49 -05:00
Randell Jesup
c29b3218d0
Bug 1155059: Patch 3&7 - fix leaks in Promise, ConsoleService and JS Finalize r=froydnj
2015-07-09 23:21:46 -04:00
Randell Jesup
603a3116b7
Bug 1155059: Patch 4 - invoke NS_ASSERTION if DispatchToMainThread fails to get MainThread ptr r=froydnj
2015-07-09 23:21:46 -04:00
Randell Jesup
cb8f0924d3
Bug 1155059: Patch 1&2 - Convert Dispatch() and friends to already_AddRefed<> r=froydnj
...
Modify Dispatch IDL and code to deal with MSVC issues with overloaded templates r=froydnj
2015-07-09 23:21:46 -04:00
Randell Jesup
8be77a6119
Bug 1155059: Patch 0 - add do_AddRef() r=froydnj
2015-07-09 23:21:46 -04:00
Mike Hommey
dba327c463
Bug 833117 - Replace g_slice_set_config() with G_SLICE environment variable. r=nfroyd,r=karlt
...
Using g_slice_set_config() fails with newer glib because the slice allocator
now has a static constructor that runs when glib is loaded, consequently
emitting a noisy error message which confuses people into believing it's the
root of their problems.
The only way left to force the slice allocator to use "system" malloc (in
practice, jemalloc) is to set the G_SLICE environment variable to
always-malloc, and that needs to happen before glib is loaded.
Fortunately, the firefox and plugin-container executables don't depend on
glib. Unfortunately, webapprt does, so the problem remains for web apps
running through it. xpcshell and other executables that depend on libxul
directly (as opposed to loading it dynamically) are not covered either.
2015-07-10 09:56:05 +09:00
Randell Jesup
07ac79c0f2
Bug 1178890: Update timer arrays after sleep to account for time sleeping r=bwc,froydnj
2015-07-09 20:18:34 -04:00
Nathan Froyd
7992fb6420
Bug 1151506 - move nsIInterfaceInfo::isMainProcessScriptable to the end of the interface's vtable; r=dbaron
...
Adding isMainProcessScriptable() into the middle of nsIInterfaceInfo
caused problems with some binary addons that relied on the ordering of
the methods in nsIInterfaceInfo. In an attempt to placate those addons,
move isMainProcessScriptable() to the end of the vtable. This change is
a no-op for normal libxul usage.
2015-06-29 10:28:14 -04:00
Nicholas Nethercote
fb8b6912c9
Bug 1179071 - Merge RemovingIterator into Iterator. r=froydnj.
...
The original motivation for the Iterator/RemovingIterator split was that
PLDHashTable Checker class would treat them differently. But that didn't end up
happening (see bug 1131308). So this patch merges them. This is a small code
size win now but it will become bigger when I add iterators to nsTHashTable and
nsBaseHashtable.
The only complication is that PLDHashTable::Iter() is now non-const, which is
a problem if you use it in a const method. So I added PLDHashTable::ConstIter()
which is used in just two places. It's a bit of a hack -- effectively a
const_cast -- but I don't think it's too bad.
2015-07-06 22:02:26 -07:00
Nicholas Nethercote
2663e88cb7
Bug 1180084 - Convert TestPLDHash.cpp to a gtest. r=froydnj.
...
The switch to unsigned integer constants (e.g. "0u") are necessary to avoid
compiler warnings about signed/unsigned comparisons.
2015-07-07 17:54:03 -07:00
Birunthan Mohanathas
c4d6688187
Bug 968520 - Add nsTArray::Assign. r=froydnj
2015-07-07 11:27:03 -07:00
Dragana Damjanovic
e3003eee82
Bug 905127 - Part 2 - remove unnecessary nsNetUtil.h includes r=jduell
2015-07-06 07:55:00 +02:00
Robert O'Callahan
aa0a113fa7
Bug 1143575. Avoid use of COMPARE macro which can clash with Android headers. r=bent
2015-06-07 12:26:40 +03:00
Nicholas Nethercote
0dd3f3ad0a
Bug 1180072 - Remove PL_DHashTableEnumerate(). r=froydnj.
...
It's no longer used, and the Iterator classes are much nicer. Yay.
2015-06-18 22:19:10 -07:00
Bill McCloskey
ad4d5d83e6
Bug 1177013 - Use CancelCurrentTransaction to avoid crashes (r=dvander)
2015-07-06 19:58:44 -07:00