Shawn Wilsher
58a139c23e
Tests for moz-anno protocol for favicons.
...
The code this was testing was originally added in bug 316077. This test was
reviewed in bug 481227 because we are modifying the favicon code path.
r=mak
2009-03-11 14:04:05 -04:00
Marco Bonardo
93a4939182
Bug 482276 - mDBVisitsForFrecency query doesn't use indices for sorting (we can be 7x faster!), r=sdwilsh
2009-03-11 14:34:26 +01:00
Boris Zbarsky
b8aeaa6484
Bug 481257. Make the insertion triggers not do an O(N) scan of the whole table. r=sdwilsh
2009-03-09 13:13:55 -04:00
Jeff Walden
98699d32c2
Bug 482068 - Finalize places statements in tests, because failure to do so => assertions that make debug builds and the people who run tests in them angry. r=sdwilsh
2009-03-08 22:12:48 -07:00
Marco Bonardo
6b584b4d71
Bug 480437 - test_expiration is working on wrong assumptions, r=dietrich
2009-03-05 13:08:43 +01:00
Marco Bonardo
210ad84906
Bug 431153 - Middle clicking on a tag in the Library left pane does not open in tabs, r=dietrich
2009-03-05 13:08:18 +01:00
Dietrich Ayala
639679471d
Bug 469422 - tag autocomplete disappears on every other character that is typed, r=mak77
2009-03-05 13:07:15 +01:00
Shawn Wilsher
d8f1be3ec1
Bug 480211 - Stop expiring history on every page visit
...
This makes the history code expire when we flush the temporary table data to
disk instead of every single time we add a visit. This is also now done on a
background thread as opposed to the main thread, in a transaction with other
work. In theory, this reduces fsyncs (but in practice, no change was noticed).
Regardless, this removes fsyncs from the main thread, which is always a good
thing to do.
r=dietrich
r=mak
2009-03-03 13:27:01 -05:00
Marco Bonardo
a9919cef88
Bug 476636 - nsFaviconService::ExpireAllFavicons cannot work, r=sdwilsh
2009-02-28 14:17:36 +01:00
Drew Willcoxon
d41a6bfc94
Bug 479082 - AutoComplete should not show unvisited not-bookmarked-elsewhere children of livemark containers, r=sdwilsh
2009-02-28 13:01:36 +01:00
Edward Lee
4e3508ccb4
Bug 479739 - Make location bar autocomplete even faster. r=sdwilsh
2009-02-25 21:46:13 -08:00
Arpad Borsos
1f930c6547
Bug 474369 - get rid of nsVoidArray; toolkit part; r+sr=benjamin
2009-02-25 16:25:10 +01:00
Shawn Wilsher
34ebf5215c
Bug 478097 - Make location bar AutoComplete faster
...
Slightly modifies our base query for the location bar that makes the query about
20% faster in some basic benchmarking.
r=dietrich
2009-02-21 15:53:07 -08:00
Shawn Wilsher
4710dc3be6
Bug 478948 - SQL statements not finalized warnings during shutdown
...
r=mak
2009-02-20 14:25:45 -08:00
Marco Bonardo
4662ddb1aa
Bug 478218 - onQuit expiration is not working, changes are never synced to disk, r=dietrich a=blocking191
2009-02-16 12:09:19 +01:00
Drew Willcoxon
8b31027ba9
Bug 455315 - when removing a bookmark we recalculate frecency with wrong isBookmark, r=dietrich
2009-02-16 12:09:19 +01:00
Shawn Wilsher
62e4ff7c7e
Bug 468705 - cache the result of _getSyncTableStatement in nsDBFlush
...
We can avoid some of the statement parsing, which will help mobile out!
r=mak
2009-02-13 18:01:55 -05:00
Marco Bonardo
d40d34bee0
Bug 477739 - Exception when clicking star icon (no editBookmarkPanel, broken JSON backup), r=dietrich a=blocking191
2009-02-12 12:32:52 +01:00
Marco Bonardo
d6266d9563
Bug 477916 - Don't allow removing the Places root through bookmarks API, r+a191=dietrich
2009-02-11 11:53:35 +01:00
Marco Bonardo
10063403f7
Bug 477793 - Make sure preventive maintenance cannot act on roots, r=sdwilsh a=blocking191
2009-02-11 11:53:35 +01:00
Marco Bonardo
a8b322321a
bug 474582 - Disable lastModifiedTime check to try fixing test orange on Linux
2009-02-09 21:49:17 +01:00
Marco Bonardo
8af19aa0fb
Bug 474582 - With initial migration Shiretoko doesn't import favorites from Internet Explorer 7 anymore, r=dietrich
2009-02-09 19:16:02 +01:00
Edward Lee
4384aa6ca1
Bug 476297 - Switch frecency idle timer to idle-daily observer. r=dietrich
2009-02-07 15:51:19 -06:00
Edward Lee
0a8120c04c
Bug 477295 - Clean up unnecessary assignments of NS_ConvertUTF*. r=sdwilsh
2009-02-06 18:18:16 -06:00
Dietrich Ayala
0198490a4d
backing out bug 432706, causes multiple regressions
2009-02-04 09:49:58 -08:00
Marco Bonardo
e21b0af40d
merge backout
2009-02-04 15:27:48 +01:00
Marco Bonardo
658f27c658
Backed out changeset 1cf6c5b25fe5 due to crashes on linux unit test boxes
2009-02-04 15:27:18 +01:00
Marco Bonardo
e80ecb6157
Bug 474582 - With initial migration Shiretoko doesn't import favorites from Internet Explorer 7 anymore, r=dietrich
2009-02-04 13:47:13 +01:00
Marco Bonardo
5d511f3bb1
Bug 475824 - preventive maintenance has low possibilites to be run, r=dietrich
2009-02-04 13:47:13 +01:00
Shawn Wilsher
8075a939ec
Bug 476292 - Crashes on startup on OS X and Linux [@ nsNavBookmarks::IsRealBookmark] [@ PL_DHashTableOperate]
...
This fixes a crash when we initialize nsNavBookmarks with a database that is out
of date (the schema version is less than the current one). Because the bookmark
service initializes the history service in its Init method, and the history
service tries to get the bookmark service if the database needs an upgrade, we
try to re-enter the bookmark service's constructor. Bad things happen.
Adds a test to ensure that we don't do this again.
r=dietrich
r=MaK77
2009-02-03 21:58:21 -05:00
Drew Willcoxon
a284ae1506
Bug 444179 - Library>Views>Sort>Sort by Tags does nothing, r=mak77
2009-01-30 13:34:38 +01:00
Jeff Muizelaar
a7c6031376
nsNavHistory::AddDocumentRedirect doesn't handle INTERNAL redirects - bug 475069 r=mak77
2009-01-29 14:26:04 -05:00
Shawn Wilsher
4756beb1ae
Bug 449406 - bookmarks of TRANSITION_DOWNLOAD and TRANSITION_EMBED don't show up in the location bar if they've been visited
...
This adds a new function to nsNavBookmarks that determines if a place id is a
"real" bookmark (not a livemark child). It also makes a number of places use
this new function to unify and simplify a number of code paths.
Additionally, it changes how frecency is calculated for bookmarked items. If a
visit is bookmarked (aIsBookmarked is true in CalculateFrecencyInternal), the
visited bookmark bonus is now added for all visits. The visit bonus was also
cut in half for bookmarks so TRANSITION_BOOKMARK will still end up with the same
value (150).
r=dietrich
r=MaK77
2009-01-27 21:01:33 -05:00
Gavin Sharp
b34e772a9e
Bug 474538 - nsIBrowserHistory::removePagesFromHost documentation is crazy, r=sdwilsh
2009-01-23 12:52:14 +01:00
Daniel Holbert
2a7d88e05a
Bug 473236 - Remove executable bit from files that don't need it. (Only changes file mode -- no code changes.) r=bsmedberg
2009-01-21 22:55:08 -08:00
Drew Wilcoxon
43ac281f8c
Bug 370197 - Places query serialization needs tests . r=mak77
2009-01-21 12:39:07 +01:00
Marco Bonardo
30a58baa84
Bug 466422 - Clicking history - show all history doesn't show any history, r=dietrich
2009-01-21 12:39:07 +01:00
Marco Bonardo
1f6a3a7d4c
Bug 474334 - "place:" is a valid query to deserialize and should not cause an "ignoring unknown key:" warning, r=dietrich
2009-01-21 12:39:07 +01:00
Edward Lee
a0fa2b97c8
Bug 471903 - pref urlbar.autocomplete.enabled is no longer implemented. r=dietrich
...
Bug 472943 - Two confusable preferences, "browser.urlbar.search.sources" and "browser.urlbar.default.behavior", should be unified
--HG--
rename : toolkit/components/places/tests/autocomplete/test_search_sources.js => toolkit/components/places/tests/autocomplete/test_enabled.js
2009-01-21 02:00:04 -06:00
Fred Jendrzejewski
7d5761cdfa
Bug 461047 - Replace nsStringArray with nsTArray<nsString>. r+sr=roc
2009-01-18 21:14:14 +01:00
Marco Bonardo
9e51b8a061
Bug 471084 - Importing a large bookmarks JSON backup makes Firefox crash (out of memory), r=dietrich
2009-01-17 15:45:37 +01:00
Marco Bonardo
9952bff6eb
Bug 452000 - Sort by keyword in Library does not work, r=dietrich
2009-01-17 15:45:37 +01:00
Robert O'Callahan
1a9b00de4e
Backed out changeset 8019a959aade
2009-01-16 22:20:33 +13:00
Fred Jendrzejewski
b79ad6fa55
Bug 461047. Replace nsStringArray with nsTArray<nsString>. r+sr=roc
...
--HG--
extra : rebase_source : 7a20af24c97867efbb28dafa6a70ea1b4cf00e58
2009-01-16 20:51:04 +13:00
Neil Rashbrook
db65d28baa
Bug 470586 - Crash calling removePagesFromHost when sidebar is showing pages grouped by day and site, r=sdwilsh
2009-01-15 15:37:33 +01:00
Drew Willcoxon
2ad84319b7
Bug 463674 - changeBookmarkURI() doesn't update internal bookmark hash, r=mak77
2009-01-15 15:37:33 +01:00
Ben Turner
a5644a9c39
Merge backout
2009-01-14 18:24:18 -08:00
Ben Turner
0f0d556f13
Backed out changeset 96a66c1a50bd for failing unit tests.
2009-01-14 18:23:21 -08:00
Neil Rashbrook
a3a6522f11
Bug 473157 Sorting shouldn't affect grouping containers, only uris r=dietrich
2009-01-14 22:38:30 +00:00
Neil Rashbrook
cc742092ce
Bug 470586 Can crash removing all pages from a host when the sidebar is grouped r=sdwilsh
2009-01-14 22:33:37 +00:00
Drew Willcoxon
c149de9294
Bug 412132 - after changing a bookmark's location, need to update the frecency of the "old" uri, r=dietrich
2009-01-13 11:48:27 +01:00
Marco Bonardo
4c89a6229d
Bug 454977 - remove INSERT OR REPLACE to avoid error prone paths with views, r=dietrich
2009-01-13 11:48:25 +01:00
Phil Ringnalda
2dff174183
I would not have choosen the weekend before a freeze for so much CLOSED TREE
2009-01-11 20:12:32 -08:00
Robert Kaiser
0b557fdaa3
bug 471886 - Make places autocomplete tests even more robust against default prefs, r=Mardak
2009-01-10 16:29:17 +01:00
Edward Lee
e10c805dd2
Bustage fix Bug 463483 (finalized typed query statement)
2009-01-07 16:53:54 -08:00
Edward Lee
a5317482ad
Bug 426864 - Only show user typed history pages for the urlbar dropdown. r=dietrich
2009-01-07 15:47:58 -08:00
Edward Lee
dacf203db8
Bug 463483 - matchOnlyTyped no longer honored with special filters. r=dietrich
...
Bug 463558 - Switch matchOnlyTyped to restrict.typed "~" (default.behavior + 32)
2009-01-07 15:47:56 -08:00
Marco Bonardo
3b1f2a552d
Bug 468400 - xpcshell-simple/test_places/unit/test_adaptive.js | *** TIMEOUT ***: The test timed out while polling database, r=sdwilsh
2009-01-08 00:37:01 +01:00
Marco Bonardo
1d07d32522
Bug 466407 - History menu often shows duplicated items, r=dietrich
2009-01-08 00:37:01 +01:00
Marco Bonardo
6fa7b73e03
Bug 471547 - move PlacesDBUtils getters to avoid possible leaks, r=sdwilsh
2009-01-08 00:37:01 +01:00
Marco Bonardo
83a374cd4f
Bug 470429 - nsPlacesDBFlush::onItemAdded should not sync if the item is a container, r=sdwilsh
2009-01-08 00:37:00 +01:00
Marco Bonardo
248d436712
Bug 462765 - instant-apply muddies the MRU folder list in the bookmark properties dialog, r=dietrich
2009-01-08 00:37:00 +01:00
mak77@bonardo.net
1c24addb1a
Bug 470348 - clear private data on shutdown does not delete history if "ask me before..." is enabled (r=dietrich, gavin)
2009-01-06 12:41:08 -08:00
Dietrich Ayala
9659c3c58d
Bug 464486 - lots of bookmark corruption reported via user support (r=marco, sdwilsh)
2009-01-03 09:26:11 -08:00
Ehsan Akhgari
6f93e82b41
Bug 471018 - Warning: nsFaviconService.cpp: outparam 'aHasData' not written on NS_SUCCEEDED(return value); r=dietrich
2009-01-03 07:42:34 +03:30
Dietrich Ayala
c01314e672
Bug 432706 - Deleting/adding/updating a large quantity of bookmarks/history is very slow due to updating observers (r=marco)
2009-01-02 11:03:38 -08:00
Marco Bonardo
0cafd269c4
Bug 470707 - [SeaMonkey] test_download_history.js fails now, r=dietrich
2008-12-30 22:42:23 +01:00
Marco Bonardo
e6b8308902
Bug 466564 - RemoveDuplicateURIs is not aware of temp views, r=dietrich
2008-12-30 22:42:23 +01:00
Marco Bonardo
be7aeedd0c
Bug 464438 - move EnsureCurrentSchema into migration path, r=dietrich
2008-12-30 22:42:23 +01:00
Marco Bonardo
485f62946f
Bug 439129 - Clearing browsing history does not hide livemarks children from the location bar, r=dietrich
2008-12-30 22:42:22 +01:00
Dietrich Ayala
17dd8776c4
Bug 414715 - Notify the user if places.sqlite is locked and bookmarks and history will not work (relanding w/ leak fix, r=marco, r=gavin, l10n-r=pike)
2008-12-30 13:44:55 +01:00
Dietrich Ayala
44e08929e7
backout bug 414715 due to leaks
2008-12-29 17:22:39 -08:00
Dietrich Ayala
c51318949c
Bug 414715 - Notify the user if places.sqlite is locked and bookmarks and history will not work (relanding w/ leak fix, r=marco, r=gavin, l10n-r=pike)
2008-12-29 14:49:05 -08:00
Robert Kaiser
a855c51d33
bug 469593 - test_423060.xul fails on SeaMonkey, r=gavin
...
--HG--
rename : toolkit/components/places/tests/chrome/Makefile.in => browser/components/feeds/test/chrome/Makefile.in
rename : toolkit/components/places/tests/chrome/sample_feed.atom => browser/components/feeds/test/chrome/sample_feed.atom
rename : toolkit/components/places/tests/chrome/test_423060.xul => browser/components/feeds/test/chrome/test_423060.xul
2008-12-23 15:58:44 +01:00
Marco Bonardo
952200fe50
Bug 470455 - test_database_sync_embed_visits.js leaks, r=sdwilsh
2008-12-22 11:07:21 +01:00
Shawn Wilsher
c80ee6de74
Bug 469972 - leaking the places database connection in strange situations; r=dietrich
2008-12-20 01:46:04 +01:00
Marco Bonardo
dce47704f5
Bug 458849 - transition download visits saved when "Keep my history..." is unchecked, r=sdwilsh
2008-12-19 13:36:15 +01:00
Dietrich Ayala
a81ff7e680
imported patch backout-bug414715
2008-12-18 17:09:25 -08:00
Dietrich Ayala
3299fb830d
Bug 414715 - Notify the user if places.sqlite is locked and bookmarks and history will not work (r=marco, r=gavin, l10n-r=pike)
2008-12-18 13:47:48 -08:00
Dietrich Ayala
5dfe4f0055
Bug 469102 - Places Tag Autocomplete breaks with certain tags (Regex escaping) (r=marco)
2008-12-18 12:33:47 -08:00
Marco Bonardo
da6bfbbb37
Bug 453529 - Retain embed visits and places into the temp table in memory, r=sdwilsh
2008-12-17 11:41:44 +01:00
Marco Bonardo
c13d5fd1dd
Bug 469062 - test_multiple_visits_around_sync.js leaks now, r=sdwilsh
2008-12-17 11:41:44 +01:00
Marco Bonardo
17817e4af5
Bug 431548 - Tagging history item takes a long time without progress indication (slight hang / freeze of UI), r=dietrich
2008-12-17 11:41:43 +01:00
Marco Bonardo
b9fdc603d8
Bug 469301 - PRBool violation in mDatabaseStatus, r=dietrich
2008-12-13 10:57:30 +01:00
Shawn Wilsher
4d53994a50
Bug 460300 - Expire favicons when they expire from cache, and when the cache is cleared
...
This makes favicons expire from the favicon service much less often. They are
now expired when the cache headers says they expire, or one week - whichever is
shorter. Additionally, all favicons expire when the cache is cleared.
r=MaK77
2008-12-11 15:01:10 -05:00
Marco Bonardo
45b8f132d3
Bug 468836 - Existing tags no longer show and cannot be edited, r=dietrich
2008-12-11 15:23:25 +01:00
Robert Sayre
38305f3678
backout bug 468836, checked in on persistent orange.
2008-12-11 02:44:01 -08:00
Marco Bonardo
1006ee8d3a
Bug 468836 - Existing tags no longer show and cannot be edited, r=dietrich
2008-12-11 01:32:24 +01:00
Edward Lee
cdd08cee41
Bug 463459 - Use a separate pref instead of empty restrict/match values to specify defaults. r=dietrich, a1.9.1=beltzner
2008-12-10 10:58:43 -06:00
Robert Kaiser
b6de2bc403
fix up my test bustage by removing a spurious { the review didn't catch, not sure why I did put it there, sorry.
2008-12-10 14:33:52 +01:00
Robert Kaiser
309980c5e5
bug 468341 - Some toolkit places tests fail on SeaMonkey unit test boxes - make tests mor tolerant to default prefs, non-override DOM error messages, non-existing browser-specific services and protcol defintions, r=sdwilsh a=tests-only
2008-12-10 13:18:14 +01:00
Marco Bonardo
6d9599a014
followup to Bug 431558 - implement preventive maintenance for places.sqlite, remove observer on test finish, r=sdwilsh
2008-12-10 11:44:01 +01:00
Dietrich Ayala
7a9981ce5f
Bug 463513 - Tagging service could hold a fixed cache instead of an open node, r=mak77
2008-12-10 11:40:13 +01:00
Shawn Wilsher
bf0e65a35b
Bug 466582 - smarter handling of remote chrome (and not allowing it)
...
This adds a new flag, URI_IS_LOCAL_RESOURCE, to nsIProtocolHandler that allows
something of this protocol to be registered in chrome.
This changeset removes a runtime check every time we open a chrome channel to
see if it is remote to a registration time check that checks flags. The old
code could be easily worked around, and allowed for remote resources to be used.
r=bsmedberg
r=bz
sr=bz
2008-12-09 16:27:42 -05:00
Marco Bonardo
475620037e
Bug 465510 - random failures on test_database_sync_after_addVisit.js, r=sdwilsh
2008-12-09 21:39:32 +01:00
Marco Bonardo
d68f8a9e09
Bug 467971 - random failures on test_multiple_visits_around_sync.js, r=sdwilsh
2008-12-09 21:39:32 +01:00
Marco Bonardo
0dd8a6691d
Bug 431558 - implement preventive maintenance for places.sqlite, r=dietrich
2008-12-09 21:39:32 +01:00
Shawn Wilsher
6ea17d3edc
Backed out changeset b6f762fde736 (bug 466582) for unit test orange.
2008-12-08 18:51:46 -05:00
Shawn Wilsher
52fa025019
Bug 466582 - smarter handling of remote chrome (and not allowing it)
...
r=bsmedberg, r=bz, sr=bz
2008-12-08 17:14:14 -05:00
Daniel Holbert
ca3e28538e
Bug 418643 trivial follow-up: Remove unneded 'typedef' token, in 'typedef struct folderChildrenInfo { ...', to fix compiler warning. r=sdwilsh
2008-12-07 11:56:39 -08:00
