This was a regression from bug 133165 which I noticed while working on
bug 480888, but wished to fix in a separate patch (despite that it would
have been slightly easier to fix it in the same patch).
The outline-overflow-inline-block-* tests fail, as expected, with the
aOverflowOverride parameter to UnionBorderBoxes always changed to null.
Note that the outline-overflow-inline-block-* tests depend on the fix
for bug 709014.
Prior to this patch, we failed to honor:
* margin-left on elements in inline layout with 0 width and 0 height
* margin-right on elements in inline layout with 0 width
I think that was because the code in CanPlaceFrame to discard both
margins when the width was 0 was running after the left-margin was
applied, unless the later code in PlaceFrame (checking both width 0 and
height 0) un-applied that left margin.
The assertion count change in test_value_computation.html is due to 2
additional "bad width" assertions (I presume from honoring large
margins that were previously ignored).
The change to 538935-1-ref.html is to match an improvement in rendering
of the margins in the test, where both sides of the margin are now
honored.
The change to layout/reftests/text-overflow/marker-basic-ref.html is to
keep the reference (which uses margins) rendering the same way following
the changes to margin handling.
The new behavior (in the reftests added in layout/reftests/inline/)
matches at least Chromium; I didn't check any other browsers.
This guarantees that the animated geometry root for an item is always in the
same display list coordinate system as the frame.
--HG--
extra : rebase_source : 249fd847a2c08f8d0846d698cce9dd4681e38a98
At the same time, move the handling of outlines on inlines that contain
blocks earlier, so that we factor it into the stored frame property (and
thus have the stored frame property) and so that we include it
accurately in the overflow calculation.
CLOSED TREE
Backed out changeset ef3d90780478 (bug 972703)
Backed out changeset 34c95e937671 (bug 889959)
Backed out changeset 5e25912d6696 (bug 889959)
At the same time, move the handling of outlines on inlines that contain
blocks earlier, so that we factor it into the stored frame property (and
thus have the stored frame property) and so that we include it
accurately in the overflow calculation.
The purpose of this change is to make the code less confusing (since it's not clear to me why one would check HasTransform here), and in general to reduce the number of callers of HasTransform, since HasTransform is a complicated check that checks too many things and probably isn't the right thing for many of its callers (see, e.g., bug 968555).
This is pure refactoring because:
(1) We're calling HasTransform only if mTransformStyle is
NS_STYLE_TRANSFORM_STYLE_PRESERVE_3D.
(2) HasTransform can return false for either of two reasons:
(a) because HasTransformStyle is false, which cannot be the case
here because HasTransformStyle checks mTransformStyle, and we
already know that check passes because of (1)
(b) because IsFrameOfType(nsIFrame::eSupportsCSSTransforms) is
false.
This means that we can replace the HasTransform check with solely the
IsFrameOfType check.
