Commit Graph

630 Commits

Author SHA1 Message Date
Shawn Wilsher
bb7e0e8c36 Bug 459781 - create our string bundle in a more sane way
This changeset only creates the string bundle when we need it, and only in one
place as opposed to two separate places.
r=dietrich
2008-10-17 06:12:53 -04:00
Shawn Wilsher
d9d1b7f304 Bug 459776 - date formatter is unused
This changeset removes a small part of code that places does in startup that is
not used or needed.
r=dietrich
2008-10-17 06:12:52 -04:00
Shawn Wilsher
1d0921f3e0 Bug 459773 - Creating a collation is expensive
This makes a lazy getter for getting our collation saving us about 3% of places
startup time.
r=dietrich
2008-10-17 06:12:52 -04:00
Marco Bonardo
867daf5b5f Bug 455474 - cleanup nsNavBookmarks::Init
r=dietrich
2008-10-17 06:12:52 -04:00
Marco Bonardo
53ea567322 Bug 459491 - nsPlacesDBFlush could use async queries instead of background thread
r=sdwilsh

--HG--
rename : toolkit/components/places/tests/background/head_background.js => toolkit/components/places/tests/sync/head_sync.js
rename : toolkit/components/places/tests/background/test_database_sync_after_addBookmark.js => toolkit/components/places/tests/sync/test_database_sync_after_addBookmark.js
rename : toolkit/components/places/tests/background/test_database_sync_after_addBookmark_batched.js => toolkit/components/places/tests/sync/test_database_sync_after_addBookmark_batched.js
rename : toolkit/components/places/tests/background/test_database_sync_after_addVisit.js => toolkit/components/places/tests/sync/test_database_sync_after_addVisit.js
rename : toolkit/components/places/tests/background/test_database_sync_after_addVisit_batched.js => toolkit/components/places/tests/sync/test_database_sync_after_addVisit_batched.js
rename : toolkit/components/places/tests/background/test_database_sync_after_modifyBookmark.js => toolkit/components/places/tests/sync/test_database_sync_after_modifyBookmark.js
rename : toolkit/components/places/tests/background/test_database_sync_after_quit_application.js => toolkit/components/places/tests/sync/test_database_sync_after_quit_application.js
rename : toolkit/components/places/tests/background/test_multiple_bookmarks_around_sync.js => toolkit/components/places/tests/sync/test_multiple_bookmarks_around_sync.js
rename : toolkit/components/places/tests/background/test_multiple_visits_around_sync.js => toolkit/components/places/tests/sync/test_multiple_visits_around_sync.js
2008-10-17 06:12:52 -04:00
Shawn Wilsher
f5d2e83ae5 Bug 459315 - Wrap favicon work in a transaction
This wraps a series of statements that run on the main thread to reduce the
number of fsyncs that end up happening.
r=dietrich
2008-10-17 06:12:52 -04:00
Shawn Wilsher
4d5fb2f862 Bug 459299 - nsNavHistory::SetPageTitleInternal is slow
This caches a statement that is created any time a pages title changes.  The
creation of the statement took roughly 66% of the functions execution time
according to shark.
It also removes a transaction that was not needed in this method.
r=dietrich
2008-10-17 06:12:52 -04:00
Marco Bonardo
b71369cd19 Bug 456029 - optimize the temp table triggers
This changeset makes the triggers work much faster which should greatly reduce
the timings of adding a visit and a bookmark.
r=sdwilsh
2008-10-17 06:12:52 -04:00
Shawn Wilsher
4f97936d8c Bug 450290 - Sync the temp tables to the permanent tables.
This changeset adds code that is run at app-startup that will flush out changes
to the temporary tables into the permanent ones.  For moz_places, this is done
whenever we sync moz_historyvisits and when we add or modify a bookmark.  For
moz_historyvisits, this is done on a timer controlled by the preference
places.syncDBTableIntervalInSecs.
Changeset includes full test coverage for the above behaviors.
r=dietrich
r=Mak77

--HG--
rename : toolkit/components/places/tests/unit/head_bookmarks.js => toolkit/components/places/tests/background/head_background.js
2008-10-17 06:12:51 -04:00
Marco Bonardo ext:(%2C%20Shawn%20Wilsher%20%3Csdwilsh%40shawnwilsher.com%3E)
5715c324ab Bug 449640 - Modify the places backend to use the temporary tables &
Bug 450705 - Optimize the query changes from the temp table rewrite
This changeset merges patches from two bugs to actually use the temporary tables
created for places.
Bug 449640 patch by Shawn Wilsher <sdwilsh@shawnwilsher.com>
r=dietrich, r=Mak77
Bug 450705 patch by Marco Bonardo <mak77@bonardo.net>
r=sdwilsh, r=dietrich, r=Mardak
2008-10-17 06:12:51 -04:00
Shawn Wilsher
5790687517 Bug 449086 - Create temporary tables for frequently used places tables
This changeset creates two temporary tables that will be used when inserting
data into moz_places and moz_historyvisits.  This will reduce the number of
writes as well as the number of fsyncs that happen.
r=dietrich
2008-10-17 06:12:50 -04:00
Shawn Wilsher
810e90b149 Bug 460315 - set journal_mode to TRUNCATE
Sets the journal_mode to the places database to TRUNCATE
r=dietrich
2008-10-16 15:59:33 -04:00
Marco Bonardo
564c306794 Bug 458683 - Backup only uri nodes into tag containers, r=dietrich 2008-10-14 17:24:08 +02:00
Neil Rashbrook
b50d21d9c9 Bug 459571 Places autocomplete results contain incorrect search string r=sdwilsh,mardak 2008-10-14 14:54:17 +01:00
Marco Bonardo
3b22c3d551 Bug 457698 - nsNavHistoryFolderResultNode::OnItemAdded ignores dynamic containers, r=dietrich 2008-10-13 18:14:50 +02:00
Marco Bonardo
6d926ff1b7 Bug 457686 - appendURINode should not append to a dynamic container if we are inside an excludeItems query, r=dietrich 2008-10-13 18:06:50 +02:00
Marco Bonardo
56441e9d6e Bug 457681 - if ExcludeReadOnlyFolders is false, readonly dynamic containers are still excluded, r=dietrich 2008-10-13 17:58:36 +02:00
Marco Bonardo
b1351fc910 Bug 457677 - PlacesUtils ignores dynamic containers, r=dietrich 2008-10-13 17:54:25 +02:00
Marco Bonardo
68881489cf Bug 458013 - QueryResultNode Tag refresh optimization is useless as it is, r=dietrich 2008-10-13 14:11:27 +02:00
Ben Turner
311284ddff Bug 455436 - "XPConnect insists on using its own error reporter even when another is already set." r+sr=jst. 2008-10-12 11:32:34 -07:00
Arpad Borsos
8b11d938d2 Bug 456388 - Remove PR_STATIC_CALLBACK and PR_CALLBACK(_DECL) from the tree; r+sr=brendan 2008-10-10 17:04:34 +02:00
Daniel Holbert
72c410a648 Bug 458167 - (comments-only changes) Grammar Nazi Vol1: s/it's/its/ for the posessive version of the word, and a few other misc comment-typos, in these directories: accessible browser config profile rdf toolkit tools xpcom xpfe 2008-10-01 23:49:45 -07:00
Marco Bonardo
bd07734758 Bug 448584 - Don't save invalid uri nodes while doing a JSON backup (don't stop while saving data), r=dietrich 2008-09-30 10:41:36 +02:00
Dietrich Ayala
89c275d5aa Bug 420331 - wyciwyg: uris show up in location bar (r=mardak) 2008-09-29 23:46:52 -07:00
Dietrich Ayala
2fa7f086c3 test for bug 331459 - Places query ignores onlyBookmarked 2008-09-29 23:28:08 -07:00
Dietrich Ayala
5d9c44b264 pushing test for bug 433317, forgot to check-in initially 2008-09-29 23:22:46 -07:00
Marco Bonardo
a599a40812 Follow-up to Bug 329534 - Live bookmarks load way too aggressively. Try to workaround possible VM timers bugs that could cause test failures. r=dietrich 2008-09-30 01:24:44 +02:00
Takeshi Ichimaru
820d6827ba Bug 329534 - Live bookmarks load way too aggressively (lock up/hang/freeze browser), r=dietrich, mak77 2008-09-27 13:05:28 +02:00
Shawn Wilsher
abd0d61c89 Backed out changeset ebafcda56f98 (bug 456910)
Backed out for Tp regression (bug 457288)
2008-09-26 15:55:03 -04:00
Shawn Wilsher
af8e0300cd Bug 456910 - Stop using exclusive locking in places
This allows us to greatly reduce the number of fsyncs when upgrading to sqlite.
The perf loss in no longer using this locking is not significant (10^-6 %).
r=dietrich
2008-09-25 13:50:41 -04:00
Marco Bonardo
77bb2e6d9c Bug 407468 - Livemark loading and failed to load messages should be static menuitems from menu.xml, original patch by Michael Schonfeld <dev@schonfeld.org>, r=mano 2008-09-25 12:30:33 +02:00
Marco Bonardo
5edd5fff2c Bug 418671 - Clean up places views drag and drop code, r=mano 2008-09-19 17:47:45 +02:00
Shawn Wilsher
5d3ab665f0 backout merge 2008-09-18 15:05:36 -04:00
Shawn Wilsher
9bf0fdc3ad backout merge 2008-09-18 15:03:15 -04:00
Shawn Wilsher
f46423d1af Backed out changeset eb14737f8488 (places fsync work) 2008-09-18 15:02:55 -04:00
Shawn Wilsher
9bc5bb6827 backout merge 2008-09-18 15:02:17 -04:00
Shawn Wilsher
47008f4df3 Backed out changeset c99b7659dc0a (places fsync work) 2008-09-18 15:01:51 -04:00
Shawn Wilsher
8df9786bcd backout merge 2008-09-18 15:01:01 -04:00
Shawn Wilsher
900250bc91 Backed out changeset f3c9af143cc1 (places fsync work) 2008-09-18 15:00:30 -04:00
Shawn Wilsher
09255da4ab Backed out changeset dabae13daacb 2008-09-18 14:47:31 -04:00
Shawn Wilsher
f909f6ff81 Test breakage fix from bug 449640 2008-09-18 13:51:33 -04:00
Shawn Wilsher
16fef55947 Bug 450290 - Sync the temp tables to the permanent tables.
This changeset adds code that is run at app-startup that will flush out changes
to the temporary tables into the permanent ones.  For moz_places, this is done
whenever we sync moz_historyvisits and when we add or modify a bookmark.  For
moz_historyvisits, this is done on a timer controlled by the preference
places.syncDBTableIntervalInSecs.
Changeset includes full test coverage for the above behaviors.
r=dietrich
r=Mak77

--HG--
rename : toolkit/components/places/tests/unit/head_bookmarks.js => toolkit/components/places/tests/background/head_background.js
2008-09-18 11:10:47 -04:00
Marco Bonardo ext:(%2C%20Shawn%20Wilsher%20%3Csdwilsh%40shawnwilsher.com%3E)
ec97557606 Bug 449640 - Modify the places backend to use the temporary tables &
Bug 450705 - Optimize the query changes from the temp table rewrite
This changeset merges patches from two bugs to actually use the temporary tables
created for places.
Bug 449640 patch by Shawn Wilsher <sdwilsh@shawnwilsher.com>
r=dietrich, r=Mak77
Bug 450705 patch by Marco Bonardo <mak77@bonardo.net>
r=sdwilsh, r=dietrich, r=Mardak
2008-09-18 11:10:34 -04:00
Shawn Wilsher
a981391a48 Bug 449086 - Create temporary tables for frequently used places tables
This changeset creates two temporary tables that will be used when inserting
data into moz_places and moz_historyvisits.  This will reduce the number of
writes as well as the number of fsyncs that happen.
r=dietrich
2008-09-18 11:10:09 -04:00
Marco Bonardo
1d4ddeb7ae Bug 430442 - Undo and redo in the library are sometimes not correctly working, r=dietrich 2008-09-11 16:16:54 +02:00
Phil Ringnalda
b65979710c Bug 454360 - Use Components.results.NS_BINDING_ABORTED instead of hardcoding the value, r=gavin 2008-09-09 21:33:27 -07:00
Ted Mielczarek
468a3823fc bug 447642 - get rid of --disable-mochitest, replace MOZ_MOCHITEST with ENABLE_TESTS. r=bsmedberg 2008-09-09 13:59:11 -04:00
Serge Gautherie
d583b6d94c Bug 450938 - "test_417228-other-roots.js:89: strict warning: assignment to undeclared variable excludedFolderId"; Av1; r=mano 2008-09-07 16:46:41 +02:00
Marco Bonardo
016e09eab3 Bug 451499 - wrong folder icon appears on smart bookmarks, r=dietrich 2008-09-06 17:21:55 +02:00
Shawn Wilsher
c7fa5f7164 Bug 453181 - Remove code that is labeled REMOVE ME
This changeset removes a bunch of code that was labeled REMOVE ME with a release
stated.  All those releases have passed, so let's get rid of the code.
r=dietrich
2008-09-05 12:20:40 -04:00