Commit Graph

7 Commits

Author SHA1 Message Date
Andrew Halberstadt
387b2d541f Bug 821865 - Update mozdevice to version 0.18, r=jhammel 2012-12-20 10:24:25 -05:00
William Lachance
14b993064f Bug 811388 - Update mozdevice to 0.15, update consumers;r=ahal 2012-11-14 09:49:04 -08:00
Jeff Hammel
00695ab541 Bug 799605 - Mirror mozbase -> m-c for bug 799288 and bug 799507 @ https://github.com/mozilla/mozbase/commit/ 36a2f63be33af799a54d7f1511dc922730b10b22 ; r=wlach 2012-10-10 09:27:06 -07:00
William Lachance
382c927895 Bug 795496 - Make mozdevice raise exceptions on error;r=ahal,jmaher
It turns out that relying on the user to check return codes for every
command was non-intuitive and resulted in many hard to trace bugs.
Now most functinos just return "None", and raise a DMError when there's an
exception. The exception to this are functions like dirExists, which now return
booleans, and throw exceptions on error. This is a fairly major refactor,
and also involved the following internal changes:

* Removed FileError and AgentError exceptions, replaced with DMError
  (having to manage three different types of exceptions was confusing,
  all the more so when we're raising them)
* Docstrings updated to remove references to return values where no
  longer relevant
* pushFile no longer will create a directory to accomodate the file
  if it doesn't exist (this makes it consistent with devicemanagerADB)
* dmSUT we validate the file, but assume that we get something back
  from the agent, instead of falling back to manual validation in the
  case that we didn't
* isDir and dirExists had the same intention, but different
  implementations for dmSUT. Replaced the dmSUT impl of getDirectory
  with that of isDir's (which was much simpler). Removed
  isDir from devicemanager.py, since it wasn't used externally
* killProcess modified to check for process existence before running
  (since the actual internal kill command will throw an exception
  if the process doesn't exist)

In addition to all this, more unit tests have been added to test these
changes for devicemanagerSUT.
2012-10-04 11:28:07 -04:00
Ed Morley
635b92ba9f Bug 793739 - mirror mozbase to m-c for week of Sept 24, 2012 @ b12b008846;r=jhammel 2012-09-25 09:35:14 -07:00
Mark Cote
8ae3041609 Bug 789496 - DeviceManagerSUT: always consume prompt after receiving agent warning. r=wlach 2012-09-10 11:33:11 -04:00
William Lachance
980573bf62 Bug 723107 - Re-add mozdevice to testing/mozbase, remove duplicate files in build/mobile;r=jmaher 2012-09-07 16:00:31 -04:00