Commit Graph

63 Commits

Author SHA1 Message Date
David Rajchenbach-Teller
b79f0094d5 Bug 1017706 - Better logging for FHR AsyncShutdown. r=rnewman 2014-06-02 04:28:00 +02:00
David Rajchenbach-Teller
9f879e7816 Bug 917883 - Use AsyncShutdown instead of spinning the event loop in healthreporter.jsm. r=gps, r=rnewman 2014-05-22 02:11:00 -04:00
Gregory Szorc
4adb89bc72 Bug 968419 - Store and submit a persistent health report identifier; r=rnewman, r=bsmedberg
Up to this point, Firefox Health Report has generated and submitted a
random UUID with each upload. Generated UUIDs were stored on the client.
During upload, the client asked the server to delete all old UUIDs.
Well-behaving clients thus left at most one record/ID on the server.

Unfortunately, clients in the wild have not been behaving properly. We
are seeing multiple documents on the server that appear to come from the
same client. Clients are uploading new records but failing to delete the
old ones. These old, undeleted "orphan" records are severely impacting
the ability to derive useful knowledge from FHR data because it is
difficult, resource intensive, and error prone to filter the records on
the server. This is undermining the ability for FHR data to be put to
good use.

This patch introduces a persistent client identifier. When the client is
initialized, it generates a random UUID. That UUID is persisted to the
profile and sent as part of every upload.

For privacy reasons, if a client opts out of data submission, the client
ID will be reset as soon as all remote data has been deleted.

We still issue and send upload IDs. They exist mostly for forensics
purposes so we may log client behavior and more accurately determine
what exactly misbehaving, orphan-producing clients are doing.

It is worth noting that this persistent client identifier will not solve
all problems of branching and orphaned records. For example, profile
copying will result in multiple clients sharing a client identifier. A
"client ID version" field has been added to facilitate an upgrade path
towards client IDs with different generation semantics.

--HG--
extra : rebase_source : b761daab39fb07b6ab8883819d68bf53462314a0
2014-02-20 11:30:52 -08:00
Gregory Szorc
b14e377e09 Bug 965587 - Add lock to Firefox Health Report uploading; r=rnewman
Previously, it was technically possible for the FHR client to have
multiple simultaneous uploads. While this should never occur in
well-behaving systems, server logs have indicated that this behavior
might be occurring.

This patch adds a lock around uploading to ensure only 1 upload
operation may be active at a given time.

To measure the impact of this change in the wild, we added a counter
that increments whenever a held lock is encountered.

--HG--
extra : rebase_source : f0bb5065a3618cd335b6b6f31e4e68850f31f151
2014-01-29 15:28:57 -08:00
Ryan VanderMeulen
b2b7a0f29e Bug 931642 - Backed out changeset f4449a06e97f (bug 917883) for causing frequent OSX crashes. 2013-12-03 18:45:17 -05:00
David Rajchenbach-Teller
9d8c8b77fd Bug 917883 - Use AsyncShutdown instead of spinning the event loop in healthreporter.jsm. r=gps 2013-11-15 21:46:38 -05:00
Blair McBride
f44c1d0d2f Bug 451283 - Move log4moz.js to Toolkit as Log.jsm. r=gps,Mossop
--HG--
rename : services/common/log4moz.js => toolkit/modules/Log.jsm
rename : services/common/tests/unit/test_log4moz.js => toolkit/modules/tests/xpcshell/test_Log.js
2013-08-26 11:55:58 -07:00
Stefan Mirea
ba46a76f9c Bug 887081 - Attach healthreporter to global object. r=gps 2013-09-06 09:08:26 -07:00
Stefan Mirea
182a158660 Bug 872758 - Delete all documents on FHR upload; r=gps 2013-06-21 10:30:30 -07:00
Stefan Mirea
a33dfc5f5f Bug 867902 - Remove old saved FHR payload from disk. r=gps 2013-06-18 11:06:20 -07:00
Stefan Mirea
fa0e1df968 Bug 852411 - Migrating from promise.js to Promise.jsm; r=gps 2013-06-13 18:36:21 -07:00
Gregory Szorc
cf599037bc Backout 9080f6701733 (bug 852411) for hitting weird xpcshell test harness behavior in multiple local builds 2013-06-14 14:38:29 -07:00
Stefan Mirea
f1ea85072a Bug 852411 - Migrating from promise.js to Promise.jsm; r=gps
--HG--
extra : rebase_source : d03cdae978479605df0a7ea728916ba78a272ffb
2013-06-13 18:36:21 -07:00
Gregory Szorc
ceac8b9cf4 Bug 846133 - Store FHR state in a file; r=rnewman
Preferences aren't robust. So, we're using a file.
2013-05-10 11:04:48 -07:00
Gavin Sharp
ea8b76dbc4 Bug 853071: add some build-time defines for channel-specific features, r=gps, f=bhearsum
--HG--
rename : browser/config/mozconfigs/linux32/release => browser/config/mozconfigs/linux32/beta
rename : browser/config/mozconfigs/linux64/release => browser/config/mozconfigs/linux64/beta
rename : browser/config/mozconfigs/macosx-universal/release => browser/config/mozconfigs/macosx-universal/beta
rename : browser/config/mozconfigs/win32/release => browser/config/mozconfigs/win32/beta
extra : transplant_source : %F6%CFK%CE%16v%07%8A%D5o%97%8C%BB%95q%D5%3C%93%2B%94
2013-04-25 12:23:21 -07:00
Gregory Szorc
c467af8637 Bug 860094 - Remove saving of last payload to disk; r=rnewman 2013-05-01 09:55:30 -07:00
Gregory Szorc
9390ea951e Bug 854018 - Record counts for FHR upload actions; r=rnewman 2013-05-01 09:41:55 -07:00
Gregory Szorc
0286e7f623 Bug 861455 - Ensure all providers are loaded during important operations; r=rnewman 2013-04-22 12:33:24 -07:00
Gregory Szorc
e22d5163e4 Bug 830492 - Manually control WAL checkpointing during heavy I/O; r=rnewman 2013-04-16 11:45:02 -07:00
Nick Alexander
1e840733ac Bug 848519 - Part 3: Replace services-common/preferences.js with gre/modules/Preferences.jsm in imports. r=gavin 2013-04-15 12:45:37 -07:00
Gregory Szorc
e10a1f7e4d Bug 848136 - Part 2: Checkpoint WAL after data collection; r=rnewman 2013-03-26 14:28:22 -07:00
Gregory Szorc
e48b8f37d4 Bug 837292 - Part 4: Followup to unbust part 2; r=rnewman 2013-03-19 13:03:07 -07:00
Gregory Szorc
d2b6632bd2 Bug 837292 - Part 2: Report new measurement version only; r=rnewman 2013-03-19 11:08:24 -07:00
Gregory Szorc
3b9cc78e74 Bug 837292 - Part 1: Don't give each provider its own Preferences object; r=rnewman 2013-03-18 20:48:13 -07:00
Gregory Szorc
5fc83ce80c Bug 845842 - Use promises that resolve on later ticks; r=rnewman
This is meant as a temporary workaround until a built-in promise library
offers similar functionality.
2013-03-18 20:47:34 -07:00
Gregory Szorc
8db0e93aa1 Bug 848861 - Send stack traces with FHR errors; r=rnewman, sr=mconnor 2013-03-18 15:07:07 -07:00
Gregory Szorc
d85437367b Bug 846083 - Submit an FHR payload after initialization failure; r=rnewman 2013-03-15 21:31:07 -07:00
Gregory Szorc
7ea2ea768e Bug 845935 - Don't perform FHR activities unless fully initialized; r=rnewman 2013-03-15 21:10:08 -07:00
Gregory Szorc
b6ebd60dd3 Bug 849947 - Flush preferences after FHR document submission; r=glandium, rnewman 2013-03-15 13:19:38 -07:00
Richard Newman
ae0ea15f23 Merge m-c to s-c. 2013-03-14 15:03:48 -07:00
Richard Newman
87718aec24 Bug 849353 - Add basic app info section to top level of FHR payload. r=gps 2013-03-14 11:24:12 -07:00
Gregory Szorc
70f019c2a7 Bug 845127 - Record Telemetry for wire size of Bagheera documents; r=rnewman 2013-03-13 10:14:41 -07:00
Gregory Szorc
ab7ba47f73 Bug 841568 - Timer for daily data collection; r=rnewman 2013-03-13 09:34:41 -07:00
Gregory Szorc
dedbedd2aa Bug 847662 - Part 3: Move provider management code into provider manager; r=rnewman
--HG--
extra : rebase_source : 7096a6a63143e7e6790ccd498f4b453708baddf5
2013-03-11 14:12:24 -07:00
Gregory Szorc
48edaac8ea Bug 847662 - Part 1: Rename Metrics.Collector -> Metrics.ProviderManager; r=rnewman
--HG--
rename : services/metrics/collector.jsm => services/metrics/providermanager.jsm
rename : services/metrics/tests/xpcshell/test_metrics_collector.js => services/metrics/tests/xpcshell/test_metrics_provider_manager.js
extra : rebase_source : b5d1e1a54adca8c8fb948d18c176c4bfa36ff769
2013-03-07 05:06:46 -08:00
Gregory Szorc
d3595ab339 Bug 846843 - Scrub profile directory from error strings; r=rnewman 2013-03-05 10:31:12 -08:00
Gregory Szorc
244a60de94 Bug 845966 - Detect more errors during FHR initialization; r=rnewman 2013-02-27 16:52:29 -08:00
Gregory Szorc
9289189422 Bug 845431 - Send more errors in FHR payload; r=rnewman 2013-02-27 16:52:26 -08:00
Gregory Szorc
964f7ce4bc Bug 842377 - Rename "constant only" to "pull only"; r=rnewman
The new name better reflects the lazy-init behavior of providers.
2013-02-18 13:05:07 -08:00
Gregory Szorc
424515f266 Bug 841244 - More Telemetry probes for Firefox Health Report. r=rnewman,gps,vladan 2013-02-18 12:45:53 -08:00
Richard Newman
a56af1c90e Bug 838879 - Part 1: split HealthReporter and AbstractHealthReporter. r=gps 2013-02-13 16:32:45 -08:00
Gregory Szorc
22ec377486 Bug 828540 - Part 2: APIs to retrieve a registered provider; r=rnewman
--HG--
extra : rebase_source : 0b91c4da3adc153ff102872ce88245bab2c7cf7c
2013-02-12 16:32:45 -08:00
Gregory Szorc
fdf09a023c Bug 838227 - Be more intelligent about activating constant-only providers. r=rnewman
This fixes a horrible bug that was preventing FHR from submitting data
for constant-only providers.
2013-02-06 19:26:26 -08:00
Gregory Szorc
5cf07cdd9a Bug 838291 - More robust APIs for obtaining FHR data; r=rnewman 2013-02-05 20:31:48 -08:00
Gregory Szorc
47de334cc8 Bug 838072 - Part 3: Call collectDailyData from FHR; r=rnewman 2013-02-05 09:59:15 -08:00
Phil Ringnalda
62fe566e61 Merge m-c to s-c 2013-02-04 18:12:00 -08:00
Gregory Szorc
ec5ad209db Bug 828720 - Telemetry probes for Firefox Health Report; r=rnewman, f=vladan 2013-02-01 13:28:02 -08:00
Gregory Szorc
a0ff5e8c22 Bug 836186 - Don't load FHR providers until they are used; r=rnewman 2013-01-31 08:58:19 -08:00
Gregory Szorc
1a0c8b87f1 Bug 836177 - Temporarily merge more JSMs to mitigate compartment overhead; r=rnewman
As with bug 834936, this is meant to be temporary until zones land and
we have decent JSM overhead levels.
2013-01-30 07:07:22 -08:00
Gregory Szorc
9660536d58 Bug 834936 - Temporarily load JSMs into fewer compartments; r=rnewman
We concatenate JSMs together so we use less compartments and therefore
less memory. This is intended to be a temporary hack until the overhead
of compartments is less.
2013-01-27 11:26:48 -08:00