Commit Graph

156 Commits

Author SHA1 Message Date
Jim Blandy
b6b202b6bb Bug 914753: Make Emacs file variable header lines correct, or at least consistent. DONTBUILD r=ehsan
The -*- file variable lines -*- establish per-file settings that Emacs will
pick up. This patch makes the following changes to those lines (and touches
nothing else):

 - Never set the buffer's mode.

   Years ago, Emacs did not have a good JavaScript mode, so it made sense
   to use Java or C++ mode in .js files. However, Emacs has had js-mode for
   years now; it's perfectly serviceable, and is available and enabled by
   default in all major Emacs packagings.

   Selecting a mode in the -*- file variable line -*- is almost always the
   wrong thing to do anyway. It overrides Emacs's default choice, which is
   (now) reasonable; and even worse, it overrides settings the user might
   have made in their '.emacs' file for that file extension. It's only
   useful when there's something specific about that particular file that
   makes a particular mode appropriate.

 - Correctly propagate settings that establish the correct indentation
   level for this file: c-basic-offset and js2-basic-offset should be
   js-indent-level. Whatever value they're given should be preserved;
   different parts of our tree use different indentation styles.

 - We don't use tabs in Mozilla JS code. Always set indent-tabs-mode: nil.
   Remove tab-width: settings, at least in files that don't contain tab
   characters.

 - Remove js2-mode settings that belong in the user's .emacs file, like
   js2-skip-preprocessor-directives.
2014-06-24 22:12:07 -07:00
Benoit Jacob
a51f56b808 Bug 1028588 - Fix dangerous public destructors in toolkit/ - r=ehsan 2014-06-23 18:40:02 -04:00
Sam Penrose
704ea0627b Bug 1025309 - Fire FxA onlogout for RPs such as FMD. r=jedp 2014-06-17 11:28:25 -07:00
Sam Penrose
9e06d7e779 Bug 1008901 - Fire 'onlogin' when the account is verified. r=jedp 2014-06-06 10:42:22 -07:00
David Keeler
165f7dcea8 bug 1006710 - add class of PSM errors to SEC and SSL errors r=briansmith 2014-05-28 15:28:03 -07:00
Sam Penrose
0a56923042 Bug 982969 - DIALOG_CLOSED_BY_USER fires oncancel. r=jedp 2014-05-13 13:56:30 -07:00
Birunthan Mohanathas
504b581650 Bug 900908 - Part 3: Change uses of numbered macros in nsIClassInfoImpl.h/nsISupportsImpl.h to the variadic variants. r=froydnj 2014-04-27 03:06:00 -04:00
Sam Penrose
d73ea131a3 Bug 995353 - fix Firefox Accounts error propagation from toolkit/ through dom/ to web content. r=jedp 2014-04-23 15:45:06 -07:00
Olli Pettay
736b1d9117 Bug 688580 - Run deferred scripts before DOMContentLoaded; r=hsivonen 2014-04-12 11:02:21 +02:00
Ryan VanderMeulen
50dca137e5 Backed out changeset 02876730f55f (bug 688580) for Android 4.0 debug mochitest-7 perma-fail.
CLOSED TREE
2014-04-10 14:38:04 -04:00
Olli Pettay
fb3b63c023 Bug 688580, run deferred scripts before DOMContentLoaded, r=hsivonen
--HG--
extra : rebase_source : e7e56d2d83c7b1bf29a3a5ea4efd7418cfbee1e0
2014-04-10 01:49:17 +03:00
Neil Rashbrook
88a9233a1e Bug 514280 Only use nsCOMPtr for interfaces r=bsmedberg 2014-04-03 23:06:26 +01:00
Jed Parsons
4e64815a07 Bug 945363 - Ensure that FXA RPs provide an onlogout handler. r=ferjm 2014-03-18 10:07:11 -07:00
Jed Parsons
b38e622a84 Bug 978896 - FxA: watch() should get silent assertion if possible. r=ferjm 2014-03-11 17:49:26 -07:00
Jed Parsons
16044c3560 Bug 947374 - Certified apps can choose arbitrary assertion audience. r=ferjm 2014-02-27 15:06:00 -08:00
Jed Parsons
934d1163d3 Bug 945278 - Firefox Accounts: Add onerror handler to catch getAssertion errors. r=ferjm 2014-01-21 15:57:50 -08:00
Jed Parsons
ac39aa60ee Bug 972582 - Fix broken base64UrlDecode in toolkit/identity. r=MattN, r=warner, sr=mossop 2014-02-19 13:53:12 -08:00
Fernando Jiménez
465f0e9589 Bug 938635 - Implement forceAuthentication for firefox accounts. Part 1: DOM API. r=jedp 2014-02-19 11:47:10 +01:00
Gregory Szorc
1f28da1c9c Bug 969021 - Part 1: Consolidate moz.build data into parent moz.build files; r=ted
Many moz.build files define things that could be defined in parent
moz.build files. Keeping the number of moz.build files low helps with
build times due to less I/O and fewer directories traversed.

This patch eliminates a lot of moz.build files by moving their content
into parent moz.build files.

--HG--
extra : rebase_source : 0cfdf2697d10532e5b03cd27fbaadb41f42b837c
extra : amend_source : 0119d4e4881217f105e0e4ba1dfa9c8f7295f3e9
extra : histedit_source : eb49e62c67af2005fdc08d9c9a07f56bee98d558%2C50951e960e450f9b0e48fc7e8ec369d8666a63b0
2014-02-06 13:00:20 -08:00
David Keeler
7748def053 bug 967629 - don't release any nsNSSShutDownObject in any destructorSafeDestroyNSSReference r=cviecco 2014-02-04 16:14:51 -08:00
Jed Parsons
357c44f512 Bug 957863 - Use FxA auth clock skew in hawk, jwcrypto, and sync. r=warner, r=rnewman 2014-01-23 18:04:38 -08:00
Jed Parsons
852744f17c Bug 929386 - BrowserID DOM API extension for Firefox Accounts. r=MattN, r=smaug 2013-12-13 15:31:23 -08:00
Jed Parsons
72fae30548 Bug 963674 - Remove xul appinfo from xpcshell tests. r=MattN 2014-01-24 13:23:21 -08:00
David Keeler
e035c31de9 bug 957368 - standardize and simplify nsNSSShutDownObject implementations r=cviecco r=briansmith 2014-01-14 09:28:43 -08:00
Ryan VanderMeulen
3c83f654a4 Backed out changesets bb7097d12256, 5e6c7217e92a, and 6779278f87df (bug 884573) and changeset 30e1a793fbf9 (bug 878941) for Cpp unit test failures. 2014-01-14 11:43:48 -05:00
Martin Thomson
defc49d86e Bug 878941 - Add IdP proxy code with tests. r=abr 2013-12-18 16:15:40 -08:00
Birunthan Mohanathas
58325c73be Bug 713082 - Part 2: Rename Util.h to ArrayUtils.h. r=Waldo
--HG--
rename : mfbt/Util.h => mfbt/ArrayUtils.h
2013-12-08 21:52:54 -05:00
Mike Hommey
931cb49886 Bug 939632 - Remove LIBRARY_NAME for leaf libraries. r=gps
Landing on a CLOSED TREE.
2013-11-19 11:50:54 +09:00
Mike Hommey
db9e5129bc Bug 939074 - Remove most LIBXUL_LIBRARY. rs=gps 2013-11-19 11:48:10 +09:00
Mike Hommey
b18be7aacd Bug 939044 - Rename remaining MODULE definitions to XPIDL_MODULE. r=mshal 2013-11-19 11:47:43 +09:00
Mike Hommey
f0d1cd1e10 Bug 939044 - Remove most definitions of MODULE. r=mshal 2013-11-19 11:47:39 +09:00
Mike Hommey
f81885e53b Bug 935881 - Use FINAL_LIBRARY for all (fake) libraries that end up linked in a single other library. r=gps 2013-11-19 11:47:14 +09:00
Mike Hommey
f1c0c07862 Bug 929905 - Consolidate sources in moz.build. r=gps 2013-10-25 08:23:05 +09:00
Mike Hommey
80c623bb6a Bug 921492 - Make StrictOrderingOnAppendList use actual alphabetical sorting. r=mshal,r=gps 2013-10-24 08:05:43 +09:00
Ms2ger
191efae989 Bug 923395 - Part a: Remove completely empty makefiles; r=gps 2013-10-20 09:25:18 +02:00
Birunthan Mohanathas
c8d9f9225c Bug 784739 - Switch from NULL to nullptr in toolkit/; r=ehsan 2013-10-10 16:36:42 -04:00
Ms2ger
df62fb8b0f Bug 900980 - Part a: Move unconditional assignments to EXPORT_LIBRARY to moz.build; rs=gps 2013-10-03 09:11:13 +02:00
Ms2ger
9d5ce8dfb7 Bug 922268 - Remove empty makefiles; r=gps 2013-10-03 09:10:00 +02:00
Gregory Szorc
89c902c7b2 Bug 920223 - Part 2: Mass convert MOCHITEST_CHROME_FILES to manifests; rs=Ms2ger 2013-09-30 09:52:01 +02:00
Ed Morley
74e3d6ce30 Backed out changeset 68b6b152f51a (bug 920223) 2013-09-30 12:50:09 +01:00
Gregory Szorc
47e946bebe Bug 920223 - Part 2: Mass convert MOCHITEST_CHROME_FILES to manifests; rs=Ms2ger 2013-09-30 09:52:01 +02:00
Gregory Szorc
160a20817c Bug 901990 - Part 2: Upgrade xpcshell manifests; r=ted
--HG--
rename : toolkit/mozapps/extensions/test/xpcshell-unpack/head_unpack.js => toolkit/mozapps/extensions/test/xpcshell/head_unpack.js
2013-09-24 11:50:08 -07:00
Ehsan Akhgari
dee6c12c6f Bug 918923 - Part 2: Switch to #including nsString.h in code using the internal strings API; r=bsmedberg 2013-09-23 13:25:00 -04:00
Mike Hommey
05b3f24e0e Bug 912293 - Remove now redundant boilerplate from Makefile.in. r=gps 2013-09-05 09:01:46 +09:00
Geoff Brown
5a46efbe2b Bug 865006 - (4) Add more xpcshell tests for android; r=jmaher 2013-08-25 10:58:31 -06:00
Ms2ger
4d0ead0110 Bug 883284 - Part f: Move LIBXUL_LIBRARY into moz.build (p-z); r=glandium 2013-08-22 08:56:01 +02:00
Ms2ger
66214743ad Bug 882859 - Part b: Move FAIL_ON_WARNINGS into moz.build; r=joey+gps 2013-08-22 08:55:59 +02:00
Masatoshi Kimura
ffde56cf45 Bug 856424 - Unpref Components for content. r=bholley 2013-08-20 02:44:31 +09:00
Trevor Saunders
b2dc01f1a7 bug 886526 - remove IS_COMPONENT and MODULE_NAME makefile vars for things in libxul r=bsmedberg r=glandium 2013-08-08 20:12:37 -04:00
Ehsan Akhgari
085494b95d Bug 895322 - Part 1: Replace the usages of MOZ_STATIC_ASSERT with C++11 static_assert; r=Waldo
This patch was mostly generated by running the following scripts on the codebase, with some
manual changes made afterwards:

# static_assert.sh
#!/bin/bash
# Command to convert an NSPR integer type to the equivalent standard integer type

function convert() {
echo "Converting $1 to $2..."
find . ! -wholename "*nsprpub*" \
       ! -wholename "*security/nss*" \
       ! -wholename "*/.hg*" \
       ! -wholename "obj-ff-dbg*" \
       ! -name nsXPCOMCID.h \
       ! -name prtypes.h \
         -type f \
      \( -iname "*.cpp" \
         -o -iname "*.h" \
         -o -iname "*.cc" \
         -o -iname "*.mm" \) | \
    xargs -n 1 `dirname $0`/assert_replacer.py #sed -i -e "s/\b$1\b/$2/g"
}

convert MOZ_STATIC_ASSERT static_assert
hg rev --no-backup mfbt/Assertions.h \
                   media/webrtc/signaling/src/sipcc/core/includes/ccapi.h \
                   modules/libmar/src/mar_private.h \
                   modules/libmar/src/mar.h


# assert_replacer.py
#!/usr/bin/python

import sys
import re

pattern = re.compile(r"\bMOZ_STATIC_ASSERT\b")

def replaceInPlace(fname):
  print fname
  f = open(fname, "rw+")
  lines = f.readlines()
  for i in range(0, len(lines)):
    while True:
      index = re.search(pattern, lines[i])
      if index != None:
        index = index.start()
        lines[i] = lines[i][0:index] + "static_assert" + lines[i][index+len("MOZ_STATIC_ASSERT"):]
        for j in range(i + 1, len(lines)):
          if lines[j].find("                 ", index) == index:
            lines[j] = lines[j][0:index] + lines[j][index+4:]
          else:
            break
      else:
        break
  f.seek(0, 0)
  f.truncate()
  f.write("".join(lines))
  f.close()

argc = len(sys.argv)
for i in range(1, argc):
  replaceInPlace(sys.argv[i])

--HG--
extra : rebase_source : 4b4a4047d82f2c205b9fad8d56dfc3f1afc0b045
2013-07-18 13:59:53 -04:00