Commit Graph

1890 Commits

Author SHA1 Message Date
Bobby Holley
b65e2ecba7 Bug 658909 - Remove GWNOJO from JSValToXPCException. r=mrbkap 2013-03-21 08:20:44 -07:00
Bobby Holley
fb94cdfee3 Bug 658909 - Remove GWNOJO from JSObject2NativeInterface. r=mrbkap 2013-03-21 08:20:44 -07:00
Bobby Holley
fa6d248e50 Bug 658909 - Remove GWNOJO for helper stubs. r=mrbkap 2013-03-21 08:20:43 -07:00
Bobby Holley
11b5031023 Bug 658909 - Remove GWNOJO from MarkWrappedNative. r=mrbkap 2013-03-21 08:20:43 -07:00
Bobby Holley
a39e82c6c7 Bug 658909 - Add a new, much simpler API for getting WNs from JS objects. r=mrbkap 2013-03-21 08:20:43 -07:00
Bobby Holley
d13583047f Bug 658909 - Stop doing all the crazy stuff in GetWrappedNativeOfJSObject. r=mrbkap 2013-03-21 08:20:43 -07:00
Bobby Holley
b62d1486bb Bug 658909 - Add a hack to support calling nohelper XPCWN methods without the proper |this|. r=mrbkap 2013-03-21 08:20:43 -07:00
Bobby Holley
93d4b3e2bf Bug 658909 - Implement carefully-checked unwrapping in XPCCallContext. r=mrbkap 2013-03-21 08:20:42 -07:00
Bobby Holley
5fcbe112e7 Bug 658909 - Set args at XPCCallContext construct time in XPC_WN_GetterSetter. r=mrbkap
It's not clear to me why it's done this way, but it confuses our ability to
determine during wrapper lookup whether we're doing a set or a get. This aligns
the behavior with XPC_WN_CallMethod, including passing JSID_VOID for the name
(which is safe because XPCCallContext explicitly special-cases JSID_VOID and
doesn't call SetName in that case).
2013-03-21 08:20:42 -07:00
Bobby Holley
17ce8369ba Bug 658909 - Initialize the same fields in both XPCCallContext constructors. r=mrbkap
This is a huge footgun. XPCCallContext is hot, but it's not too hot to be safe
here. Garbage XPCWN and JSObject pointers are bad.
2013-03-21 08:20:42 -07:00
Bobby Holley
87e5d84514 Bug 658909 - Remove unnecessary ccx param. r=mrbkap 2013-03-21 08:20:42 -07:00
Bobby Holley
5c2f6cfd84 Bug 658909 - Make isSafeToUnwrap pseudo-dynamic for SOWs. r=mrbkap
This can go away as soon as XBL scopes are no longer behind a pref.
2013-03-21 08:20:41 -07:00
Bobby Holley
2bf214ff20 Bug 658909 - Force |this| computation in SandboxCallableProxyHandler::call when using Xrays. r=bz
Comment says it all.
2013-03-21 08:20:41 -07:00
Bobby Holley
3cebc24c68 Bug 853283 - Grab the window directly from the navigator in nsNavigatorSH::NewResolve. r=mrbkap 2013-03-21 08:20:41 -07:00
Ryan VanderMeulen
59aa9e54e3 Backed out changeset 55d19e574b86 (bug 853283) for Windows debug bustage on a CLOSED TREE. 2013-03-21 15:25:14 -04:00
Ryan VanderMeulen
75a33a8191 Backed out 22 changesets (bug 658909) for Windows debug bustage. 2013-03-21 15:24:54 -04:00
Ryan VanderMeulen
9bfb899cee Backed out 3 changesets (bug 851895) for Windows debug bustage. 2013-03-21 15:24:04 -04:00
Ryan VanderMeulen
f2110c1812 Backed out changesets 775abfe4876f and 1b75fab8561b (bug 844783) under suspicion of breaking Windows debug builds on a CLOSED TREE. 2013-03-21 14:15:31 -04:00
Mike Shal
c2a9341a2e Bug 852534 - Remove GRE_MODULE from Makefile.in; r=gps 2013-03-21 08:41:00 -07:00
Bobby Holley
b9ca3f72f3 Bug 844783 - Disable XBL scopes for XUL-whitelisted domains. r=bz 2013-03-21 09:33:34 -07:00
Bobby Holley
e83099fd69 Bug 851895 - Tests. r=mrbkap 2013-03-21 08:20:46 -07:00
Bobby Holley
756ba16356 Bug 851895 - Expand the this-fixup hack to include Cu. r=mrbkap 2013-03-21 08:20:46 -07:00
Bobby Holley
a34d52b79e Bug 851895 - Don't assert against a failure in CanCallNow. r=mrbkap
This can definitely happen now if the |this| object is wrong. It's possible
that we should be checking this earlier, but as the code stands this assertion
is incorrect.
2013-03-21 08:20:46 -07:00
Bobby Holley
f09db0c385 Bug 658909 - Tests. r=mrbkap 2013-03-21 08:20:45 -07:00
Bobby Holley
6e76c314c6 Bug 658909 - Port tearoff-handling guts of GWNOJO to XPCCallContext and remove GWNOJO. r=mrbkap 2013-03-21 08:20:45 -07:00
Bobby Holley
02780e6be7 Bug 658909 - Remove GWNOJO from PreserveWrapper. r=mrbkap 2013-03-21 08:20:45 -07:00
Bobby Holley
5dd8152ac6 Bug 658909 - Remove GWNOJO from AccessCheck. r=mrbkap 2013-03-21 08:20:45 -07:00
Bobby Holley
7b7ed3edeb Bug 658909 - Remove GWNOJO from nsXPConnect. r=mrbkap 2013-03-21 08:20:44 -07:00
Bobby Holley
92e5a036c5 Bug 658909 - Remove GWNOJO from XPCVariant. r=mrbkap
The old code seems to be deciding whether we have a double-wrapped object by
checking _either_ the rv of GWNOJO _or_ the potential slim wrapper. This is
nonsensical, because double-wrapped objects are never slim wrappers.
Furthermore, that variable here is named 'proto', which further suggests
that this code is nonsensical. So let's just check for WNs.

Also, it seems pretty wack to be innerizing here before storing the jsval,
but I'm going to leave that for now.
2013-03-21 08:20:44 -07:00
Bobby Holley
59e03695ec Bug 658909 - Remove GWNOJO from XPCJSID. r=mrbkap 2013-03-21 08:20:44 -07:00
Bobby Holley
ed16fdf0fe Bug 658909 - Remove GWNOJO from JSValToXPCException. r=mrbkap 2013-03-21 08:20:44 -07:00
Bobby Holley
1bb0fe7c95 Bug 658909 - Remove GWNOJO from JSObject2NativeInterface. r=mrbkap 2013-03-21 08:20:44 -07:00
Bobby Holley
c5dc21550e Bug 658909 - Remove GWNOJO for helper stubs. r=mrbkap 2013-03-21 08:20:43 -07:00
Bobby Holley
1af3565955 Bug 658909 - Remove GWNOJO from MarkWrappedNative. r=mrbkap 2013-03-21 08:20:43 -07:00
Bobby Holley
b18fe7a48a Bug 658909 - Add a new, much simpler API for getting WNs from JS objects. r=mrbkap 2013-03-21 08:20:43 -07:00
Bobby Holley
60293a6469 Bug 658909 - Stop doing all the crazy stuff in GetWrappedNativeOfJSObject. r=mrbkap 2013-03-21 08:20:43 -07:00
Bobby Holley
a7f73d651b Bug 658909 - Add a hack to support calling nohelper XPCWN methods without the proper |this|. r=mrbkap 2013-03-21 08:20:43 -07:00
Bobby Holley
867314402d Bug 658909 - Implement carefully-checked unwrapping in XPCCallContext. r=mrbkap 2013-03-21 08:20:42 -07:00
Bobby Holley
f7e0eaeb81 Bug 658909 - Set args at XPCCallContext construct time in XPC_WN_GetterSetter. r=mrbkap
It's not clear to me why it's done this way, but it confuses our ability to
determine during wrapper lookup whether we're doing a set or a get. This aligns
the behavior with XPC_WN_CallMethod, including passing JSID_VOID for the name
(which is safe because XPCCallContext explicitly special-cases JSID_VOID and
doesn't call SetName in that case).
2013-03-21 08:20:42 -07:00
Bobby Holley
a426c37549 Bug 658909 - Initialize the same fields in both XPCCallContext constructors. r=mrbkap
This is a huge footgun. XPCCallContext is hot, but it's not too hot to be safe
here. Garbage XPCWN and JSObject pointers are bad.
2013-03-21 08:20:42 -07:00
Bobby Holley
09e256a90d Bug 658909 - Remove unnecessary ccx param. r=mrbkap 2013-03-21 08:20:42 -07:00
Bobby Holley
d6a9021608 Bug 658909 - Make isSafeToUnwrap pseudo-dynamic for SOWs. r=mrbkap
This can go away as soon as XBL scopes are no longer behind a pref.
2013-03-21 08:20:41 -07:00
Bobby Holley
0ead2198ad Bug 658909 - Force |this| computation in SandboxCallableProxyHandler::call when using Xrays. r=bz
Comment says it all.
2013-03-21 08:20:41 -07:00
Bobby Holley
b3f7f775a5 Bug 853283 - Grab the window directly from the navigator in nsNavigatorSH::NewResolve. r=mrbkap 2013-03-21 08:20:41 -07:00
Jon Coppeard
1e656de13c Bug 853028 - GC: Fix some rooting issues found by static analysis r=terrence
--HG--
extra : rebase_source : a1d340a00516ae890c98fa7420497e85526823fc
2013-03-21 12:56:58 +00:00
Gene Lian
f70fb08d9a Bug 852911 - B2G MMS: fail to expose correct nsIDOMMozMmsMessage.attachments. r=smaug 2013-03-21 14:49:23 +08:00
Ted Mielczarek
bc92001c0b bug 604039 - Add DOM Gamepad APIs. r=smaug
--HG--
extra : rebase_source : ffffdc4549da1b25ea263b623c05ae1afb3d46a0
2011-08-03 14:12:08 -04:00
Jan de Mooij
eb375c1d4a Bug 850156 - Use separate memory reporters for Ion and baseline code. r=njn,dvander 2013-03-20 11:24:17 +01:00
Gregory Szorc
09e7b06723 Bug 844654 - Part 3: Remove now empty Makefile.in files; rs=khuey
--HG--
extra : rebase_source : 8de9c7f68a953e574dda22f8c14c2b2ca60444f9
2013-03-19 18:49:07 -07:00
Mike Shal
9680b82df6 Bug 844654 - Part 2: Move MODULE to moz.build; rs=gps 2013-03-19 11:47:00 -07:00